boundary

Commit Graph

Author	SHA1	Message	Date
Todd Knight	7f6e78e66e	Handler hostcatalogs (#86 ) * Created host catalog service. * Fixing uri generation for create. * Use newly submitted static host catalog. * Copying over tests from projects. * Fix UpdateHostCatalogRequest merging proto. * Properly use static host catalog prefixes in tests. * Correct test to verify the expected uri and id prefix is set. * Add test for unsetting descriptions. * Correct bad spelling in comment. * Tweaking variable names. * Adding Stringer to the catalog type and setting the type on the response. * Setting up the catalogType to contain more info regarding its type. * Validate the type field in requests. * Remove unused method. * Comment describing invariants around types. * Wiring in the repo into the static catalog handler. * Updated comments to the exported methods. * fix: return the result of handlers.NotFoundError instead of just calling it. * Fixing typos referencing just hosts instead of host catlogs. * Update NewService returns an error and a non pointer type. * Pull "org_id" and "project_id" into constants and the validation of them into the ValidateAncestors. * Check errors for all RegisterHandlerServer calls. fix: Remove left over reference that could cause a panic. * fix: Changing "x := []string{}" to "var x []string" * fix: Log errors in test cleanup. * Changing the code to use google.golang.org/protobuf instead of the older github based protobuf library. * Changing all t.Fatal checks to require.NoError calls. * Changing unrecognized prefixes to Invalid Argument instead of Not Found. * fix: toDbUpdateMask now returns error if it was unable to find any valid paths. * Define CreatedTime, UpdatedTime, and Type at initialization time in toProto. * Remove unused host catalog from test. * Change a t.Fatal to a require.NoError that I missed earlier. * Change shutdown error logging to t.Errorfs. * Shorten validateX function names. * Inline API responses. * Add todo to make a new repo per request. * Inline regex check for invalid id. * Change stored repos into repo creating functions which satisfies ICU-223. * Wrap proto comments to be under 80 characters long. * Remove the exception on the read only fields that can be set in an Update request. * Removing out of date comment. * Use iam.TestScopes instead of making the project myself. * Renaming files to be consistant with go test standards and resource naming standards. * Remove TODO related to a task completed in an earlier commit. * Fix the previous commit which removed the wrong TODO.	6 years ago
Jim	7d4993fb61	iam users (#96 )	6 years ago
Michael Gaffney	5bdd8a46ea	Extract timestamp scanners into reusable package (#91 ) * Refactor: move Timestamp from static/store to db/timestamp * Refactor: convert remaining Timestamps to timestamp.Timestamp * Use new db timestamp	6 years ago
Michael Gaffney	0c7f6da936	Static Host Catalog (#51 ) * database: add wt_public_id domain type * static-hosts: add migrations * Rename migrations * migrations: add description column and fix foreign keys * Add protobuf for static host * Add HostCatalog and HostSet * Add Options * Add foreign key constraint * Add package doc * Add copied scanner code * Add NewHostCatalog with tests * Override default table name for static host catalog * WIP: save static host catalog to database * WIP: Print db url for debugging * Add iam test helper function * Make gorm default to null for names and descriptions * Add foreign key constraint from host catalog to scope * Names are not needed for the test org and project * Avoid an ordering dependency in down migrations * Use wt_timestamp * Add check constraint on host address column * Add Host * Add HostSet * Add HostSetMember * Test a HostSetMember can be written to the database * Move the getters and setters for table name to a new file The TableName methods are needed by gorm and the SetTableName methods are for oplog. Moving them to a new file so related functionality is in the same file. * Add repository * Add NewRepository * Close connection before cleanup of database * Add comments to protobuf file and regenerate * Define repository methods for HostCatalog * Assign PublicId when resource is inserted into the database * Wrap a nil parameter error * Add oplog tickets for static host types * WIP: first cut at CreateCatalog * CreateHostCatalog: more tests * Detect unique constraint violation * Use const for PublicId prefixes * Use PostgreSQL error name instead of error code * Add TODO comments * Fix comments * Use PublicId not PublicID * Refactor: move error variables from host/static to db The error variables defined in host/static are generic and can be reused by other packages. * Create a new repository for each test * Validate CreateCatalog returns a new HostCatalog * Do not modify the HostCatalog passed in * Implement UpdateCatalog * Minor cleanup to make folds work * Implement LookupCatalog * Refactor: extract allocCatalog function * Add comment * Refactor: extract newCatalogMetadata function * Make error strings more consistent * Move database specific error check to internal/db package * Change signature of DeleteCatalog and update docs * Implement DeleteCatalog * Make error strings more consistent * Add examples * Update docs * Add package level doc and example for repository * No need for using reflect.DeepEqual * Remove redundant comment * Clarify ErrMultipleRecords results in the transaction being rolled back * Remove redundant error checks * Remove unnecessary check * Return early instead of using nested 'else' statements * Update and Delete must return a row count * catch err on defers (#82) Co-authored-by: Jim Lambert <jimlambrt@Jims-MBP-3.home> * Remove 'if assert' pattern * Use assert package in test helper function * Add test for updating a non existent catalog * Use a single assert when a specific error is expected * Use assert package when it clarifies the check * Catch errors in cleanup functions * Update comments in protobuf file * Update doc for UpdateCatalog to reflect the new behavior * Add common error values for field mask errors * Require a field mask when calling update methods * Add TODO for removing direct call to gorm * Export Public ID prefixes * Add db timestamp guards * Remove unused option Co-authored-by: Jim <jlambert@hashicorp.com> Co-authored-by: Jim Lambert <jimlambrt@Jims-MBP-3.home>	6 years ago
Todd Knight	44152ae63e	Add API Error Handler (#74 ) * Add error handler that converts from rpc.Status errors to Watchtower API errors. * Better testing for ErrorHandler. * Rename testcase and remove empty default switch case. * Change the error status back to int64. * Converting everything to int32s. jsonpb wraps int64s as a string which we dont like. We'll figure out how to use values larger than int64s when it comes up. * Remove special casing for TraceId which isn't needed anymore. * Removing wrappers from error details since we never need to know when they are set or unset from the end user. * Using the helper error functions inside the project service. * Correct usage of hclog, replace panic with Error log. * Adding periods to all API returned errors, correct spelling, fix missed invalid argument error not using helper function. * Change our logged errors to Error instead of Warn. * Add TODO for defining and using our own defined API error codes. * Add TODO to remove internal error messages.	6 years ago
Todd Knight	c0c6a9b0b8	Handler project (#44 ) * Renamed fakeRepo to mockRepo * Changing around TODOs to capture current plans with the code. * Remove the repo interface and use a real DB for tests. * Fixed a few tests. * Adding checks for properly formatted identifiers. * Updating code to account for recent merges. Relaxing some restrictions on what an id can look like. * Added small comment explaining why RegisterGrpcGatewayer interface exists. * Move project service up a call level. Long term I think it would make sense to define these services even higher up the call stack, potentially at the initialization of the controller server, near where the DB is initialized. * Making these fields align with those in the resources under hosts/... * Hard code the service initialization in the handler registration code. * Regenerate project related code proto code. * Removing type field for project. * Adds basic project handling in CLI/SDK (#47) * Adds SDK for creating and reading projects * Reorganizes a bit * Adds CLI for creating and reading projects * Fixes some some generation bugs * Adds redirect support for default org ID * Fix protobuf import references being moved. * Update client test to look for "orgs" and "projects" instead of "org" and "project" * Update expected segments test * Fix setAddr handling when default organization is in use * Set client in target after create or read Co-authored-by: Jim Lambert <jimlambrt@Jims-MBP-3.home> Co-authored-by: Jim <jlambert@hashicorp.com> Co-authored-by: Michael Gaffney <mgaffney@users.noreply.github.com> Co-authored-by: Jeff Mitchell <jeffrey.mitchell@gmail.com>	6 years ago
Jim	8a5197e39e	implement schema, store and repository for IAM scopes of organization and project	6 years ago
Todd Knight	05330db741	Add projectless paths for host-catalogs. (#31 ) * Add projectless paths for host-catalogs.	6 years ago
Jim	725a777baf	refactor friendly name to just be name (#29 )	6 years ago
Jeff Mitchell	f36f25a23b	Add json_name fields to proto for complex names (#27 ) This was generating fine before but it makes it explicit in the proto and it avoids weirdness where the protobuf tag will say a name is something like requestId where the json tag says it's request_id. This way they line up. One thing not honoring this properly is TraceId. I don't know why the JSON tag being generated doesn't match even when explicitly set here. For now I'm just manually fixing it.	6 years ago
Jim	27b4d7a034	basic internal db interfaces and Gorm implementation * db reader and writer interfaces which should allow us to encapsulate the vast majority of database code in this package. * GormReadWriter implementation of the Reader and Writer interfaces	6 years ago
Jeff Mitchell	1f3c52f495	Name and addr updates (#26 ) * Rename FriendlyName to Name * Standardize on connection parameters for the server being addr This syncs up WATCHTOWER_ADDR and -addr (formerly -address) and frees up -address to be used in resources (which it is). * Add description fields	6 years ago
Jeff Mitchell	4afb4f6be5	Minor proto updates (#22 )	6 years ago
Jeff Mitchell	6970b14143	Update type value to wrapper	6 years ago
Jeff Mitchell	2926cc1000	Add initial API generation bits (#20 ) * Add initial API generation bits * Revert accidental changes to oplog	6 years ago
Jim	2f0dd58f11	set default value in gorm tag, so database timestamp defaults will get set	6 years ago
Jim	73363d4c71	adapt to use structwrapping from go-kms-wrapping	6 years ago
Jeff Mitchell	13056e1f51	Migrate host resources to hosts package (#15 ) Migrate host resources to hosts package and some other minor changes	6 years ago
Todd Knight	c7126ae69b	Static Catalog Api definition (#12 ) * Setup buf to see and process protos correctly. This commit adds a proposed directory structure for protos. Included is a rough draft of the Ec2Catalog protos. * Add host and host_catalog service apis. This also has for the first time the move away from holding individual ids for resources and instead using the full uri path as the api facing identifier. There are some issues with the swagger generation stripping out the format of the path matching so currently only PATCH uses the approach I would like to move to. In follow up commits I'll try to either get swagger to display the correct expected paths or I'll resolve if that is even needed by our clients. * Move all protos and generated files to under the internal directory. This also required updating the buf config to explicitly name the exluded linted proto files under oplog since previously /internal/ was listed as a root in buf. Future commit will move oplog proto files to be with the others. * Moved oplog related protos to under the proto directory and regenerated. * Update the oplog protos to be compliant with buf lint. * Clean up comments in tools. * Merged in recent changes to oplog protos. * Add resource result messages to contain the read only fields and separate them from the writable fields. * Merge the ec2 catalog resources in with the more generic host_catalog resource. * Cleaning the generated swagger. This included adding summaries for each proto rpc method, Making the resources be the full fqn, removing the default error, and a few other tweaks. * Make project plural in the paths. * Adding the ability to add and remove hosts from a host set. * Add the ignore result limit for host set request. * Make size and host lists read only. * Add documentation about what host references are allowed to be added. * Remove ignore result limit when listing items. These can be added in later. * Add handlers and tests for unimplemented services. * Add bootstrap target and update how tools are built (#13) * Update tool installation method, add bootstrap target to makefile * Changing org to orgs in all paths and org param to org_id. * Adding tests for unimplemented service implementations. Co-authored-by: Jeff Mitchell <jeffrey.mitchell@gmail.com>	6 years ago
Todd Knight	4d86db6ba5	Introduce the proto directory structure. (#9 ) * Setup buf to see and process protos correctly. This commit adds a proposed directory structure for protos. Included is a rough draft of the Ec2Catalog protos. * Setup buf to see and process protos correctly. This commit adds a proposed directory structure for protos, but leaves the existing oplog related protos alone. Included is a rough draft of the Ec2Catalog protos. * Update makefile and add script to generate the appropriate pb.go files. * Add comment explaining google.golang.org/protobuf vs github.com/golang/protobuf * Move all protos and generated files to under the internal directory. This also required updating the buf config to explicitly name the excluded linted proto files under oplog since previously /internal/ was listed as a root in buf. Future commit will move oplog proto files to be with the others. * Moved oplog related protos to under the proto directory and regenerated. * Update the oplog protos to be compliant with buf lint.	6 years ago

1 2 3

120 Commits (jeff-error-cli-update)