From fa2dc80e367d606a7a01c3d4133e76fa018bf180 Mon Sep 17 00:00:00 2001 From: Todd Date: Mon, 8 Jan 2024 10:20:43 -0800 Subject: [PATCH] Close the logfile at test cleanup (#4224) --- internal/clientcache/cmd/daemon/logfile_test.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/internal/clientcache/cmd/daemon/logfile_test.go b/internal/clientcache/cmd/daemon/logfile_test.go index 80293b21c8..dec0e3ec09 100644 --- a/internal/clientcache/cmd/daemon/logfile_test.go +++ b/internal/clientcache/cmd/daemon/logfile_test.go @@ -27,6 +27,9 @@ func TestWithEventer(t *testing.T) { dir := t.TempDir() l, err := logFile(ctx, dir, 1) require.NoError(t, err) + t.Cleanup(func() { + assert.NoError(t, l.Close()) + }) var logLock sync.Mutex logger := hclog.New(&hclog.LoggerOptions{ @@ -79,6 +82,9 @@ func TestRotation(t *testing.T) { dir := t.TempDir() l, err := logFile(ctx, dir, 1) require.NoError(t, err) + t.Cleanup(func() { + assert.NoError(t, l.Close()) + }) fi, err := os.Stat(filepath.Join(dir, logFileName)) require.NoError(t, err)