chore: remove more dead code (#5640)

internal/auth/oidc/auth_method.go

@@ -412,10 +412,6 @@ func (am *AuthMethod) convertAccountClaimMaps(ctx context.Context) ([]*AccountCl
 		return nil, errors.New(ctx, errors.InvalidPublicId, op, "missing public id")
 	}
 	newAccountClaimMaps := make([]*AccountClaimMap, 0, len(am.AccountClaimMaps))
-	const (
-		from = 0
-		to   = 1
-	)
 	acms, err := ParseAccountClaimMaps(ctx, am.AccountClaimMaps...)
 	if err != nil {
 		return nil, errors.Wrap(ctx, err, op)

internal/auth/oidc/auth_method_test.go

@@ -5,7 +5,6 @@ package oidc
 
 import (
 	"context"
-	"net/url"
 	"sort"
 	"testing"
 
@@ -35,7 +34,6 @@ func TestAuthMethod_Create(t *testing.T) {
 
 	type args struct {
 		scopeId      string
-		issuer       *url.URL
 		clientId     string
 		clientSecret ClientSecret
 		opt          []Option

internal/auth/oidc/provider_test.go

@@ -107,7 +107,6 @@ func Test_convertToProvider(t *testing.T) {
 	testAm.ApiUrl = allowedRedirect
 	testAm.Certificates = []string{tp.CACert()}
 
-	type args struct{}
 	tests := []struct {
 		name        string
 		am          *AuthMethod

internal/clientcache/internal/cache/consts.go

@@ -10,8 +10,4 @@ const (
 	// defaultLimitedResultSetSize is the default number of results to
 	// return when limiting
 	defaultLimitedResultSetSize = 250
-
-	// unlimitedMaxResultSetSize is the value to use when we want to return all
-	// results
-	unlimitedMaxResultSetSize = -1
 )

internal/clientcache/internal/cache/repository_token_test.go

@@ -829,12 +829,6 @@ var infinityValue = infinityDate{
 	IsInfinity: true,
 }
 
-// negInfinityValue represents a time.Time that is negative infinity
-var negInfinityValue = infinityDate{
-	Time:          time.Time{},
-	IsNegInfinity: true,
-}
-
 // infinityDate is used to represent a time.Time that can be infinity, neg
 // infinity or a regular time.Time
 type infinityDate struct {

internal/cmd/commands/aliasescmd/funcs.go

@@ -12,10 +12,6 @@ import (
 	"github.com/hashicorp/boundary/internal/cmd/base"
 )
 
-type extraCmdVars struct {
-	flagMembers []string
-}
-
 func (c *Command) extraHelpFunc(helpMap map[string]func() string) string {
 	var helpStr string
 	switch c.Func {

internal/cmd/commands/connect/connect.go

@@ -28,8 +28,6 @@ import (
 	exec "golang.org/x/sys/execabs"
 )
 
-const sessionCancelTimeout = 10 * time.Second
-
 type SessionInfo struct {
 	Address         string                       `json:"address"`
 	Port            int                          `json:"port"`

internal/daemon/controller/handlers/accounts/account_service.go

@@ -62,8 +62,6 @@ const (
 	emailAttrField    = "attributes.email"
 	dnAttrField       = "attributes.dn"
 	memberOfAttrField = "attributes.member_of_groups"
-
-	domain = "auth"
 )
 
 var (

internal/daemon/controller/handlers/accounts/account_service_test.go

@@ -45,8 +45,6 @@ import (
 	"google.golang.org/protobuf/types/known/wrapperspb"
 )
 
-const domain = "auth"
-
 var (
 	pwAuthorizedActions = []string{
 		action.NoOp.String(),

internal/daemon/controller/handlers/host_sets/host_set_service.go

@@ -68,8 +68,6 @@ var (
 	)
 )
 
-const domain = "host"
-
 func init() {
 	var err error
 	if maskManager[static.Subtype], err = handlers.NewMaskManager(

internal/oplog/testing.go

@@ -158,10 +158,6 @@ order by ccu.table_name,pgc.conname `
 	rw := dbw.New(db)
 	rows, err := rw.Query(testCtx, constraintSql, []any{tableName})
 	require.NoError(err)
-	type result struct {
-		Name      string
-		TableName string
-	}
 	results := []constraintResults{}
 	for rows.Next() {
 		var r constraintResults

internal/types/subtypes/attributes_test.go

@@ -51,7 +51,6 @@ func TestProtoAttributeKey(t *testing.T) {
 }
 
 func TestProtoAttributeKeyErrors(t *testing.T) {
-	type notproto struct{}
 	cases := []struct {
 		name        string
 		msg         proto.Message