From e83f5bcd4cf3c092e59cfb8a1501a04457a29b9a Mon Sep 17 00:00:00 2001 From: Louis Ruch Date: Fri, 12 May 2023 10:24:03 -0700 Subject: [PATCH] feat(storage): Rename NewLocalFS to NewSyncingFS --- internal/storage/storage.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/internal/storage/storage.go b/internal/storage/storage.go index 574f2430e1..ebc066af0e 100644 --- a/internal/storage/storage.go +++ b/internal/storage/storage.go @@ -15,8 +15,13 @@ import ( // RecordingStorage can be used to create a FS usable for session recording. type RecordingStorage interface { - NewLocalFS(ctx context.Context, bucket *storagebuckets.StorageBucket, _ ...Option) (FS, error) + // NewSyncingFS returns a FS that will use local storage as a cache and sync files when they are closed. + NewSyncingFS(ctx context.Context, bucket *storagebuckets.StorageBucket, _ ...Option) (FS, error) + + // NewRemoteFS returns a ReadOnly FS that can be used to retrieve files from a storage bucket. NewRemoteFS(ctx context.Context, bucket *storagebuckets.StorageBucket, _ ...Option) (FS, error) + + // PluginClients returns a map of storage plugin clients keyed on the plugin name. PluginClients() map[string]plgpb.StoragePluginServiceClient }