Remove calls to `t.Helper()` from test methods (not helpers) (#1063)

internal/auth/password/testing_test.go

@@ -26,7 +26,6 @@ func Test_TestAuthMethods(t *testing.T) {
 }
 
 func Test_TestAccounts(t *testing.T) {
-	t.Helper()
 	assert, require := assert.New(t), require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)

internal/host/static/testing_test.go

@@ -26,7 +26,6 @@ func Test_TestCatalogs(t *testing.T) {
 }
 
 func Test_TestHosts(t *testing.T) {
-	t.Helper()
 	assert, require := assert.New(t), require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)
@@ -46,7 +45,6 @@ func Test_TestHosts(t *testing.T) {
 }
 
 func Test_TestSets(t *testing.T) {
-	t.Helper()
 	assert, require := assert.New(t), require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)
@@ -66,7 +64,6 @@ func Test_TestSets(t *testing.T) {
 }
 
 func Test_TestSetMembers(t *testing.T) {
-	t.Helper()
 	assert, require := assert.New(t), require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)

internal/iam/testing_test.go

@@ -77,7 +77,6 @@ func Test_TestRepo(t *testing.T) {
 }
 
 func Test_TestUser(t *testing.T) {
-	t.Helper()
 	assert, require := assert.New(t), require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)
@@ -93,7 +92,6 @@ func Test_TestUser(t *testing.T) {
 }
 
 func Test_TestRole(t *testing.T) {
-	t.Helper()
 	assert, require := assert.New(t), require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)
@@ -112,7 +110,6 @@ func Test_TestRole(t *testing.T) {
 }
 
 func Test_TestRoleGrant(t *testing.T) {
-	t.Helper()
 	require := require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)
@@ -128,7 +125,6 @@ func Test_TestRoleGrant(t *testing.T) {
 }
 
 func Test_TestUserRole(t *testing.T) {
-	t.Helper()
 	require := require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)
@@ -164,7 +160,6 @@ func Test_TestUserRole(t *testing.T) {
 }
 
 func Test_TestGroupRole(t *testing.T) {
-	t.Helper()
 	require := require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)
@@ -202,7 +197,6 @@ func Test_TestGroupRole(t *testing.T) {
 }
 
 func Test_TestGroupMember(t *testing.T) {
-	t.Helper()
 	require := require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)

internal/kms/testing_test.go

@@ -11,7 +11,6 @@ import (
 )
 
 func Test_TestRootKey(t *testing.T) {
-	t.Helper()
 	assert, require := assert.New(t), require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)
@@ -23,7 +22,6 @@ func Test_TestRootKey(t *testing.T) {
 }
 
 func Test_TestRootKeyVersion(t *testing.T) {
-	t.Helper()
 	assert, require := assert.New(t), require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)
@@ -36,7 +34,6 @@ func Test_TestRootKeyVersion(t *testing.T) {
 }
 
 func Test_TestDatabaseKey(t *testing.T) {
-	t.Helper()
 	assert, require := assert.New(t), require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)
@@ -52,7 +49,6 @@ func Test_TestDatabaseKey(t *testing.T) {
 }
 
 func Test_TestDatabaseKeyVersion(t *testing.T) {
-	t.Helper()
 	require := require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	kmsWrapper := db.TestWrapper(t)
@@ -67,7 +63,6 @@ func Test_TestDatabaseKeyVersion(t *testing.T) {
 }
 
 func Test_TestOplogKey(t *testing.T) {
-	t.Helper()
 	assert, require := assert.New(t), require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)
@@ -83,7 +78,6 @@ func Test_TestOplogKey(t *testing.T) {
 }
 
 func Test_TestOplogKeyVersion(t *testing.T) {
-	t.Helper()
 	require := require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	kmsWrapper := db.TestWrapper(t)
@@ -98,7 +92,6 @@ func Test_TestOplogKeyVersion(t *testing.T) {
 }
 
 func Test_TestTokenKey(t *testing.T) {
-	t.Helper()
 	assert, require := assert.New(t), require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)
@@ -114,7 +107,6 @@ func Test_TestTokenKey(t *testing.T) {
 }
 
 func Test_TestTokenKeyVersion(t *testing.T) {
-	t.Helper()
 	require := require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	kmsWrapper := db.TestWrapper(t)
@@ -129,7 +121,6 @@ func Test_TestTokenKeyVersion(t *testing.T) {
 }
 
 func Test_TestSessionKey(t *testing.T) {
-	t.Helper()
 	assert, require := assert.New(t), require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)
@@ -145,7 +136,6 @@ func Test_TestSessionKey(t *testing.T) {
 }
 
 func Test_TestSessionKeyVersion(t *testing.T) {
-	t.Helper()
 	require := require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	kmsWrapper := db.TestWrapper(t)

internal/session/testing_test.go

@@ -78,7 +78,6 @@ func Test_TestWorker(t *testing.T) {
 }
 
 func Test_TestCert(t *testing.T) {
-	t.Helper()
 	assert, require := assert.New(t), require.New(t)
 	wrapper := db.TestWrapper(t)
 	userId, err := db.NewPublicId(iam.UserPrefix)

internal/target/testing_test.go

@@ -11,7 +11,6 @@ import (
 )
 
 func Test_TestTcpTarget(t *testing.T) {
-	t.Helper()
 	require := require.New(t)
 	conn, _ := db.TestSetup(t, "postgres")
 	wrapper := db.TestWrapper(t)