From 9d82958c9f7610f76ed994fbaaaa37596a5f50eb Mon Sep 17 00:00:00 2001 From: Timothy Messier Date: Thu, 14 Dec 2023 17:53:23 +0000 Subject: [PATCH] test(sqltest): Shorten prepared statement identifiers Some of the prepared statement identifies used in these tests exceeded the identifier character limit. This results in postgres truncating the name, which is fine for a test, but does result in some noise in the test output. This change shortens the identifies to eliminate noise like the following: psql:/test/credential/vault/credential_vault_library_ssh_private_key_mapping_override.sql:49: NOTICE: identifier "insert_credential_vault_library_ssh_private_key_mapping_override" will be truncated to "insert_credential_vault_library_ssh_private_key_mapping_overrid" The tests should no longer create notices like these. --- ...ial_vault_library_ssh_private_key_mapping_override.sql | 8 ++++---- ...l_vault_library_username_password_mapping_override.sql | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/internal/db/sqltest/tests/credential/vault/credential_vault_library_ssh_private_key_mapping_override.sql b/internal/db/sqltest/tests/credential/vault/credential_vault_library_ssh_private_key_mapping_override.sql index 42aea4642f..011c7c153f 100644 --- a/internal/db/sqltest/tests/credential/vault/credential_vault_library_ssh_private_key_mapping_override.sql +++ b/internal/db/sqltest/tests/credential/vault/credential_vault_library_ssh_private_key_mapping_override.sql @@ -42,22 +42,22 @@ begin; select is(count(*), 0::bigint) from credential_vault_library_ssh_private_key_mapping_override where library_id = 'vl______wvl8'; select is(count(*), 0::bigint) from credential_vault_library_mapping_override where library_id = 'vl______wvl8'; - prepare insert_credential_vault_library_ssh_private_key_mapping_override as + prepare insert_cvl_ssh_private_key_mapping_override as insert into credential_vault_library_ssh_private_key_mapping_override (library_id, username_attribute, private_key_attribute) values ('vl______wvl8', 'my_username', 'my_private_key'); - select lives_ok('insert_credential_vault_library_ssh_private_key_mapping_override'); + select lives_ok('insert_cvl_ssh_private_key_mapping_override'); select is(count(*), 1::bigint) from credential_vault_library_ssh_private_key_mapping_override where library_id = 'vl______wvl8'; select is(count(*), 1::bigint) from credential_vault_library_mapping_override where library_id = 'vl______wvl8'; -- validate the delete triggers - prepare delete_credential_vault_library_ssh_private_key_mapping_override as + prepare delete_cvl_ssh_private_key_mapping_override as delete from credential_vault_library_ssh_private_key_mapping_override where library_id = 'vl______wvl8'; - select lives_ok('delete_credential_vault_library_ssh_private_key_mapping_override'); + select lives_ok('delete_cvl_ssh_private_key_mapping_override'); select is(count(*), 0::bigint) from credential_vault_library_ssh_private_key_mapping_override where library_id = 'vl______wvl8'; select is(count(*), 0::bigint) from credential_vault_library_mapping_override where library_id = 'vl______wvl8'; diff --git a/internal/db/sqltest/tests/credential/vault/credential_vault_library_username_password_mapping_override.sql b/internal/db/sqltest/tests/credential/vault/credential_vault_library_username_password_mapping_override.sql index e7389d1e3c..92ccd468c4 100644 --- a/internal/db/sqltest/tests/credential/vault/credential_vault_library_username_password_mapping_override.sql +++ b/internal/db/sqltest/tests/credential/vault/credential_vault_library_username_password_mapping_override.sql @@ -42,22 +42,22 @@ begin; select is(count(*), 0::bigint) from credential_vault_library_username_password_mapping_override where library_id = 'vl______wvl3'; select is(count(*), 0::bigint) from credential_vault_library_mapping_override where library_id = 'vl______wvl3'; - prepare insert_credential_vault_library_username_password_mapping_override as + prepare insert_cvl_username_password_mapping_override as insert into credential_vault_library_username_password_mapping_override (library_id, username_attribute, password_attribute) values ('vl______wvl3', 'my_username', 'my_password'); - select lives_ok('insert_credential_vault_library_username_password_mapping_override'); + select lives_ok('insert_cvl_username_password_mapping_override'); select is(count(*), 1::bigint) from credential_vault_library_username_password_mapping_override where library_id = 'vl______wvl3'; select is(count(*), 1::bigint) from credential_vault_library_mapping_override where library_id = 'vl______wvl3'; -- validate the delete triggers - prepare delete_credential_vault_library_username_password_mapping_override as + prepare delete_cvl_username_password_mapping_override as delete from credential_vault_library_username_password_mapping_override where library_id = 'vl______wvl3'; - select lives_ok('delete_credential_vault_library_username_password_mapping_override'); + select lives_ok('delete_cvl_username_password_mapping_override'); select is(count(*), 0::bigint) from credential_vault_library_username_password_mapping_override where library_id = 'vl______wvl3'; select is(count(*), 0::bigint) from credential_vault_library_mapping_override where library_id = 'vl______wvl3';