From 9bec68f32cf762e15d3e3004b7f47df9b9f680cd Mon Sep 17 00:00:00 2001 From: Louis Ruch Date: Wed, 24 Nov 2021 11:56:04 -0800 Subject: [PATCH] refact(servers): Cleanup redundant if else (#1741) --- .../servers/controller/session_cleanup_job.go | 23 ++++++++----------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/internal/servers/controller/session_cleanup_job.go b/internal/servers/controller/session_cleanup_job.go index cff63e790f..1eadb51891 100644 --- a/internal/servers/controller/session_cleanup_job.go +++ b/internal/servers/controller/session_cleanup_job.go @@ -95,19 +95,16 @@ func (j *sessionCleanupJob) Run(ctx context.Context) error { return errors.Wrap(ctx, err, op) } - if len(results) < 1 { - } else { - for _, result := range results { - event.WriteError(ctx, op, stderrors.New("worker has not reported status within acceptable grace period, all connections closed"), - event.WithInfo( - "private_id", result.ServerId, - "update_time", result.LastUpdateTime, - "grace_period_seconds", j.gracePeriod, - "number_connections_closed", result.NumberConnectionsClosed, - )) - - j.totalClosed += result.NumberConnectionsClosed - } + for _, result := range results { + event.WriteError(ctx, op, stderrors.New("worker has not reported status within acceptable grace period, all connections closed"), + event.WithInfo( + "private_id", result.ServerId, + "update_time", result.LastUpdateTime, + "grace_period_seconds", j.gracePeriod, + "number_connections_closed", result.NumberConnectionsClosed, + )) + + j.totalClosed += result.NumberConnectionsClosed } return nil