chore(e2e): Fix availability zone check (#5935)

enos/enos-scenario-e2e-aws-base-with-vault.hcl

@@ -34,8 +34,9 @@ scenario "e2e_aws_base_with_vault" {
 
     variables {
       instance_type = [
+        var.controller_instance_type,
         var.worker_instance_type,
-        var.controller_instance_type
+        var.target_instance_type
       ]
     }
   }

enos/enos-scenario-e2e-aws-base.hcl

@@ -34,8 +34,9 @@ scenario "e2e_aws_base" {
 
     variables {
       instance_type = [
+        var.controller_instance_type,
         var.worker_instance_type,
-        var.controller_instance_type
+        var.target_instance_type
       ]
     }
   }

enos/enos-scenario-e2e-aws.hcl

@@ -39,8 +39,9 @@ scenario "e2e_aws" {
 
     variables {
       instance_type = [
+        var.controller_instance_type,
         var.worker_instance_type,
-        var.controller_instance_type
+        var.target_instance_type
       ]
     }
   }

enos/enos-scenario-e2e-database.hcl

@@ -36,8 +36,7 @@ scenario "e2e_database" {
 
     variables {
       instance_type = [
-        var.worker_instance_type,
-        var.controller_instance_type
+        var.target_instance_type
       ]
     }
   }

enos/enos-scenario-e2e-ui-aws.hcl

@@ -35,8 +35,9 @@ scenario "e2e_ui_aws" {
 
     variables {
       instance_type = [
+        var.controller_instance_type,
         var.worker_instance_type,
-        var.controller_instance_type
+        var.target_instance_type
       ]
     }
   }

enos/modules/aws_az_finder/main.tf

@@ -16,14 +16,20 @@ variable "instance_type" {
 }
 
 data "aws_ec2_instance_type_offerings" "infra" {
+  for_each = toset(var.instance_type)
   filter {
     name   = "instance-type"
-    values = var.instance_type
+    values = [each.key]
   }
 
   location_type = "availability-zone"
 }
 
+locals {
+  az_sets    = [for d in data.aws_ec2_instance_type_offerings.infra : toset(d.locations)]
+  common_azs = length(local.az_sets) > 0 ? setintersection(local.az_sets...) : []
+}
+
 output "availability_zones" {
-  value = data.aws_ec2_instance_type_offerings.infra.locations
+  value = local.common_azs
 }