From 8d80d10ff7d3fb3bb6a446876ac05e48fb907372 Mon Sep 17 00:00:00 2001 From: Johan Brandhorst-Satzkorn Date: Tue, 12 Apr 2022 16:56:04 -0400 Subject: [PATCH] fix(controller): Cancel tests on fatal errors (#1994) When requesting a token, any error is fatal to the test. The previous behavior would return a nil token, which could cause subsequent uses to panic. This will instead interrupt any test immediately on error. --- internal/servers/controller/testing.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/servers/controller/testing.go b/internal/servers/controller/testing.go index bf9e46059c..19c805f025 100644 --- a/internal/servers/controller/testing.go +++ b/internal/servers/controller/testing.go @@ -152,7 +152,7 @@ func (tc *TestController) Logger() hclog.Logger { func (tc *TestController) Token() *authtokens.AuthToken { if tc.opts.DisableAuthMethodCreation { - tc.t.Error("no default auth method ID configured") + tc.t.Fatal("no default auth method ID configured") return nil } result, err := authmethods.NewClient(tc.Client()).Authenticate( @@ -165,12 +165,12 @@ func (tc *TestController) Token() *authtokens.AuthToken { }, ) if err != nil { - tc.t.Error(fmt.Errorf("error logging in: %w", err)) + tc.t.Fatal(fmt.Errorf("error logging in: %w", err)) return nil } token := new(authtokens.AuthToken) if err := json.Unmarshal(result.GetRawAttributes(), token); err != nil { - tc.t.Error(fmt.Errorf("error unmarshaling token: %w", err)) + tc.t.Fatal(fmt.Errorf("error unmarshaling token: %w", err)) return nil } return token