From 7bb44b46f5cd2228d63a5a4e9d0c5c7297a31b00 Mon Sep 17 00:00:00 2001
From: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Date: Mon, 3 Apr 2023 16:47:30 -0700
Subject: [PATCH] internal/db: add session recording tables

Add the following new tables used for storing session recordings:

* recording_session
* recording_connection
* recording_channel
* recording_channel_ssh
* storage_bucket
---
 .../68/01_add_session_connection_uq.up.sql    |  12 +
 .../postgres/68/02_add_storage_bucket.up.sql  |  22 ++
 .../postgres/68/03_session_recording.up.sql   | 249 ++++++++++++++++++
 internal/db/sqltest/Makefile                  |   3 +-
 .../tests/recording/recording_channel_ssh.sql |  84 ++++++
 .../tests/recording/recording_connection.sql  | 105 ++++++++
 .../tests/recording/recording_session.sql     |  60 +++++
 7 files changed, 534 insertions(+), 1 deletion(-)
 create mode 100644 internal/db/schema/migrations/oss/postgres/68/01_add_session_connection_uq.up.sql
 create mode 100644 internal/db/schema/migrations/oss/postgres/68/02_add_storage_bucket.up.sql
 create mode 100644 internal/db/schema/migrations/oss/postgres/68/03_session_recording.up.sql
 create mode 100644 internal/db/sqltest/tests/recording/recording_channel_ssh.sql
 create mode 100644 internal/db/sqltest/tests/recording/recording_connection.sql
 create mode 100644 internal/db/sqltest/tests/recording/recording_session.sql

diff --git a/internal/db/schema/migrations/oss/postgres/68/01_add_session_connection_uq.up.sql b/internal/db/schema/migrations/oss/postgres/68/01_add_session_connection_uq.up.sql
new file mode 100644
index 0000000000..ef915eafc2
--- /dev/null
+++ b/internal/db/schema/migrations/oss/postgres/68/01_add_session_connection_uq.up.sql
@@ -0,0 +1,12 @@
+-- Copyright (c) HashiCorp, Inc.
+-- SPDX-License-Identifier: MPL-2.0
+
+begin;
+
+  -- Adds a unique constraint so that the recording_connection
+  -- table can use a foreign key matching both of these.
+  alter table session_connection
+    add constraint session_connection_session_id_public_id_uq
+    unique (session_id, public_id);
+
+commit;
diff --git a/internal/db/schema/migrations/oss/postgres/68/02_add_storage_bucket.up.sql b/internal/db/schema/migrations/oss/postgres/68/02_add_storage_bucket.up.sql
new file mode 100644
index 0000000000..f02ddc68a0
--- /dev/null
+++ b/internal/db/schema/migrations/oss/postgres/68/02_add_storage_bucket.up.sql
@@ -0,0 +1,22 @@
+-- Copyright (c) HashiCorp, Inc.
+-- SPDX-License-Identifier: MPL-2.0
+
+begin;
+  
+  -- Stub for storage plugin storage bucket table
+  create table storage_plugin_storage_bucket (
+    public_id wt_public_id primary key,
+    worker_filter wt_bexprfilter not null
+  );
+
+  -- Stub for storage bucket table
+  create table storage_bucket (
+    public_id wt_public_id primary key,
+    scope_id wt_scope_id
+      constraint iam_scope_fkey
+        references iam_scope (public_id)
+        on delete restrict -- Scopes with storage buckets cannot be deleted
+        on update cascade
+  );
+
+commit;
diff --git a/internal/db/schema/migrations/oss/postgres/68/03_session_recording.up.sql b/internal/db/schema/migrations/oss/postgres/68/03_session_recording.up.sql
new file mode 100644
index 0000000000..8e635e1e56
--- /dev/null
+++ b/internal/db/schema/migrations/oss/postgres/68/03_session_recording.up.sql
@@ -0,0 +1,249 @@
+-- Copyright (c) HashiCorp, Inc.
+-- SPDX-License-Identifier: MPL-2.0
+
+begin;
+
+  create domain rec_timestamp as timestamptz default null;
+  comment on domain rec_timestamp is
+    'a nullable timestamp with a time zone used for start and end times of recordings';
+
+
+  create table recording_session (
+    public_id wt_public_id primary key,
+    storage_bucket_id wt_public_id not null
+      constraint storage_bucket_fkey
+        references storage_bucket (public_id)
+        on delete restrict -- Storage buckets with session recordings cannot be deleted
+        on update cascade,
+    session_id wt_public_id null -- Can be null if associated session has been deleted
+      constraint session_fkey
+        references session (public_id)
+        on delete set null -- Set null if associated session is deleted
+        on update cascade
+      constraint recording_session_session_id_uq unique,
+    create_time wt_timestamp not null,
+    update_time wt_timestamp not null,
+    start_time rec_timestamp null, -- When the session recording was started in the worker
+    -- When the session recording ended in the worker
+    -- Guaranteed to be recorded monotonically relative to start_time.
+    end_time rec_timestamp null
+      constraint end_time_null_or_after_start_time
+        check (end_time > start_time),
+    constraint recording_session_session_id_public_id_uq
+      unique (session_id, public_id)
+  );
+  comment on table recording_session is
+    'recording_session holds metadata for the recording of a session. It outlives the session itself.';
+
+  create trigger update_time_column before update on recording_session
+    for each row execute procedure update_time_column();
+
+  create trigger default_create_time_column before insert on recording_session
+    for each row execute procedure default_create_time();
+
+  create trigger immutable_columns before update on recording_session
+    for each row execute procedure immutable_columns('public_id', 'storage_bucket_id', 'create_time');
+  
+  create trigger set_once_columns before update on recording_session
+    for each row execute procedure set_once_columns('start_time', 'end_time');
+
+  create function check_session_id_not_null() returns trigger
+  as $$
+  begin
+    if new.session_id is null then
+      raise exception 'a new recorded session must have a session_id';
+    end if;
+    return new;
+  end;
+  $$ language plpgsql;
+  comment on function check_session_id_not_null is
+    'check_session_id_not_null ensures that new recorded sessions have a session associated with them.';
+
+  create trigger check_session_id_not_null before insert on recording_session
+    for each row execute procedure check_session_id_not_null();
+
+  create table recording_connection (
+    public_id wt_public_id primary key,
+    session_id wt_public_id null, -- Can be null if associated session has been deleted
+    session_connection_id wt_public_id null -- Can be null if associated connection has been deleted
+      constraint recording_connection_session_connection_id_uq unique,
+    recording_session_id wt_public_id not null,
+    create_time wt_timestamp not null,
+    update_time wt_timestamp not null,
+    start_time rec_timestamp null, -- When the connection recording was started in the worker
+    -- When the connection recording ended in the worker
+    -- Guaranteed to be recorded monotonically relative to start_time.
+    end_time rec_timestamp null
+      constraint end_time_null_or_after_start_time
+        check (end_time > start_time),
+    -- Need to be nullable as we only know them when the connection is closed.
+    bytes_up bigint null
+      constraint bytes_up_null_zero_or_positive
+        check (bytes_up >= 0),
+    bytes_down bigint null
+      constraint bytes_down_null_zero_or_positive
+        check (bytes_down >= 0),
+    constraint session_connection_fkey
+      foreign key (session_id, session_connection_id)
+      references session_connection (session_id, public_id)
+      on delete set null -- Set both IDs null if associated connection/session is deleted
+      on update cascade,
+    constraint recording_session_fkey1
+      foreign key (session_id, recording_session_id)
+      references recording_session (session_id, public_id)
+      on delete cascade -- Note that this doesn't actually cascade deletes from recording_session
+      on update cascade,
+    constraint recording_session_fkey2
+      foreign key (recording_session_id)
+      references recording_session (public_id)
+      on delete cascade -- Cascade deletes from recording_session
+      on update cascade
+  );
+  comment on table recording_connection is
+    'recording_connection holds metadata for a recorded connection. It outlives the connection itself. '
+    'It belongs to exactly one recording_session';
+
+  create trigger update_time_column before update on recording_connection
+    for each row execute procedure update_time_column();
+
+  create trigger default_create_time_column before insert on recording_connection
+    for each row execute procedure default_create_time();
+
+  create trigger immutable_columns before update on recording_connection
+    for each row execute procedure immutable_columns('public_id', 'recording_session_id', 'create_time');
+
+  create trigger set_once_columns before update on recording_connection
+    for each row execute procedure set_once_columns('start_time', 'end_time', 'bytes_up', 'bytes_down');
+
+  create function check_session_id_and_session_connection_id_not_null() returns trigger
+  as $$
+  begin
+    if new.session_id is null then
+      raise exception 'a new recorded connection must have a session_id';
+    end if;
+    if new.session_connection_id is null then
+      raise exception 'a new recorded connection must have a session_connection_id';
+    end if;
+    return new;
+  end;
+  $$ language plpgsql;
+  comment on function check_session_id_and_session_connection_id_not_null is
+    'check_session_id_and_session_connection_id_not_null ensures that new recorded connections have a session and session connection associated with them.';
+
+  create trigger check_session_id_and_session_connection_id_not_null before insert on recording_connection
+    for each row execute procedure check_session_id_and_session_connection_id_not_null();
+
+  create table recording_channel (
+    public_id wt_public_id primary key,
+    recording_connection_id wt_public_id not null
+      constraint recording_connection_fkey
+        references recording_connection (public_id)
+        on delete cascade
+        on update cascade,
+    constraint recording_channel_recording_connection_id_public_id_uq
+      unique (recording_connection_id, public_id)
+  );
+  comment on table recording_channel is
+    'recording_channel is a base table for recorded channel types. It belongs to exactly one recording_connection';
+
+  create trigger immutable_columns before update on recording_channel
+    for each row execute procedure immutable_columns('public_id', 'recording_connection_id');
+
+  create function insert_recording_channel_subtype() returns trigger
+  as $$
+  begin
+    insert into recording_channel
+      (public_id, recording_connection_id)
+    values
+      (new.public_id, new.recording_connection_id);
+    return new;
+  end;
+  $$ language plpgsql;
+  comment on function insert_recording_channel_subtype is
+    'insert_recording_channel_subtype inserts a row into the base table when a row is inserted into a subtype table.';
+
+  create function delete_recording_channel_subtype() returns trigger
+  as $$
+  begin
+    delete
+      from recording_channel
+     where public_id = old.public_id;
+    return null; -- result is ignored since this is an after trigger
+  end;
+  $$ language plpgsql;
+  comment on function delete_recording_channel_subtype is
+    'delete_recording_channel_subtype deletes a row from the base table when a row is deleted in a subtype table.';
+
+
+  -- TODO: We currently only include the channel type here,
+  -- but it's not enough on its own to determine what mime types
+  -- are supported by a channel. We'll need extra information in
+  -- the schema for this, but it's not clear what yet.
+  -- Channel types reference: https://www.iana.org/assignments/ssh-parameters/ssh-parameters.xml#ssh-parameters-11
+  create table recording_channel_ssh_channel_type_enm (
+    name text primary key
+      constraint only_predefined_channel_types_allowed
+        check(name in ('unknown', 'session', 'x11', 'forwarded-tcpip', 'direct-tcpip'))
+  );
+  comment on table recording_channel_ssh_channel_type_enm is
+    'recording_channel_ssh_channel_type_enm holds valid values for the channel_type of a recording_channel_ssh row. '
+    'Some known channel types are defined in https://www.iana.org/assignments/ssh-parameters/ssh-parameters.xml#ssh-parameters-11';
+
+  insert into recording_channel_ssh_channel_type_enm (name)
+  values
+    ('unknown'),
+    ('session'),
+    ('x11'),
+    ('forwarded-tcpip'),
+    ('direct-tcpip');
+
+  create trigger immutable_columns before update on recording_channel_ssh_channel_type_enm
+    for each row execute procedure immutable_columns('name');
+
+  create table recording_channel_ssh (
+    public_id wt_public_id primary key,
+    recording_connection_id wt_public_id not null,
+    create_time wt_timestamp not null,
+    update_time wt_timestamp not null,
+    start_time rec_timestamp not null, -- When the channel recording was started in the worker
+    -- When the channel recording ended in the worker
+    -- Guaranteed to be recorded monotonically relative to start_time.
+    end_time rec_timestamp not null
+      constraint end_time_after_start_time
+        check (end_time > start_time),
+    bytes_up bigint not null
+      constraint bytes_up_zero_or_positive
+        check (bytes_up >= 0),
+    bytes_down bigint not null
+      constraint bytes_down_zero_or_positive
+        check (bytes_down >= 0),
+    channel_type text not null
+      constraint recording_channel_ssh_channel_type_enm_fkey
+        references recording_channel_ssh_channel_type_enm (name)
+        on delete restrict
+        on update cascade,
+    constraint recording_channel_fkey
+      foreign key (public_id, recording_connection_id)
+        references recording_channel (public_id, recording_connection_id)
+        on delete cascade
+        on update cascade
+  );
+  comment on table recording_channel_ssh is
+    'recording_channel_ssh is a subtype table for a recorded ssh channel. It belongs to exactly one recording_connection';
+
+  create trigger update_time_column before update on recording_channel_ssh
+    for each row execute procedure update_time_column();
+
+  create trigger default_create_time_column before insert on recording_channel_ssh
+    for each row execute procedure default_create_time();
+
+  create trigger immutable_columns before update on recording_channel_ssh
+    for each row execute procedure immutable_columns('public_id', 'recording_connection_id', 'create_time', 'start_time', 'end_time', 'bytes_up', 'bytes_down', 'channel_type');
+
+  create trigger insert_recording_channel_subtype before insert on recording_channel_ssh
+    for each row execute procedure insert_recording_channel_subtype();
+
+  create trigger delete_recording_channel_subtype after delete on recording_channel_ssh
+    for each row execute procedure delete_recording_channel_subtype();
+
+commit;
diff --git a/internal/db/sqltest/Makefile b/internal/db/sqltest/Makefile
index b149746f95..fe88b398d5 100644
--- a/internal/db/sqltest/Makefile
+++ b/internal/db/sqltest/Makefile
@@ -27,7 +27,8 @@ TESTS ?= tests/setup/*.sql \
 		 tests/target/*.sql \
 		 tests/controller/*.sql \
 		 tests/hcp/*/*.sql \
-		 tests/kms/*.sql
+		 tests/kms/*.sql \
+		 tests/recording/*.sql
 
 POSTGRES_DOCKER_IMAGE_BASE ?= postgres
 
diff --git a/internal/db/sqltest/tests/recording/recording_channel_ssh.sql b/internal/db/sqltest/tests/recording/recording_channel_ssh.sql
new file mode 100644
index 0000000000..c15d4f62ca
--- /dev/null
+++ b/internal/db/sqltest/tests/recording/recording_channel_ssh.sql
@@ -0,0 +1,84 @@
+-- Copyright (c) HashiCorp, Inc.
+-- SPDX-License-Identifier: MPL-2.0
+
+-- recording_channel_ssh tests the following triggers:
+--    insert_recording_channel_subtype
+--    delete_recording_channel_subtype
+-- and the following constraints:
+--    end_time_null_or_after_start_time
+--    bytes_up_null_zero_or_positive
+--    bytes_down_null_zero_or_positive
+
+begin;
+  select plan(9);
+  select wtt_load('widgets', 'iam', 'kms', 'auth', 'hosts', 'targets', 'sessions');
+  
+  insert into storage_bucket (public_id, scope_id) values ('sb_123456789', 'global');
+  insert into recording_session
+    (public_id,      storage_bucket_id, session_id)
+  values
+    ('sr_123456789', 'sb_123456789',    's1_____clare');
+  insert into session_connection
+    (public_id,      session_id)
+  values
+    ('sc_123456789', 's1_____clare');
+  insert into recording_connection
+    (public_id,      session_id,     session_connection_id, recording_session_id)
+  values
+    ('cr_123456789', 's1_____clare', 'sc_123456789',        'sr_123456789');
+
+  -- Try to set end_time before start_time
+  prepare end_time_before_start_time as
+    insert into recording_channel_ssh
+      (public_id,       recording_connection_id, start_time,                     end_time,                                        bytes_up, bytes_down, channel_type)
+    values
+      ('chr_123456789', 'cr_123456789',          clock_timestamp()::timestamptz, clock_timestamp()::timestamptz - '1s'::interval, 10,       10,         'session');
+  select throws_ok('end_time_before_start_time', '23514', null, 'inserting a row with end_time before star_time succeeded');
+
+  -- Try to set bytes_up to a negative number
+  prepare negative_bytes_up as
+    insert into recording_channel_ssh
+      (public_id,       recording_connection_id, start_time,                     end_time,                                        bytes_up, bytes_down, channel_type)
+    values
+      ('chr_123456789', 'cr_123456789',          clock_timestamp()::timestamptz, clock_timestamp()::timestamptz + '1s'::interval, -1,       10,         'session');
+  select throws_ok('negative_bytes_up', '23514', null, 'inserting a row with a negative bytes_up value succeeded');
+
+  -- Try to set bytes_down to a negative number
+  prepare negative_bytes_down as
+    insert into recording_channel_ssh
+      (public_id,       recording_connection_id, start_time,                     end_time,                                        bytes_up, bytes_down, channel_type)
+    values
+      ('chr_123456789', 'cr_123456789',          clock_timestamp()::timestamptz, clock_timestamp()::timestamptz + '1s'::interval, 10,       -1,         'session');
+  select throws_ok('negative_bytes_down', '23514', null, 'inserting a row with a negative bytes_down value succeeded');
+
+  -- Check that there are no rows
+  select is(count(*), 0::bigint) from recording_channel;
+
+  insert into recording_channel_ssh
+    (public_id,       recording_connection_id, start_time,                     end_time,                                        bytes_up, bytes_down, channel_type)
+  values
+    ('chr_123456789', 'cr_123456789',          clock_timestamp()::timestamptz, clock_timestamp()::timestamptz + '1s'::interval, 10,       10,         'session');
+
+  -- Check that a row was inserted
+  select is(count(*), 1::bigint) from recording_channel where public_id = 'chr_123456789' and recording_connection_id = 'cr_123456789';
+  
+  -- Deleting the session connection should leave the recording in place
+  delete from session_connection where public_id = 'sc_123456789';
+  -- Row should still be present
+  select is(count(*), 1::bigint) from recording_channel where public_id = 'chr_123456789';
+
+  -- Deleting the session should leave the recording in place
+  delete from session where public_id = 's1_____clare';
+  -- Row should still be present
+  select is(count(*), 1::bigint) from recording_channel where public_id = 'chr_123456789';
+
+  -- Deleting the session recording should cascade to the channel recording
+  delete from recording_session where public_id = 'sr_123456789';
+  -- Row should be deleted
+  select is(count(*), 0::bigint) from recording_channel where public_id = 'chr_123456789';
+
+  -- Check that it was also deleted from recording_channel
+  select is(count(*), 0::bigint) from recording_channel;
+
+  select * from finish();
+rollback;
diff --git a/internal/db/sqltest/tests/recording/recording_connection.sql b/internal/db/sqltest/tests/recording/recording_connection.sql
new file mode 100644
index 0000000000..cfd12063c8
--- /dev/null
+++ b/internal/db/sqltest/tests/recording/recording_connection.sql
@@ -0,0 +1,105 @@
+-- Copyright (c) HashiCorp, Inc.
+-- SPDX-License-Identifier: MPL-2.0
+
+-- recording_connection tests the following triggers:
+--    check_session_id_and_session_connection_id_not_null
+--    set_once_columns
+-- and the following constraints:
+--    end_time_null_or_after_start_time
+--    bytes_up_null_zero_or_positive
+--    bytes_down_null_zero_or_positive
+
+begin;
+  select plan(10);
+  select wtt_load('widgets', 'iam', 'kms', 'auth', 'hosts', 'targets', 'sessions');
+  
+  insert into storage_bucket (public_id, scope_id) values ('sb_123456789', 'global');
+  insert into recording_session
+    (public_id,      storage_bucket_id, session_id)
+  values
+    ('sr_123456789', 'sb_123456789',    's1_____clare');
+  insert into session_connection
+    (public_id,      session_id)
+  values
+    ('sc_123456789', 's1_____clare');
+
+  -- Try to insert row with null session id
+  prepare insert_recording_connection_with_null_session_id as
+    insert into recording_connection
+      (public_id,      session_id, session_connection_id, recording_session_id)
+    values
+      ('cr_123456789', null,       'sc_123456789',        'sr_123456789');
+  select throws_ok('insert_recording_connection_with_null_session_id', null, null, 'insert recording_connection with null session_id succeeded');
+  
+  -- Try to insert row with null session connection id
+  prepare insert_recording_connection_with_null_session_connection_id as
+    insert into recording_connection
+      (public_id,      session_id,     session_connection_id, recording_session_id)
+    values
+      ('cr_123456789', 's1_____clare', null,                  'sr_123456789');
+  select throws_ok('insert_recording_connection_with_null_session_connection_id', null, null, 'insert recording_connection with null session_connection_id succeeded');
+
+  insert into recording_connection
+    (public_id,      session_id,     session_connection_id, recording_session_id)
+  values
+    ('cr_123456789', 's1_____clare', 'sc_123456789',        'sr_123456789');
+
+  -- Try to set end_time before start_time
+  prepare set_end_time_before_start_time as
+    update recording_connection set
+      start_time = clock_timestamp()::timestamptz,
+      end_time = clock_timestamp()::timestamptz - '1s'::interval,
+      bytes_up = 10,
+      bytes_down = 10
+    where public_id = 'cr_123456789';
+  select throws_ok('set_end_time_before_start_time', '23514', null, 'setting an end_time before the start_time succeeded');
+
+  -- Try to set bytes_up to a negative number
+  prepare set_negative_bytes_up as
+    update recording_connection set
+      start_time = clock_timestamp()::timestamptz,
+      end_time = clock_timestamp()::timestamptz + '1s'::interval,
+      bytes_up = -1,
+      bytes_down = 10
+    where public_id = 'cr_123456789';
+  select throws_ok('set_negative_bytes_up', '23514', null, 'setting a negative bytes_up value succeeded');
+
+  -- Try to set bytes_down to a negative number
+  prepare set_negative_bytes_down as
+    update recording_connection set
+      start_time = clock_timestamp()::timestamptz,
+      end_time = clock_timestamp()::timestamptz + '1s'::interval,
+      bytes_up = 10,
+      bytes_down = -1
+    where public_id = 'cr_123456789';
+  select throws_ok('set_negative_bytes_down', '23514', null, 'setting a negative bytes_down value succeeded');
+
+  prepare close_recording_connection as
+    update recording_connection set
+      start_time = clock_timestamp()::timestamptz,
+      end_time = clock_timestamp()::timestamptz + '1s'::interval,
+      bytes_up = 10,
+      bytes_down = 10
+    where public_id = 'cr_123456789';
+  select lives_ok('close_recording_connection');
+
+  -- Closing again should fail
+  select throws_ok('close_recording_connection', '23602', null, 'closing a recording_connection twice succeeded');
+  
+  -- Deleting the session connection should leave the recording in place
+  delete from session_connection where public_id = 'sc_123456789';
+  -- Row should still be present
+  select is(count(*), 1::bigint) from recording_connection where public_id = 'cr_123456789';
+
+  -- Deleting the session should leave the recording in place
+  delete from session where public_id = 's1_____clare';
+  -- Row should still be present
+  select is(count(*), 1::bigint) from recording_connection where public_id = 'cr_123456789';
+
+  -- Deleting the session recording should cascade to the connection recording
+  delete from recording_session where public_id = 'sr_123456789';
+  -- Row should be deleted
+  select is(count(*), 0::bigint) from recording_connection where public_id = 'cr_123456789';
+
+  select * from finish();
+rollback;
diff --git a/internal/db/sqltest/tests/recording/recording_session.sql b/internal/db/sqltest/tests/recording/recording_session.sql
new file mode 100644
index 0000000000..2a846b0e2e
--- /dev/null
+++ b/internal/db/sqltest/tests/recording/recording_session.sql
@@ -0,0 +1,60 @@
+-- Copyright (c) HashiCorp, Inc.
+-- SPDX-License-Identifier: MPL-2.0
+
+-- recording_session tests the following triggers:
+--    check_session_id_not_null
+--    set_once_columns
+-- and the following constraints:
+--    end_time_null_or_after_start_time
+
+begin;
+  select plan(7);
+  select wtt_load('widgets', 'iam', 'kms', 'auth', 'hosts', 'targets', 'sessions');
+  
+  insert into storage_bucket (public_id, scope_id) values ('sb_123456789', 'global');
+
+  -- Try to insert row with null session id
+  prepare insert_invalid_recording_session as
+    insert into recording_session
+      (public_id,      storage_bucket_id, session_id)
+    values
+      ('sr_123456789', 'sb_123456789',    null);
+  select throws_ok('insert_invalid_recording_session', null, null, 'insert invalid recording_session succeeded');
+
+  prepare insert_recording_session as
+    insert into recording_session
+      (public_id,      storage_bucket_id, session_id)
+    values
+      ('sr_123456789', 'sb_123456789',    's1_____clare');
+  select lives_ok('insert_recording_session');
+
+  -- Try to set end_time before start_time
+  prepare invalid_close_recording_session as
+    update recording_session set
+      start_time = clock_timestamp()::timestamptz,
+      end_time = clock_timestamp()::timestamptz - '1s'::interval
+    where public_id = 'sr_123456789';
+  select throws_ok('invalid_close_recording_session', '23514', null, 'setting end_time before start_time succeeded');
+
+  prepare close_recording_session as
+    update recording_session set
+      start_time = clock_timestamp()::timestamptz,
+      end_time = clock_timestamp()::timestamptz + '1s'::interval
+    where public_id = 'sr_123456789';
+  select lives_ok('close_recording_session');
+
+  -- Closing a second time should error
+  select throws_ok('close_recording_session', '23602', null, 'closing a recording_session twice succeeded');
+
+  -- Deleting the session should leave the recording in place
+  delete from session where public_id = 's1_____clare';
+  -- Row should still be present
+  select is(count(*), 1::bigint) from recording_session where public_id = 'sr_123456789';
+
+  -- Deleting the storage bucket with active recordings should fail
+  prepare delete_bucket as
+    delete from storage_bucket where public_id = 'sb_123456789';
+  select throws_ok('delete_bucket', null, null, 'deleting a storage_bucket with recordings succeeded');
+
+  select * from finish();
+rollback;