backport of commit 37f3ebf385

pull/4419/head
Johan Brandhorst-Satzkorn 2 years ago
parent a16b08b845
commit 59ff4e1afd

@ -114,10 +114,6 @@ func (s Service) ListGroups(ctx context.Context, req *pbs.ListGroupsRequest) (*p
if err != nil {
return nil, err
}
// If no scopes match, return an empty response
if len(scopeIds) == 0 {
return &pbs.ListGroupsResponse{}, nil
}
pageSize := int(s.maxPageSize)
// Use the requested page size only if it is smaller than

@ -801,6 +801,28 @@ func TestListPagination(t *testing.T) {
protocmp.IgnoreFields(&pbs.ListGroupsResponse{}, "list_token"),
),
)
// Create unauthenticated user
unauthAt := authtoken.TestAuthToken(t, conn, kms, oWithGroups.GetPublicId())
unauthR := iam.TestRole(t, conn, pWithGroups.GetPublicId())
_ = iam.TestUserRole(t, conn, unauthR.GetPublicId(), unauthAt.GetIamUserId())
// Make a request with the unauthenticated user,
// ensure the response is 403 forbidden.
requestInfo = authpb.RequestInfo{
TokenFormat: uint32(auth.AuthTokenTypeBearer),
PublicId: unauthAt.GetPublicId(),
Token: unauthAt.GetToken(),
}
requestContext = context.WithValue(context.Background(), requests.ContextRequestInformationKey, &requests.RequestContext{})
ctx = auth.NewVerifierContext(requestContext, iamRepoFn, tokenRepoFn, serversRepoFn, kms, &requestInfo)
_, err = a.ListGroups(ctx, &pbs.ListGroupsRequest{
ScopeId: "global",
Recursive: true,
})
require.Error(t, err)
assert.Equal(t, handlers.ForbiddenError(), err)
}
func TestDelete(t *testing.T) {

Loading…
Cancel
Save