From 4636efce8f8b547f7c7ebfddaa4d85dc44cb95c0 Mon Sep 17 00:00:00 2001 From: Jim Date: Fri, 15 Apr 2022 12:20:44 -0400 Subject: [PATCH] refactor (tests): GetEventDetails(...) will stop returning nil (#2019) --- internal/tests/api/testing.go | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/internal/tests/api/testing.go b/internal/tests/api/testing.go index 0a561f4710..2f46405409 100644 --- a/internal/tests/api/testing.go +++ b/internal/tests/api/testing.go @@ -3,6 +3,7 @@ package api import ( "encoding/json" "io/ioutil" + "reflect" "testing" "github.com/hashicorp/eventlogger/filters/encrypt" @@ -31,18 +32,11 @@ func GetEventDetails(t *testing.T, e *cloudevents.Event, messageType string) map require.NotNil(e) require.NotEmpty(messageType) data, ok := e.Data.(map[string]interface{}) - if !ok { - return nil - } + require.Truef(ok, "event was not a map[string]interface") msgType, ok := data[messageType].(map[string]interface{}) - if !ok { - return nil - } - + require.Truef(ok, "event data did not contain a %q. Current keys: %q", messageType, reflect.ValueOf(data).MapKeys()) details, ok := msgType["details"].(map[string]interface{}) - if !ok { - return nil - } + require.Truef(ok, `%q of event did not contain "details"`, messageType) return details }