From 2a78c81b3e2b7e36b24d2b6dd46068defa54cc5e Mon Sep 17 00:00:00 2001 From: Jeff Malnick Date: Mon, 5 Oct 2020 15:55:25 -0700 Subject: [PATCH] Make errors more helpful by including possible flags --- .../servers/controller/handlers/targets/target_service.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/servers/controller/handlers/targets/target_service.go b/internal/servers/controller/handlers/targets/target_service.go index fe4ddd35c4..4f4dd17fac 100644 --- a/internal/servers/controller/handlers/targets/target_service.go +++ b/internal/servers/controller/handlers/targets/target_service.go @@ -703,10 +703,10 @@ func validateCreateRequest(req *pbs.CreateTargetRequest) error { return handlers.ValidateCreateRequest(req.GetItem(), func() map[string]string { badFields := map[string]string{} if !handlers.ValidId(scope.Project.Prefix(), req.GetItem().GetScopeId()) { - badFields["scope_id"] = "This field is required to have a properly formatted project scope id." + badFields["scope_id"] = "This field is required to have a properly formatted project scope id. Try '-scope-id '." } if req.GetItem().GetName() == nil || req.GetItem().GetName().GetValue() == "" { - badFields["name"] = "This field is required." + badFields["name"] = "Name field is required. Try '-name '." } if req.GetItem().GetSessionConnectionLimit() != nil { val := req.GetItem().GetSessionConnectionLimit().GetValue() @@ -714,11 +714,11 @@ func validateCreateRequest(req *pbs.CreateTargetRequest) error { case val == -1: case val > 0: default: - badFields["session_connection_limit"] = "This must be -1 (unlimited) or greater than zero." + badFields["session_connection_limit"] = "Session connection limit must be -1 (unlimited) or greater than zero. Try '-session-connection-limit '." } } if req.GetItem().GetSessionMaxSeconds() != nil && req.GetItem().GetSessionMaxSeconds().GetValue() == 0 { - badFields["session_max_seconds"] = "This must be greater than zero." + badFields["session_max_seconds"] = "Session max seconds must be greater than zero. Try '-session-max-seconds '." } switch target.SubtypeFromType(req.GetItem().GetType()) { case target.TcpSubType: