From 1f0748a8c3bb4a000bea03e06233f9c8e2b79135 Mon Sep 17 00:00:00 2001 From: Jeff Mitchell Date: Tue, 5 May 2020 14:02:46 -0400 Subject: [PATCH] Don't make Id fields pointers as they are immutable --- api/internal/genapi/parse.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/api/internal/genapi/parse.go b/api/internal/genapi/parse.go index 75abfbe671..2f0cc93666 100644 --- a/api/internal/genapi/parse.go +++ b/api/internal/genapi/parse.go @@ -116,7 +116,11 @@ func parsePBs() { var selectorExpr *ast.SelectorExpr switch typ := field.Type.(type) { case *ast.Ident: - typ.Name = "*" + typ.Name + // Id values are immutable and should always exist, so + // don't make it a pointer + if field.Names[0].Name != "Id" { + typ.Name = "*" + typ.Name + } goto TAGMODIFY case *ast.ArrayType: goto TAGMODIFY