From 1bbe510384749bbcfec60ae5f2d95a96fe2732aa Mon Sep 17 00:00:00 2001 From: Johan Brandhorst-Satzkorn Date: Wed, 14 Feb 2024 18:10:10 -0800 Subject: [PATCH] handlers/managed_groups: test for pagination parameters Note that this already always returned the pagination parameters, but now we have a test that it does so. --- .../managed_group_service_test.go | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/internal/daemon/controller/handlers/managed_groups/managed_group_service_test.go b/internal/daemon/controller/handlers/managed_groups/managed_group_service_test.go index 3ac8ebc972..c94058e1b2 100644 --- a/internal/daemon/controller/handlers/managed_groups/managed_group_service_test.go +++ b/internal/daemon/controller/handlers/managed_groups/managed_group_service_test.go @@ -997,6 +997,27 @@ func TestListPagination(t *testing.T) { protocmp.IgnoreFields(&pbs.ListManagedGroupsResponse{}, "list_token"), ), ) + + // Create unauthenticated user + unauthAt := authtoken.TestAuthToken(t, conn, kmsCache, o.GetPublicId()) + unauthR := iam.TestRole(t, conn, pwt.GetPublicId()) + _ = iam.TestUserRole(t, conn, unauthR.GetPublicId(), unauthAt.GetIamUserId()) + + // Make a request with the unauthenticated user, + // ensure the response contains the pagination parameters. + requestInfo = authpb.RequestInfo{ + TokenFormat: uint32(auth.AuthTokenTypeBearer), + PublicId: unauthAt.GetPublicId(), + Token: unauthAt.GetToken(), + } + requestContext = context.WithValue(context.Background(), requests.ContextRequestInformationKey, &requests.RequestContext{}) + ctx = auth.NewVerifierContext(requestContext, iamRepoFn, tokenRepoFn, serversRepoFn, kmsCache, &requestInfo) + + _, err = s.ListManagedGroups(ctx, &pbs.ListManagedGroupsRequest{ + AuthMethodId: authMethod.GetPublicId(), + }) + require.Error(t, err) + assert.ErrorIs(t, handlers.ForbiddenError(), err) }) t.Run("ldap", func(t *testing.T) { @@ -1296,6 +1317,27 @@ func TestListPagination(t *testing.T) { protocmp.IgnoreFields(&pbs.ListManagedGroupsResponse{}, "list_token"), ), ) + + // Create unauthenticated user + unauthAt := authtoken.TestAuthToken(t, conn, kmsCache, o.GetPublicId()) + unauthR := iam.TestRole(t, conn, pwt.GetPublicId()) + _ = iam.TestUserRole(t, conn, unauthR.GetPublicId(), unauthAt.GetIamUserId()) + + // Make a request with the unauthenticated user, + // ensure the response contains the pagination parameters. + requestInfo = authpb.RequestInfo{ + TokenFormat: uint32(auth.AuthTokenTypeBearer), + PublicId: unauthAt.GetPublicId(), + Token: unauthAt.GetToken(), + } + requestContext = context.WithValue(context.Background(), requests.ContextRequestInformationKey, &requests.RequestContext{}) + ctx = auth.NewVerifierContext(requestContext, iamRepoFn, tokenRepoFn, serversRepoFn, kmsCache, &requestInfo) + + _, err = s.ListManagedGroups(ctx, &pbs.ListManagedGroupsRequest{ + AuthMethodId: authMethod.GetPublicId(), + }) + require.Error(t, err) + assert.ErrorIs(t, handlers.ForbiddenError(), err) }) }