From 14b3237a69aa2e630ab165c0c6de4ab8becf0bf7 Mon Sep 17 00:00:00 2001 From: Sepehr Date: Fri, 22 Sep 2023 07:16:32 -0400 Subject: [PATCH] fix (telemetry): filtering events: fix default deny filter behavior --- internal/event/cloudevents_formatter_node.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/internal/event/cloudevents_formatter_node.go b/internal/event/cloudevents_formatter_node.go index ae436bb21d..d4dd6c7eb9 100644 --- a/internal/event/cloudevents_formatter_node.go +++ b/internal/event/cloudevents_formatter_node.go @@ -69,13 +69,16 @@ func newCloudEventsFormatterFilter(source *url.URL, format cloudevents.Format, o } n.deny = append(n.deny, f) } - } else { + } + // if the user does not specify any filter (allow/deny), we add default deny filter + if len(opts.withDeny) == 0 && len(opts.withAllow) == 0 { defaultDenyFilters, err := defaultCloudEventsDenyFilters() if err != nil { return nil, err } n.deny = append(n.deny, defaultDenyFilters...) } + n.Predicate = newPredicate(n.allow, n.deny) return &n, nil }