From 0cfd8279b0699ac07496f2d736b6bce1d19fbae5 Mon Sep 17 00:00:00 2001 From: Timothy Messier Date: Thu, 2 Dec 2021 16:32:19 -0500 Subject: [PATCH] fix(controller/targets): Fix creation of credential libraries The arg order was incorrect for ingress/egress credentials. Ref: 2cc58ff9014deb3cf48d1d2fe158467978ff2a0e Blame: 36f1ae75f714efc3091e28714cb18e9a9148f298 --- .../servers/controller/handlers/targets/target_service.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/servers/controller/handlers/targets/target_service.go b/internal/servers/controller/handlers/targets/target_service.go index 2d9da18b5b..95f7a196e5 100644 --- a/internal/servers/controller/handlers/targets/target_service.go +++ b/internal/servers/controller/handlers/targets/target_service.go @@ -1351,7 +1351,7 @@ func (s Service) addCredentialSourcesInRepo(ctx context.Context, targetId string if err != nil { return nil, nil, nil, err } - credLibs, err := createCredLibs(targetId, applicationIds, egressIds, nil) + credLibs, err := createCredLibs(targetId, applicationIds, nil, egressIds) if err != nil { return nil, nil, nil, handlers.ApiErrorWithCodeAndMessage(codes.Internal, "Unable to set credential sources in target: %v.", err) } @@ -1374,7 +1374,7 @@ func (s Service) setCredentialSourcesInRepo(ctx context.Context, targetId string return nil, nil, nil, err } - credLibs, err := createCredLibs(targetId, applicationIds, egressIds, nil) + credLibs, err := createCredLibs(targetId, applicationIds, nil, egressIds) if err != nil { return nil, nil, nil, handlers.ApiErrorWithCodeAndMessage(codes.Internal, "Unable to set credential sources in target: %v.", err) } @@ -1402,7 +1402,7 @@ func (s Service) removeCredentialSourcesInRepo(ctx context.Context, targetId str return nil, nil, nil, err } - credLibs, err := createCredLibs(targetId, applicationIds, egressIds, nil) + credLibs, err := createCredLibs(targetId, applicationIds, nil, egressIds) if err != nil { return nil, nil, nil, handlers.ApiErrorWithCodeAndMessage(codes.Internal, "Unable to set credential sources in target: %v.", err) }