From 0231fbe68c5556e8a218e85851c9ee2ceb91e8be Mon Sep 17 00:00:00 2001 From: Jim Lambert Date: Wed, 10 Jun 2020 07:03:51 -0400 Subject: [PATCH] minor changes to remove a line of dead code and update a comment --- internal/oplog/oplog_test.go | 1 - internal/oplog/writer.go | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/internal/oplog/oplog_test.go b/internal/oplog/oplog_test.go index 0824cbc80b..428453c818 100644 --- a/internal/oplog/oplog_test.go +++ b/internal/oplog/oplog_test.go @@ -430,7 +430,6 @@ func Test_Replay(t *testing.T) { assert.Equal(foundUser.Id, foundReplayedUser.Id) assert.Equal(foundUser.Name, foundReplayedUser.Name) - // assert.Equal(foundUser.Name, userName) assert.Equal(foundUser.PhoneNumber, foundReplayedUser.PhoneNumber) assert.Equal(foundReplayedUser.PhoneNumber, "867-5309") assert.Equal(foundUser.Email, foundReplayedUser.Email) diff --git a/internal/oplog/writer.go b/internal/oplog/writer.go index 6581c8086b..94462d9a1c 100644 --- a/internal/oplog/writer.go +++ b/internal/oplog/writer.go @@ -54,9 +54,8 @@ func (w *GormWriter) Create(i interface{}) error { } // Update the entry using the fieldMaskPaths and setNullPaths, which are -// Paths from field_mask.proto. fieldMaskPaths is required. setToNullPaths is -// optional. fieldMaskPaths and setNullPaths cannot intersect and both cannot be -// zero len. +// Paths from field_mask.proto. fieldMaskPaths and setNullPaths cannot +// intersect and both cannot be zero len. func (w *GormWriter) Update(i interface{}, fieldMaskPaths, setToNullPaths []string) error { if w.Tx == nil { return errors.New("update Tx is nil")