84 Commits (7ca4ec00ee0bd1406751f1bca472e4fa6d4caca7)

Author	SHA1	Message	Date
Justin Baur	c6dccc354c	[PS-1092] Organization Service Observables (#3462) ... * Update imports * Implement observables in a few places * Add tests * Get all clients working * Use _destroy * Address PR feedback * Address PR feedback * Address feedback	4 years ago
Colton Hurst	d168d5ee9b	Fix last seen & spacing issue (#3567) ... * Fix last seen & spacing issue * Address PR comments, moving try catch to config service	4 years ago
Thomas Rittson	5ffa3ccd20	Prevent banned imports into libs/common (#3599) ... Also fix typescript-eslint/parser config and fix linting errors	4 years ago
Gbubemi Smith	22a878792e	[SG-168] Passwordless login web MVP (#3424) ... * passwordless login page redesign * passwordless login page redesign * restyled login form to use tailwind * restyled login form to use tailwind * moved texts on login device template to locales * made reactive form changes for clients * added request model * made more changes * added implmentation to auth request api * fixed refrencing issue * renamed model property * Added resend notification functionality * Added new file * login with device first draft * login with device first draft * login with device first draft * login with device first draft * connection to anonymous hub * connection to anonymous hub * refactored confirm login response * removed comment * cleaned up login * changed uptyped form builder * changed uptyped form builder * [SG-168] Update login strategy with passwordless login credentials. * [SG-168] Removed logs. Changed inputs for passwordless logic strategy. Removed tokenRequestPasswordless it is using the same as password. * code cleanup * code cleanup * removed login with device from self hosted * fixed PR comments * added module for login * fixed post request bug * added feature flag * added feature flag * added feature flag Co-authored-by: André Bispo <abispo@bitwarden.com>	4 years ago
Robyn MacCallum	f4e61d1cec	[SG-520] Native messaging handler (#3566) ... * [SG-523] Base test runner app for native messages (#3269) * Base test runner app for native messages * Remove default test script * Add case for canceled status * Modify to allow usage of libs crypto services and functions * Small adjustments * Handshake request (#3277) * Handshake request * Fix capitalization * Update info text * lock node-ipc to 9.2.1 * [SG-569] Native Messaging settings bug (#3285) * Fix bug where updating setting wasn't starting the native messaging listener * Update test runner error message * [SG-532] Implement Status command in Native Messaging Service (#3310) * Status command start * Refactor ipc test service and add status command * fixed linter errors * Move types into a model file * Cleanup and comments * Fix auth status condition * Remove .vscode settings file. Fix this in a separate work item * Add active field to status response * Extract native messaging types into their own files * Remove experimental decorators * Turn off no console lint rule for the test runner * Casing fix * Models import casing fixes * Remove in progress file (merge error) * Move models to their own folder and add index.ts * Remove file that got un-deleted * Remove file that will be added in separate command * Fix imports that got borked * [SG-533] Implement bw-credential-retrieval (#3334) * Status command start * Refactor ipc test service and add status command * fixed linter errors * Move types into a model file * Cleanup and comments * Fix auth status condition * Remove .vscode settings file. Fix this in a separate work item * Implement bw-credential-retrieval * Add active field to status response * Extract native messaging types into their own files * Remove experimental decorators * Turn off no console lint rule for the test runner * Casing fix * Models import casing fixes * Add error handling for passing a bad public key to handshake * [SG-534] and [SG-535] Implement Credential Create and Update commands (#3342) * Status command start * Refactor ipc test service and add status command * fixed linter errors * Move types into a model file * Cleanup and comments * Fix auth status condition * Remove .vscode settings file. Fix this in a separate work item * Implement bw-credential-retrieval * Add active field to status response * Add bw-credential-create * Better response handling in test runner * Extract native messaging types into their own files * Remove experimental decorators * Turn off no console lint rule for the test runner * Casing fix * Models import casing fixes * bw-cipher-create move type into its own file * Use LogUtils for all logging * Implement bw-credential-update * Give naming conventions for types * Rename file correctly * Update handleEncyptedMessage with EncString changes * [SG-626] Fix Desktop app not showing updated credentials from native messages (#3380) * Add MessagingService to send messages on login create and update * Add `not-active-user` error to create and update and other refactors * [SG-536] Implement bw-generate-password (#3370) * implement bw-generate-password * Fix merge conflict resolution errors * Update apps/desktop/native-messaging-test-runner/src/bw-generate-password.ts Co-authored-by: Addison Beck <addisonbeck1@gmail.com> * Logging improvements * Add NativeMessagingVersion enum * Add version check in NativeMessagingHandler Co-authored-by: Addison Beck <addisonbeck1@gmail.com> * Refactor account status checks and check for locked state in generate command (#3461) * Add feawture flag to show/hide ddg setting (#3506) * [SG-649] Add confirmation dialog and tweak shared key retrieval (#3451) * Add confirmation dialog when completing handshake * Copy updates for dialog * HandshakeResponse type fixes * Add longer timeout for handshake command * [SG-663] RefactorNativeMessagingHandlerService and strengthen typing (#3551) * NativeMessageHandlerService refactor and additional types * Return empty array if no uri to retrieve command * Move commands from test runner into a separate folder * Fix bug where confirmation dialog messes with styling * Enable DDG feature * Fix generated password not saving to history * Take credentialId as parameter to update * Add applicationName to handshake payload * Add warning text to confirmation modal Co-authored-by: Addison Beck <addisonbeck1@gmail.com>	4 years ago
Matt Gibson	df9e6e21c9	Ps 1291/apply to from json pattern to state (#3425) ... * Clean up dangling behaviorSubject * Handle null in utils * fix null check * Await promises, even in async functions * Add to/fromJSON methods to State and Accounts This is needed since all storage in manifest v3 is key-value-pair-based and session storage of most data is actually serialized into an encrypted string. * Simplify AccountKeys json parsing * Fix account key (de)serialization * Remove unused DecodedToken state * Correct filename typo * Simplify keys `toJSON` tests * Explain AccountKeys `toJSON` return type * Remove unnecessary `any`s * Remove unique ArrayBuffer serialization * Initialize items in MemoryStorageService * Revert "Fix account key (de)serialization" This reverts commit b1dffb5c2c, which was breaking serializations * Move fromJSON to owning object * Add DeepJsonify type * Use Records for storage * Add new Account Settings to serialized data * Fix failing serialization tests * Extract complex type conversion to helper methods * Remove unnecessary decorator * Return null from json deserializers * Remove unnecessary decorators * Remove obsolete test * Use type-fest `Jsonify` formatting rules for external library * Update jsonify comment Co-authored-by: @eliykat * Remove erroneous comment * Fix unintended deep-jsonify changes * Fix prettierignore * Fix formatting of deep-jsonify.ts Co-authored-by: Thomas Rittson <trittson@bitwarden.com> Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>	4 years ago
Addison Beck	f72ef2dce5	Don't try and parse a json response if one is not received (#3574)	4 years ago
Addison Beck	1fcba78905	[SG-656] Use a captcha bypass during registration (#3531) ... * Use a captcha bypass during registration The trial initiation flow has a registration step that automatically does a login in the background. This has Captcha problems, namely that it can spawn two captchas in a row - one during registration and one during login. This is not ideal UX, so we've added a bypass token that returns from the registration endpoint that can be used to skip the next captcha. * [review] Introduce ICaptcheProtectedResponse	4 years ago
Gbubemi Smith	734f052faa	[SG-590] Missing error messages (#3514) ... * added removed locale keys on clients * resolved comments	4 years ago
Colton Hurst	d4581b0ba3	Remove admin url from config object (#3479)	4 years ago
Justin Baur	f47dbccdef	Fix file casing (#3468)	4 years ago
Colton Hurst	3b69a60511	SM-90: Add Server Version to Browser About Page (#3223) ... * Add structure to display server version on browser * Add getConfig to State Service interface * Clean up settings component code * Switch to ServerConfig, use Observables in the ConfigService, and more * Fix runtime error * Sm 90 addison (#3275) * Use await instead of then * Rename stateServerConfig -> storedServerConfig * Move config validation logic to the model * Use implied check for undefined * Rename getStateServicerServerConfig -> buildServerConfig * Rename getApiServiceServerConfig -> pollServerConfig * Build server config in async * small fixes and add last seen text * Move config server to /config folder * Update with concatMap and other changes * Config project updates * Rename fileds to convention and remove unneeded migration * Update libs/common/src/services/state.service.ts Update based on Oscar's recommendation Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> * Update options for Oscar's rec * Rename abstractions to abstracitons * Fix null issues and add options * Combine classes into one file, per Oscar's rec * Add null checking * Fix dependency issue * Add null checks, await, and fix date issue * Remove unneeded null check * In progress commit, unsuitable for for more than dev env, just backing up changes made with Oscar * Fix temp code to force last seen state * Add localization and escapes in the browser about section * Call complete on destroy subject rather than unsubscribe * use mediumDate and formatDate for the last seen date messaging * Add ThirdPartyServerName in example * Add deprecated note per Oscar's comment * [SM-90] Change to using a modal for browser about (#3417) * Fix inconsistent constructor null checking * ServerConfig can be null, fixes this * Switch to call super first, as required * remove unneeded null checks * Remove null checks from server-config.data.ts class * Update via PR comments and add back needed null check in server conf obj * Remove type annotation from serverConfig$ * Update self-hosted to be <small> per design decision * Re-fetch config every hour * Make third party server version <small> and change wording per Oscar's PR comment * Add expiresSoon function and re-fetch if the serverConfig will expire soon (older than 18 hours) * Fix misaligned small third party server message text Co-authored-by: Addison Beck <addisonbeck1@gmail.com> Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>	4 years ago
Thomas Rittson	233c85f7a3	[EC-515] Re-enable node consoleLog.service test (#3448)	4 years ago
rr-bw	7c5e4dd3d6	[CL-7] Avatar (#3153) ... * CL-7 Begin Implementing Avatar * add figma design to parameters * rework size property * Update Figma file to correct component * remove circle input (avatar will always be a circle) * adjust sizing and limit inputs * Setup color input and functionality * Add border option * fix bug duplicating classes * Update size for large avatar * Remove unnecessary class * Fix typo * Remove 'dynamic' input (Avatar will now regenerate on changes by default) * Use Tailwind class instead of an arbitrary value * Remove gravatars (deprecated, see SG-434) * Rename methods to a more accurate name * Rework classList() getter method * Remove unnecessary logic and services * Make properties private, and rename for better clarity * Move sanitizer logic to the TS code rather than the template * Rework and move function to a common static class in Utils * Rename 'data' to 'text' for clarity * Rework classList implementation * Remove email since we removed gravatars * Remove template * set color based on color, id, or text input * rework generate method * add explicit null/undefined check * remove comment Co-authored-by: Vincent Salucci <26154748+vincentsalucci@users.noreply.github.com>	4 years ago
Daniel James Smith	57d60e2114	[PS-1282] Enable Arabic language support for desktop, browser, web (#3333) ... * Register Arabic language with native name * Register Arabic language for web vault * Register Arabic language for browser * Register Arabic language for desktop	4 years ago
Thomas Rittson	cff2422d7f	[EC-499] Add encryptService to domain model decryption (#3385) ... Co-authored-by: Matt Gibson <mgibson@bitwarden.com>	4 years ago
Thomas Rittson	063acfef40	Add typing to localData object (#3368)	4 years ago
Daniel James Smith	25207c2858	Extract settings related methods into VaultTimeoutSettingsService (#3419) ... * Extract into new VaultTimeoutSettingsService * Ensure new service is instantiated and registered for DI * Create vaultTimeoutSettingsServiceFactory * Fix VaultTimeoutServiceFactory * Remove any and use void instead	4 years ago
Rui Tomé	595412c5fe	[EC-381] Transition settings service into providing observables (#3253) ... * [EC-381] Deleted unused method clearCache from Settings Service * [EC-381] Marked settings methods as obsolete on State service * [EC-381] Using observables on settings service * [EC-381] Added unit tests for Settings service * [EC-381] Checking userId on clear * [EC-381] Updated references to StateService activeAccountUnlocked$ * [EC-381] Updated getEquivalentDomains to return observable * [EC-381] Updated settings service to user concatMap on activeAccountUnlocked$ * [EC-381] Renamed getEquivalentDomains to equivalentDomains * [EC-381] Completing Behaviors on settings.service tests * [EC-381] Removed unused settingsPrefix from settings service * [EC-381] Removed equivalentDomains from settings service and added type AccountSettingsSettings * [EC-381] Updated settings service settings$ to not be nullable * [EC-381] Settings default to {}	4 years ago
Daniel James Smith	88a6541bd8	Refactorings for vaultTimeoutService/ServiceFactories (#3416) ... * Move vaultTimeoutAbstraction into it's own folder * Move vaultTimeout service into it's own folder * Added vaultTimeoutServiceFactory and it's missing dependencies	4 years ago
Justin Baur	2c208edb98	Add `sync$` observable (#3384) ... * Add sync$ observable * Update lock method Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	4 years ago
cd-bitwarden	a108476c3c	[SM-89] Updates to encrypted export (#2963) ... * Rough draft of Export/Import changes w/ password encryption * fix for encrypted export changes * Create launch.json * Updates to export logic modal user secret prompt * Updates to error handling * renaming the component for checking the user secret to a name that is more clear about what it accomplishes * Fixing lint errors * Adding a comment * Suggested changes from CR * Suggested changes from CR * Making suggested changes * removing unnecessary properties * changes suggested * Fix * Updating error messages * Removing unecessary launch.json file commit * running lint, removing commented code * removing launch.json * Updates to remove the userVerificationPromptService * updates * Removing unused import, running npm prettier/lint * Changes to use Form Fields * Updates * updates requested by Matt * Update apps/web/src/app/tools/import-export/export.component.ts Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com> * Suggested Changes from PR * Fix after merge from Master * changes to styling * Removing unused code and cleanup * Update libs/angular/src/components/user-verification-prompt.component.ts Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com> * Update apps/web/src/locales/en/messages.json Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com> * Changes suggested by Thomas R * Merging master into branch * Revert "Merging master into branch" This reverts commit eb2cdffe49. * Requested changes and improvements * merging master into feature branch * Revert "merging master into feature branch" This reverts commit e287715251. * Suggested Changes * changes * requested changes * Requested changes * removing comments, fixing code * reducing copied code * fixing bug * fixing bug * changes * WIP * Thomas's requested changes * adding back missing spaces * change needed after the merge from master into feature branch * prettier + lint * Updating the EncryptedExportType Import * Fixing build errors Co-authored-by: Thomas Rittson <eliykat@users.noreply.github.com> * Move FilePasswordPrompt to ImportExportModule Also remove base class Also remove duplicate service providers * Run prettier * Suggested Changes from Thomas * only require filePassword and confirmFilePassword if it's type is FileEncrypted * Update to only enable the field when submitting a file password encrypted file * Requested changes, moving logic to web * undoing change to bit button * Refactor to process file-encrypted imports in main import.component *  Refactor confirm file password check * Remove UserVerificationPromptService * Address CodeScene feedback * Updates to disable the required file password field when needed * Subscribe to reactive form changes to adjust validators * style changes requested by suhkleen * Delete duplicate classes Co-authored-by: CarleyDiaz-Bitwarden <103955722+CarleyDiaz-Bitwarden@users.noreply.github.com> Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com> Co-authored-by: Thomas Rittson <trittson@bitwarden.com> Co-authored-by: Thomas Rittson <eliykat@users.noreply.github.com>	4 years ago
Kyle Spearrin	231e1bf666	catch fastmail errors in notCreated response prop (#3395)	4 years ago
Todd Martin	33af940515	Revert PR #3393 because it was not the right solution ... This reverts commit 8dd15a1ff3. Co-authored-by: Todd Martin <>	4 years ago
Todd Martin	8dd15a1ff3	Changed where website parameter is passed in to forwarding services. (#3393) ... Co-authored-by: Todd Martin <>	4 years ago
Oscar Hinton	e7c7037a14	Add eslint-plugin-rxjs & rxjs-angular (#3373)	4 years ago
Thomas Rittson	90137936fa	[EC-473] Add feature flags to common code (#3324)	4 years ago
Daniel James Smith	4c5a46ce13	[PS-1363] Tech debt and small refactorings (#3377) ... * Remove cast to any as Utils.gobal got typed with #3131 * BitwardenFileUploadService: Remove unneeded dependency * Remove allowSoftLock from vaultTimeoutService * ImportService: Remove dependency on PlatformUtilsSvc	4 years ago
Kyle Spearrin	bb70113279	feedback from fastmail (#3375) ... * feedback from fastmail * follow redirects for getting account id api	4 years ago
Justin Baur	7145b13df1	[PS-1093] Move Organization Api Calls (#3243) ... * Move organization api calls into seperate service * Remove unneeded unknown * Address PR feedback	4 years ago
Kyle Spearrin	2a49824581	[SG-515] add fastmail integration for generator (#3318) ... * add fastmail integration for generator * prettier * introduce forwarder interface and implementations	4 years ago
David S	4c099aca46	[PS-1302] added duckduckgo's email forwarding service 🦆 (#3306) ... * added duckduckgo's email forwarding * removed unnecessary excxeption * renamed "Private Duck Address" to "DuckDuckGo" Co-authored-by: Dattito <github@relay.datti.to>	4 years ago
Daniel James Smith	dcd858d8ae	[PS-1286] Enable Basque language support for desktop, browser, web (#3332) ... * Register basque language with native name * Register basque language for web vault * Register basque language for browser * Register basque language for desktop	4 years ago
Matt Gibson	5339344630	PS-1133 Feature/mv3 browser observable memory caching (#3245) ... * Create sessions sync structure * Add observing to session-syncer * Do not run syncer logic in decorator tests * Extract test constants * Change Observables to BehaviorSubject * Move sendMessage to static method in BrowserApi * Implement session sync * only watch in manifest v3 * Use session sync on folder service * Add array observable sync * Bypass cache on update from message * Create feature and dev flags for browser * Protect development-only methods with decorator * Improve todo comments for long-term residency * Use class properties in init * Do not reuse mocks * Use json (de)serialization patterns * Fix failing session storage in dev environment * Split up complex EncString constructor * Default false for decrypted session storage * Try removing hydrate EncString method * PR review * PR test review	4 years ago
Matt Gibson	9d0dd613fb	PS-1267 Null check URI values (#3315)	4 years ago
Thomas Rittson	d30701ada7	[EC-416] Refactor organization permission checks (#3252) ... * Replace Permissions enum and helper methods with callbacks * Remove scim feature flag * Check if org has feature enabled as part of canManage checks * Pin jest-mock-extended at v2.0.6 to fix compilation error	4 years ago
Thomas Rittson	4a1c3eb1ec	[EC-423] Fix unit tests (#3265) ... * Create base jest.config file * Fix various tests that were broken * Add maxWorkers to jest config * Undo change to testEnvironment * Enable tsconfig.spec.json	4 years ago
Justin Baur	1ba76dec16	[PS-1107] User Verification Service Refactor (#3219) ... * UserVerificationService refactor * Remove temp change * move import order * Address PR feedback	4 years ago
Justin Baur	43d428b3df	[PS-816] Add Autofill Shortcut to MV3 Extension (#3131) ... * Work on background service worker. * Work on shortcuts * Work on supporting service worker * Put new background behind version check * Fix build * Use new storage service * create commands from crypto service (#2995) * Work on service worker autofill * Got basic autofill working * Final touches * Work on tests * Revert some changes * Add modifications * Remove unused ciphers for now * Cleanup * Address PR feedback * Update lock file * Update noop service * Add chrome type * Handle "/" in branch names Updates web workflow to handle the `/` in branch names when it's a PR. * Remove any Co-authored-by: Jake Fink <jfink@bitwarden.com> Co-authored-by: Micaiah Martin <77340197+mimartin12@users.noreply.github.com>	4 years ago
Daniel James Smith	cfc8858ef9	Fix active account and searchBar observables/subscriptions (#3268) ... * Change subscription to rely on observables and not on BehaviourSubject * Ensure OnDestroy is added to AppComponent * Fix check for no active accounts to redirect to the login page instead of lock * Change subscription handling on SearchBarService * Fix naming convention: Observables should have a $ suffix * Remove obsolete linter hint * Fix activeAccountUnlocked getting exposed as Observable but is instantiated as BehaviourSubject	4 years ago
Oscar Hinton	af371af6e1	[SM-88] [BEEEP] Add support for chrome.storage.managed for environment urls (#3120) ... * Add managed_schema * Add note on login page which server you are logging into. * Implement it * Remove caching logic since it seems unecessary * Add error * Handle error in hasManagedEnvironment * Fix compile	4 years ago
Rui Tomé	c263eacd88	[EC-376] Extract API logic from PolicyService to PolicyApiService (#3203) ... * Added abstractions for PolicyApiService and PolicyService * Added implementations for PolicyApiService and PolicyService * Updated all references to new PolicyApiService and PolicyService * Deleted old PolicyService abstraction and implementation * Fixed CLI import path for policy.service * Fixed main.background.ts policyApiService dependency for policyService * Updated policy-api.service with the correct imports * [EC-376] Sorted methods order in PolicyApiService * [EC-376] Removed unused clearCache method from PolicyService * [EC-376] Added upsert method to PolicyService * [EC-376] PolicyApiService putPolicy method now upserts data to PolicyService	4 years ago
Daniel James Smith	a1e536a5ef	[PS-1175] Resolve issue with processReload not executing (#3240) ... * Removed check for getBiometricLocked It always returned false even when no biometrics were used. * Remove the other check for getBiometricsLocked * Ensure that biometricFingerprintValidation is reset, when biometrics are disabled * Removed getBiometricsLocked and setBiometricsLocked With nothing in the codebase reading the state of getBiometricsLocked, I've removed all places where it was set or saved. * Refactor execution of reload into a separate method * Conditonally pass the window object to `BrowserApi.reloadExtension` * Clarify in comment, that the PIN has to be set with ask for Master Password on restart * Ensure the process reload is executed on logout * Use accounts instead of lastActive == null to determine a reload on logout * Moved identical logic from desktop and browser into system.service * Simplified check for refresh to handle no accounts found, logout, lock with lastActive longer than 5 seconds	4 years ago
Thomas Rittson	b625767f13	Fix non-enterprise users being able to access scim (#3250)	4 years ago
Thomas Rittson	8626e1d4e6	[EC-281] Add de/serialization methods to CipherView objects (#2970)	4 years ago
Thomas Rittson	83c0456340	[EC-364] Expose key getters on CryptoService (#3170) ... * Move resolveLegacyKey to encryptService for utf8 decryption * Deprecate account.keys.legacyEtmKey Includes migration to tidy up leftover data * Use new IEncrypted interface	4 years ago
Andreas Coroiu	a22ef4d36c	[EC-317] Desktop client delete user account (#3151) ... * [EC-317] feat: add delete account section in settings * [EC-317] feat: add new delete account modal * [EC-317] feat: add ability to replace top-most modal * [EC-317] chore: remove unecessary lint ignore * [EC-317] fix: so delete account is closed if export vault is opened * [EC-317] feat: inital delete account design without i18n * [EC-317] feat: disabled but basic working delete functionality * [EC-317] feat: implement according to new design * [EC-317] feat: use translations * [EC-317] feat: implement working deletion * [EC-317] feat: add loading state and error messages * [EC-317] feat: add menu bar item * [EC-317] feat: update form to support typed reactive forms * [EC-317] chore: update translation text after design review * [EC-317] feat: move deletion logic to service * [EC-317] refactor: update web deletion * [EC-317] feat: disable submit if secret is empty * [EC-317] fix: handle errors in components as well * [EC-317] fix: use abstraction as interface * [EC-317] refactor: extract deleteAccount from api service * [EC-317] fix: typo in translations * [EC-317] chore: rename to accountApiService	4 years ago
Justin Baur	a46510bab4	[PS-1202] Also update the decrypted history (#3205)	4 years ago
Rui Tomé	da341e1317	[EC-247] Add columns to provider portal clients table (#3147) ... * Added properties "userCount", "seats" and "plan" to ProviderOrganizationResponse * Added text message "numberOfUsers" * Updated provider clients component with new columns * Removed never used dependency * Changed userCount to non nullable number * Added condition on the component to only show seats number if not null * Changed view condition to an explicit check	4 years ago
Thomas Rittson	2c9ccefa12	Do not set state to null and throw if this occurs (#3191)	4 years ago