441 Commits (666ff42d22a0cf0e97d5ad18f0ef8d1cb1a3e5eb)

Author	SHA1	Message	Date
Bernd Schoolmann	cf7f9cfc7e	[BEEEP|PM-32521] Remove compare key hash and move to proof of decryption (#19101) ... * Remove compare key hash and move to proof of decryption * Fix cli build * Fix mv2 * Fix provider * Prettier	3 months ago
Alex Morask	b964cfc8e4	[PM-32612] Only show subscription menu option when premium user has subscription (#19209) ... * fix(billing): only show Subscription menu option when premium user has subscription * fix(billing): missed state service invocation changes	3 months ago
Bernd Schoolmann	d20f659bbc	[PM-31406] fix: TypeScript 5.9 type compatibility fixes for vault-owned code (#19191) ... * fix: TypeScript 5.9 type compatibility fixes for vault-owned code Add explicit `as BufferSource` casts and `Uint8Array` wrapping to satisfy stricter type checking in TypeScript 5.9. Non-functional changes. * Fix cli build	3 months ago
Andreas Coroiu	69f0e61cda	[PM-32442] Enforce tsc-strict on desktop and CLI apps (#19058) ... * fix: ts-strict not applying to desktop * fix: ts-strict not applying to cli * fix: desktop ESM module resolution in storybook	3 months ago
Thomas Avery	672a6026e3	[PM-27331] Update the sdk service to use accountCryptographicState (#18274) ... * Update the sdk service to use accountCryptographicState	3 months ago
John Harrington	f8b5e15a44	[PM-31731] [Defect] No error is returned when entering an invalid email + an invalid verification code (#18913) ... * share i18n key for both invalid email and invalid otp submission * claude review	3 months ago
John Harrington	ab0739b693	rename flag to emails (#18955)	3 months ago
John Harrington	d7cca1bedf	[PM-23108] CLI Add Email Verification to Send Receive (#18649)	3 months ago
Nick Krantz	4fe29c71ce	allow archiving organization ciphers in the cli (#18793)	3 months ago
Alex Dragovich	e485623ed8	[PM-31685] Removing email hashes (#18744) ... * [PM-31685] Removing email hashes * [PM-31685] fixing tests, which are now passing * [PM-31685] removing anon access emails field and reusing emails field * [PM-31685] fixing missed tests * [PM-31685] fixing missed tests * [PM-31685] code review changes * [PM-31685] do not encrypt emails by use of domain functionality * [PM-31685] test fixes	4 months ago
Bernd Schoolmann	f7a5ad712f	[PM-29208] Remove individual cryptographic-key states & migrate key service (#18164) ... * Remove inividual user key states and migrate to account cryptographic state * Fix browser * Fix tests * Clean up migration * Remove key-pair creation from login strategy * Add clearing for the account cryptographic state * Add migration * Cleanup * Fix linting	4 months ago
Rui Tomé	c21841a2df	[PM-26485] Add member status validation to CLI confirm command (#18557) ... * Add validation for organization user status in CLI Confirm command - Implemented a new method to validate the status of an organization user before confirmation. - Added checks for various user states: invited, confirmed, revoked, and accepted. - Enhanced error handling to provide clearer feedback based on user status. * Refactor validation logic in ConfirmCommand to remove unnecessary user ID check - Removed the check for null userId in the validateOrganizationUserStatus method. - Simplified the validation process for organization user status before confirmation. * Add unit tests for ConfirmCommand in CLI - Created a new test suite for the ConfirmCommand to validate its functionality. - Implemented tests for various scenarios including bad requests, user status validations, and successful confirmations. - Enhanced error handling tests to ensure proper responses for missing organization keys and API failures.	4 months ago
Nick Krantz	256fe6305f	restore archived item from trash to archive (#18795)	4 months ago
Alex Dragovich	1b812d2274	Revert "Remove feature flag check from password generation (#18003)" (#18794) ... This reverts commit 7c6d98b50e.	4 months ago
adudek-bw	7c6d98b50e	Remove feature flag check from password generation (#18003) ... * Remove feature flag check from password generation	4 months ago
renovate[bot]	afc46cc50a	[deps] Vault: Update @koa/router to v15 (#18086) ... * [deps] Vault: Update @koa/router to v15 * update router imports from `@koa/router` * remove `@types/koa__router` no longer needed with update to `@koa/router` --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Nick Krantz <125900171+nick-livefront@users.noreply.github.com> Co-authored-by: Nick Krantz <nick@livefront.com>	4 months ago
John Harrington	0740c037a6	[PM-30922] Client changes to encrypt send access email list (#18486)	4 months ago
Nik Gilmore	06c8c7316d	[PM-30301][PM-30302] Use SDK for Create and Update cipher operations (#18149) ... * Migrate create and edit operations to use SDK for ciphers * WIP: Adds admin call to edit ciphers with SDK * Add client version to SDK intialization settings * Remove console.log statements * Adds originalCipherId and collectionIds to updateCipher * Update tests for new cipehrService interfaces * Rename SdkCipherOperations feature flag * Add call to Admin edit SDK if flag is passed * Add tests for SDK path * Revert changes to .npmrc * Remove outdated comments * Fix feature flag name * Fix UUID format in cipher.service.spec.ts * Update calls to cipherService.updateWithServer and .createWithServer to new interface * Update CLI and Desktop to use new cipherSErvice interfaces * Fix tests for new cipherService interface change * Bump sdk-internal and commercial-sdk-internal versions to 0.2.0-main.439 * Fix linting errors * Fix typescript errors impacted by this chnage * Fix caching issue on browser extension when using SDK cipher ops. * Remove commented code * Fix bug causing race condition due to not consuming / awaiting observable. * Add missing 'await' to decrypt call * Clean up unnecessary else statements and fix function naming * Add comments for this.clearCache * Add tests for SDK CipherView conversion functions * Replace sdkservice with cipher-sdk.service * Fix import issues in browser * Fix import issues in cli * Fix type issues * Fix type issues * Fix type issues * Fix test that fails sporadically due to timing issue	4 months ago
Thomas Avery	bc8c925cd0	[PM-27486] Remove feature flag PM25174_DisableType0Decryption (#18413)	4 months ago
Colton Hurst	3b2286fbb0	Revert "[deps] Platform: Lock file maintenance (#14932)" (#18406) ... This reverts commit 5dee97158a.	4 months ago
renovate[bot]	5dee97158a	[deps] Platform: Lock file maintenance (#14932) ... * [deps]: Lock file maintenance * Pin is-generator-function, downgrade open * Bump zbus to match zbus_macro * Attempt to fix rust compile issue by matching zbus and zbus_macro * Update ashpd ... * Fix lockfile --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Hinton <hinton@users.noreply.github.com>	4 months ago
Leslie Xiong	44bdaf71b3	Desktop/pm 18769/migrate vault filters (#17919) ... Migrated vault filters to new v3 vault's navigation * Decoupled existing vault filtering from vault component by using routed params with routed-vault-filter-bridge * Converted vault filters to standalone components * Removed extending filter Base Components from deprecated /libs/angular library and handled logic directly * Moved shared 'models' and 'services' directories from web-vault into /libs/vault	4 months ago
bmbitwarden	27d43c500f	PM-28183 implemented new sends filter and search design (#17901) ... * PM-28183 implemented new sends filter and search design * PM-28183 resolved table issue fallout from merge conflict * PM-28183 resolved browser paste url issue * PM-28183 put new feature behind feature flag * PM-28183 resolved feature flag * PM-28183 resolved type-safe approach pr comment * PM-28183 resolved DesktopSendUIRefresh feature flag is enabled. pr comment * PM-28183 restored SendUIRefresh * PM-28183 resolved query parameter subscription pr comment * PM-28183 resolved pr comment re enum like objects * PM-28183 resolved remove enum like objects pr comment * PM-28183 resolved pr comment re defining filteredSends member variable * PM-28183 resolved pr comment re Code Duplication in syncCompleted Handler * PM-28183 resolved pr comment re Floating Promise * PM-28183 restored feature flag * PM-28183 resolved pr comment re Dual Binding Pattern * PM28183 resolved options cell button pr comment * PM 28183 resolved pr comment re Incorrect CSS Class - Breaking Layout * PM 28183 resolved pr comment re uery Param Update Causes Redundant Filter Application * PM-28183 resolved lint issues * PM 28183 resolved lint issues * PM-28183 resolved type issue with import * PM-28183 resolved import in failling test * chore: rerun web build * PM-28183 resolved build issues * PM-28183 resolved build issues * PM-28183 resolved lint issues	4 months ago
Thomas Avery	0e2748784b	[PM-25385] Remove unlock-with-master-password-unlock-data flag (#18010) ... * remove feature flag from lock component * Add missing windowHidden desktop feature * Remove the flag from CLI unlock * Remove the flag from enum file	5 months ago
Vincent Salucci	86764d807a	[PM-22434] Remove CreateDefaultLocation feature flag references and definition (#18057) ... * chore: remove ff from vault-popup-list-filters.service, refs PM-22434 * chore: remove ff from confirm.command, refs PM-22434 * chore: remove ff from bulk-confirm-dialog.component, refs PM-22434 * chore: remove ff from member-actions.service and clean up leftover imports, refs PM-22434 * chore: remove ff from policy-edit-dialog.component, refs PM-22434 * chore: remove ff from organization-data-ownership.component, refs PM-22434 * chore: remove ff from vnext-organization-data-ownership.component, refs PM-22434 * chore: remove ff from vault-filter.service, refs PM-22434 * chore: remove ff from vault-filter.service (libs), refs PM-22434 * chore: remove ff from export.component, refs PM-22434 * chore: update observeMyItemsExclusionCriteria method documentation comments, refs PM-22434 * chore: remove ff from item-details-section.component, refs PM-22434 * chore: remove ff definition, refs PM-22434 * fix: remove configService from superclasses, refs PM-22434 * chore: update injection for VaultPopupListFilters service instantiation, refs PM-22434 * chore: update ConfirmCommand instantiation, refs PM-22434 * chore: update import order in member-actions.service, refs PM-22434 * fix: constructor argument update to amend merge conflict, refs PM-22434 * chore: remove unnecessary feature flag related tests for confirm user, refs PM-22434 * fix: remove unused services from member-actions.service.spec, refs PM-22434	5 months ago
Maciej Zieniuk	7fa1a6f07f	[PM-27236] account registration v2 for key connector (#17951) ... * account registration v2 for key connector * explicit naming * test coverage * missing AccountCryptographicStateService and DI dependencies * redundant SdkLoadService.Ready * update sdk version	5 months ago
Bernd Schoolmann	ea45c5d3c0	[PM-27315] Add account cryptographic state service (#17589) ... * Update account init and save signed public key * Add account cryptographic state service * Fix build * Cleanup * Fix build * Fix import * Fix build on browser * Fix * Fix DI * Fix * Fix * Fix * Fix * Fix * Fix test * Fix desktop build * Fix * Address nits * Cleanup setting private key * Add tests * Add tests * Add test coverage * Relative imports * Fix web build * Cleanup setting of private key	5 months ago
Jared Snider	cbd80d0186	refactor(IdentityTokenResponse): [Auth/PM-3287] Remove deprecated resetMasterPassword property from IdentityTokenResponse (#17794) ... * PM-3287 - Remove resetMasterPassword from authResult and identityTokenResponse and replace with userDecryptionOptions where relevant * PM-3287 - (1) Move SSO code to SSO section (2) Update error scenario conditional + log user out upon error. * PM-3287 - Fix comment per PR feedback * PM-3287 - CLI Login with SSO - move MP validation logic back to original location to avoid putting it before 2FA rejection handling. * PM-3287 - Update returns	5 months ago
Bernd Schoolmann	4846d217a9	[PM-28901] Fix master key not being set to state after kdf update (#17990) ... * Fix master key not being set to state after kdf update * Fix cli build * Fix test error * Fix hash purpose * Add test for master key being set * Fix incorrect variable name	5 months ago
Maciej Zieniuk	ced97a4467	cli status command shows locked status when unlocked (#17708)	5 months ago
Todd Martin	27d82aaf28	feat(accounts): Add creationDate of account to AccountInfo ... * Add creationDate of account to AccountInfo * Added initialization of creationDate. * Removed extra changes. * Fixed tests to initialize creation date * Added helper method to abstract account initialization in tests. * More test updates. * Linting * Additional test fixes. * Fixed spec reference * Fixed imports * Linting. * Fixed browser test. * Modified tsconfig to reference spec file. * Fixed import. * Removed dependency on os. This is necessary so that the @bitwarden/common/spec lib package can be referenced in tests without node. * Revert "Removed dependency on os. This is necessary so that the @bitwarden/common/spec lib package can be referenced in tests without node." This reverts commit 669f6557b6. * Updated stories to hard-code new field. * Removed changes to tsconfig * Revert "Removed changes to tsconfig" This reverts commit b7d916e8dc.	5 months ago
Bernd Schoolmann	51d29f777e	[PM-24353] Drop legacy pin support (#17328) ... * Drop legacy pin support * Fix cli build * Fix browser build * Remove pin key * Fix comment * Fix CI / tests * Add migration to remove key * Inline export key * Extract vault export key generation * Cleanup * Add migrator * Fix mv2 build	6 months ago
Ike	0e277a411d	[PM-1632] Redirect on SSO required response from `connect/token` (#17637) ... * feat: add Identity Sso Required Response type as possible response from token endpoint. * feat: consume sso organization identifier to redirect user * feat: add get requiresSso to AuthResult for more ergonomic code. * feat: sso-redirect on sso-required for CLI and Desktop * chore: fixing type errors * test: fix and add tests for new sso method * docs: fix misspelling * fix: get email from AuthResult instead of the FormGroup * fix:claude: when email is not available for SSO login show error toast. * fix:claude: add null safety check	6 months ago
Bernd Schoolmann	2fd3923c30	Disable info log on SDK CLI (#17834)	6 months ago
Bernd Schoolmann	395e4f2c05	[PM-27591] Remove orgid in vault decryption code (#17099) ... * Remove orgid in vault decryption code * Remove folder usage without provided key * Fix folder test * Fix build * Fix build * Fix build * Fix tests * Update spec to not use EncString decrypt * Fix tests * Fix test * Fix test * Remove comment * Remove org id parameter	6 months ago
Maciej Zieniuk	bbea11388a	[PM-26057] Enforce session timeout policy (#17424) ... * enforce session timeout policy * better angular validation * lint fix * missing switch break * fallback when timeout not supported with highest available timeout * failing unit tests * incorrect policy message * vault timeout type adjustments * fallback to "on browser refresh" for browser, when policy is set to "on system locked", but not available (Safari) * docs, naming improvements * fallback for current user session timeout to "on refresh", when policy is set to "on system locked", but not available. * don't display policy message when the policy does not affect available timeout options * 8 hours default when changing from non-numeric timeout to Custom. * failing unit test * missing locales, changing functions access to private, docs * removal of redundant magic number * missing await * await once for available timeout options * adjusted messaging * unit test coverage * vault timeout numeric module exports * unit test coverage	6 months ago
Bernd Schoolmann	6e2203d6d4	[PM-18026] Implement forced, automatic KDF upgrades (#15937) ... * Implement automatic kdf upgrades * Fix kdf config not being updated * Update legacy kdf state on master password unlock sync * Fix cli build * Fix * Deduplicate prompts * Fix dismiss time * Fix default kdf setting * Fix build * Undo changes * Fix test * Fix prettier * Fix test * Update libs/angular/src/key-management/encrypted-migration/encrypted-migrations-scheduler.service.ts Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com> * Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com> * Update libs/angular/src/key-management/encrypted-migration/encrypted-migrations-scheduler.service.ts Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com> * Only sync when there is at least one migration * Relative imports * Add tech debt comment * Resolve inconsistent prefix * Clean up * Update docs * Use default PBKDF2 iteratinos instead of custom threshold * Undo type check * Fix build * Add comment * Cleanup * Cleanup * Address component feedback * Use isnullorwhitespace * Fix tests * Allow migration only on vault * Fix tests * Run prettier * Fix tests * Prevent await race condition * Fix min and default values in kdf migration * Run sync only when a migration was run * Update libs/common/src/key-management/encrypted-migrator/default-encrypted-migrator.ts Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com> * Fix link not being blue * Fix later button on browser --------- Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>	6 months ago
Bernd Schoolmann	2e8faa9994	[PM-12628] Fix cli showing locked status when using session and check (#17515) ... * Fix cli showing locked status when using session and check * Cleanup	6 months ago
Brandon Treston	b9d5724312	[PM-24011] Add handler for new policy sync push notification (#17465) ... * add handler for new policy sync push notification * fix story book build failure * move logic into policy service, fix tests * add account service * add missing service to clie	6 months ago
Bernd Schoolmann	eb4fd42153	[PM-28446] Log package types (#17496) ... * User agent * Update to use header * Fix build on cli * Replace unsandboxed with unknown * Apply feedback * Prevent sending null values	6 months ago
John Harrington	6f5491f7dc	PM-22143 Refactor TS enums to be const objects (Send specific enums) (#16399)	6 months ago
Dave	cf6569bfea	feat(user-decryption-options) [PM-26413]: Remove ActiveUserState from UserDecryptionOptionsService (#16894) ... * feat(user-decryption-options) [PM-26413]: Update UserDecryptionOptionsService and tests to use UserId-only APIs. * feat(user-decryption-options) [PM-26413]: Update InternalUserDecryptionOptionsService call sites to use UserId-only API. * feat(user-decryption-options) [PM-26413] Update userDecryptionOptions$ call sites to use the UserId-only API. * feat(user-decryption-options) [PM-26413]: Update additional call sites. * feat(user-decryption-options) [PM-26413]: Update dependencies and an additional call site. * feat(user-verification-service) [PM-26413]: Replace where allowed by unrestricted imports invocation of UserVerificationService.hasMasterPassword (deprecated) with UserDecryptionOptions.hasMasterPasswordById$. Additional work to complete as tech debt tracked in PM-27009. * feat(user-decryption-options) [PM-26413]: Update for non-null strict adherence. * feat(user-decryption-options) [PM-26413]: Update type safety and defensive returns. * chore(user-decryption-options) [PM-26413]: Comment cleanup. * feat(user-decryption-options) [PM-26413]: Update tests. * feat(user-decryption-options) [PM-26413]: Standardize null-checking on active account id for new API consumption. * feat(vault-timeout-settings-service) [PM-26413]: Add test cases to illustrate null active account from AccountService. * fix(fido2-user-verification-service-spec) [PM-26413]: Update test harness to use FakeAccountService. * fix(downstream-components) [PM-26413]: Prefer use of the getUserId operator in all authenticated contexts for user id provided to UserDecryptionOptionsService. --------- Co-authored-by: bnagawiecki <107435978+bnagawiecki@users.noreply.github.com>	6 months ago
Dave	daf7b7d2ce	fix(two-factor) [PM-21204]: Users without premium cannot disable premium 2FA (#17134) ... * refactor(two-factor-service) [PM-21204]: Stub API methods in TwoFactorService (domain). * refactor(two-factor-service) [PM-21204]: Build out stubs and add documentation. * refactor(two-factor-service) [PM-21204]: Update TwoFactorApiService call sites to use TwoFactorService. * refactor(two-fatcor) [PM-21204]: Remove deprecated and unused formPromise methods. * refactor(two-factor) [PM-21204]: Move 2FA-supporting services into common/auth/two-factor feature namespace. * refactor(two-factor) [PM-21204]: Update imports for service/init containers. * feat(two-factor) [PM-21204]: Add a disabling flow for Premium 2FA when enabled on a non-Premium account. * fix(two-factor-service) [PM-21204]: Fix type-safety of module constants. * fix(multiple) [PM-21204]: Prettier. * fix(user-verification-dialog) [PM-21204]: Remove bodyText configuration for this use. * fix(user-verification-dialog) [PM-21204]: Improve the error message displayed to the user.	6 months ago
Thomas Avery	35f35c4361	[PM-26498] Add proofOfDecryption method to MasterPasswordUnlockService (#17322) ... * Add proofOfDecryption method to MasterPasswordUnlockService	6 months ago
Maciej Zieniuk	ff12e672e6	[PM-23614] Remove activeUserOrgKeys$ from the key service (#17045) ... * Remove activeUserOrgKeys$ from the key service * test leftover * test leftover	7 months ago
Bernd Schoolmann	3125f679d3	[PM-25206] Inject service instead of passing as param (#16801) ... * Inject service instead of passing as param * [PM-25206] Move locking logic to LockService (#16802) * Move locking logic to lock service * Fix tests * Fix CLI * Fix test * FIx safari build * Update call to lock service * Remove locked callback * Clean up lock service logic * Add tests * Fix cli build * Add extension lock service * Fix cli build * Fix build * Undo ac changes * Undo ac changes * Run prettier * Fix build * Remove duplicate call * [PM-25206] Remove VaultTimeoutService lock logic (#16804) * Move consumers off of vaulttimeoutsettingsservice lock * Fix build * Fix build * Fix build * Fix firefox build * Fix test * Fix ts strict errors * Fix ts strict error * Undo AC changes * Cleanup * Fix * Fix missing service	7 months ago
SmithThe4th	c42a7b2ef5	[PM-27506] CLI allows creating SSH key items with null fields (#17063) ... * Added checks to on the sshkey view to prevent null fields * Give default values to the template * Give default values to the template * change function signature to match ts-strct styles * Added unit tests for the ssh key to view and replaced deafults to empty strings	7 months ago
Shane Melton	0d543c7059	[PM-27055] Use undefined instead of null for folder/organization filtering (#17120)	7 months ago
Bernd Schoolmann	7e7107f165	[PM-27221] Update legacy kdf state on master password unlock sync (#16966) ... * Update legacy kdf state on master password unlock sync * Fix cli build * Fix * Fix build * Fix cli * Fix browser	7 months ago
Bernd Schoolmann	433a2801f6	[PM-25174] Disable type 0 decryption based on feature flag (#16865) ... * Disable type 0 decryption based on feature flag * Add tests * Move init to encrypt service	7 months ago