743 Commits (23ec6bacc9a992a4e2e1eb9aeff8a61dcfb60bfc)

Author	SHA1	Message	Date
Bernd Schoolmann	23ec6bacc9	[PM-20225] Prevent legacy users without userkey from logging in (#14267) ... * Prevent legacy users without userkey from logging in * Remove further web-migration code for legacy users * Add i18n for legacy user error message * Update comment * Remove migrate legacy component * Remove i18n messages * Remove migrate legacy encryption reference	10 months ago
Addison Beck	26caeb3083	Implement and extend tsconfig.base across projects (#14554) ... * Implement and extend tsconfig.base across projects * fixup! Merge remote-tracking branch 'origin/main' into rename-tsconfig * fix: import tsconfig.base from components * fix: skip typechecking node modules * fixing tests * fix the tests for real * undo accidentally change	10 months ago
Oscar Hinton	f3ff1e98ec	Remove standalone true from vault (#15040) ... Remove standalone: true from every instance since it's the default as of Angular 19.	10 months ago
Oscar Hinton	26fb7effd3	Remove standalone true from platform and UIF (#15032) ... Remove standalone: true from every instance since it's the default as of Angular 19.	10 months ago
Oscar Hinton	2fbc4c1578	[CL-525] Upgrade angular to v19 (#14815) ... Upgrade Angular to v19 using the update guide. - Add `standalone: false` to any missed component in stories or tests. - Update jest.config to follow the new best practices.	10 months ago
Todd Martin	721657a5c3	Update syntax for Github. (#14845)	10 months ago
Matt Gibson	9f9cb0d13d	Add-userid-to-encryption-methods (#14844) ... * Get userId from response if available This is a small improvement for the Auth team which avoids inspection of the access token, sometimes. * Initialize sdk clients with a userId * return both Cipher and encryptedFor when encrypting a cipher Update cipher api requests to include encryptedFor attribute * Prefer named types with documentation * Update sdk to latest * Fixup types * Fixup tests * Revert getting userId from identity token response --------- Co-authored-by: Shane <smelton@bitwarden.com>	10 months ago
Thomas Avery	895d54fd5e	[PM-21443] Require userId for KeyService's everHadUserKey$ (#14712) ... * Require userId for KeyService's everHadUserKey$ * handle null active user in tdeDecryptionRequiredGuard	10 months ago
Addison Beck	56a3b14583	Introduce eslint errors for risky/circular imports (#14804) ... * first draft at an idea dependency graph * ignore existing errors * remove conflicting rule regarding internal platform logic in libs * review: allow components to import from platform	10 months ago
Jordan Aasen	57911f210b	[PM-21896] - prevent double reprompt for copy password in desktop cipher form (#14883) ... * prevent double reprompt for copy password in desktop cipher form * adjust name * fix input name	10 months ago
Jason Ng	fd10a26df9	[PM-18804] generator nudges (#14705) ... * added generator spotlight to credential generator component * moved generator spotlight to browser component and add as slot in libs. update copy for send * added an aria label for the generator nudge body content * new copy and styles for browser send will be behind feature flag * update featureflag call to observable in send-v2 * changed how nudge text is made in credential generator * added new observable to vault nudges to return specific boolean. Update naming of vault types. update observable calls in credential-generator and send-v2 * update send-v2 and credential generator to use new renamed nudges * update to create nudge generator spotlight component. using this inside the credential generator for nudge spotlight * fix imports for Nudge related code * add libs/angular to storybook --------- Co-authored-by: Nick Krantz <nick@livefront.com>	10 months ago
Nick Krantz	1c4d851046	[PM-21005] Clear Add/Edit form cache when browser loses focus (#14634)	10 months ago
Jordan Aasen	7641dab0f0	[PM-18801] - account security nudge (#14771) ... * account security nudge * fix messages.json * fix tests * fix logic for account security item * fix tests * adjust account security nudge work to updated nudge service * fix account security nudge * remove unused code. do not show account security badge * include ff and safari in link html * fix import * Revert "include ff and safari in link html" This reverts commit cd12a36274.	10 months ago
Nick Krantz	83c4438efe	Refactor: Move `NudgesService` to `libs/angular/vault` (#14843) ... * move NudgesService to libs/angular/vault to avoid circular dependencies * remove fix for spotlight component in storybook	10 months ago
Alec Rippberger	72cfc0bca1	fix(environment-urls): [PM-19890] [Defect][Extension] Environment URLs are removed (#14821) ... * Return early to avoid setEnvironment * Remove ts-strict-ignore and update typing	10 months ago
Maciej Zieniuk	e73f902aee	[PM-18576] Fix missing user id on remove password (#13777) ... * Passed in userId on RemovePasswordComponent. * Added userId on other references to KeyConnectorService methods * remove password component refactor, test coverage, enabled strict * explicit user id provided to key connector service * redirect to / instead when user not logged in or not managing organization * key connector service explicit user id * key connector service no longer requires account service * key connector service missing null type * cli convert to key connector unit tests * remove unnecessary SyncService * error toast not showing on ErrorResponse * bad import due to merge conflict * bad import due to merge conflict * missing loading in remove password component for browser extension * error handling in remove password component * organization observable race condition in key-connector * usesKeyConnector always returns boolean * unit test coverage * key connector reactive * reactive key connector service * introducing convertAccountRequired$ * cli build fix * moving message sending side effect to sync * key connector service unit tests * fix unit tests * unit tests in wrong place after KM code ownership move * infinite page reload * failing unit tests * failing unit tests --------- Co-authored-by: Todd Martin <tmartin@bitwarden.com>	10 months ago
Todd Martin	2bde090b37	chore(view-cache): Rename view-cache docs to README to allow Github rendering ... * Renamed documentation file * Updated documentation link.	10 months ago
Alex Morask	d2cce5b997	Fix input errors on provider setup (#14799)	10 months ago
rr-bw	afbddeaf86	refactor(set-change-password): [Auth/PM-18458] Create new ChangePasswordComponent (#14226) ... This PR creates a new ChangePasswordComponent. The first use-case of the ChangePasswordComponent is to place it inside a new PasswordSettingsComponent, which is accessed by going to Account Settings > Security. The ChangePasswordComponent will be updated in future PRs to handle more change password scenarios. Feature Flags: PM16117_ChangeExistingPasswordRefactor	10 months ago
Oscar Hinton	ac49e594c1	Add standalone false to all non migrated (#14797) ... Adds standalone: false to all components since Angular is changing the default to true and we'd rather not have the angular PR change 300+ files.	10 months ago
SmithThe4th	ad3121f535	[PM-12423] Migrate Cipher Decryption to Use SDK (#14206) ... * Created mappings for client domain object to SDK * Add abstract decrypt observable * Added todo for future consideration * Added implementation to cipher service * Added adapter and unit tests * Created cipher encryption abstraction and service * Register cipher encryption service * Added tests for the cipher encryption service * changed signature * Updated feature flag name * added new function to be used for decrypting ciphers * Added new encryptedKey field * added new function to be used for decrypting ciphers * Manually set fields * Added encrypted key in attachment view * Fixed test * Updated references to use decrypt with feature flag * Added dependency * updated package.json * lint fix * fixed tests * Fixed small mapping issues * Fixed test * Added function to decrypt fido2 key value * Added function to decrypt fido2 key value and updated test * updated to use sdk function without prociding the key * updated localdata sdk type change * decrypt attachment content using sdk * Fixed dependency issues * updated package.json * Refactored service to handle getting decrypted buffer using the legacy and sdk implementations * updated services and component to use refactored version * Updated decryptCiphersWithSdk to use decryptManyLegacy for batch decryption, ensuring the SDK is only called once per batch * Fixed merge conflicts * Fixed merge conflicts * Fixed merge conflicts * Fixed lint issues * Moved getDecryptedAttachmentBuffer to cipher service * Moved getDecryptedAttachmentBuffer to cipher service * ensure CipherView properties are null instead of undefined * Fixed test * ensure AttachmentView properties are null instead of undefined * Linked ticket in comment * removed unused orgKey	10 months ago
cyprain-okeke	5fb46df341	[PM 21106]Remove button not responsive for admin Console Remove Sponorship (#14743) ... * Resolve the remove button inactive * Resolve the lint error	10 months ago
Patrick-Pimentel-Bitwarden	0b0397c3f0	fix(enums-eslint): Enum Rule for ESLint (#14650) ... * fix(enums-eslint): Enum Rule for ESLint - Added enums in the warnings for eslint. * fix(enums-eslint): Enum Rule for ESLint - Updated to error in both places for enums. * fix(enums-eslint): Enum Rule for ESLint - Added new eslint plugin for warning on enums. * fix(enums-eslint): Enum Rule for ESLint - Changed based on suggestion. Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com> * refactor(browser-platform-utils): Remove Deprecation and Fix Code - Changed usages of firefox to private and moved the usages to the preferred public method and removed the deprecations. * fix(enums-eslint): Enum Rule for ESLint - Updated to error and added disable rules for all other places. * fix(enums-eslint): Enum Rule for ESLint - Undid other changes by accident	10 months ago
Todd Martin	eed18c9294	chore(view-cache): [PM-21154] Move view-cache its own feature package and adjust imports ... * Moved view-cache services to directory * Fixed DI for browser extension. * Fixed tests.	10 months ago
Bryan Cunningham	4d15f2d43c	[PM-16057] use Roboto as primary font (#14553) ... * swap to using roboto variable font	10 months ago
Justin Baur	1b756df749	[PM-14484] `ApiService` showing html in error message (#14658) ... * Make ApiService more testable * Add ApiService tests * Switch to only reading text/plain content	10 months ago
Todd Martin	4191bb9533	chore(captcha): [PM-15162] Remove handling of captcha enforcement and bypass token ... * Removed captcha references. * Removed connectors from webpack * Fixed extra parameter. * Resolve merge conflicts. * Fixed extra argument. * Fixed failing tests. * Fixed failing test. * Accessibility cookie cleanup * Cleaned up accessibility component. * Deleted old registration endpoint * Remove unused register request object. * Fixed merge error that changed font family. * Fixed formatting from merge. * Linting	10 months ago
Alec Rippberger	3030eb7552	[PM-19212] Consolidate password set routing to AuthGuard using ForceSetPasswordReason (#14356) ... * Consolidates component routing, removing routing to update-temp-password from components. All routing to update-temp-password should happen in the AuthGuard now. --------- Co-authored-by: Jared Snider <jsnider@bitwarden.com> Co-authored-by: Todd Martin <tmartin@bitwarden.com>	10 months ago
Vicki League	8ecb32f30f	[CL-333] Icon Refresh Feature Branch (#14298) ... * [CL-571] Update icons to new fileset and metaphors (#14163) * [CL-518] Convert icons docs to stories (#14299) * [CL-574] Update inline autofill icons (#14379) --------- Co-authored-by: William Martin <contact@willmartian.com>	10 months ago
Todd Martin	74b6bb15e8	Delete old SSO component. (#14604)	10 months ago
Bernd Schoolmann	744c1b1b49	[PM-21001] Move vault code to new encrypt service interface (#14546) ... * Move vault code to new encrypt service interface * Fix tests	10 months ago
Nick Krantz	46df5279a3	[PM-18485] Remove new device verification guard (#14417) ... * remove NewDeviceVerificationGuard and all associated entities. New Device verification feature has rolled out in production, this guard is no longer needed. * remove unused properties from the vault profile service	10 months ago
Brandon Treston	fd43222938	[PM-19383] admins unable to download attachments (#14363) ... * add admin support for downloading attachments * fix delete and upload * fix delete admin to return a response * fix upload * add missing param * use getCipherAdmin * fix cli	11 months ago
Matt Gibson	013a34e042	[PM-17440] Use SDK for decryption (#14277) ... * Improve dev logging * Define decrypt with sdk flag * Use SDK's pure crypto functions for decryption feature flagged by `use-sdk-for-decryption` * Avoid pushing decryption requests to web workers for SDK web workers are able to use the SDK, but they require the SDK module to be initialized. If this is eventually seen as desired, we'll need client-specific worker scripts. * Apply suggestions from code review Co-authored-by: Bernd Schoolmann <mail@quexten.com> * fixup! Apply suggestions from code review * fixup: Update feature flag state in config callbacks * Apply suggestions from code review Co-authored-by: Bernd Schoolmann <mail@quexten.com> --------- Co-authored-by: Bernd Schoolmann <mail@quexten.com>	11 months ago
cyprain-okeke	a7d04dc212	[PM-17775] Allow admin to send f4 e sponsorship (#14390) ... * Added nav item for f4e in org admin console * shotgun surgery for adding "useAdminSponsoredFamilies" feature from the org table * Resolved issue with members nav item also being selected when f4e is selected * Separated out billing's logic from the org layout component * Removed unused observable * Moved logic to existing f4e policy service and added unit tests * Resolved script typescript error * Resolved goofy switchMap * Add changes for the issue orgs * Added changes for the dialog * Rename the files properly * Remove the commented code * Change the implement to align with design * Add todo comments * Remove the comment todo * Fix the uni test error * Resolve the unit test * Resolve the unit test issue * Resolve the pr comments on any and route * remove the any * remove the generic validator * Resolve the unit test * add validations for email * Add changes for the autoscale * Changes to allow admin to send F4E sponsorship * Fix the lint errors * Resolve the lint errors * Fix the revokeAccount message * Fix the lint runtime error * Resolve the lint issues * Remove unused components * Changes to add isadminInitiated * remove the FIXME comment * Resolve the failing test * Fix the pr comments * Resolve the orgkey and other comments * Resolve the lint error * Resolve the lint error * resolve the spelling error * refactor the getStatus method * Remove the deprecated method * Resolve the unusual type casting * revert the change --------- Co-authored-by: Conner Turnbull <cturnbull@bitwarden.com> Co-authored-by: Conner Turnbull <133619638+cturnbull-bitwarden@users.noreply.github.com>	11 months ago
Thomas Avery	d43e4757df	[PM-7604] Require target UserID for KdfConfigService (#14380) ... * Require userId for KdfConfigService * Update auth team callers * Update tools team callers	11 months ago
Jordan Aasen	b589951c90	[PM-18520] - Update desktop cipher forms to use the same UI as web app and extension - (#13992) ... * WIP - cipher form refactor * cipher clone * cipher clone * finalize item view and form changes * fix tests * hide changes behind feature flag * set flag to false * create vault items v2. add button selector * revert change to flag and vault items * add attachments * revert change to tsconfig * move module * fix modules * cleanup * fix import * fix import * fix import * remove showForm * update feature flag * wip - cleanup * fix up services * cleanup * fix type errors * fix lint errors * add dialog component * revert changes to menu * revert changes to menu * fix vault-items-v2 * set feature flag to FALSE * add missing i18n keys. fix collection state * remove generator. update modules. bug fix * fix restricted imports * mark method as deprecated. add uri arg back * fix shared.module * fix shared.module * fix shared.module * add uri * check and prompt for premium when opening attachments dialog * move VaultItemDialogResult back * fix import in spec file * update copy functions * fix MP reprompt issue	11 months ago
Bernd Schoolmann	e231286f37	[PM-19731] Refactor encrypt service to expose key wrapping (#14080) ... * Refactor encrypt service to expose key wrapping * Fix build * Undo ts strict removal * Fix wrong method being used to encrypt key material * Rename parameters and remove todo * Add summary to encrypt * Update libs/common/src/key-management/crypto/services/encrypt.service.implementation.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/crypto/services/encrypt.service.implementation.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/crypto/services/encrypt.service.implementation.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/crypto/services/encrypt.service.implementation.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/crypto/abstractions/encrypt.service.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/crypto/services/encrypt.service.implementation.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Add tests for unhappy paths * Add test coverage * Add links --------- Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>	11 months ago
Shane Melton	d6bda3bcdf	[PM-20433] Add view cache options for view cache service signals to allow cached values to persist navigation events (#14348)	11 months ago
Shane Melton	143473927e	[PM-10611] End user notification sync (#14116) ... * [PM-10611] Remove Angular dependencies from Notifications module * [PM-10611] Move end user notification service to /libs/common/vault/notifications * [PM-10611] Implement listenForEndUserNotifications() for EndUserNotificationService * [PM-10611] Add missing taskId to notification models * [PM-10611] Add switch cases for end user notification payloads * [PM-10611] Mark task related notifications as read when visiting the at-risk password page * [PM-10611] Revert change to default-notifications service * [PM-10611] Fix test * [PM-10611] Fix tests and log warning in case more notifications than the default page size are available * [PM-10611] Use separate feature flag for end user notifications * [PM-10611] Fix test	11 months ago
Maciej Zieniuk	4da03821ce	move key connector components to KM team ownership (#14008)	11 months ago
Jonas Hendrickx	e026799071	[PM-13128] Enable Breadcrumb Policies (#13584) ... * [PM-13128] Enable Breadcrumb Policies * [PM-13128] Enable Breadcrumb Policies * [PM-13128] wip * [PM-13128] wip * [PM-13128] wip * [PM-13128] wip * remove dead code * wip * wip * wip * refactor * Fix for providers * revert to functional auth guard * change prerequisite to info variant * address comment * r * r * r * tests * r * r * fix tests * feedback * fix tests * fix tests * Rename upselling to breadcrumbing * Address feedback * Fix build & tests * Make the guard callback use Observable instead of a promise * Pm 13128 suggestions (#14041) * Rename new enum value * Show the upgrade button when breadcrumbing is enabled * Show mouse pointer when cursor is hovered above badge * Do not make the dialogs overlap * Align badge middle * Gap * Badge should be a `button` instead of `span` * missing button@type --------- Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com> Co-authored-by: Alex Morask <amorask@bitwarden.com>	11 months ago
Shane Melton	8258ea39b0	[PM-18903] Desktop sync issues (#13681) ... * [PM-18707] Use different BroadcasterSubscriptionId in base view component to avoid collision with desktop view component * [PM-18707] Use userId instead of payloadUserId for cipher notification syncs * [PM-19032] Live Sync on Desktop (#13851) * migrate the vault-items to an observables rather than async/promises - this helps keep data in sync with the service state and avoids race conditions * migrate the view component to an observables rather than async/promises - this helps keep data in sync with the service state and avoids race conditions * decrypt saved cipher from server * bump timeout for upserting ciphers * mark `go` as async in desktop vault - previously it was a floating promise * Revert "mark `go` as async in desktop vault" This reverts commit fd28f40b18. * Revert "bump timeout for upserting ciphers" This reverts commit e963acc377. * move vault utilities to `common` rather than `lib` to avoid circular dependencies * use `perUserCache$` for `cipherViews$` to avoid new subscriptions from being created * use userId from observable rather than locally set to be the most up to date * [PM-18707] Add clearBuffer$ input to perUserCache$ helper so that the internal share replay buffers can be cleared * [PM-18707] Rework forceCipherViews$ to clearBuffer$ refactor - Add dependency for cipherDecryptionKeys$ for the cipherViews so that decryption is never attempted without keys * [PM-18707] Add overload to perUserCache to satisfy type checker * [PM-18707] Fix overloads * [PM-18707] Add check for empty failed to decrypt ciphers * [PM-18707] Mark vault component for check after observable emits. The cipherViews$ observable now persists between subscriptions, meaning that updates via the sync push notifications can occur outside the AngularZone causing delays in updating the view. --------- Co-authored-by: Nick Krantz <125900171+nick-livefront@users.noreply.github.com> Co-authored-by: Nick Krantz <nick@livefront.com>	11 months ago
Bernd Schoolmann	b09305577f	[PM-19603] Change asymmetric interface to only allow key encapsulation (#14046) ... * Change asymmetric interface to only allow key encapsulation * Fix naming * Clean up naming * Update libs/common/src/key-management/crypto/abstractions/encrypt.service.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/crypto/services/encrypt.service.implementation.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/crypto/abstractions/encrypt.service.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Fix test --------- Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>	11 months ago
Todd Martin	f7934b98c6	fix(login): [PM-11502] Support Remember Email option consistently ... * Moved saving of SSO email outside of browser/desktop code * Clarified comments. * Tests * Refactored login component services to manage state * Fixed input on login component * Fixed tests * Linting * Moved web setting in state into web override * updated tests * Fixed typing. * Fixed type safety issues. * Added comments and renamed for clarity. * Removed method parameters that weren't used * Added clarifying comments * Added more comments. * Removed test that is not necessary on base * Test cleanup * More comments. * Linting * Fixed test. * Fixed base URL * Fixed typechecking. * Type checking * Moved setting of email state to default service * Added comments. * Consolidated SSO URL formatting * Updated comment * Fixed reference. * Fixed missing parameter. * Initialized service. * Added comments * Added initialization of new service * Made email optional due to CLI. * Fixed comment on handleSsoClick. * Added SSO email persistence to v1 component. * Updated login email service. * Updated setting of remember me * Removed unnecessary input checking and rearranged functions * Fixed name * Added handling of Remember Email to old component for passkey click * Updated v1 component to persist the email on Continue click * Fix merge conflicts. * Merge conflicts in login component. * Persisted login email on v1 browser component. * Merge conflicts * fix(snap) [PM-17464][PM-17463][PM-15587] Allow Snap to use custom callback protocol * Removed Snap from custom protocol workaround * Fixed tests. * Updated case numbers on test * Resolved PR feedback. * PM-11502 - LoginEmailSvcAbstraction - mark methods as abstract to satisfy strict ts. * Removed test * Changed to persist on leaving fields instead of button click. * Fixed type checking. --------- Co-authored-by: Bernd Schoolmann <mail@quexten.com> Co-authored-by: Jared Snider <jsnider@bitwarden.com> Co-authored-by: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com>	11 months ago
Bernd Schoolmann	5a1b0744f0	[PM-17665] Move cryptofunction service to km (#13285) ... * Move cryptofunction service to km * Fix formatting * Fix import * Fix build on desktop * Fix build on browser and tests	11 months ago
rr-bw	a4040b6b6b	refactor(set-change-password): [Auth/PM-17649] Move CompareInputs Validator (#14173) ... This PR - Moves the `compareInputs` validator to `libs/auth` (with some minor updates to the validator) - Adds unit tests for `compareInputs` - Removes the deprecated input validators from `InputsFieldMatch` along with the `inputs-field-match.validator.ts` file	11 months ago
rr-bw	81350a2ee1	Revert "refactor(set-change-password): [Auth/PM-17649] Move and test compareI…" (#14171) ... This reverts commit ecb4b2d0b7.	11 months ago
rr-bw	ecb4b2d0b7	refactor(set-change-password): [Auth/PM-17649] Move and test compareInputs validator (#13553) ... - Move the `compareInputs` validator to `libs/auth` - Add tests for the `compareInputs` validator - Delete the deprecated `InputsFieldMatch` class (inputs-field-match.validator.ts)	11 months ago
Kyle Spearrin	254cad29b3	[PM-8951] set pin validation to min length of 4 (#13312) ... * set pin validation to min length of 4 * use reactive forms * PM-8951 - SetPin - remove dialog close logic if pin is invalid so validation errors can be shown to the user. --------- Co-authored-by: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com> Co-authored-by: Jared Snider <jsnider@bitwarden.com>	11 months ago