18 Commits (main)

Author	SHA1	Message	Date
neuronull	9c6eeddf5b	Add script to install Rust env. Use in CI and pre-commit hooks. (#19891)	2 days ago
Will Martin	d763590ce6	[CL-1023][CL-1031] Design system refresh: Milestone 1 (#19061) ... * [CL-1009] button style updates (#18301) * add new button styles * update disabled styles * updated size stories * update disabled button story names * updated button stories * add more explicit screenshots * make class list a computed signal * updated button docs * allow unstyled button to inherit color * use unstyled button in callouts until callout updates * base button directive WIP * add base button directive * fix focus and hover styles * fix lint error * remove commented code that moved to base directive * ensure buttonStype defaults correctly * migrate legacy icon button types * contrast button wips * pull in latest and fix disabled with attr * fix legacy variant * add back nav contrast button variant * updated icon button docs * rename nav contrast variant and fix contrast focus * fix button sizing * fix product switcher button classes * add contrast icon button story * fix border color * update to primaryGhost variant * [CL-1025] icon font refresh (#18727) * adding new icons * migrate to new icon names * updated icon build docs * resolve conflicts and re-run migration * add icons deps to uif ownership * fix incorrect migration * fix misnamed icon * create filter icon and fix mapping error * updated readme and add migration script to package.json * fix prettier warnings * remove browser alt from definition list * add missing icon types * fix image name migrated in error and update regex to not change these * ensure icon array is updated automatically * updated build comment * remove unnecessary direct execution command * remove direct run command * allow legacy icon names to map to new icons * [CL-1025] Icon font refresh - Temporary migration state with legacy names (#18948) * Revert icon name migrations, preserve migration tooling Reverted all icon name changes that were applied by the migration scripts, while preserving: - New icon SVG files in libs/assets/src/material-icons/ - Icon font files in libs/angular/src/scss/bwicons/ - Migration scripts in scripts/material-icons/ - NPM scripts and dependencies for icon tooling This allows running the migration fresh when ready. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Build icon font with bidirectional legacy/new name mapping Ran icons:build to generate bidirectional icon mappings: - SCSS now includes 155 icons (both Figma and legacy BWI names) - TypeScript icon.ts updated with all 155 names - All legacy names (e.g., bwi-question-circle, bwi-plus) point to new icon assets - All new names (e.g., bwi-help, bwi-add) also available - Codebase can continue using legacy names with new icon designs This enables the temporary migration state where code uses existing legacy icon names but displays the new refreshed icon assets. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Fix: revert bwi-filter back to bwi-grid across codebase bwi-grid is the correct new icon name and should not be reverted. The changes from bwi-filter to bwi-grid were manual corrections, not part of the automated migration. Updated 16 files to restore bwi-grid icon references. Addresses feedback from Bryan Cunningham on PR #18948 --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> * remove duplicate key and add back dep ownership change * fix formatting errors --------- Co-authored-by: Will Martin <contact@willmartian.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> * fix button variant * [CL-1040] updated palette colors (#19401) * [CL-973] chip component (#18798) * wip * WIP * create chip filter component * trying to get truncation to work * fix truncation * create chip-action component * fix type errors * add chip component * add shared story args * have chips take label input * fix test template and imports * fixing arg types and disabled states * simplify disabled logic * fix dimssis button alignment * update menu focus color * updated chip docs * update chip-select usage to chip-filter * fix full width icon layout * remove commited code * export chip component * remove commented code * expose full width * chip component should not go full width * use bit-icon in filter template * remove commented code * updated chip docs * remove extra truncate class * fix dupe input definitions * move import to correct line * read base chip values directly * remove standlaone as it's the default * forward size correctly * create full width arg type * let type be infered * updated jsdoc comments * use more modern angular syntax * rename components to use kebab case * remove redundant docs * remove inaccurate link docs * remove enum like types * remove dead code * remove unused spec * remove host bindings * restructure chips folders * add max width class * remove full width docs * add internal comment * bind to missing controls * fixing docs * replace disabled verbiage with inactive * remove unnecessary comment * default to primary * do not allow end icon in action chip * take chip action screenshots in both themes * use selected input for base directive * fix width error * coerce to boolean * fixed end icon reference * fix code reference to endIcon * fixing chip filter specs * fix missing input transform * fix docs * fix input and add truncate * ensure chip content truncates * updated slot naming * updated example to use new flow control * fix typing for option.icon * fix failing test, fix filter type, and support colored icons in filter options * fix failing test * doc updates * change dismissed event name * remove standalone * fix selector * fix docs * remove unused fvw data property and fix docs links * use base as host directive in chip * fix spec button selectors * fix duplicate class binding * fix incorrect variant resolution * handle undefined size * fix signal type * remove duplicate input * fix failing spec * updated styles for trailing icon spacing and font size * padding tweaks for visual design * make variant a writable model * use logical text align * update slot names * remove dismissible input * add back missing import * remove ability to set chip filter to small size * create size arg type --------- Co-authored-by: Vicki League <vleague@bitwarden.com> * [CL-987] Update Nav Group and Nav Item components (#18965) * updated side nav `nav-group` and `nav-item` components * - added focus states - set cursor pointer for nav-item - updated arrow orientations * - updated `navItemIndentationPadding` - reverted `[treeDepth]` for `nav-group` - removed placeholder arrow * - removed text style from starting slot container - fixed routes in story * created shared container classes var * fixes from rebase, override `border-radius` for collapse arrow button * updated `tw-theme`: reverted `--color-bg-hover` and added `--color-bg-sidenav-hover` * removed end slot `div` styles from rebase, updated `buttonType` in `nav-group` story * added dark mode `--color-bg-sidenav-hover` * added `xsmall` size variant to 'Icon Button' * - updated navs to use 'xsmall' button - fixed container padding - removed custom arrow button styles * fixed type error * fixed focus-visible state by adding `tw-outline-none` to `nav-item` * fixed type error * placed arrow button directly in start slot * defined `containerClasses` in template * renamed 'item-active-hover' to 'active-item-hover' for consistency * missed renaming from `item-active-hover` to `active-item-hover` * fixed 'hover' and 'active' colors, added colors for arrow hover states * - separated buttons sizes for 'Button' and 'Icon Button' from `BaseButtonDirective` into respective components - moved `border-radius` style from Directive into own components * fixed/simplified focus colors, added sidenav specific focus colors * updated 'arrow' icon size for nav group, updated 'xsmall' font size * trigger Claude review * removed `tw-text-2xl` in nav-group for arrow button * removed unused `NgClass` import * more cleanup, removed unused `Ng` imports * converted `_isActive` to signal and `showActiveStyles` to computed * removed instances of `variant="tree"` * renamed color variables from `admin-sidenav` to `sidenav-secondary` --------- Co-authored-by: Will Martin <contact@willmartian.com> * fix lint * [CL-1096] Fix icon button width shrinking in flex containers (#19529) Add tw-shrink-0 to prevent icon buttons from shrinking below their fixed size when placed inside flex containers. * [CL-1101] Fix chip dismiss button hover style and add interaction state stories (#19530) Use the correct bg-bg-hover token for dismiss button hover background, matching the Figma spec. The previous hover-contrast token was invisible on light backgrounds. Add InteractionStates story showing Default, Hover, Focus, and Inactive states for both large and small sizes. * [CL-1098] Fix danger icon button color in form field suffix (#19532) * [CL] Fix danger icon button color in form field suffix Don't apply tw-text-muted to icon button suffixes — icon buttons manage their own text color via buttonType, so the muted class was overriding danger/primary colors (e.g. blue icon on red background in Cipher Form). * [CL] Fix danger icon button color in form field suffix Don't apply tw-text-muted to icon button suffixes — icon buttons manage their own text color via buttonType, so the muted class was overriding danger/primary colors (e.g. blue icon on red background in Cipher Form). Also adds a DangerButtonInputGroup story to capture this case. * [CL-1094] Update icon button default variant to primaryGhost (#19534) * [CL-1094] Update icon button default variant to primaryGhost Change buttonType from input to model in BaseButtonDirective, and set the default to primaryGhost in the icon button constructor. * [CL-1094] Fix icon button default variant using own input + effect Using model.set() in the constructor is overridden by Angular's input initialization lifecycle. Instead, own buttonType as an input directly on BitIconButtonComponent with primaryGhost as the default, and sync to the base directive via effect. * [CL-959] update badge component styles (#19026) * badge wip * dynamic truncated badge tooltip * support legacy variants for now * add deprecation types and remove hover styles * updated story docs * add default icons for badges * fix incorrect color mapping * add ability to hide start icon * take snapshot in both themes * add icon size styles * remove tooltip code * update at risk password to use actual buttons * more specific badge truncation docs * remove badge module from imports * use chip action for link * fix missing import * use chip in multi-select inputs * update org badge to use primary chip * update premium badge to accent primary action chip * use chip action for vault item fill * remove unnecessary icon in badge * update obsolete notification variant * replace usage of bitBadge on button in stories * remove explicit input to hide startIcon * use berry instead of badge * fix type error * fixing imports and badge usage * use logical text align * remove dead code and update jsdoc comment * add back ability to not truncate * remove default icon for accent-primary * add missing translation keys to multi select story * allow null as default icon type * add element selector and update stories to use it * conditionally apply truncate class * conditionally apply title text * migrate badge to berry * use correct input for content * use berry in toggle group stories * remove unused template reference * remove unused import of badge * remove unused custom color code * remove unused service injection * [CL-1102] Fix help icon size in bit-label (#19533) * [CL-1102] Fix help icon size in bit-label Target bwi icons inside bit-label with [&_.bwi]:tw-text-xl to restore correct icon sizing after recent icon style changes. * [CL-1102] Fix text alignment regression in bit-label Add tw-leading-none to bwi icons to prevent the line-height from tw-text-xl from disrupting baseline alignment. * remove bwi-sm from label icon --------- Co-authored-by: Bryan Cunningham <bryan.cunningham@me.com> * [CL-964] Update Callout Component (#19424) * updated callout component * renamed consumer bit-callout `type` from 'default' to 'subtle' * updated callout 'end' slot * migrated spotlight to callout, deleted spotlight * - updated `title` comment - updated stories and mdx * removed `useAlertRole` * added `CommonModule` import and updated `buttonType` in stories * updated 'Accessibility' guidelines * updated 'close' button * - updated stories for clearer code - set `(onDismiss)` only for WithCloseButton story * added boolean switch for `persistent` to story * fixed tests * prettier fix * - updated `bit-callout` instances of `buttonType="unstyled"` to use appropriate `buttonType` - updated story for correct usage of button styles * fixed `type` in `vault-list` * updated to use `bit-icon` * - fixed vertical centering of icon and text - updated to 'OnPush' change detection * fixed error: added 'close' to `mockLayoutI18n` * updated `bit-callout` jsdoc comment and mdx * fixed `persistent` callout in `admin-settings` * removed "interrupt" language * reverted fix for `bit-callout` `persistent` * fixed type error * added `close` translation to stories utilizing `bit-callout` * converted to JSDoc comments * updated 'close' button to check if `dismiss` output is bound * fix: removed `readonly` from `isDismissible` * converted `isDismissble` to signal * added translation to `phishing-warning' story * added bottom margin back in to callout component * fixed type error, fixed `icon` values * revert subscription-card callout icon to default if not defined * fix: update 'bit-callout' type to 'subtle' * updated colors in `tw-theme` * added conditional check to compute vertical alignment class * updated more colors, slight restructure to match design * fixed vertical alignment with 'close button', avoid long text crowding/overflowing * remove default icons on non-semantic variants (#19614) * remove default icons on non-semantic variants * add back info icon to info variant * remove info icon again * [CL-1095] add expanded state for disclosure button (#19637) * add brand stronger colors * add aria-expanded styling for primary ghost button * make all variants aria-expanded style match hover styles * update orage-600 color value to fix contrast * minor spacing update to account for expanded button style * do not show expanded state on sidenav buttons * no expanded style on toggle width button * remove extra letter spacing and update story copy (#19668) * [CL-1123] fix ghost button inactive styles (#19669) * fix ghost button inactive styles * remove type declaration * [CL-1119] toggle berry update (#19609) * update toggle groups to use berry * set berry variant based on selected state * fix failing spec * add spec to test berry variant set correctly * fix import errors caused by bad merge conflict resolution * remove unnecessary variant delaration * update kitchen sink stories to use berry * [CL-1122] BUG FIX: Migrated Icon Buttons with button type 'danger' to 'dangerGhost' (#19677) * migrated `bitIconButton` with 'danger' `buttonType` to 'dangerGhost' * reverted icon-button story * fix button variant from merge * [CL-1117] BUG FIX: Side nav collapse arrow is placed too far left (#19623) * - updated spacing for side-nav collapse arrow button - updated collapsed nav-item button spacing and dimensions - moved individual nav-item wrapper padding into side-nav component - added button to 'WithLongText' nav-item story * added sidenav specific hover style to toggle collapse button * - set horizontal padding back to 'nav-item' - updated 'bit-divider' color to 'bg-border-brand' * updated hover styles for interactive trailing elements * added '4px' more end padding to trailing buttons * updated 'bit-divider' colors for secondary and dark theme * moved button hover styles into 'side-nav' button variant * updated sidenav-divider color for dark theme * removed `tw-w-10` on nav-item collapsed * updated inline padding to `12px` for both collapse and expanded states * [CL-1117] cleaned up, renamed, and organized sidenav color variables (#19665) * - unified 'strong' styles and `showActiveStyles` into `[style]` - updated 'side-nav' button variant's `aria-expanded` and `focus-visible` styles * - inherit bg and fg from parent `sidenav` - allow trailing buttons set own fg * updated nav group story for trailing elements * updated nav-logo 'focus' to nav focus style * let toggle width arrow inherit 'aria-expanded' style from 'side-nav' buttontype * removed danger button variants from nav group story --------- Co-authored-by: Bryan Cunningham <bcunningham@bitwarden.com> Co-authored-by: Vicki League <vleague@bitwarden.com> Co-authored-by: Leslie Xiong <lxiong@livefront.com>	2 weeks ago
Andreas Coroiu	477b856519	[PM-31696] Create reverse proxy emulator (#19361) ... * [PM-31696] Add reverse proxy emulator for load balancer cookie testing Adds a local dev/QA tool that emulates AWS ELB authentication without real AWS infrastructure. It gates all traffic behind a BitwardenLoadBalancerCookie and serves a simple auth page to issue it, enabling testing of the load balancer cookie bootstrap flow (PM-27124). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * [PM-31696] Replace http-proxy with Node.js built-ins http-proxy has not been published in 6 years and uses the deprecated util._extend API. Replace it with https.request + piping for HTTP and tls.connect + socket piping for WebSocket, removing the dependency and the --no-deprecation workaround entirely. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * [PM-31696] Fix TLS verification for public backends Extend the default CA bundle with the self-signed cert instead of replacing it, so both localhost dev servers and public backends (e.g. vault.bitwarden.com) are trusted without --insecure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * [PM-31696] Add cookie rotation via R keypress Press R while the proxy is running to increment the cookie generation, immediately invalidating all existing session cookies and forcing clients to re-authenticate on their next request. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs: tweak docs * feat: improve error messages * docs: update readme --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>	3 weeks ago
Todd Martin	528f59875e	chore(deps): Include Cargo dependencies in dep-ownership lint check ... * Added Cardo dep ownership. * Fixed file paths. * Moved aes-gcm from KM to Tools.	3 months ago
Andreas Coroiu	64590cb3c8	[PM-25911] Add commercial sdk internal as dependency (#16883) ... * feat: add commercial sdk as optional dependency * feat: add alias to CLI * feat: add alias to browser * feat: add alias to web * fix: revert optional - we cant omit optional dependencies or the builds break * feat: remove commercial package from browser build * feat: remove commercial package from cli build * feat: remove commercial package from web build * chore: add commercial sdk to renovate * fix: windows cli workflow * fix: accidental change * feat: add lint for version string * undo weird merge changes	5 months ago
Addison Beck	26caeb3083	Implement and extend tsconfig.base across projects (#14554) ... * Implement and extend tsconfig.base across projects * fixup! Merge remote-tracking branch 'origin/main' into rename-tsconfig * fix: import tsconfig.base from components * fix: skip typechecking node modules * fixing tests * fix the tests for real * undo accidentally change	10 months ago
Oscar Hinton	2fbc4c1578	[CL-525] Upgrade angular to v19 (#14815) ... Upgrade Angular to v19 using the update guide. - Add `standalone: false` to any missed component in stories or tests. - Update jest.config to follow the new best practices.	10 months ago
Todd Martin	2622422cf7	Migrate Renovate config to JSON5 (#13233) ... * Renamed to JSON5 * Updated linting script to use new file name. * Add JSON5 dependency * Added JSON5 to renovate. * Removed JSON5 formatting * Prettier * Added comment for demonstration --------- Co-authored-by: Matt Bishop <mbishop@bitwarden.com>	1 year ago
Oscar Hinton	70ea75d8f7	[PM-17496] Migrate eslint to flat config (#12806) ... The legacy config is deprecated and will be removed in eslint 10. The flat config also allows us to write js functions which will assist in handling limitations with multiple identical rules.	1 year ago
Oscar Hinton	653b730969	[PM-16872] Update libs to use explicit dependencies (#12770) ... Update all libs to use explicit dependencies rather than relying on tsconfig.libs.json. This allows us to more easily understand the dependencies between libs and prevent users from accidentally adding new dependencies. We still use tsconfig.libs (now renamed tsconfig.spec) for tests.	1 year ago
Oscar Hinton	48f99099b2	[PM-16845] Lint unowned dependencies (#12748) ... * Lint unowned dependencies * Split npm ci and run linter * Set explicit versions for unchanged parts of the workflow .... * Rename yao-pkg * Add owners for sdk-internal, fuses and angular-eslint/schematics * Assign owners for angular and storybook * Add typescript-strict-plugin * Add two more unowned dependencies --------- Co-authored-by: Todd Martin <106564991+trmartin4@users.noreply.github.com> Co-authored-by: Addison Beck <github@addisonbeck.com>	1 year ago
Matt Gibson	9c1e2ebd67	Typescript-strict-plugin (#12235) ... * Use typescript-strict-plugin to iteratively turn on strict * Add strict testing to pipeline Can be executed locally through either `npm run test:types` for full type checking including spec files, or `npx tsc-strict` for only tsconfig.json included files. * turn on strict for scripts directory * Use plugin for all tsconfigs in monorepo vscode is capable of executing tsc with plugins, but uses the most relevant tsconfig to do so. If the plugin is not a part of that config, it is skipped and developers get no feedback of strict compile time issues. These updates remedy that at the cost of slightly more complex removal of the plugin when the time comes. * remove plugin from configs that extend one that already has it * Update workspace settings to honor strict plugin * Apply strict-plugin to native message test runner * Update vscode workspace to use root tsc version * `./node_modules/.bin/update-strict-comments` 🤖 This is a one-time operation. All future files should adhere to strict type checking. * Add fixme to `ts-strict-ignore` comments * `update-strict-comments` 🤖 repeated for new merge files	1 year ago
Oscar Hinton	e3e675383f	Fix locale test after typescript upgrade (#11859) ... The TypeScript update broke locale tests, to fix this we need to define moduleResolution manually as mentioned in the TS changelog.	1 year ago
Maciej Zieniuk	df14e3f030	[PM-13207] Detect incompatible locale changes (#11425) ... * detecting unsupported modifications in locales * typo fix * limit to english locales, increased verbosity * increased verbosity	2 years ago
renovate[bot]	28de9439be	[deps] Autofill: Update prettier to v3 (#7014) ... * [deps] Autofill: Update prettier to v3 * prettier formatting updates --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jonathan Prusik <jprusik@classynemesis.com>	2 years ago
Matt Gibson	c58b0c0753	Return error code when any tsc typecheck fails (#5459) ... * Return error code when any tsc typecheck fails * Try with bash `sh ./scripts/test-types.s` resulted in errors missing `[[`, which is a bash builtin. It's possible the ubuntu runner is using some other shell. * Fix spec type errors * Switch to node for Windows compatibility	3 years ago
Kyle Spearrin	faf8b7f679	Revert "cloc script. move script to folder" ... This reverts commit a72955433b.	8 years ago
Kyle Spearrin	a72955433b	cloc script. move script to folder	8 years ago