86 Commits (anders/electron-builder)

Author	SHA1	Message	Date
Jordan Aasen	2a72d2e74d	[PM-25685][PM-31077] - Migrate all Folder models (#17077) ... * enforce strict types on folders * fix folder api service * fix tests * fix test * fix type issue * fix test * add extra checks for folders. add specs * fix folder.id checks * fix id logic * remove unecessary check * name name and id optional in folder model * fix tests * Update folder and folderview * fix folder with id export * fix tests * fix tests * more defensive typing * fix tests * no need to check for presence * check for empty name in folder toDomain * fixes to folder * initialize id in folder constructor. fix failing tests * remove optional param to folder constructor * fix folder * fix test * remove remaining checks for null folder id * fix logic * pass null for empty folder ids * make id more explicit * fix failing test * fix failing test * fix "No Folder" filter	3 months ago
Mike Amirault	5e31ba9cce	[PM-27220] Switch export filetype select to simple select (#17865)	3 months ago
John Harrington	201d36201f	[PM-30247] Previously archived items are not archived after import (#18546)	3 months ago
Leslie Xiong	44bdaf71b3	Desktop/pm 18769/migrate vault filters (#17919) ... Migrated vault filters to new v3 vault's navigation * Decoupled existing vault filtering from vault component by using routed params with routed-vault-filter-bridge * Converted vault filters to standalone components * Removed extending filter Base Components from deprecated /libs/angular library and handled logic directly * Moved shared 'models' and 'services' directories from web-vault into /libs/vault	4 months ago
Bernd Schoolmann	f167f06b62	[PM-30442] Fix cipherkey getting included in export of unencrypted json (#18206) ... * Fix cipherkey being exported in unencrytped json export * Fix unencrypted json exporting with cipher key * Fix unencrypted export for org vaults --------- Co-authored-by: SmithThe4th <gsmith@bitwarden.com>	4 months ago
Vincent Salucci	86764d807a	[PM-22434] Remove CreateDefaultLocation feature flag references and definition (#18057) ... * chore: remove ff from vault-popup-list-filters.service, refs PM-22434 * chore: remove ff from confirm.command, refs PM-22434 * chore: remove ff from bulk-confirm-dialog.component, refs PM-22434 * chore: remove ff from member-actions.service and clean up leftover imports, refs PM-22434 * chore: remove ff from policy-edit-dialog.component, refs PM-22434 * chore: remove ff from organization-data-ownership.component, refs PM-22434 * chore: remove ff from vnext-organization-data-ownership.component, refs PM-22434 * chore: remove ff from vault-filter.service, refs PM-22434 * chore: remove ff from vault-filter.service (libs), refs PM-22434 * chore: remove ff from export.component, refs PM-22434 * chore: update observeMyItemsExclusionCriteria method documentation comments, refs PM-22434 * chore: remove ff from item-details-section.component, refs PM-22434 * chore: remove ff definition, refs PM-22434 * fix: remove configService from superclasses, refs PM-22434 * chore: update injection for VaultPopupListFilters service instantiation, refs PM-22434 * chore: update ConfirmCommand instantiation, refs PM-22434 * chore: update import order in member-actions.service, refs PM-22434 * fix: constructor argument update to amend merge conflict, refs PM-22434 * chore: remove unnecessary feature flag related tests for confirm user, refs PM-22434 * fix: remove unused services from member-actions.service.spec, refs PM-22434	4 months ago
Daniel James Smith	1c6a83f311	[BEEEP][PM-29441] Introduce bitwarden-encrypted-json-importer (#17651) ... * Introduce bitwarden-encrypted-json-importer An effort to introduce type guards and split the logic between the differently protected bitwarden-json import-formats * Improved stricter types, but not quite ts-strict yet * Add guard to prevent passing password-protected exports to the wrong importer. * Only create one return object instead of multiple * Updated changes afer npm ci and npm run prettier --------- Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	5 months ago
Alex Dragovich	14dd732b52	[PM-23258] changing verbiage from import data to import items (#17123) ... * [PM-23258] changing verbiage from import data to import items * [PM-23258] Removing vault and data from import and export titles, navs, and buttons * [PM-23258] more verbiage changes * [PM-23258] reverting unnecessary change * [PM-23258] removing unused text from messages json files * [PM-23258] small text changes from design * [PM-23258] including secrets manager changes	5 months ago
Bernd Schoolmann	51d29f777e	[PM-24353] Drop legacy pin support (#17328) ... * Drop legacy pin support * Fix cli build * Fix browser build * Remove pin key * Fix comment * Fix CI / tests * Add migration to remove key * Inline export key * Extract vault export key generation * Cleanup * Add migrator * Fix mv2 build	5 months ago
Andreas Coroiu	a66227638e	Update sdk-internal to 374 (fix breaking changes) (#17325) ... * feat: update sdk-internal * fix: symbol.dispose breaking change * fix: TextEncoder/Decoder breaking change * fix: move polyfills to a global setup script * typo	6 months ago
Maciej Zieniuk	ff12e672e6	[PM-23614] Remove activeUserOrgKeys$ from the key service (#17045) ... * Remove activeUserOrgKeys$ from the key service * test leftover * test leftover	6 months ago
John Harrington	8e8092c828	[PM-27648] [Defect] The .zip option is displayed on organizational export in Admin Console (#17140) ... * consider admin console context when determining export types and callout * checkpoint on simplified fix before swapping to signals * Update libs/tools/export/vault-export/vault-export-ui/src/components/export.component.ts Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> * Update libs/tools/export/vault-export/vault-export-ui/src/components/export.component.ts Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> --------- Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>	6 months ago
John Harrington	e333c0a8bc	Preserve export type across export source selections (#16922)	7 months ago
SmithThe4th	3609127858	[PM-25683] Migrate Cipher model and sub-models (#16974) ... * Made domain classes ts-strict compliant and fixed spec files * Fixed domain base class and other test files * Added conditional utils and fixed small nits * removed comments * removd ts expect errors * Added removed counter * renamed test name * fixed tests	7 months ago
Oscar Hinton	f23f3f87bd	Tools - Prefer signal & change detection (#16941)	7 months ago
John Harrington	2858d12011	add export related code changes (#16789) ... • export related changes from PR 16399	7 months ago
John Harrington	64105e64e9	[PM-24105] Remove usage of getUserKey on keyService (#16626) ... • prefer undefined over null • obtain required UserId once per method, before branching • guards moved to beginning of methods * lift UserId retrieval to occur once during import * remove redundant userId retrieval	7 months ago
John Harrington	13f3792f34	PM-26439 minor code improvements related to pm 19467 (#16704) ... * add support for export-scope-callout.component to conditionally render organizational export message * avoid null comparison and remove explicit undefined type parameter	7 months ago
John Harrington	65d56ca2f3	[PM-25481] Update copy in Admin-Console export-page (#16594) ... * add support for export-scope-callout.component to conditionally render organizational export message • use config service to capture feature flag status • use platform service and routing to determine admin console context	8 months ago
John Harrington	75253c7709	[PM-24099] Tools - Remove getOrgKey from the key service (#16351) ... * replace deprecated getOrgKey() method • obtain account using `accountService.activeAccount$` and then use id property to guarentee validity of UserId	8 months ago
Addison Beck	092c95d11f	build: add nx configuration to tools nested libraries (#16564) ... Add Nx project.json configurations and test scripts to all 8 nested libraries: - @bitwarden/send-ui - @bitwarden/generator-core - @bitwarden/generator-components - @bitwarden/vault-export-core - @bitwarden/vault-export-ui - @bitwarden/generator-history - @bitwarden/generator-legacy - @bitwarden/generator-navigation All libraries now have working nx build, nx lint, and nx test commands.	8 months ago
Daniel James Smith	94764467e8	[PM-25918] Move required userId for export request up to component/command level (#14391) ... * Require userId for KdfConfigService * cleanup KdfConfigService unit tests * Move required userId for export request up to component/command level * Fix service creation/dependency injection * Revert changes to kdf-config.service.spec cause by a bad rebase * Fix linting issue * Fix tests caused by bad rebase * Validate provided userId to equal the current active user * Create tests for vault-export.service Deleted old tests which since have been replaced with individual-vault-export.service.spec.ts --------- Co-authored-by: Thomas Avery <tavery@bitwarden.com> Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	8 months ago
Daniel James Smith	b091719748	Introduce a stricter use of the OrganizationId type on org-vault exports (#15836) ... Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	8 months ago
Daniel James Smith	ba817f0389	[PM-25503] Use org export api on encrypted and unencrypted org exports (#16290) ... * Introduce a new vault-export-api.service to replace the existing getOrganizationExport method in apiService * Use new vault-export-api.service instead of the ApiService to retrieve organizational export data * Remove unused method from apiService * Register VaultExportApiService on browser * Fxi linting issue by executing `npm run prettier` * Rename abstraction and implementation of VaultExportApiService * Use undefined instead of null * Rename file of default impl of vault-export-api-service * Fix test broken with 1bcdd80eea * Define type for exportPromises --------- Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	8 months ago
Bryan Cunningham	4449d8baf6	[CL-689][CL-799] Fix Icon button a11y errors (#15750) ... * Throw error if appA11yTitle is null in icon button * Add required label input * Fix icon button errors in CL components and storeis * fix popover aria-label errors * remove commented code * add labels to icon buttons in browser * add labels to icon buttons in web * add labels to icon buttons in license * add labels to icon buttons in send * add labels to icon buttons in angular * fix missing pipe error * fix sso icon button missed in error * update labels in vault * add section expand button label * Adding labels to icon buttons * Add lint rule to not allow icon buttons without label input * rename util file * trigger updates on title change * update eslint rule name and folder * add edit collection label to vault headers * fix web header story label * add show/hide summary labels * update summary message * fix breadcrumbs label message * fix JSDoc to use correct input * remove commented code * use label as aria-label always. Remove init function * add moreBreadcrumbs translation message to other apps * add @bitwarden/team-ui-foundation as code owner for component eslint rules * switch title to const variable * add jsdoc comment on what the label input is used for * [PM-22415] Tax ID notifications for Organizations and Providers (#15996) * [NO LOGIC] Rename BillableEntity to BitwardenSubscriber This helps us maintain paraody with server where we call this choice type ISubscriber. I chose BitwardenSubscriber to avoid overlap with RxJS * [NO LOGIC] Move subscriber-billing.client to clients folder * [NO LOGIC] Move organization warnings under organization folder * Move getWarnings from OrganizationBillingApiService to new OrganizationBillingClient I'd like us to move away from stashing so much in libs and utilizing the JsLibServicesModule when it's not necessary to do so. These are invocations used exclusively by the Web Vault and, until that changes, they should be treated as such * Refactor OrganizationWarningsService There was a case added to the Inactive Subscription warning for a free trial, but free trials do not represent inactive subscriptions so this was semantically incorrect. This creates another method that pulls the free trial warning and shows a dialog asking the user to subscribe if they're on one. * Implement Tax ID Warnings throughout Admin Console and Provider Portal * Fix linting error * Jimmy's feedback * remove duplicate messages keys * revert changes to popover stories * add back dupe myItems key for now as it was already here * fix directive type errors * remove variable left in error from merge conflict * revert unintentional change to reports layout * add back reports change --------- Co-authored-by: Alex Morask <144709477+amorask-bitwarden@users.noreply.github.com>	9 months ago
Brandon Treston	27089fbb57	[PM-24227] Enable TS-strict for Collection Domain models (#15765) ... * wip ts-strict * wip ts-strict * wip * cleanup * cleanup * fix story * fix story * fix story * wip * clean up CollectionAdminView construction * fix deprecated function call * fix cli * clean up * fix story * wip * fix cli * requested changes * clean up, fixing minor bugs, more type saftey * assign props in static ctor, clean up	9 months ago
Bernd Schoolmann	6bd8638ad8	[PM-24126] Move pin service to km ownership (#15821) ... * Move pin service to km ownership * Run format * Eslint * Fix tsconfig * Fix imports and test * Clean up imports * Remove unused dependency on PinService * Fix comments --------- Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	10 months ago
Brandon Treston	d0d1359ff4	[PM-12048] Wire up vNextCollectionService (#14871) ... * remove derived state, add cache in service. Fix ts strict errors * cleanup * promote vNextCollectionService * wip * replace callers in web WIP * refactor tests for web * update callers to use vNextCollectionServcie methods in CLI * WIP make decryptMany public again, fix callers, imports * wip cli * wip desktop * update callers in browser, fix tests * remove in service cache * cleanup * fix test * clean up * address cr feedback * remove duplicate userId * clean up * remove unused import * fix vault-settings-import-nudge.service * fix caching issue * clean up * refactor decryption, cleanup, update callers * clean up * Use in-memory statedefinition * Ac/pm 12048 v next collection service pairing (#15239) * Draft from pairing with Gibson * Add todos * Add comment * wip * refactor upsert --------- Co-authored-by: Brandon <btreston@bitwarden.com> * clean up * fix state definitions * fix linter error * cleanup * add test, fix shareReplay * fix item-more-options component * fix desktop build * refactor state to account for null as an initial value, remove caching * add proper cache, add unit test, update callers * clean up * fix routing when deleting collections * cleanup * use combineLatest * fix ts-strict errors, fix error handling * refactor Collection and CollectionView properties for ts-strict * Revert "refactor Collection and CollectionView properties for ts-strict" This reverts commit a5c63aab76. --------- Co-authored-by: Thomas Rittson <trittson@bitwarden.com> Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>	10 months ago
Bernd Schoolmann	60855c734f	[PM-17666] Move Encstring to KM ownership (#15457) ... * Move Encstring to KM ownership * Fix wrong import * Fix build * Fix remaining imports * Fix tests	10 months ago
Bernd Schoolmann	03a7530f8b	Remove legacy key support form tools code (#15349)	10 months ago
Brandon Treston	1c237a3753	[PM-20633] rename personal ownership (#15228) ... * sensible renames * renames * clean up comments	11 months ago
SmithThe4th	e291e2df0a	[PM-21451] [Vault] [CLI] Changes to Enforce "Remove card item type policy" (#15187) ... * Created new service to get restricted types for the CLI * Created service for cli to get restricted types * Utilized restriction service in commands * Renamed function * Refactored service and made it simpler to check when a cipher type is restricted or not * Moved service to common so it can be utilized on the cli * Refactored service to use restricted type service * Removed userId passing from commands * Exclude restrict types from export * Added missing dependency * Added missing dependency * Added missing dependency * Added service utils commit from desktop PR * refactored to use reusable function * updated reference * updated reference * Fixed merge conflicts * Refactired services to use isCipherRestricted * Refactored restricted item types service * Updated services to use the reafctored item types service	11 months ago
Oscar Hinton	95856bf3cf	[CL-714] Remove standalone true from tools (#15039) ... Remove standalone: true from every instance since it's the default as of Angular 19.	12 months ago
Addison Beck	26caeb3083	Implement and extend tsconfig.base across projects (#14554) ... * Implement and extend tsconfig.base across projects * fixup! Merge remote-tracking branch 'origin/main' into rename-tsconfig * fix: import tsconfig.base from components * fix: skip typechecking node modules * fixing tests * fix the tests for real * undo accidentally change	12 months ago
✨ Audrey ✨	97a591e738	[PM-16793] port credential generator service to providers (#14071) ... * introduce extension service * deprecate legacy forwarder types * eliminate repeat algorithm emissions * extend logging to preference management * align forwarder ids with vendor ids * fix duplicate policy emissions; debugging required logger enhancements ----- Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>	12 months ago
Oscar Hinton	c8629b92d3	[CL-694] Remove unused imports (#14795) ... * Remove unused imports * Remove more unused imports	1 year ago
SmithThe4th	ad3121f535	[PM-12423] Migrate Cipher Decryption to Use SDK (#14206) ... * Created mappings for client domain object to SDK * Add abstract decrypt observable * Added todo for future consideration * Added implementation to cipher service * Added adapter and unit tests * Created cipher encryption abstraction and service * Register cipher encryption service * Added tests for the cipher encryption service * changed signature * Updated feature flag name * added new function to be used for decrypting ciphers * Added new encryptedKey field * added new function to be used for decrypting ciphers * Manually set fields * Added encrypted key in attachment view * Fixed test * Updated references to use decrypt with feature flag * Added dependency * updated package.json * lint fix * fixed tests * Fixed small mapping issues * Fixed test * Added function to decrypt fido2 key value * Added function to decrypt fido2 key value and updated test * updated to use sdk function without prociding the key * updated localdata sdk type change * decrypt attachment content using sdk * Fixed dependency issues * updated package.json * Refactored service to handle getting decrypted buffer using the legacy and sdk implementations * updated services and component to use refactored version * Updated decryptCiphersWithSdk to use decryptManyLegacy for batch decryption, ensuring the SDK is only called once per batch * Fixed merge conflicts * Fixed merge conflicts * Fixed merge conflicts * Fixed lint issues * Moved getDecryptedAttachmentBuffer to cipher service * Moved getDecryptedAttachmentBuffer to cipher service * ensure CipherView properties are null instead of undefined * Fixed test * ensure AttachmentView properties are null instead of undefined * Linked ticket in comment * removed unused orgKey	1 year ago
Patrick-Pimentel-Bitwarden	0b0397c3f0	fix(enums-eslint): Enum Rule for ESLint (#14650) ... * fix(enums-eslint): Enum Rule for ESLint - Added enums in the warnings for eslint. * fix(enums-eslint): Enum Rule for ESLint - Updated to error in both places for enums. * fix(enums-eslint): Enum Rule for ESLint - Added new eslint plugin for warning on enums. * fix(enums-eslint): Enum Rule for ESLint - Changed based on suggestion. Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com> * refactor(browser-platform-utils): Remove Deprecation and Fix Code - Changed usages of firefox to private and moved the usages to the preferred public method and removed the deprecations. * fix(enums-eslint): Enum Rule for ESLint - Updated to error and added disable rules for all other places. * fix(enums-eslint): Enum Rule for ESLint - Undid other changes by accident	1 year ago
Bernd Schoolmann	67b0a19319	[PM-21001] Move tools usage of encrypt service (#14540) ... * Add new encrypt service functions * Undo changes * Cleanup * Fix build * Fix comments * Move tools usage of encrypt service	1 year ago
Thomas Avery	d43e4757df	[PM-7604] Require target UserID for KdfConfigService (#14380) ... * Require userId for KdfConfigService * Update auth team callers * Update tools team callers	1 year ago
Vijay Oommen	a829965262	[PM-20386] valuesChanges returns a string (#14338)	1 year ago
Daniel James Smith	170f97da8e	[PM-20333] Remove "export-attachments" feature flag (#14310) ... * Remove usage of export-attachments feature flag * Remove export-attachments feature flag definition * Update export.command documentation --------- Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	1 year ago
Bernd Schoolmann	5a1b0744f0	[PM-17665] Move cryptofunction service to km (#13285) ... * Move cryptofunction service to km * Fix formatting * Fix import * Fix build on desktop * Fix build on browser and tests	1 year ago
Daniel James Smith	f13bc2766b	Set selected format to json, when the zip format option is removed (#14092) ... Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	1 year ago
Daniel James Smith	7992e0247e	Fix wrong file extension being set when exporting with attachments (#14067) ... Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	1 year ago
Daniel James Smith	0311681803	Fix filename not including "_encrypted_" when selecting encrypted vault exports (#14066) ... Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	1 year ago
Daniel James Smith	49924512b8	[PM-19656] Fix zip option not being set correctly after navigating to Admin Console (#14058) ... * Simplify if to reduce nesting * Start subscribing to changes of the vaultSelector as soon as possible during ngOnInit --------- Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	1 year ago
Daniel James Smith	7ed2145393	Set correct filename extensions on vault-export (#14018) ... Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	1 year ago
Brandon Treston	0fd01ed7ee	[PM-18566] Wire up vNextPolicyService for Clients (#13678) ... * wire up vNext impl * wire up vNextPolicyService for browser * wire up vNextPolicyService for desktop * wire up vNextPolicyService for cli * fix test * fix missed caller * cleanup * fix missing property assignment * fix QA bug for PM-19205 * fix QA bug for PM-19206 * fix QA bug for pm-19228 * cleanup	1 year ago
Bernd Schoolmann	27baa92fcf	[PM-10749] [BEEEP] New export format: Zip with attachments (#10465) ... * Add new export format: zip * Restrict zip export to just individual vaults * Add tests * Remove unused import * Fix build error * Fix tests * Fix test * Fix retrieval of ciphers by passing in activeUserId * Guard feature behind `export-attachments`-feature-flag * Extend cipher filter to also filter out any ciphers that are assigned to an organization * Added apiService to retrieve AttachmentData (metaData) and then download the attachment - Added ApiService as a depdency within DI for VaultExportService/IndividualVaultExportService - Added unit tests for filtering ciphers - Added unit test for downloading attachment metadata and attachments * Moved attachment decryption into a separate method and added unit tests * Added null check for creating the base attachment folder * Move format check for zip within Org export into an early return/throw * Add feature flag guard on the CLI * Extend ExportScopeCallout to display an individual export will contain attachment when zip-format is selected * Fix adding/removing the zip-export option based on selected vault and state of `export-attachments` feature-flag * Separate AAA visually using whitespace within tests * Remove unused error var * Write test that verifies different http request failures when retrieving attachment data * Remove uneeded ignore lint rule * Rewrite test to actually check that ciphers assigned to an org are filtered out * Introduce ExportedVault return type (#13842) * Define ExportedVault type unioned by 2 new types that describe a plain-text export vs a blob-based zip-export * Extend static getFileName to handle formats and add unit-tests * Introduce new export return type throughout the vault export module - Update abstractions - Update return types within implementations - Update callers/consumers to handle the new return value - Fix all unit tests * Add support for new export return type and fix download of blobs via CLI * Add documentation to public methods --------- Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com> --------- Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com> Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	1 year ago