bitwarden-clients

Commit Graph

Author	SHA1	Message	Date
Oscar Hinton	abc6e54bb9	Platform - Prefer signal & change detection (#16946 )	4 months ago
Justin Baur	b1f090e054	Add `lang` attr on desktop and browser (#14691 )	9 months ago
Oscar Hinton	2fbc4c1578	[CL-525] Upgrade angular to v19 (#14815 ) Upgrade Angular to v19 using the update guide. - Add `standalone: false` to any missed component in stories or tests. - Update jest.config to follow the new best practices.	9 months ago
Todd Martin	721657a5c3	Update syntax for Github. (#14845 )	9 months ago
Nick Krantz	1c4d851046	[PM-21005] Clear Add/Edit form cache when browser loses focus (#14634 )	9 months ago
Todd Martin	2bde090b37	chore(view-cache): Rename view-cache docs to README to allow Github rendering * Renamed documentation file * Updated documentation link.	9 months ago
Oscar Hinton	ac49e594c1	Add standalone false to all non migrated (#14797 ) Adds standalone: false to all components since Angular is changing the default to true and we'd rather not have the angular PR change 300+ files.	9 months ago
Todd Martin	eed18c9294	chore(view-cache): [PM-21154] Move view-cache its own feature package and adjust imports * Moved view-cache services to directory * Fixed DI for browser extension. * Fixed tests.	10 months ago
Shane Melton	d6bda3bcdf	[PM-20433] Add view cache options for view cache service signals to allow cached values to persist navigation events (#14348 )	10 months ago
Patrick-Pimentel-Bitwarden	1af8fe2012	feat(device-approval-persistence): [PM-19380] Device Approval Persistence (#13958 ) * feat(device-approval-persistence): [PM-19380] Device Approval Persistence - Added lookup on standard auth requests. * fix(device-approval-persistence): [PM-19380] Device Approval Persistence - Fixed issue with null value trying to be parsed from the fromJSON function. --------- Co-authored-by: Todd Martin <tmartin@bitwarden.com>	11 months ago
Oscar Hinton	a569dd9ad6	[PM-15892] [PM-12250]Remove nord and remnants from solarizedark (#13449 ) * Remove nord and remnants from solarizedark * Update window reload color * Remove extension-refresh feature flag from clients (#13450) Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com> * Remove usage of nord and solarized themes within DarkImageDirective --------- Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com> Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	12 months ago
Oscar Hinton	e5f83ff086	[PM-17031] Create UI-common (#12831 ) Extract core functionality from `libs/angular` to allow teams to depend on `libs/ui-common` instead. Moves the following functionality to `ui-common`. - `I18nPipe`. `libs/angular` still has an old copy but `components` depends on the new variant from `ui-common`. - `safeProvider`, `SafeProvider` and `SafeInjectionToken`. `libs/angular`re-exports these to avoid needing to update all consumers.	1 year ago
Matt Gibson	9c1e2ebd67	Typescript-strict-plugin (#12235 ) * Use typescript-strict-plugin to iteratively turn on strict * Add strict testing to pipeline Can be executed locally through either `npm run test:types` for full type checking including spec files, or `npx tsc-strict` for only tsconfig.json included files. * turn on strict for scripts directory * Use plugin for all tsconfigs in monorepo vscode is capable of executing tsc with plugins, but uses the most relevant tsconfig to do so. If the plugin is not a part of that config, it is skipped and developers get no feedback of strict compile time issues. These updates remedy that at the cost of slightly more complex removal of the plugin when the time comes. * remove plugin from configs that extend one that already has it * Update workspace settings to honor strict plugin * Apply strict-plugin to native message test runner * Update vscode workspace to use root tsc version * `./node_modules/.bin/update-strict-comments` 🤖 This is a one-time operation. All future files should adhere to strict type checking. * Add fixme to `ts-strict-ignore` comments * `update-strict-comments` 🤖 repeated for new merge files	1 year ago
Alec Rippberger	234a832fc4	/register does not redirect to /signup when email-verification flag is enabled (#12001 ) * Manually route to signup page when the email verification feature flag is enabled * Revert "Manually route to signup page when the email verification feature flag is enabled" This reverts commit `f3a2b412b9`. * Do not show toast when redirecting to signup	1 year ago
Jonathan Prusik	eba1212e1c	[PM-14351] Migrate away from theme enum (#11812 ) * update extension autofill concerns to use theme object and type over enum * mark ThemeType enum as deprecated * update theming service concerns to use theme object and type over enum	1 year ago
Bernd Schoolmann	b486fcc689	[Pm-13097] Rename cryptoservice to keyservice and move it to km ownership (#11358 ) * Rename cryptoservice to keyservice * Rename cryptoservice to keyservice * Move key service to key management ownership * Remove accidentally added file * Fix cli build * Fix browser build * Run prettier * Fix builds * Fix cli build * Fix tests * Fix incorrect renames * Rename webauthn-login-crypto-service * Fix build errors due to merge conflicts * Fix linting	1 year ago
Will Martin	6918606677	[PM-3530] browser extension view cache (#10437 ) Introduces a way to store temporary component state, for the purposes of persisting views between extension popup open and close.	2 years ago
Jordan Aasen	898338ff9d	migrate platform toasts to CL toastService (#10666 )	2 years ago
Daniel García	3c7663a965	[PM-7809] Fix memory leak in AngularThemingService for Safari extension (#9434 ) * [PM-7809] Fix memory leak in AngularThemingService for Safari * Use getSystemThemeFromWindow in createSystemThemeFromWindow	2 years ago
Thomas Rittson	794da48437	[AC-2806] Add support for conditional routing based on feature flag value (#9798 ) Co-authored-by: Shane Melton <smelton@bitwarden.com>	2 years ago
Matt Gibson	b4631b0dd1	Ps/improve-log-service (#8989 ) * Match console method signatures in logService abstraction * Add a few usages of improved signature * Remove reality check test * Improve electron logging	2 years ago
Oscar Hinton	14b2eb99a2	[PM-2282] Make feature flags type safe (#8612 ) Refactors the feature flags in ConfigService to be type safe. It also moves the default value to a centralized location rather than the caller defining it. This ensures consistency across the various places they are used.	2 years ago
Justin Baur	395ed3f5d4	[PM-7489] Introduce `MessageSender` & `MessageListener` (#8709 ) * Introduce MessageSender * Update `messageSenderFactory` * Remove Comment * Use BrowserApi * Update Comment * Rename to CommandDefinition * Add More Documentation to MessageSender * Add `EMPTY` helpers and remove NoopMessageSender * Calm Down Logging * Limit Logging On Known Errors * Use `messageStream` Parameter Co-authored-by: Matt Gibson <mgibson@bitwarden.com> * Add eslint rules * Update Error Handling Co-authored-by: Cesar Gonzalez <cesar.a.gonzalezcs@gmail.com> * Delete Lazy Classes In Favor of Observable Factories * Remove Fido Messages --------- Co-authored-by: Matt Gibson <mgibson@bitwarden.com> Co-authored-by: Cesar Gonzalez <cesar.a.gonzalezcs@gmail.com>	2 years ago
Thomas Rittson	26226c4090	[AC-2356] Use safeProvider in web core services module (#8521 ) * Also add tests * Exclude type (compile-time) tests from jest config	2 years ago
Will Martin	a201e9cff1	[PM-7229] Fix circular dependency in ErrorHandler (#8573 ) * call injector explicitly in ErrorHandler * Fallback to `super` on early error Co-authored-by: Matt Gibson <mgibson@bitwarden.com> --------- Co-authored-by: Matt Gibson <mgibson@bitwarden.com>,	2 years ago
Justin Baur	45f9f5695e	Add Custom `ErrorHandler` (#8543 )	2 years ago
Oscar Hinton	2edc156dd6	[STRICT TS] Migrate platform abstract services functions (#8527 ) We currently use a callback syntax for abstract services. This syntax isn't completely strict compliant and will fail the strictPropertyInitialization check. We also currently don't get any compile time errors if we forget to implement a function. To that end this PR updates all platform owned services to use the appropriate abstract keyword for non implemented functions. I also updated the fields to be actual functions and not properties.	2 years ago
Thomas Rittson	d10c14791d	[AC-2329] [BEEEP] Use safeProvider in desktop services module (#8457 )	2 years ago
Thomas Rittson	b3b344866e	[AC-2278] [AC-2296] Use SafeProvider in browser services module (#8418 )	2 years ago
Matt Gibson	62ad39e697	Ps/pm 5965/better config polling (#8325 ) * Create tracker that can await until expected observables are received. * Test dates are almost equal * Remove unused class method * Allow for updating active account in accout service fake * Correct observable tracker behavior Clarify documentation * Transition config service to state provider Updates the config fetching behavior to be lazy and ensure that any emitted value has been updated if older than a configurable value (statically compiled). If desired, config fetching can be ensured fresh through an async. * Update calls to config service in DI and bootstrapping * Migrate account server configs * Fix global config fetching * Test migration rollback * Adhere to implementation naming convention * Adhere to abstract class naming convention * Complete config abstraction rename * Remove unnecessary cli config service * Fix builds * Validate observable does not complete * Use token service to determine authed or unauthed config pull * Remove superfluous factory config * Name describe blocks after the thing they test * Remove implementation documentation Unfortunately the experience when linking to external documentation is quite poor. Instead of following the link and retrieving docs, you get a link that can be clicked to take you out of context to the docs. No link _does_ retrieve docs, but lacks indication in the implementation that documentation exists at all. On the balance, removing the link is the better experience. * Fix storybook	2 years ago
Justin Baur	e6fe0d1d13	[PM-5539] Migrate ThemingService (#8219 ) * Update ThemingService * Finish ThemingService * Lint * More Tests & Docs * Refactor to ThemeStateService * Rename File * Fix Import * Remove `type` added to imports * Update InitServices * Fix Test * Remove Unreferenced Code * Remove Unneeded Null Check * Add Ticket Link * Add Back THEMING_DISK * Fix Desktop * Create SYSTEM_THEME_OBSERVABLE * Fix Browser Injection * Update Desktop Manual Access * Fix Default Theme * Update Test	2 years ago
Thomas Rittson	29b5643310	[AC-2278] [BEEEP] Typesafe Angular DI (#8206 ) Use SafeProvider as a factory for all our providers to ensure that the DI token, implementation, and deps all match. --------- Co-authored-by: Matt Gibson <mgibson@bitwarden.com>	2 years ago
Will Martin	cb8849c355	Add eslint rule no-floating-promises (#7789 ) * add eslint rule no-floating-promises * add eslint-disable comment to offending lines	2 years ago
renovate[bot]	28de9439be	[deps] Autofill: Update prettier to v3 (#7014 ) * [deps] Autofill: Update prettier to v3 * prettier formatting updates --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jonathan Prusik <jprusik@classynemesis.com>	2 years ago
Oscar Hinton	a5e3432f85	Assign ownership to many libs files (#6928 ) Assign ownership to many of the remaining libs/common files. Criteria for ownership: * Files used by a single team, is now owned by that team. * Files related to a domain owned by a team is now owned by that team. * Where ownership is unclear the "lowest level" service takes ownership.	2 years ago
Matt Gibson	36b7d30804	Fix failing crypto tests (#5948 ) * Change everything to Uint8Array related to https://github.com/jestjs/jest/issues/14379 * Work on failing type tests * Revert changes to custom matcher setup * Remove last BufferArrays from tests * Fix custom matcher type errors in vscode * Remove errant `.buffer` calls on Uint8Arrays * Encryption Pair should serialize Array Buffer and Uint8Array * Fix EncArrayBuffer encryption --------- Co-authored-by: Thomas Rittson <trittson@bitwarden.com>	3 years ago
Shane Melton	0afbd90a2d	[AC-1192] Create new device approvals component for TDE (#5548 ) * Add feature flag route guard and tests * Add additional test for not showing error toast * Strengthen error toast test with message check * Cleanup leaking test state in platformService mock * Negate if statement to reduce nesting * Update return type to CanActivateFn * Use null check instead of undefined * Introduce interface to support different feature flag types - Switch to observable pattern to access serverConfig$ subject - Add catchError handler to allow navigation in case of unexpected exception - Add additional tests * Add additional test for missing feature flag * Remove subscription to the serverConfig observable Introduce type checking logic to determine the appropriately typed flag getter to use in configService * [AC-1192] Create initial device approvals component and route * [AC-1192] Introduce appIfFeature directive for conditionally rendering content based on feature flags * [AC-1192] Add DeviceApprovals link in Settings navigation * Remove align middle from bitCell directive The bitRow directive supports alignment for the entire row and should be used instead * [AC-1192] Add initial device approvals page template * [AC-1192] Introduce fingerprint pipe * [AC-1192] Create core organization module in bitwarden_license directory * [AC-1192] Add support for new Devices icon to no items component - Add new Devices svg - Make icon property of bit-no-items an Input property * [AC-1192] Introduce organization-auth-request.service.ts with related views/responses * [AC-1192] Display pending requests on device approvals page - Add support for loading spinner and no items component * [AC-1192] Add method to bulk deny auth requests * [AC-1192] Add functionality to deny requests from device approvals page * [AC-1192] Add organizationUserId to pending-auth-request.view.ts * [AC-1192] Add approvePendingRequest method to organization-auth-request.service.ts * [AC-1192] Add logic to approve a device approval request * [AC-1192] Change bitMenuItem directive into a component and implement ButtonLikeAbstraction Update the bitMenuItem to be a component and implement the ButtonLikeAbstraction to support the bitAction directive. * [AC-1192] Update menu items to use bitActions * [AC-1192] Update device approvals description copy * [AC-1192] Revert changes to bitMenuItem directive * [AC-1192] Rework menus to use click handlers - Wrap async actions to catch/log any exceptions, set an in-progress state, and refresh after completion - Show a loading spinner in the header when an action is in progress - Disable all menu items when an action is in progress * [AC-1192] Move Devices icon into admin-console web directory * [AC-1192] bit-no-items formatting * [AC-1192] Update appIfFeature directive to hide content on error * [AC-1192] Remove deprecated providedIn for OrganizationAuthRequestService * [AC-1192] Rename key to encryptedUserKey to be more descriptive * [AC-1192] Cleanup loading/spinner logic on data refresh * [AC-1192] Set middle as the default bitRow.alignContent * [AC-1192] Change default alignRowContent for table story * [AC-1192] Rename userId to fingerprintMaterial to be more general The fingerprint material is not always the userId so this name is more general * [AC-1192] Remove redundant alignContent attribute * [AC-1192] Move fingerprint pipe to platform	3 years ago
Thomas Rittson	22caae116c	Restrict angular imports (#5597 ) * Refactor restricted imports eslint rule, add angular deps * Move FormValidationErrorsService into libs/angular * Remove angular decorators from configService * Remove angular decorator from anonymousHubService	3 years ago
Rui Tomé	0ab982038c	[AC-1088] Truncating collection names on Groups table (#5236 ) * [AC-1088] Set no-wrap to 'select all' column on groups table * [AC-1088] Using EllipsisPipe on GroupsComponent to truncate group names * [AC-1088] Reverted using no-wrap on column header * [AC-1088] Removed truncateCollectionNames * [AC-1088] Added 'truncate' option to badge and badge-list components * [AC-1088] Truncating collection names on groups component * [AC-1088] Marked EllipsisPipe as deprecated * [AC-1088] Removed EllipsisPipe from GroupsComponent * [AC-1088] Added badge truncate to storybook stories * [AC-1088] Setting badge css requirements for truncate * [AC-1088] Added storybook stories for truncated badges * [AC-1088] Set badges truncate default value to true * [AC-1088] Set badges to use class tw-inline-block and tw-align-text-top * [AC-1088] Set title on each badge list item if truncated * [AC-1088] Set title on badge if truncated * [AC-1088] Removed duplicate truncate on badge-list component * [AC-1088] Swapped setting badge title from ngAfterContentInit to HostBinding * [AC-1088] Configured badge stories to have the truncate option * [AC-1088] Fixed badges tooltip to not include commas added for screen readers on badge lists * [AC-1088] Added lengthy text to single badge on storybook * [AC-1088] In badge-list moved the commas out from the badges * [AC-1088] Removed irrelevant comment and moved the text align class next to other font classes	3 years ago
Matt Gibson	78248db590	Platform/pm 19/platform team file moves (#5460 ) * Rename service-factory folder * Move cryptographic service factories * Move crypto models * Move crypto services * Move domain base class * Platform code owners * Move desktop log services * Move log files * Establish component library ownership * Move background listeners * Move background background * Move localization to Platform * Move browser alarms to Platform * Move browser state to Platform * Move CLI state to Platform * Move Desktop native concerns to Platform * Move flag and misc to Platform * Lint fixes * Move electron state to platform * Move web state to Platform * Move lib state to Platform * Fix broken tests * Rename interface to idiomatic TS * `npm run prettier` 🤖 * Resolve review feedback * Set platform as owners of web core and shared * Expand moved services * Fix test types --------- Co-authored-by: Hinton <hinton@users.noreply.github.com>	3 years ago

40 Commits (anders/electron-builder)