3049 Commits (anders/electron-builder)

Author	SHA1	Message	Date
Brandon Treston	c8ba23e28d	[PM-26378] Auto confirm events (#19025) ... * add notification handler for auto confirm * add missing state check * fix test * isolate angular specific code from shared lib code * clean up * use autoconfirm method * add event logging for auto confirm * update copy	3 months ago
John Harrington	f8b5e15a44	[PM-31731] [Defect] No error is returned when entering an invalid email + an invalid verification code (#18913) ... * share i18n key for both invalid email and invalid otp submission * claude review	3 months ago
John Harrington	263ec94124	[PM-32161] Remove all emails when email list field is cleared and send is saved (#18959) ... * add new validation criteria to prevent authType.Email with an empty emails field * simplify validation logic	3 months ago
Stephon Brown	ab59590019	[PM-29823] Add Tests for Updates (#19040) ... * refactor: Remove direct self-hosted org creation from OrganizationPlansComponent * tests: Add comprehensive test suite for OrganizationPlansComponent	3 months ago
Todd Martin	c086df14e7	chore(ownership): Move account-fingerprint to KM ownership	3 months ago
John Harrington	bc6b1c3b83	[PM-32242] Error message is incorrectly formatted for password protected Send (#18991) ... * re-work error display to match design specs * fix password auth in attemptV1Access * fix locales file (formatting)	3 months ago
Alex	1ef8f257b0	[PM-31803] Fix Password Manager reports not displaying items with limited collection access (#18956) ... When "Owners and admins can manage all collections and items" is OFF, Password Manager reports incorrectly filter out items from collections where the user has "Can view", "Can view except passwords", or "Can edit except passwords" access. The root cause is that all five PM report components filter ciphers using `(!this.organization && !edit) || !viewPassword`. Since PM reports run without an organization context (this.organization is undefined), this condition excludes any item where edit=false or viewPassword=false. These permission checks are unnecessary for PM reports because: 1. Personal vault items always have edit=true and viewPassword=true, so the checks never applied to them. 2. Organization items should appear in reports regardless of permission level — the user has collection access, and edit restrictions should only affect the item dialog, not report visibility. 3. Admin Console reports (which work correctly) skip this filtering because this.organization is always set, making the condition always false. This also explains why "Can edit except passwords" items only appeared in the Unsecured Websites report — it was the only report that didn't check !viewPassword. Removed the edit/viewPassword filter conditions from all five PM report components: - exposed-passwords-report - weak-passwords-report - reused-passwords-report - inactive-two-factor-report - unsecured-websites-report	3 months ago
Alex	03340aee71	[PM-31163] stabilize table column widths with fixed layout (#18708) ... * stabilize table column widths with fixed layout (PM-31163) Add layout="fixed" and explicit width classes to report tables to prevent column widths from shifting during virtual scroll. Files changed: - weak-passwords-report.component.html - reused-passwords-report.component.html - exposed-passwords-report.component.html - inactive-two-factor-report.component.html - unsecured-websites-report.component.html * use auto width for name column to fix width calculation (PM-31163) Remove tw-w-1/2 from name column headers. With layout="fixed", the explicit percentages didn't sum to 100%, causing inconsistent column widths. Before: | 48px | 50% | 25% | 25% | = 48px + 100% (overflow) After: | 48px | auto | 25% | 25% | = columns sum correctly Name column now uses auto to fill remaining space. * render headers in Admin Console to fix column widths (PM-31163) Admin Console reports had a very wide icon column because no headers were rendered. Without headers, table-layout: fixed uses data row content to determine column widths, causing inconsistent sizing. Root cause: Three reports had their entire <ng-container header> block inside @if (!isAdminConsoleActive), so when isAdminConsoleActive=true (Admin Console), no headers were rendered at all. Before (broken): @if (!isAdminConsoleActive) { <ng-container header> <!-- Entire header skipped in Admin Console --> <th>Icon</th> <th>Name</th> <th>Owner</th> </ng-container> } After (fixed): <ng-container header> <!-- Always render headers --> <th>Icon</th> <th>Name</th> @if (!isAdminConsoleActive) { <th>Owner</th> <!-- Only Owner is conditional --> } </ng-container> This matches the pattern already used by weak-passwords-report and exposed-passwords-report, which were working correctly. Files changed: - unsecured-websites-report.component.html - reused-passwords-report.component.html - inactive-two-factor-report.component.html Result: - Admin Console now renders headers with correct column widths - Icon column is 48px (tw-w-12) as expected - Owner column properly hidden in Admin Console view * truncate long item names to prevent column overflow - you can hover cursor for tooltip to see full name	3 months ago
Alex	ec33ea4f3c	[PM-27782] Update Access Intelligence loading state text (#18808) ... * [PM-27782] Update Access Intelligence loading state text Simplify the loading progress messages shown during Access Intelligence report generation to be more user-friendly and concise. Changes: - Add new i18n keys with simplified text - Update ProgressStepConfig to use new keys Progress message updates: - "Fetching member data..." → "Reviewing member data..." - "Analyzing password health..." → "Analyzing passwords..." - "Calculating risk scores..." → "Calculating risks..." - "Generating report data..." → "Generating reports..." - "Saving report..." → "Compiling insights..." - "Compiling insights..." → "Done!" * delete old messages * remove all "this might take a few minutes"	3 months ago
John Harrington	9f18a68707	remove unwanted text and place wanted in bit-hint (#18989)	3 months ago
Brandon Treston	8a670f1731	fix circular dependency (#19023)	3 months ago
Mike Amirault	c0e9678c06	[PM-31770] Fix Send expires text formatting (#18926) ... * [PM-31770] Fix Send expires text formatting * Address PR review comments	3 months ago
John Harrington	c415beb653	add password specific header (#18988)	3 months ago
bw-ghapp[bot]	22a6fb1e6d	Autosync the updated translations (#19009) ... Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>	3 months ago
John Harrington	f5b1be7e62	add dynamic EV headers (#18949)	3 months ago
Jordan Aasen	323f30c8e9	[PM-29892] - fix bulk share in vault (#18601) ... * fix bulk share in vault * clean up types. * remove unnecessary optional chain * add back defensive programming. update restore * fix searchableCollectionNodes * add back optional chains	3 months ago
Jason Ng	10a20a43a3	[PM-31738] update archive toasts (#18923) ... * update archive toast for all clients and trash archive restore toast, update archive cipher utilities spec	3 months ago
cyprain-okeke	f46511b3e8	[PM-30908]Correct Premium subscription status handling (#18475) ... * Implement the required changes * Fix the family plan creation for expired sub * Resolve the pr comments * resolve the resubscribe issue * Removed redirectOnCompletion: true from the resubscribe * Display the Change payment method dialog on the subscription page * adjust the page reload time * revert payment method open in subscription page * Enable cancel premium see the subscription page * Revert the removal of hasPremiumPersonally * remove extra space * Add can view subscription * Use the canViewSubscription * Resolve the tab default to premium * use the subscription Instead of hasPremium * Revert the changes on user-subscription * Use the flag to redirect to subscription page * revert the canViewSubscription change * resolve the route issue with premium * Change the path to * Revert the previous iteration changes * Fix the build error	3 months ago
Jared	b567fea7e7	[PM-29506] Rid of old feature flag for members feature flag (#18884) ... * [PM-31750] Refactor members routing and user confirmation logic * Simplified user confirmation process by removing feature flag checks. * Updated routing to directly use the new members component without feature flagging. * Removed deprecated members component references from routing modules. * Cleaned up feature flag enum by removing unused entries. * trigger claude * [PM-31750] Refactor members component and remove deprecated files * Renamed vNextMembersComponent to MembersComponent for consistency. * Removed deprecated_members.component.ts and associated HTML files. * Updated routing and references to use the new MembersComponent. * Cleaned up related tests to reflect the component name change. * Refactor import statements in security-tasks.service.ts for improved readability * Update apps/web/src/app/admin-console/organizations/manage/user-confirm.component.ts Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * Remove BaseMembersComponent and related imports from the admin console, streamlining member management functionality. * Remove unused ConfigService import from UserConfirmComponent to clean up code. * Implement feature flag logic for user restoration in MemberDialogComponent, allowing conditional restoration based on DefaultUserCollectionRestore flag. --------- Co-authored-by: Thomas Rittson <trittson@bitwarden.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>	3 months ago
Brandon Treston	011f250684	[PM-32075] Fix self host bug due to type mismatch (#18919) ... * fix self host bug with data model * fix type issues * fix types, make successful required	3 months ago
Daniel James Smith	69264c8841	[PM-32212] Migrate platform font icons to bit-icon (#18970) ... * Changes on browser * Changes on desktop * Changes on web * Fix chromatic story --------- Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	3 months ago
bw-ghapp[bot]	412d1b541d	Autosync the updated translations (#18963) ... Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>	3 months ago
Brad	8d3cbd3da6	[PM-31801] Fix: Allow admins/owners to edit all ciphers in reports when Org setting is enabled#18856 ... This PR fixes an issue where admins couldn't edit ciphers in organization reports when the "Allow Admin Access to All Collection Items" setting was enabled. The fix adds a check for organization.allowAdminAccessToAllCollectionItems in the canManage() method across all organization report components. When this setting is enabled, admins/owners can now properly edit all ciphers regardless of collection membership.	3 months ago
Brad	1be55763a3	[PM-31689] Fix Org 2FA report: cipher names should always show #18927 ... Fix issue where ciphers appearing in the Org 2FA report would render without the cipher name shown. This was happening for all ciphers in Collections the active User did not have access to.	3 months ago
Jared	2e83244158	Update showDescription property in BasePolicyEditDefinition to false (#18915)	3 months ago
Alex	7342bf672f	[PM-31161] reports scroll bug (#18769) ... * Fix virtual scroll gap in exposed-passwords-report by setting rowSize to 54px * Fix virtual scroll gap in weak-passwords-report by setting rowSize to 54px	3 months ago
Thomas Avery	4d93348a2e	[PM-30812] Update userKey rotation to use saltForUser (#18697)	3 months ago
Jason Ng	30d3a36c7e	[PM-31938] refactor archive btn logic in web view modal (#18874) ... * refactor showArchiveBtn logic in web view modal	3 months ago
Brad	a9ccb421c4	[PM-30542] Conditionally render old Access Intelligence tabs, sub heading copy update (#18847) ... First step of removing code for old Access Intelligence tabs. The old tabs should not appear when the milestone 11 feature flag is on. Once flipped in Production, the remainder of this ticket can be completed (old code entirely removed) Also included in this change is a copy update for the sub heading of the page.	3 months ago
Nick Krantz	f20686cdf4	[PM-24978] Corrupt Attachment Keys (#17790) ... * display translated content for attachments that cannot be downloaded * consume decryption failure from the sdk for attachments * add decryption errors from sdk * only show fix attachment issues for when key is null and it does not have a decryption failure * separate decryption failure state in view	3 months ago
Jared	3f3fc6f984	[PM-31937] Close drawer on navigation (#18852) ... * Implement OnDestroy lifecycle hook in PoliciesComponent to close dialog on component destruction. Update dialog reference handling for improved resource management. * Add documentation to dialogs.mdx so others can know how to prevent drawers staying open * Fix for PR action test * Update PoliciesComponent to use optional chaining for myDialogRef	3 months ago
Jason Ng	04b17816d7	[PM-31670] replace bulk archive toast message (#18877)	3 months ago
Brad	0f5163453e	[PM-30540] Access Intelligence action button updates (mark critical, assign tasks) (#18730) ... Updates the buttons available in the Access Intelligence "Applications" tab. - The "Mark as critical" button appears when at least 1 row is selected in the table, and if all selected applications are already marked critical, changes to a "Mark as not critical" button. This functionality allows Admins to either bulk mark critical applications, or bulk unmark critical applications. - "Assign tasks" has been moved into this tab view, and now is only enabled when there are critical ciphers found without assigned password change tasks. A tooltip appears when hovering on the disabled state, informing the Admin that all tasks have already been assigned.	3 months ago
Brandon Treston	1aef83b6e3	[PM-28262] Bulk re-invite UI improvements (#18754) ... * implement dilogs and logic * clean up, add tests * add feature flag key * product requested changes * more product changes * edit error message	3 months ago
Jared	3b535802db	[PM-26020] Implement dynamic cipher creation permissions in vault header and new… (#18579) ... * Implement dynamic cipher creation permissions in vault header and new cipher menu components * Enhance new cipher menu button behavior and accessibility. Implement dynamic button label based on creation permissions, allowing direct collection creation when applicable. Update button trigger logic to improve user experience. * Update apps/web/src/app/vault/individual-vault/vault-header/vault-header.component.ts Co-authored-by: SmithThe4th <gsmith@bitwarden.com> * Add canCreateCipher getter for improved readability --------- Co-authored-by: SmithThe4th <gsmith@bitwarden.com>	3 months ago
Jackson Engstrom	6f1a618714	[PM-31732] Fix issue with user flow from vault-item-dialog	3 months ago
Jason Ng	322ff6b70b	[PM-31675] remove archive from web edit (#18764) ... * refactor default cipher archive service, update archive/unarchive in vault-item-dialog, remove archive/unarchive items in edit form	3 months ago
Stephon Brown	37eeffd03a	[PM-29602] Build Upgrade Dialogs (#18539) ... * BREAKING CHANGE: rename tax-client and add proration endpoint update * fix(billing)!: rename tax-client in components * feat(billing): Add upgrade endpoint * fix(billing): update preview client error * fix(billing): add billing address to clients * feat(billing): Update messages for changes * feat(biilling): Update unified upgrade dialog logic * feat(billing): add new premium org card * feat(billing): add premium org component * fix(billing): Update account billing client and remove redundant status * fix(billing): unified upgrade dialog add feature flag and tests * fix(billing): update unified upgrade logic * fix(billing): update tests and logic update update fix * fix(billing): add required messages message * fix(billing): update unified dialog logic and re-add comments * feat(billing): improves premium org upgrade dialog Adds a close button to the premium organization upgrade dialog. Updates the success toast message after upgrading to teams. Hides the formatted amount for credit discounts. Sets the change detection strategy to OnPush for improved performance. * fix(billing): prevents multiple upgrade dialogs from opening Adds a check to prevent multiple upgrade dialogs from opening simultaneously. Ensures correct redirection to the organization vault after upgrading to Teams or Enterprise. * Feat(tooltip): Add `showTooltipOnFocus` input to TooltipDirective * Fix(billing): Disable tooltip on focus for various billing buttons * Refactor(billing): Standardize subscription cadence display * Refactor(billing): Update InvoicePreview with prorated amount details * Refactor(billing): Enhance Premium Org Upgrade Payment logic * Feat(billing): Add SubscriptionCadence import to account billing client * refactor(i18n): Rename 'premiumMembershipDiscount' to 'premiumSubscriptionCredit' * fix(billing): Ensure encrypted org key is present during upgrade * refactor(billing): revert PremiumUpgradeDialog focus management * refactor(billing): Clean up subscription details and type definitions * feat(billing): Add dedicated Premium to Organization upgrade dialog * refactor(billing): Return organization ID from PremiumOrgUpgradeService * refactor(billing): Remove premium to org upgrade logic from UnifiedUpgradeDialog * feat(billing): Integrate PremiumOrgUpgradeDialog into account subscription * Refactor: Make `openUpgradeDialog` return `void` * Remove obsolete `planSelectionStepTitleOverride` tests * Feature: Add 'Back' status to UpgradePaymentStatus * Test: Mock `OrganizationService` in `PremiumOrgUpgradePaymentComponent` tests * Chore: Remove redundant comment in unified upgrade dialog HTML * refactor(billing): Remove obsolete unified upgrade change * refactor(billing): remove unused ApiService and DestroyRef * feat(billing): add pre-condition checks for premium org upgrade dialog * refactor(billing): clean up unused dialog data and HTML comment * refactor(billing): rename premium org upgrade dialog flag * feat(billing): close premium org upgrade dialog if feature is disabled * feat(payment): add hideHeader input to DisplayPaymentMethodComponent * refactor(billing): update premium org upgrade payment to display existing payment method * test(billing): update premium org upgrade payment component tests * docs(billing): refine JSDoc for PremiumOrgUpgradeDialogParams * Revert "Feat(tooltip): Add `showTooltipOnFocus` input to TooltipDirective" This reverts commit 02f62bc0fd. * Revert "Fix(billing): Disable tooltip on focus for various billing buttons" This reverts commit 91f7747df7. * fix(billing): Ensure early exit for closed premium org upgrade payment * refactor: rename PremiumOrgUpgradeComponent to PremiumOrgUpgradePlanSelectionComponent * feat(i18n): add payment method update error translation key * feat(billing): introduce DisplayPaymentMethodInlineComponent * feat(billing): integrate inline payment method in PremiumOrgUpgradePayment * feat(pricing): allow hiding pricing term in cart summary * refactor(billing): optimize invoice preview and update cart configuration * refactor(billing): migrate AccountSubscriptionComponent state to signals * chore(html): improve form field layout and accessibility * feat(pricing): add `hidePricingTerm` input and basic header logic * feat(pricing): apply `hidePricingTerm` to cart item breakdowns * docs(pricing): update cart summary documentation for `hideBreakdown` and `hidePricingTerm` * test(pricing): add tests for `hidePricingTerm` and refine term display selector * refactor(pricing): update cart summary test selectors for robustness * docs: reformat `hideBreakdown` description in `CartSummaryComponent` MDX * refactor: remoe additonal DisplayPaymentMethodInlineComponent in imports * Revert "feat(i18n): add payment method update error translation key" This reverts commit b4aeb74e1a. * feat(i18n): Add payment method update error message * refactor(pricing): move CartSummaryComponent hidePricingTerm to input * docs(pricing): update CartSummaryComponent `hidePricingTerm` usage in MDX * test(pricing): update CartSummaryComponent `hidePricingTerm` tests and stories * chore(pricing): add spacing in CartSummaryComponent spec assertion * refactor(billing): Use ngOnInit for dialog initialization logic * refactor(billing): Migrate hidePricingTerm from Cart type to direct input * Refactor: Update payment method action buttons to use `bitLink` * feat(billing): add hidePricingTerm input to MockCartSummaryComponent	3 months ago
Jared	f22736bb64	[PM-25627] convert policy dialogs to drawer (#18534) ... * Enhance policy edit dialogs by updating dialog size to large for improved layout and switching to openDrawer method for better user experience. * Enhance policy edit dialogs by adding policy status badges to indicate if a policy is enabled, improving user visibility and experience. * Update dialog component styles to enhance drawer behavior by changing height to full screen and adding sticky footer for improved layout and user experience. * Refactor policy display layout by wrapping buttons and badges in a flex container for improved alignment and spacing. * Refactor password policy forms in admin console for improved layout - Simplified the structure of form fields in `master-password.component.html` and `password-generator.component.html` by removing unnecessary div wrappers. - Updated the label for the password type policy override in `messages.json` for clarity. * Update dialog size in policy edit component for consistency - Changed the dialog size from 'large' to 'default' in `policy-edit-dialog.component.html` to align with design standards. * refactor(dialog): update dialog component styles for drawer layout - Adjusted height class for drawer dialogs from 'tw-h-screen' to 'tw-h-full' for better layout management. - Removed sticky positioning for footer in drawer mode to improve visual consistency. * refactor(dialog): enhance form layout for policy edit dialogs - Added classes for full height and flex column layout to the form elements in policy edit dialogs for improved visual consistency and usability.	3 months ago
Nick Krantz	3855332279	[PM-31431] Refactor vault prompts (#18740) ... * move existing prompting into separate service for the web vault * add unit tests for web vault prompt service * add provider * remove `autoConfirmDialogRef` * rename auto confirm dialog	3 months ago
Jared	da219b911e	[PM-26195] Refactor selection logic in VaultItemsComponent to ensure bulk select visual bug fix (#18674) ... * Refactor selection logic in VaultItemsComponent to ensure bulk selection matches visual order. Added getSortedEditableItems method for sorting based on current table configuration, enhancing user experience during selection. * Refactor sorting logic in VaultItemsComponent to clarify collection prioritization. Updated comments to indicate that collection comparison is direction-independent, enhancing code readability and maintainability.	3 months ago
bitwarden-devops-bot	f6af7f3e23	Bumped client version(s)	3 months ago
bw-ghapp[bot]	203766879c	Autosync the updated translations (#18806) ... Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>	3 months ago
Vijay Oommen	cb2e5a04d0	[PM-29621] Changed error message to indicate lack of permissions (#18528)	3 months ago
Brad	b6ff3a110e	[PM-18855] Add edit Cipher permission check to Cipher Authorization Service and use in Vault dialog (#18375) ... Centralize edit permission checks in CipherAuthorizationService instead of using the disableForm parameter passed to VaultItemDialogComponent. This refactoring improves consistency with how delete and restore permissions are handled, establishes a single source of truth for authorization logic, and simplifies caller components. This change also fixes the bug in ticket, which allows Users to properly edit Ciphers inside of the various Admin Console report types.	3 months ago
Brad	6a01e7436c	[PM-30543] Add select all checkbox to Access Intelligance Applications table (#18682) ... Adds a "Select all" checkbox to the table in the Access Intelligence applications tab. This allows users to quickly select or deselect all applications currently showing in the table for marking as critical apps.	3 months ago
Andreas Coroiu	1898c27ad3	[PM-30404] Exclude .wasm.js from babel (#18555) ... * feat: exclude .wasm.js from babel * feat: exclude from browser and desktop too	3 months ago
Jared	2fd3404c27	Revert "Disable native icon for datetime-local field and use our own icons for stylizing (#18633)" (#18796) ... This reverts commit 2d8f74bf70.	3 months ago
Jared	f010d28492	[PM-25365] Enhance layout responsiveness in vault component header (#18679) ... * Enhance layout responsiveness in vault components by adding flex properties to improve structure and ensure proper height management. * Refactor vault component layout to rid of my changes * Update apps/web/src/app/vault/individual-vault/vault.component.html Co-authored-by: Jackson Engstrom <jengstrom@bitwarden.com> --------- Co-authored-by: Jackson Engstrom <jengstrom@bitwarden.com>	3 months ago
Jason Ng	0b8d61a1b8	[PM-31423] updated isAdminConsoleAction check in cipher-report (#18662)	3 months ago