bitwarden-clients

Commit Graph

Author	SHA1	Message	Date
Patrick-Pimentel-Bitwarden	94cb1fe07b	feat(auth-tech-debt): [PM-24103] Remove Get User Key to UserKey$ (#16589 ) * fix(auth-tech-debt): [PM-24103] Remove Get User Key to UserKey$ - Fixed and updated tests. * fix(auth-tech-debt): [PM-24103] Remove Get User Key to UserKey$ - Fixed test variable being made more vague.	8 months ago
Thomas Avery	7afc456077	[PM-23246] CLI unlock with masterPasswordUnlockData (#16217 ) * unlock with masterPasswordUnlockData in the CLI	8 months ago
Dave	7943066724	Reapply feat(two-factor-api-service) [PM-26465]: (Refactor) Two-Factor API Service (#16856 ) (#16884 ) This reverts commit `d082d336e7`. Feature branch was accidentally merged before QA testing completed.	8 months ago
Nick Krantz	eee2aca111	auto-accept edits when commands are piped together - the user does not have the ability to accept a prompt (#16889 )	8 months ago
John Harrington	64105e64e9	[PM-24105] Remove usage of getUserKey on keyService (#16626 ) • prefer undefined over null • obtain required UserId once per method, before branching • guards moved to beginning of methods * lift UserId retrieval to occur once during import * remove redundant userId retrieval	8 months ago
Dave	d082d336e7	Revert "feat(two-factor-api-service) [PM-26465]: (Refactor) Two-Factor API Se…" (#16856 ) This reverts commit `886003ba88`.	8 months ago
Dave	886003ba88	feat(two-factor-api-service) [PM-26465]: (Refactor) Two-Factor API Service (#16747 ) * feat(two-factor-api-service) [PM-26465]: Add TwoFactorApiServiceAbstraction. * feat(two-factor-api-service) [PM-26465]: Add TwoFactorApiService implementation. * feat(two-factor-api-service) [PM-26465]: Add test suite for TwoFactorApiService. * feat(two-factor-api-service) [PM-26465]: Replace ApiService dependencies with TwoFactorApiService for all refactored methods. * feat(two-factor-api-service) [PM-26465]: Finish removal of Two-Factor API methods from ApiService. * fix(two-factor-api-service) [PM-26465]: Correct endpoint spelling. * feat(two-factor-api-service) [PM-26465]: Update dependency support for CLI. * fix(two-factor-api-service) [PM-26465]: Update tests/deps for corrected spelling. * feat(two-factor-api-service) [PM-26465]: Add TwoFactorApiService to Browser services module. * fix(two-factor-api-service) [PM-26465]: Re-spell dependencies to take Abstraction throughout, move to JslibServices module for cleaner importing across clients. feat(two-factor-api-service) [PM-26465]: Move new services to a feature area, rename abstract and concrete/default. * feat(two-factor-api-service) [PM-26465]: Move the feature area to common/auth, not auth/common. * feat(two-factor-api-service) [PM-26465]: Remove now-unneeded include from auth/tsconfig.	8 months ago
Bernd Schoolmann	cc8bd71775	[PM-21033/PM-22863] User Encryption v2 (#14942 ) * Add new encrypt service functions * Undo changes * Cleanup * Fix build * Fix comments * Switch encrypt service to use SDK functions * Move remaining functions to PureCrypto * Tests * Increase test coverage * Split up userkey rotation v2 and add tests * Fix eslint * Fix type errors * Fix tests * Implement signing keys * Fix sdk init * Remove key rotation v2 flag * Fix parsing when user does not have signing keys * Clear up trusted key naming * Split up getNewAccountKeys * Add trim and lowercase * Replace user.email with masterKeySalt * Add wasTrustDenied to verifyTrust in key rotation service * Move testable userkey rotation service code to testable class * Fix build * Add comments * Undo changes * Fix incorrect behavior on aborting key rotation and fix import * Fix tests * Make members of userkey rotation service protected * Fix type error * Cleanup and add injectable annotation * Fix tests * Update apps/web/src/app/key-management/key-rotation/user-key-rotation.service.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Remove v1 rotation request * Add upgrade to user encryption v2 * Fix types * Update sdk method calls * Update request models for new server api for rotation * Fix build * Update userkey rotation for new server API * Update crypto client call for new sdk changes * Fix rotation with signing keys * Cargo lock * Fix userkey rotation service * Fix types * Undo changes to feature flag service * Fix linting * [PM-22863] Account security state (#15309) * Add account security state * Update key rotation * Rename * Fix build * Cleanup * Further cleanup * Tests * Increase test coverage * Add test * Increase test coverage * Fix builds and update sdk * Fix build * Fix tests * Reset changes to encrypt service * Cleanup * Add comment * Cleanup * Cleanup * Rename model * Cleanup * Fix build * Clean up * Fix types * Cleanup * Cleanup * Cleanup * Add test * Simplify request model * Rename and add comments * Fix tests * Update responses to use less strict typing * Fix response parsing for v1 users * Update libs/common/src/key-management/keys/response/private-keys.response.ts Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com> * Update libs/common/src/key-management/keys/response/private-keys.response.ts Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com> * Fix build * Fix build * Fix build * Undo change * Fix attachments not encrypting for v2 users --------- Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>	8 months ago
Oscar Hinton	095729d6fa	[PM-23189] Add client managed token provider (#15408 ) * Add client managed token provider * Change token service to accept user id * Resolve breaking changes in the SDK * Fix tests * Update sdk * Fix type * Fix types * Fix cli * Fix browser * Add optional userId to refreshIdentityToken * Fix merge issues * Fix tests	8 months ago
rr-bw	fdf47ffe3b	refactor(login-error): (Auth) [PM-22145] Improved Error State for Failed Login (#16569 ) Updates the inline error message on a failed login.	8 months ago
Nick Krantz	bbbc10f233	Fix logic for list filtering for trash and archived items (#16702 )	8 months ago
SmithThe4th	9182628b28	Decrypt folder from returned saved folder (#16434 )	8 months ago
Nick Krantz	727689d827	[PM-24534] Archive via CLI (#16502 ) * refactor `canInteract` into a component level usage. - The default service is going to be used in the CLI which won't make use of the UI-related aspects * all nested entities to be imported from the vault * initial add of archive command to the cli * add archive to oss serve * check for deleted cipher when attempting to archive * add searchability/list functionality for archived ciphers * restore an archived cipher * unarchive a cipher when a user is editing it and has lost their premium status * add missing feature flags * re-export only needed services from the vault * add needed await * add prompt when applicable for editing an archived cipher * move cipher archive service into `common/vault` * fix testing code	8 months ago
Alex	8531109081	[PM-25417] DIRT API Service Refactor (ADR-0005) (#16353 ) * encode username for uri and add spec * verify response from getHibpBreach method * test/validate for BreachAccountResponse type and length instead of mock response * - extract dirt api method out of global api service - create new directory structure - change imports accordingly - extract breach account response - put extracted code into new dirt dir * codeowners and dep injection for new hibp service	9 months ago
Daniel James Smith	94764467e8	[PM-25918] Move required userId for export request up to component/command level (#14391 ) * Require userId for KdfConfigService * cleanup KdfConfigService unit tests * Move required userId for export request up to component/command level * Fix service creation/dependency injection * Revert changes to kdf-config.service.spec cause by a bad rebase * Fix linting issue * Fix tests caused by bad rebase * Validate provided userId to equal the current active user * Create tests for vault-export.service Deleted old tests which since have been replaced with individual-vault-export.service.spec.ts --------- Co-authored-by: Thomas Avery <tavery@bitwarden.com> Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	9 months ago
Jared Snider	42ec956782	feat(PlatformUtils): [Auth/PM-25817] New PlatformUtilsService.isChromium() method (#16468 )	9 months ago
Jordan Aasen	4b78da1623	[PM-21794] - remove RemoveCardItemTypePolicy flag (#16450 ) * remove restricted item types flag * fix RestrictedItemTypesService constructor	9 months ago
Daniel James Smith	ba817f0389	[PM-25503] Use org export api on encrypted and unencrypted org exports (#16290 ) * Introduce a new vault-export-api.service to replace the existing getOrganizationExport method in apiService * Use new vault-export-api.service instead of the ApiService to retrieve organizational export data * Remove unused method from apiService * Register VaultExportApiService on browser * Fxi linting issue by executing `npm run prettier` * Rename abstraction and implementation of VaultExportApiService * Use undefined instead of null * Rename file of default impl of vault-export-api-service * Fix test broken with `1bcdd80eea` * Define type for exportPromises --------- Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	9 months ago
Andreas Coroiu	a2e36c4489	feat: add folder.clear warning (#16376 )	9 months ago
Daniel James Smith	66f5700a75	[PM-24748][PM-24072] Chromium importer (#16100 ) * Add importer dummy lib, add cargo deps for win/mac * Add Chromium importer source from bitwarden/password-access * Mod crypto is no more * Expose some Chromium importer functions via NAPI, replace home with home_dir crate * Add Chromium importer to the main <-> renderer IPC, export all functions from Rust * Add password and notes fields to the imported logins * Fix windows to use homedir instead of home * Return success/failure results * Import from account logins and join * Linux v10 support * Use mod util on Windows * Use mod util on macOS * Refactor to move shared code into chromium.rs * Fix windows * Fix Linux as well * Linux v11 support for Chrome/Gnome, everything is async now * Support multiple browsers on Linux v11 * Move oo7 to Linux * Fix Windows * Fix macOS * Add support for Brave browser in Linux configuration * Add support for Opera browser in Linux configuration * Fix Edge and add Arc on macOS * Add Opera on macOS * Add support for Vivaldi browser in macOS configuration * Add support for Chromium browser in macOS configuration * Fix Edge on Windows * Add Opera on Windows * Add Vivaldi on windows * Add Chromium to supported browsers on Windows * stub out UI options for chromium direct import * call IPC funcs from import-desktop * add notes to chrome csv importer * remove (csv) from import tool names and format item names as hostnames * Add ABE/v20 encryption support * ABE/v20 architecture description * Add a build step to produce admin.exe and service.exe * Add Windows v20/ABE configuration functionality to specify the full path to the admin.exe and service.exe. Use ipc.platform.chromiumImporter.configureWindowsCryptoService to configure the Chromium importer on Windows. * rename ARCHITECTURE.md to README.md * aligns with guidance from architecture re: in-repository documentation. * also fixes a failing lint. * cargo fmt * cargo clippy fix * Declare feature flag for using chromium importer * Linter fix after executing npm run prettier * Use feature flag to guard the use of the chromium importer * Added temporary logging to further debug, why the Angular change detection isn't working as expected * introduce importer metadata; host metadata from service; includes tests * fix cli build * Register autotype module in lib.rs introduce by a bad merge * Fix web build * Fix issue with loaders being undefined and the feature flag turned off * Add missing Chromium support when selecting chromecsv * debugging * remove chromium support from chromecsv metadata * fix default loader selection * [PM-24753] cargo lib file (#16090) * Add new modules * Fix chromium importer * Fix compile bugs for toolchain * remove importer folder * remove IPC code * undo setting change * clippy fixes * cargo fmt * clippy fixes * clippy fixes * clippy fixes * clippy fixes * lint fix * fix release build * Add files in CODEOWNERS * Create tools owned preload.ts * Move chromium-importer.service under tools-ownership * Fix typeError When accessing the Chromium direct import options the file button is hidden, so trying to access it's values will fail * Fix tools owned preload * Remove dead code and redundant truncation * Remove configureWindowsCryptoService function/methods * Clean up cargo files * Fix unused async * Update apps/desktop/desktop_native/bitwarden_chromium_importer/Cargo.toml Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> * Fix napi deps * fix lints * format * fix linux lint * fix windows lints * format * fix missing `?` * fix a different missing `?` --------- Co-authored-by: Dmitry Yakimenko <detunized@gmail.com> Co-authored-by: Kyle Spearrin <kyle.spearrin@gmail.com> Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com> Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com> Co-authored-by: ✨ Audrey ✨ <audrey@audreyality.com> Co-authored-by: adudek-bw <adudek@bitwarden.com> Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>	9 months ago
Maciej Zieniuk	3a62e9c2f1	[PM-21772] Show key connector domain for new sso users (#15381 ) * Passed in userId on RemovePasswordComponent. * Added userId on other references to KeyConnectorService methods * remove password component refactor, test coverage, enabled strict * explicit user id provided to key connector service * redirect to / instead when user not logged in or not managing organization * key connector service explicit user id * key connector service no longer requires account service * key connector service missing null type * cli convert to key connector unit tests * remove unnecessary SyncService * error toast not showing on ErrorResponse * bad import due to merge conflict * bad import due to merge conflict * missing loading in remove password component for browser extension * error handling in remove password component * organization observable race condition in key-connector * usesKeyConnector always returns boolean * unit test coverage * key connector reactive * reactive key connector service * introducing convertAccountRequired$ * cli build fix * moving message sending side effect to sync * key connector service unit tests * fix unit tests * move key connector components to KM team ownership * new unit tests in wrong place * key connector domain shown in remove password component * type safety improvements * convert to key connector command localization * key connector domain in convert to key connector command * convert to key connector command unit tests with prompt assert * organization name placement change in the remove password component * unit test update * show key connector domain for new sso users * confirm key connector domain page does not require auth guard * confirm key connector domain page showing correctly * key connector url required to be provided when migrating user * missing locales * desktop styling * have to sync and navigate to vault after key connector keys exchange * logging verbosity * splitting the web client * splitting the browser client * cleanup * splitting the desktop client * cleanup * cleanup * not necessary if condition * key connector domain tests fix for sso componrnt and login strategy * confirm key connector domain base component unit tests coverage * confirm key connector domain command for cli * confirm key connector domain command for cli unit tests * design adjustments removed repeated text, vertical buttons on desktop, wrong paddings on browser extension * key connector service unit test coverage * new linting rules fixes * accept invitation to organization called twice results in error. Web vault remembers it's original route destination, which we do not want in case of accepting invitation and Key Connector, since provisioning new user through SSO and Key Connector, the user is already accepted. * moved required key connector domain confirmation into state * revert redirect from auth guard * cleanup * sso-login.strategy unit test failing * two-factor-auth.component unit test failing * two-factor-auth.component unit test coverage * cli unit test failing * removal of redundant logs * removal of un-necessary new lines * consolidated component * consolidated component css cleanup * use KdfConfig type * consolidate KDF into KdfConfig type in identity token response * moving KC requiresDomainConfirmation lower in order, after successful auth * simplification of trySetUserKeyWithMasterKey * redirect to confirm key connector route when locked but can't unlock yet --------- Co-authored-by: Todd Martin <tmartin@bitwarden.com>	9 months ago
Shane Melton	b6ef7716da	[PM-24243] Load config service feature flag into SDK client (#15855 ) * [PM-24243] Load config service feature flag into SDK client during initialization * [PM-24243] Bump sdk version * [PM-24243] Update load_flags to use generic Map instead of strongly typed object * [PM-24243] Pass entire feature states object into SDK * [PM-24243] Bump SDK version * [PM-24243] Fix failing test	9 months ago
Justin Baur	73e8532ecc	feat(tokens): Allow Inactive user authenticated API calls	9 months ago
Ike	7bc04e2218	fix: do not fetch refresh token on sync during CLI login (#16155 ) fix: fetching a refresh token on a full sync during api key login on cli caused rate limit issues. we no longer fetch a refresh token on login since we shouldn't need it.	10 months ago
Brandon Treston	28b5a2bb5e	[PM-22717] Expose DefaultUserCollectionEmail to clients (#15643 ) * enforce restrictions based on collection type, set default collection type * fix ts strict errors * fix default collection enforcement in vault header * enforce default collection restrictions in vault collection row * enforce default collection restrictions in AC vault header * enforce default collection restriction for select all * fix ts strict error * switch to signal, fix feature flag * fix story * clean up * remove feature flag, move check for defaultCollecion to CollecitonView * fix test * remove unused configService * fix test: coerce null to undefined for collection Id * clean up leaky abstraction for default collection * fix ts-strict error * fix parens * add new property to models, update logic, refactor for ts-strict * fix type * rename defaultCollection getter * clean up * clean up * clean up, add comment, fix submit * add comment * add feature flag * check model for name * cleanup readonly logic, remove featureflag logic * wip * refactor CollectionRequest into Create and Update models * fix readonly logic * cleanup * set defaultUserCollectionEmail in decryption from Collection * split save into update/create methods * fix readonly logic * fix collections post and put requests * add defaultUserCollection email to model when submitting collection dialog	10 months ago
Justin Baur	5f7f1d1924	Resolve state <-> state-test-utils circular dependency (#16093 ) * Resolve state <-> state-test-utils circular dependency * Fix type errors	10 months ago
Daniel García	12df7def61	[PM-19479] Client-Managed SDK state definition (#14839 ) * [PM-19479] Client-Managed SDK state definition * Remove test code * Update based on latest sdk * Add DB config * Remove uuid conversion step * Move mapper into separate file * Revert to client managed state * Move mapper to Cipher * Typo --------- Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>	10 months ago
Thomas Avery	a6e7efddeb	[PM-23627] Require publicKey for keyService getFingerprint (#15933 ) * require public key on keyService getFingerprint * Update consumers and add error handling & logging	10 months ago
Patrick-Pimentel-Bitwarden	719a43d050	Feat PM-19877 System Notification Processing (#15611 ) * feat(notification-processing): [PM-19877] System Notification Implementation - Minor changes to popup logic and removed content in login component. * docs(notification-processing): [PM-19877] System Notification Implementation - Added more docs. * docs(notification-processing): [PM-19877] System Notification Implementation - Added markdown document. * fix(notification-processing): [PM-19877] System Notification Implementation - Updated condition for if notification is supported. * fix(notification-processing): [PM-19877] System Notification Implementation - Updated services module with correct platform utils service.	10 months ago
Justin Baur	939fd402c3	[PM-24677] Slim StateService down so it can be moved to state lib (#16021 ) * Slim StateService down so it can be moved to state lib * Fix accidental import changes * Add `switchAccount` assertion * Needs to use mock	10 months ago
Jonathan Prusik	0c166b3f94	remove BlockBrowserInjectionsByDomain feature flag (#16008 )	10 months ago
Bernd Schoolmann	a60b7fed9a	[PM-17667] Move key-generation service to KM ownership (#16015 ) * Move key-generation service * Update comment * Add deprecation comments * Fix firefox build * Update comment * Update DI import * Update module imports	10 months ago
Brandon Treston	27089fbb57	[PM-24227] Enable TS-strict for Collection Domain models (#15765 ) * wip ts-strict * wip ts-strict * wip * cleanup * cleanup * fix story * fix story * fix story * wip * clean up CollectionAdminView construction * fix deprecated function call * fix cli * clean up * fix story * wip * fix cli * requested changes * clean up, fixing minor bugs, more type saftey * assign props in static ctor, clean up	10 months ago
Brandon Treston	d4952d211e	[PM-24096] replace getOrgKey with orgKey$, refactor collectionAdminService (#15928 ) * replace getOrgKey with orgKey$, refactor collectionAdminService * clean up * uncomment accidental commet * remove cache	10 months ago
Patrick Lenihan	d3c6ba9f4b	[PM-20220] feat: Add support for fd and unix socket bindings (#14262 ) * Add support for unix sockets with (unix://) scheme * Add support for listening socket FD (fd+listening:// scheme) * Add support for connected socket FD (fd+connected:// scheme) --------- Co-authored-by: Addison Beck <github@addisonbeck.com>	10 months ago
✨ Audrey ✨	01d95f325f	hide experimental `bw send --email` flag (#15955 )	10 months ago
Rui Tomé	a139fb5def	[PM-24433] Update the CLI confirm org-member command to create a default collection (#15917 ) * Update the CLI ConfirmCommand to send the DefaultUserCollectionName for default collection creation * Add "My Items" message to CLI * Refactor ConfirmCommand to encapsulate default user collection name encryption in a separate method	10 months ago
Thomas Rittson	61cd0c4f51	[PM-23920] Admin Console - adopt strongly typed guids (#15814 ) Update organization, collection and policy to use strongly typed IDs	10 months ago
Daniel Riera	2549afc45d	PM-23890 Update overlays when a cipher is deleted (#15800 ) * PM-23890 WIP * add messaging service references * Revert "PM-19574 Browser Autofill overlay displays outdated data (#15624)" This reverts commit `9eceaa3d4c`. * add test * fix merge spacing * Revert "Revert "PM-19574 Browser Autofill overlay displays outdated data (#15624)"" This reverts commit `0fc6ec4d0b`.	10 months ago
✨ Audrey ✨	d5e78e9549	[PM-24092] fix positional argument processing (#15756 )	10 months ago
Bernd Schoolmann	2e9a47721e	Remove legacy key support in vault code (#15348 )	10 months ago
Bernd Schoolmann	6bd8638ad8	[PM-24126] Move pin service to km ownership (#15821 ) * Move pin service to km ownership * Run format * Eslint * Fix tsconfig * Fix imports and test * Clean up imports * Remove unused dependency on PinService * Fix comments --------- Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	10 months ago
Bernd Schoolmann	0cc473fb0f	Remove legacy key support form platform code (#15351 )	10 months ago
Justin Baur	4f9b2b618f	[PM-24280] Remove account service from state (#15828 ) * Introduce ActiveUserAccessor * Use ActiveUserAccessor over AccountService * Updates tests and testing utils to support ActiveUserAccessor * Update all injection points * Fix types test * Use ternary instead	10 months ago
Bernd Schoolmann	5dae5267d9	[PM-22623] Remove most TS encryption code, remove service workers (#15153 ) * Add new encrypt service functions * Undo changes * Cleanup * Fix build * Fix comments * Switch encrypt service to use SDK functions * Move remaining functions to PureCrypto * Tests * Increase test coverage * Enforce sdk.ready and drop unused codepaths * Delete unused code * Delete unused code * Delete more code * Add forgotten sdk init logic * Fix build * Fix cli * Fix tests * Fix build * Fix browser build * Remove compare and add more comments / warnings * Run prettier * Remove unused feature flags * Add hazmat warning to aesDecrypt * Fix build * Fix comment * Fix test	10 months ago
Bernd Schoolmann	a7d3c0f5c2	[PM-23809] Add simplified interface to MP service (#15631 ) * Add new mp service api * Fix tests * Add test coverage * Add newline * Fix type * Rename to "unwrapUserKeyFromMasterPasswordUnlockData" * Fix build * Fix build on cli * Fix linting * Re-sort spec * Add tests * Fix test and build issues * Fix build * Clean up * Remove introduced function * Clean up comments * Fix abstract class types * Fix comments * Cleanup * Cleanup * Update libs/common/src/key-management/master-password/types/master-password.types.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/master-password/services/master-password.service.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/master-password/types/master-password.types.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Add comments * Fix build * Add arg null check * Cleanup * Fix build * Fix build on browser * Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Add tests for null params * Cleanup and deprecate more functions * Fix formatting * Prettier * Clean up * Update libs/key-management/src/abstractions/key.service.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Make emailToSalt private and expose abstract saltForUser * Add tests * Add docs * Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> --------- Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>	11 months ago
Thomas Avery	2db31d1228	[PM-22611] Require userid for masterKey methods on the key service (#15663 ) * Require userId on targeted methods. * update method consumers * unit tests	11 months ago
Jordan Aasen	7b85870e58	[PM-22377] - [Vault] [Clients] Update cipher form component to restrict editing old My Vault items (#15687 ) * disable cipher form for "My Items" ciphers * use correct property * prevent changing non org fields in cli for org owned vaults * update var name * fix tests * fix stories * revert changes to item details section. update comment in edit command * remove unused props * fix test * re-apply logic to enforce org ownership * re-apply logic to enforce org ownership * fix logic and test * add empty line to comment * remove unused var * delegate form enabling/disabling to cipherFormContainer * rename var and getter back to original. update comment	11 months ago
Brandon Treston	d0d1359ff4	[PM-12048] Wire up vNextCollectionService (#14871 ) * remove derived state, add cache in service. Fix ts strict errors * cleanup * promote vNextCollectionService * wip * replace callers in web WIP * refactor tests for web * update callers to use vNextCollectionServcie methods in CLI * WIP make decryptMany public again, fix callers, imports * wip cli * wip desktop * update callers in browser, fix tests * remove in service cache * cleanup * fix test * clean up * address cr feedback * remove duplicate userId * clean up * remove unused import * fix vault-settings-import-nudge.service * fix caching issue * clean up * refactor decryption, cleanup, update callers * clean up * Use in-memory statedefinition * Ac/pm 12048 v next collection service pairing (#15239) * Draft from pairing with Gibson * Add todos * Add comment * wip * refactor upsert --------- Co-authored-by: Brandon <btreston@bitwarden.com> * clean up * fix state definitions * fix linter error * cleanup * add test, fix shareReplay * fix item-more-options component * fix desktop build * refactor state to account for null as an initial value, remove caching * add proper cache, add unit test, update callers * clean up * fix routing when deleting collections * cleanup * use combineLatest * fix ts-strict errors, fix error handling * refactor Collection and CollectionView properties for ts-strict * Revert "refactor Collection and CollectionView properties for ts-strict" This reverts commit `a5c63aab76`. --------- Co-authored-by: Thomas Rittson <trittson@bitwarden.com> Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>	11 months ago
Jordan Aasen	fe1c040993	[PM-23789][PM-237090][PM-23791][PM-23792] - [Web][Desktop][Browser] - Do not import cards if policy is enabled (#15740 ) * restrict item types in import * add comment * fix spec * fix dep * clean up logic	11 months ago
✨ Audrey ✨	5290e0a63b	[PM-19054] configure send with email otp authentication via cli (#15360 )	11 months ago
Bernd Schoolmann	60855c734f	[PM-17666] Move Encstring to KM ownership (#15457 ) * Move Encstring to KM ownership * Fix wrong import * Fix build * Fix remaining imports * Fix tests	11 months ago
SmithThe4th	3c6f763233	[PM-23306] "Show cards in autofill" is defaulting to on when the setting is enabled (#15534 ) * disable card autofill * Fixed dependency issues	11 months ago
Thomas Avery	09fb74679d	[PM-21912] Require userID for KeyService's hasUserKey (#14890 ) * Update keyService hasUserKey to require userId and remove unused/duplicate methods * Update lock component consumer * Update send commands to pass in userId * update SSO login to pass in userID * Update bw serve to pass in userID * remove unneeded method from electron-key.service	11 months ago
Jared Snider	b9f930a609	fix(tde-offboarding): Auth/PM-19165 - Handle TDE offboarding on an untrusted device with warning message (#15430 ) When a user logs in via SSO after their org has offboarded from TDE, we now show them a helpful error message stating that they must either login on a Trusted device, or ask their admin to assign them a password. Feature flag: `PM16117_SetInitialPasswordRefactor`	11 months ago
Todd Martin	d1c6b334b1	feat(DuckDuckGo): [PM-9388] Add new device type for DuckDuckGo browser * Add new device type for DuckDuckGo browser * Added feature support property for sync domains * Added new features * Added isDuckDuckGo() to CLI * Addressed PR feedback. * Renamed new property * Fixed rename that missed CLI.	11 months ago
SmithThe4th	4bfcc9d076	[PM-23008] Error when attempting to export vault (#15397 ) * moved restrictedItemTypesService creation before export service is created * Fixed cliRestrictedItemTypesService arrangement	11 months ago
Jordan Aasen	62750a06ec	[PM-36] - [Tech Debt] Move SearchService to libs/common/vault (#15251 ) * wip - migrate search service to vault * fix import	12 months ago
Ike	7c9e95271d	[PM -20329] browser auth approval client api service (#15161 ) * feat: Create methods for calling GET auth-request/pending endpoint. * feat: update banner service on web, and desktop vault * test: updated banner test to use auth request services * fix: DI fixes * feat: add RequestDeviceId to AuthRequestResponse * fix: add Browser Approvals feature flags to desktop vault and web vault banner service * test: fix tests for feature flag	12 months ago
SmithThe4th	e291e2df0a	[PM-21451] [Vault] [CLI] Changes to Enforce "Remove card item type policy" (#15187 ) * Created new service to get restricted types for the CLI * Created service for cli to get restricted types * Utilized restriction service in commands * Renamed function * Refactored service and made it simpler to check when a cipher type is restricted or not * Moved service to common so it can be utilized on the cli * Refactored service to use restricted type service * Removed userId passing from commands * Exclude restrict types from export * Added missing dependency * Added missing dependency * Added missing dependency * Added service utils commit from desktop PR * refactored to use reusable function * updated reference * updated reference * Fixed merge conflicts * Refactired services to use isCipherRestricted * Refactored restricted item types service * Updated services to use the reafctored item types service	12 months ago
Thomas Avery	90b07728d7	[PM-22133] Require userID for clearStoredUserKey (#14973 )	1 year ago
Rui Tomé	b5bddd0b06	[PM-17154] Limit item deletion feature flag removal (#15094 ) * Refactor components to remove limitItemDeletion feature flag usage This commit simplifies the logic in various components by removing the limitItemDeletion feature flag. The conditions for displaying restore and delete actions are now based solely on the cipher's permissions, enhancing code clarity and maintainability. * Refactor cipher deletion logic to remove the feature flag and collection ID dependency This commit updates the cipher deletion logic across multiple components and services by removing the unnecessary dependency on collection IDs. The `canDeleteCipher$` method now solely relies on the cipher's permissions, simplifying the code and improving maintainability. * Remove LimitItemDeletion feature flag from feature-flag enum and default values * Remove configService from ServiceContainer and MainBackground constructor parameters * Remove configService from RestoreCommand instantiation in OssServeConfigurator and VaultProgram classes	1 year ago
Oscar Hinton	18573bdc48	[PM-22250] Bump open (#15011 ) Upgrade open to latest version.	1 year ago
Todd Martin	2c404d35d4	fix(2fa): Update CLI to send email regardless of number of methods	1 year ago
Bernd Schoolmann	23ec6bacc9	[PM-20225] Prevent legacy users without userkey from logging in (#14267 ) * Prevent legacy users without userkey from logging in * Remove further web-migration code for legacy users * Add i18n for legacy user error message * Update comment * Remove migrate legacy component * Remove i18n messages * Remove migrate legacy encryption reference	1 year ago
Oscar Hinton	5423ab3268	[PM-21934] Upgrade to eslint 9 (#14754 ) Upgrades to Eslint v9. Since this is a major version there were breaking changes, but since we've previously migrated to flat configs in #12806 those were minimal.	1 year ago
Thomas Avery	bd29397fd8	[PM-21611] Require userId on KeyService clear methods (#14788 )	1 year ago
SmithThe4th	46a0b709fe	[PM-21644] Cannot retrieve attachment from bw serve (#14806 ) * Modified saveAttachmenttofIle to implement callback attachment content decryption * renamed parameter	1 year ago
Bernd Schoolmann	d93f547cfb	[PM-21001] Move platform code to new encrypt service interface (#14544 ) * Move platform code to new encrypt service interface * Fix tests * Fix tests * Fix cli build	1 year ago
Maciej Zieniuk	239556b55f	[PM-18017] Show key connector domain in remove password page (#14695 ) * Passed in userId on RemovePasswordComponent. * Added userId on other references to KeyConnectorService methods * remove password component refactor, test coverage, enabled strict * explicit user id provided to key connector service * redirect to / instead when user not logged in or not managing organization * key connector service explicit user id * key connector service no longer requires account service * key connector service missing null type * cli convert to key connector unit tests * remove unnecessary SyncService * error toast not showing on ErrorResponse * bad import due to merge conflict * bad import due to merge conflict * missing loading in remove password component for browser extension * error handling in remove password component * organization observable race condition in key-connector * usesKeyConnector always returns boolean * unit test coverage * key connector reactive * reactive key connector service * introducing convertAccountRequired$ * cli build fix * moving message sending side effect to sync * key connector service unit tests * fix unit tests * move key connector components to KM team ownership * new unit tests in wrong place * key connector domain shown in remove password component * type safety improvements * convert to key connector command localization * key connector domain in convert to key connector command * convert to key connector command unit tests with prompt assert * organization name placement change in the remove password component * unit test update * key connector url required to be provided when migrating user * unit tests in wrong place after KM code ownership move * infinite page reload * failing unit tests * failing unit tests --------- Co-authored-by: Todd Martin <tmartin@bitwarden.com>	1 year ago
Maciej Zieniuk	e73f902aee	[PM-18576] Fix missing user id on remove password (#13777 ) * Passed in userId on RemovePasswordComponent. * Added userId on other references to KeyConnectorService methods * remove password component refactor, test coverage, enabled strict * explicit user id provided to key connector service * redirect to / instead when user not logged in or not managing organization * key connector service explicit user id * key connector service no longer requires account service * key connector service missing null type * cli convert to key connector unit tests * remove unnecessary SyncService * error toast not showing on ErrorResponse * bad import due to merge conflict * bad import due to merge conflict * missing loading in remove password component for browser extension * error handling in remove password component * organization observable race condition in key-connector * usesKeyConnector always returns boolean * unit test coverage * key connector reactive * reactive key connector service * introducing convertAccountRequired$ * cli build fix * moving message sending side effect to sync * key connector service unit tests * fix unit tests * unit tests in wrong place after KM code ownership move * infinite page reload * failing unit tests * failing unit tests --------- Co-authored-by: Todd Martin <tmartin@bitwarden.com>	1 year ago
SmithThe4th	ad3121f535	[PM-12423] Migrate Cipher Decryption to Use SDK (#14206 ) * Created mappings for client domain object to SDK * Add abstract decrypt observable * Added todo for future consideration * Added implementation to cipher service * Added adapter and unit tests * Created cipher encryption abstraction and service * Register cipher encryption service * Added tests for the cipher encryption service * changed signature * Updated feature flag name * added new function to be used for decrypting ciphers * Added new encryptedKey field * added new function to be used for decrypting ciphers * Manually set fields * Added encrypted key in attachment view * Fixed test * Updated references to use decrypt with feature flag * Added dependency * updated package.json * lint fix * fixed tests * Fixed small mapping issues * Fixed test * Added function to decrypt fido2 key value * Added function to decrypt fido2 key value and updated test * updated to use sdk function without prociding the key * updated localdata sdk type change * decrypt attachment content using sdk * Fixed dependency issues * updated package.json * Refactored service to handle getting decrypted buffer using the legacy and sdk implementations * updated services and component to use refactored version * Updated decryptCiphersWithSdk to use decryptManyLegacy for batch decryption, ensuring the SDK is only called once per batch * Fixed merge conflicts * Fixed merge conflicts * Fixed merge conflicts * Fixed lint issues * Moved getDecryptedAttachmentBuffer to cipher service * Moved getDecryptedAttachmentBuffer to cipher service * ensure CipherView properties are null instead of undefined * Fixed test * ensure AttachmentView properties are null instead of undefined * Linked ticket in comment * removed unused orgKey	1 year ago
Todd Martin	4c68f61d47	feat(CLI-SSO-Login): [Auth/PM-21116] CLI - SSO Login - Add SSO Org Identifier option (#14605 ) * Add --identifier option for SSO on CLI * Add option for identifier * Moved auto-submit after the setting of client arguments * Adjusted comment * Changed to pass in as SSO option * Renamed to orgSsoIdentifier for clarity * Added more changes to orgSsoIdentifier.	1 year ago
Justin Baur	1b756df749	[PM-14484] `ApiService` showing html in error message (#14658 ) * Make ApiService more testable * Add ApiService tests * Switch to only reading text/plain content	1 year ago
Todd Martin	4191bb9533	chore(captcha): [PM-15162] Remove handling of captcha enforcement and bypass token * Removed captcha references. * Removed connectors from webpack * Fixed extra parameter. * Resolve merge conflicts. * Fixed extra argument. * Fixed failing tests. * Fixed failing test. * Accessibility cookie cleanup * Cleaned up accessibility component. * Deleted old registration endpoint * Remove unused register request object. * Fixed merge error that changed font family. * Fixed formatting from merge. * Linting	1 year ago
Alec Rippberger	3030eb7552	[PM-19212] Consolidate password set routing to AuthGuard using ForceSetPasswordReason (#14356 ) * Consolidates component routing, removing routing to update-temp-password from components. All routing to update-temp-password should happen in the AuthGuard now. --------- Co-authored-by: Jared Snider <jsnider@bitwarden.com> Co-authored-by: Todd Martin <tmartin@bitwarden.com>	1 year ago
Bernd Schoolmann	744c1b1b49	[PM-21001] Move vault code to new encrypt service interface (#14546 ) * Move vault code to new encrypt service interface * Fix tests	1 year ago
Brandon Treston	fd43222938	[PM-19383] admins unable to download attachments (#14363 ) * add admin support for downloading attachments * fix delete and upload * fix delete admin to return a response * fix upload * add missing param * use getCipherAdmin * fix cli	1 year ago
Thomas Avery	d43e4757df	[PM-7604] Require target UserID for KdfConfigService (#14380 ) * Require userId for KdfConfigService * Update auth team callers * Update tools team callers	1 year ago
Bernd Schoolmann	fd0db40f79	[PM-20492] Refactor symmetric keys - remove key buffer representation, migrate consumers to .toEncoded() (#14371 ) * Refactor encrypt service to expose key wrapping * Fix build * Undo ts strict removal * Fix wrong method being used to encrypt key material * Rename parameters and remove todo * Add summary to encrypt * Update libs/common/src/key-management/crypto/services/encrypt.service.implementation.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/crypto/services/encrypt.service.implementation.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/crypto/services/encrypt.service.implementation.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/crypto/services/encrypt.service.implementation.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/crypto/abstractions/encrypt.service.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Update libs/common/src/key-management/crypto/services/encrypt.service.implementation.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com> * Add tests for unhappy paths * Add test coverage * Add links * Remove direct buffer access * Fix build on cli --------- Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>	1 year ago
Maciej Zieniuk	4da03821ce	move key connector components to KM team ownership (#14008 )	1 year ago
Daniel James Smith	170f97da8e	[PM-20333] Remove "export-attachments" feature flag (#14310 ) * Remove usage of export-attachments feature flag * Remove export-attachments feature flag definition * Update export.command documentation --------- Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	1 year ago
Bernd Schoolmann	5a1b0744f0	[PM-17665] Move cryptofunction service to km (#13285 ) * Move cryptofunction service to km * Fix formatting * Fix import * Fix build on desktop * Fix build on browser and tests	1 year ago
Bernd Schoolmann	1450a033b3	[PM-19469] Add logs for unlock time (#13972 ) * Add logs for unlock time * Undo local flag override * Update message * Update messages * Fix build on chrome	1 year ago
Brandon Treston	9b3c28fcea	[PM-19746] Add new permission check to browser (#14075 ) * add new permisssions check to browser * add permission logic to view * fix tests * cleanup * fix permissions model for CLI and desktop * feedback	1 year ago
Thomas Avery	17f661e3d1	[PM-19287] Feature flag for encrypt service (#13894 ) * Extract getFeatureFlagValue to pure function Co-authored-by: Matt Gibson <mgibson@bitwarden.com> * Add broadcasting abstractions and OnServerConfigChange interface. Co-authored-by: Matt Gibson <mgibson@bitwarden.com> * Add implementation of onServerConfigChange on encrypt services Co-authored-by: Matt Gibson <mgibson@bitwarden.com> * Add onServerConfigChange implementation for encrypt worker Co-authored-by: Matt Gibson <mgibson@bitwarden.com> * Wire up broadcasting in dependency injection Co-authored-by: Matt Gibson <mgibson@bitwarden.com> * Add unit tests * Handle subscribing for onServerConfigChange in init services --------- Co-authored-by: Matt Gibson <mgibson@bitwarden.com>	1 year ago
Bernd Schoolmann	15738f16ae	[PM-18038] Fix safari using outdated biometrics protocol (#13287 ) * Fix safari using outdated biometrics protocol * Remove logging * Remove log * Move canEnableBiometricUnlock to biometric service * Fix build * Add tests * Fix type error * Attempt to fix build * Fix build * Fix test failure	1 year ago
Bernd Schoolmann	22039d038d	[PM-3475] Remove deprecated keys (#13266 ) * Remove deprecated keys * Fix cli build * Fix build	1 year ago
Brandon Treston	0fd01ed7ee	[PM-18566] Wire up vNextPolicyService for Clients (#13678 ) * wire up vNext impl * wire up vNextPolicyService for browser * wire up vNextPolicyService for desktop * wire up vNextPolicyService for cli * fix test * fix missed caller * cleanup * fix missing property assignment * fix QA bug for PM-19205 * fix QA bug for PM-19206 * fix QA bug for pm-19228 * cleanup	1 year ago
Justin Baur	a9fd16968f	[PM-14999] Remove Sequentialize (#12113 ) * Remove Sequentialize * Delete `clearCaches`	1 year ago
Bernd Schoolmann	27baa92fcf	[PM-10749] [BEEEP] New export format: Zip with attachments (#10465 ) * Add new export format: zip * Restrict zip export to just individual vaults * Add tests * Remove unused import * Fix build error * Fix tests * Fix test * Fix retrieval of ciphers by passing in activeUserId * Guard feature behind `export-attachments`-feature-flag * Extend cipher filter to also filter out any ciphers that are assigned to an organization * Added apiService to retrieve AttachmentData (metaData) and then download the attachment - Added ApiService as a depdency within DI for VaultExportService/IndividualVaultExportService - Added unit tests for filtering ciphers - Added unit test for downloading attachment metadata and attachments * Moved attachment decryption into a separate method and added unit tests * Added null check for creating the base attachment folder * Move format check for zip within Org export into an early return/throw * Add feature flag guard on the CLI * Extend ExportScopeCallout to display an individual export will contain attachment when zip-format is selected * Fix adding/removing the zip-export option based on selected vault and state of `export-attachments` feature-flag * Separate AAA visually using whitespace within tests * Remove unused error var * Write test that verifies different http request failures when retrieving attachment data * Remove uneeded ignore lint rule * Rewrite test to actually check that ciphers assigned to an org are filtered out * Introduce ExportedVault return type (#13842) * Define ExportedVault type unioned by 2 new types that describe a plain-text export vs a blob-based zip-export * Extend static getFileName to handle formats and add unit-tests * Introduce new export return type throughout the vault export module - Update abstractions - Update return types within implementations - Update callers/consumers to handle the new return value - Fix all unit tests * Add support for new export return type and fix download of blobs via CLI * Add documentation to public methods --------- Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com> --------- Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com> Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	1 year ago
Thomas Avery	a11536a424	[PM-17668] Move DeviceTrustService to KM ownership (#13194 ) * move DeviceTrustService to KM ownership * update codecov	1 year ago
Brandon Treston	4d68952ef3	[PM-18089] Update cipher permissions model and consumers (#13606 ) * update cipher permissions model and consumers * add new property to tests * fix test, add property to toCipherData() * add missing ConfigService * fix story * refactor * fix error, cleanup * revert refactor * refactor * remove uneeded test * cleanup * fix build error * refactor * clean up * add tests * move validation check to after featrue flagged logic * iterate on feedback * feedback	1 year ago
Thomas Rittson	0c507f54f6	[PM-13323] Move remaining collection code to AC Team (#13731 )	1 year ago
Thomas Avery	81335978d8	[PM-17669] Move MasterPasswordService to KM (#13148 ) * Move MasterPasswordService to KM	1 year ago
Thomas Avery	7e96b7a9a6	[PM-17670] Move KeyConnectorService to KM ownership (#13277 ) * Move KeyConnectorService to KM ownership * Add to codecov * Move key connector request models	1 year ago
rr-bw	e268055dc1	feature(set-change-password): [Auth/PM-17648] Create MasterPasswordApiService (#13552 ) Creates a MasterPasswordApiService to house our API calls related to setting and changing a master password.	1 year ago
Ike	c0f9754bdf	[PM-18943] Update New Device OTP Prompt message for CLI (#13780 ) * fix(newDeviceVerification): updating prompt for new device OTP in the CLI	1 year ago
Bernd Schoolmann	01f6fd7ee3	[PM-16227] Move import to sdk and enable it in browser/web (#12479 ) * Move import to sdk and enable it in browser/web * Add uncomitted files * Update package lock * Fix prettier formatting * Fix build * Rewrite import logic * Update ssh import logic for cipher form component * Fix build on browser * Break early in retry logic * Fix build * Fix build * Fix build errors * Update paste icons and throw error on wrong import * Fix tests * Fix build for cli * Undo change to jest config * Undo change to feature flag enum * Remove unneeded lifetime * Fix browser build * Refactor control flow * Fix i18n key and improve import behavior * Remove for loop limit * Clean up tests * Remove unused code * Update libs/vault/src/cipher-form/components/sshkey-section/sshkey-section.component.ts Co-authored-by: SmithThe4th <gsmith@bitwarden.com> * Move import logic to service and add tests * Fix linting * Remove erroneous includes * Attempt to fix storybook * Fix storybook, explicitly implement ssh-import-prompt service abstraction * Fix eslint * Update libs/importer/src/importers/bitwarden/bitwarden-json-importer.ts Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com> * Fix services module * Remove ssh import sdk init code * Add tests for errors * Fix import * Fix import * Fix pkcs8 encrypted key not parsing * Fix import button showing on web --------- Co-authored-by: SmithThe4th <gsmith@bitwarden.com> Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>	1 year ago
Thomas Rittson	ef72f513b1	eslint: report unused disable directives (#13463 ) Remove any unused disable directives and FIXMEs in our code	1 year ago

1 2 3 4 5 ...

436 Commits (anders/electron-builder)