26 Commits (dcd31da01a118774544efbb36bb6600a33f99ca4)

Author	SHA1	Message	Date
Sam Doran	a8de35e131	task_executor - use correct value for ssh connection retries (#75155) ... Since the task and connection both have the same 'retries' keyword, the task default would override the connection value. Do not pass 'retries' from the task to the connection options. * Set ssh_connection retries default value back to 0 It was 0 before the move to config and was changed to 3 by accident.	5 years ago
David Lee Whiteside	805799ac8b	add pkcs11 support to Ansible ssh connection module (#32829) ... * rebased with upstream * removed extra usetty as it wasnt needed, style changes, added var option setable by inventory for pkcs11 * update pkcs11_provider version_added * Update lib/ansible/plugins/connection/ssh.py Co-authored-by: Jordan Borean <jborean93@gmail.com> * Update lib/ansible/plugins/connection/ssh.py Correct logic for a password being required for pkcs11_provider Co-authored-by: Jordan Borean <jborean93@gmail.com> * style nit fixes for checking pkcs11_provider is set * fixed duplication when using password_prompt with pkcs11_provider * added changelog fragment * added changelog fragment Co-authored-by: David Whiteside <david.whiteside@nrel.gov> Co-authored-by: Matt Davis <nitzmahone@users.noreply.github.com> Co-authored-by: Jordan Borean <jborean93@gmail.com>	5 years ago
Brian Coca	b07a78b4ba	remove deprecated connection password functions (#74155) ... * they were moved from connecitons to become plugins * fixed clog, removed sanity ignore * fixed tests to use become functions	5 years ago
Brian Coca	935528e22e	finish migrating ssh plugin to config system (#73708) ... * finish migrating ssh plugin to config system fixes #72739 fixes #57220 * fix connection detection in reset * correct options for connection meta reset Co-authored-by: David Shrewsbury <Shrews@users.noreply.github.com>	5 years ago
Brian Coca	2b0cd2c13f	use correct executable and options in all cases (#73323) ... Use correct ssh executable and options in all cases on connection plugin * Also nicer naming/comments Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>	5 years ago
Bob Weinand	f200487414	Fix filedescriptor out of range in select() when running commands (#65058) ... * Fix filedescriptor out of range in select() when running commands * Simplify the run_command() code Now that we're using selectors in run_command(), we can simplify some of the code. * Use fileobj.read() instead of os.read() * No longer use get_buffer_size() as we can just slurp all of the data instead. Also use a simpler conditional check of whether the selector map is empty Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>	6 years ago
Rick Elrod	65edd5e37f	Split test_connection into individual files ... Signed-off-by: Rick Elrod <rick@elrod.me>	6 years ago
Matt Martz	c55317a2bd	Update connection plugins to use correct, non-deprecated, methods (#52038) ... * Update connection plugins to use correct, non-deprecated, methods * Update tests to reflect calling become plugins	7 years ago
Matt Martz	445ff39f94	Become plugins (#50991) ... * [WIP] become plugins Move from hardcoded method to plugins for ease of use, expansion and overrides - load into connection as it is going to be the main consumer - play_context will also use to keep backwards compat API - ensure shell is used to construct commands when needed - migrate settings remove from base config in favor of plugin specific configs - cleanup ansible-doc - add become plugin docs - remove deprecated sudo/su code and keywords - adjust become options for cli - set plugin options from context - ensure config defs are avaialbe before instance - refactored getting the shell plugin, fixed tests - changed into regex as they were string matching, which does not work with random string generation - explicitly set flags for play context tests - moved plugin loading up front - now loads for basedir also - allow pyc/o for non m modules - fixes to tests and some plugins - migrate to play objects fro play_context - simiplify gathering - added utf8 headers - moved option setting - add fail msg to dzdo - use tuple for multiple options on fail/missing - fix relative plugin paths - shift from play context to play - all tasks already inherit this from play directly - remove obsolete 'set play' - correct environment handling - add wrap_exe option to pfexec - fix runas to noop - fixed setting play context - added password configs - removed required false - remove from doc building till they are ready future development: - deal with 'enable' and 'runas' which are not 'command wrappers' but 'state flags' and currently hardcoded in diff subsystems * cleanup remove callers to removed func removed --sudo cli doc refs remove runas become_exe ensure keyerorr on plugin also fix backwards compat, missing method is attributeerror, not ansible error get remote_user consistently ignore missing system_tmpdirs on plugin load correct config precedence add deprecation fix networking imports backwards compat for plugins using BECOME_METHODS * Port become_plugins to context.CLIARGS This is a work in progress: * Stop passing options around everywhere as we can use context.CLIARGS instead * Refactor make_become_commands as asked for by alikins * Typo in comment fix * Stop loading values from the cli in more than one place Both play and play_context were saving default values from the cli arguments directly. This changes things so that the default values are loaded into the play and then play_context takes them from there. * Rename BECOME_PLUGIN_PATH to DEFAULT_BECOME_PLUGIN_PATH As alikins said, all other plugin paths are named DEFAULT_plugintype_PLUGIN_PATH. If we're going to rename these, that should be done all at one time rather than piecemeal. * One to throw away This is a set of hacks to get setting FieldAttribute defaults to command line args to work. It's not fully done yet. After talking it over with sivel and jimi-c this should be done by fixing FieldAttributeBase and _get_parent_attribute() calls to do the right thing when there is a non-None default. What we want to be able to do ideally is something like this: class Base(FieldAttributeBase): _check_mode = FieldAttribute([..] default=lambda: context.CLIARGS['check']) class Play(Base): # lambda so that we have a chance to parse the command line args # before we get here. In the future we might be able to restructure # this so that the cli parsing code runs before these classes are # defined. class Task(Base): pass And still have a playbook like this function: --- - hosts: tasks: - command: whoami check_mode: True (The check_mode test that is added as a separate commit in this PR will let you test variations on this case). There's a few separate reasons that the code doesn't let us do this or a non-ugly workaround for this as written right now. The fix that jimi-c, sivel, and I talked about may let us do this or it may still require a workaround (but less ugly) (having one class that has the FieldAttributes with default values and one class that inherits from that but just overrides the FieldAttributes which now have defaults) * Revert "One to throw away" This reverts commit 23aa883cbed11429ef1be2a2d0ed18f83a3b8064. * Set FieldAttr defaults directly from CLIARGS * Remove dead code * Move timeout directly to PlayContext, it's never needed on Play * just for backwards compat, add a static version of BECOME_METHODS to constants * Make the become attr on the connection public, since it's used outside of the connection * Logic fix * Nuke connection testing if it supports specific become methods * Remove unused vars * Address rebase issues * Fix path encoding issue * Remove unused import * Various cleanups * Restore network_cli check in _low_level_execute_command * type improvements for cliargs_deferred_get and swap shallowcopy to default to False * minor cleanups * Allow the su plugin to work, since it doesn't define a prompt the same way * Fix up ksu become plugin * Only set prompt if build_become_command was called * Add helper to assist connection plugins in knowing they need to wait for a prompt * Fix tests and code expectations * Doc updates * Various additional minor cleanups * Make doas functional * Don't change connection signature, load become plugin from TaskExecutor * Remove unused imports * Add comment about setting the become plugin on the playcontext * Fix up tests for recent changes * Support 'Password:' natively for the doas plugin * Make default prompts raw * wording cleanups. ci_complete * Remove unrelated changes * Address spelling mistake * Restore removed test, and udpate to use new functionality * Add changelog fragment * Don't hard fail in set_attributes_from_cli on missing CLI keys * Remove unrelated change to loader * Remove internal deprecated FieldAttributes now * Emit deprecation warnings now	7 years ago
Sam Doran	9d4c0dc111	Catch sshpass authentication errors and don't retry multiple times to prevent account lockout (#50776) ... * Catch SSH authentication errors and don't retry multiple times to prevent account lock out Signed-off-by: Sam Doran <sdoran@redhat.com> * Subclass AnsibleAuthenticationFailure from AnsibleConnectionFailure Use comparison rather than range() because it's much more efficient. Signed-off-by: Sam Doran <sdoran@redhat.com> * Add tests Signed-off-by: Sam Doran <sdoran@redhat.com> * Make paramiko_ssh connection plugin behave the same way Signed-off-by: Sam Doran <sdoran@redhat.com> * Add changelog Signed-off-by: Sam Doran <sdoran@redhat.com>	7 years ago
Matt Clay	3033fd96b0	Move unit test compat code out of `lib/ansible/`. (#46996) ... * Move ansible.compat.tests to test/units/compat/. * Fix unit test references to ansible.compat.tests. * Move builtins compat to separate file. * Fix classification of test/units/compat/ dir.	8 years ago
Brian Coca	4aac0f5f18	allow configuring sftp/scp executables (#36648) ... * allow configuring sftp/scp executables fixes #36616 also removed dupe test	8 years ago
Matt Martz	29c1d5cb5d	Ensure that the become password is written on py3 in the ssh connection plugin. Fixes #34727	8 years ago
jctanner	218987eac1	ANSIBLE_SSH_USETTY configuration option (#33148) ... * Allow the user to circumvent adding -tt on ssh commands to help aid in debugging ssh related problems. * Move config to the plugin * Set version_added * Change yaml section to "connection" * Fix ssh unit tests	9 years ago
Toshio Kuratomi	3edac559d3	the smart transport is broken by ssh retry code ... 1fe67f9 introduced retries to the ssh connection put file and fetch file. Unfortunately, that change broke the smart transport because it started raising exceptions instead of returning from _run(). This breakage is documented in #23711. An attempt to fix it was made at #23717 but the first attempt was objected to as needing to touch too much code. The second attmept was objected to as smart was forced to encapsulate retries (thus retrying a sftp "rety" times before trying scp "retry" times and then finally moving onto piped). This third attempt has retries encapsulate smart. So each sub-transport is tried once and if all three fail, another retry attempt is made which tries each of the three again. Fixes #23711 Fixes #23717	9 years ago
Gabor Lekeny	7eab802669	SSH fails with '"parsed": false' error message ... Fixes: #15436	9 years ago
Dag Wieers	4efec414e7	test/: PEP8 compliancy (#24803) ... * test/: PEP8 compliancy - Make PEP8 compliant * Python3 chokes on casting int to bytes (#24952) But if we tell the formatter that the var is a number, it works	9 years ago
Strahinja Kustudić	9f0be5a556	Ignores ControlPersist broken pipe errors. Fixes #16731 ... Ansible will now automatically retry a connection if SSH returns an error: mux_client_hello_exchange: write packet: Broken pipe This is probably a bug in SSH, but because it's safe to retry this connection there is no need for Ansible to fail because of it.	9 years ago
Toshio Kuratomi	2fff690caa	Update module_utils.six to latest (#22855) ... * Update module_utils.six to latest We've been held back on the version of six we could use on the module side to 1.4.x because of python-2.4 compatibility. Now that our minimum is Python-2.6, we can update to the latest version of six in module_utils and get rid of the second copy in lib/ansible/compat.	9 years ago
Matt Martz	d34153a61e	Re-enable ssh retry tests with isolation fixes (#22221) ... * Re-enable ssh retry tests with isolation fixes * Don't use mock, use monkeypatch instead	9 years ago
Matt Clay	30b6ed8377	Disable failing tests until they can be fixed.	9 years ago
Matt Martz	1fe67f9f43	Extend SSH Retry to put_file and fetch_file (#20187) ... * Move retry logic into _ssh_retry decorator, and apply to exec_command, put_file and fetch_file * Update tests to reflect change * Move _ssh_retry to _run, and update tests to reflect * piped should use exec_command instead of removed _exec_command * Rework tests to support selectors instead of select.select	9 years ago
Matt Clay	a5e3d13adc	Remove shebangs from unit tests.	9 years ago
Toshio Kuratomi	d1a6b07fe1	Move ssh and local connection plugins from using raw select to selectors ... At the moment, this change will use EPoll on Linux, KQueue on *BSDs, etc, so it should alleviate problems with too many open file descriptors. * Bundle a copy of selectors2 so that we have the selectors API everywhere. * Add licensing information to selectors2 file so it's clear what the licensing terms and conditions are. * Exclude the bundled copy of selectors2 from our boilerplate code-smell test * Rewrite ssh_run tests to attempt to work around problem with mocking select on shippable Fixes #14143	9 years ago
Toshio Kuratomi	ed00741a01	Mcsalgado's change to use shlex.quote instead of pipes.quote (#18534) ... * Replace pipes.quote for shlex_quote * More migration of pipes.quote to shlex_quote Note that we cannot yet move module code over. Modules have six-1.4 bundled which does not have shlex_quote. This shouldn't be a problem as the function is still importable from pipes.quote. It's just that this has become an implementation detail that makes us want to import from shlex instead. Once we get rid of the python2.4 dependency we can update to a newer version of bundled six module-side and then we're free to use shlex_quote everywhere.	10 years ago
Matt Clay	ac8842eee8	Fix unit test dirs to match code under test.	10 years ago