ansible

Commit Graph

Author	SHA1	Message	Date
Ruairidh MacLeod	d101009688	facts - set correct OS family for Rocky Linux (#74530 )	5 years ago
Abhijeet Kasurde	3811fddede	Amazon: Fix distribution facts for older release Ansible can gather distribution facts for older Amazon Linux with /etc/os-release data. Fixes: #73946 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	5 years ago
Abhijeet Kasurde	fb66b4ffbc	distribution: Add Amazon Linux distribution facts (#73767 ) * Update Amazon Linux Distribution facts gathering logic * Update tests Fixes: #73742 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	5 years ago
Sam Doran	2f5c83dfb1	Add AlmaLinux to the family of Red Hat-like operating systems (#73541 ) * Add changelog and fixtures for AlmaLinux support Co-authored-by: Christoph Schug <com+github@schug.net>	5 years ago
Alexander Sowitzki	218f5c3648	user - Prevent user fact lookup failure if LOGNAME is set (#17029 ) (#73439 ) The `UserFactCollector` queries the user login name via `getpass.getuser()` and looks up the corresponding entry in the password database. The login name may differ from the actual user name, eg. if the `LOGNAME` env variable is set. The lookup fails in this case. Added a fallback in this case that tries to get the entry via the user ID.	5 years ago
Rick Elrod	7f0eb7ad79	[facts] Differentiate CentOS vs CentOS Stream (#73034 ) Change: - On CentOS Stream, make distribution_release be "Stream" - On CentOS Core, it continues to be "Core" - Implement custom distribution file parser for CentOS, so we can look for "CentOS Linux" and "CentOS Stream" - Two new fixtures introduced (CentOS Linux 8.1 and CentOS Stream 8) - Removed two dicts from `Distribution` class that were seemingly not used anywhere. Test Plan: - ci_complete - New test fixtures Tickets: - Fixes #73027 Signed-off-by: Rick Elrod <rick@elrod.me>	5 years ago
Rick Elrod	20509b6507	[facts] fix version facts on FreeBSD RC/PRERELEASE (#73020 ) Change: - The FreeBSD release can contain -RC or -PRERELEASE in addition to -RELEASE, -STABLE, or -CURRENT. Test Plan: - Added new fixed from an RC version of TrueNAS which uses a -PRERELEASE version of FreeBSD. Tickets: - Fixes #72331 Signed-off-by: Rick Elrod <rick@elrod.me>	5 years ago
Abhijeet Kasurde	a223ea5185	distribution - handle NetBSD OS Family (#70799 ) Fixes: #43739 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	6 years ago
Christian Loos	ea119d3089	fix distribution fact for SLES4SAP (#71559 ) `b6b238a` fixed the SLES4SAP detection, which was at this time ok. Sadly Suse changed with SLES 15 the /etc/os-release file, so the above change will no longer work. This commit updates the SLES4SAP detection regarding https://www.suse.com/support/kb/doc/?id=000019341. The symlink realpath is matched with endswith, because in SLES 12+ the link target is SLES_SAP.prod, but in SLES 11 the link target is SUSE_SLES_SAP.prod.	6 years ago
Abhijeet Kasurde	173091e2e3	distro: Add support for Pardus distribution (#71663 ) Fixes: #71636 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	6 years ago
Abhijeet Kasurde	4f96f9826c	distribution: Add support for DragonFly (#70748 ) partially fixes #43739 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	6 years ago
Eduard Rozenberg	566c5e6ce1	Handle Slackware OS version strings containing a plus (“+”) (#68142 ) A couple of years ago Slackware -current began using a plus (“+”) at the end of the distribution version string to indicate a future version work-in-progress. Rearrange distribution_files unit tests to easily support more tests - add conftest with common fixtures - use parametrize for testing multiple scenarios * Add changelog * Add unit tests for Slackware distribution parsing * Use correct fixtures for Slackware Data comes from /etc/slackware-version Co-authored-by: Sam Doran <sdoran@redhat.com> Co-authored-by: <Eduard Rozenberg <eduardr@pobox.com>>	6 years ago
s-hamann	e39a9bf583	Add support for Parrot Linux, a Debian derivate (#69158 ) Co-authored-by: black <invalid>	6 years ago
Matt Clay	98a0995fd0	Clean up unit test boilerplate.	6 years ago
Dongsu Park	598e3392a9	Discover Flatcar Linux properly for hostname (#69627 ) To avoid issues with Flatcar Container Linux being unable to be found, detect Flatcar distro name especially for hostname, just like CoreOS Container Linux was supported. See also https://github.com/ansible/ansible/issues/69516	6 years ago
Abhijeet Kasurde	7b3d9cbcb8	distribution: Added support for openEuler OS (#69324 ) Detect os_family for openEuler OS as 'RedHat', instead of 'openEuler'. Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	6 years ago
Abhijeet Kasurde	564907d8ac	distribution: Refactor test_distribution_version testcases (#69300 )	6 years ago
Sam Doran	1d91e03119	Ensure Clear Linux parsing is actually parsing a Clear Linux host and all others fall back to NA (#53298 ) Fixes a bug where parse_distribution_file_ClearLinux() was called on CoreOS (and probably many other distros) and it returned True since it successfully parses the distribution file. Since this file exists on many Linux distributions and they are a very similar format, add an additional check to make sure it is Clear Linux. Change the order in which distribution files are processed so NA is last. This prevents a match on CoreOS hosts since they also have /etc/os-release and the called matching function for NA is very general and will match CoreOS. * Add changelog * Add unit tests Only add tests for Clear Linux parsing since that was the cause of this issue.	7 years ago
Abhijeet Kasurde	57d85031d7	Parse multiple values for single key in cmdline facts (#49591 ) * Facts parsing for cmdline can now handle multiple values for a single key. * Unit tests for cmdline fact parsing * Review comments Fixes: #22766 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	7 years ago
Roberto Polli	caa0c9d4cc	Fixes #25725 : strip quotes from lsb_release and distribution description. (#31143 )	7 years ago
Matt Clay	3033fd96b0	Move unit test compat code out of `lib/ansible/`. (#46996 ) * Move ansible.compat.tests to test/units/compat/. * Fix unit test references to ansible.compat.tests. * Move builtins compat to separate file. * Fix classification of test/units/compat/ dir.	8 years ago
Adrian Likins	45a9f96774	Facts Refresh (2.4 roadmap) (#23012 ) Facts Refresh (2.4 roadmap) This commit implements most of the 2.4 roadmap 'Facts Refresh' - move facts.py to facts/__init__.py - move facts Distribution() to its own class - add a facts/utils.py - move get_file_content and get_uname_version to facts/utils.py - move Facts() class from facts/__init__ to facts/facts.py - mv get_file_lines to facts/utils.py - mv Ohai()/Facter() class to facts/ohai.py and facter.py - Start moving fact Hardware() classes to facts/hardware/.py - mv HPUX() hardware class to facts/hardware/hpux.py - move SunOSHardware() fact class to facts/hardware/sunos.py - move OpenBSDHardware() class to facts/hardware/openbsd.py - mv FreeBsdHardware() and DragonFlyHardware() to facts/hardware/ - mv NetBSDHardware() to facts/hardware/netbsd.py - mv Darwin() hardware class to facts/hardware/darwin.py - pep8/etc cleanups on facts/hardware/.py - Mv network facts classes to facts/network/.py - mv Virtual fact classes to facts/virtual - mv Hardware.get_sysctl to facts/sysctl.py:get_sysctl - Also mv get_uname_version from facts/utils.py -> distribution.py since distribution.py is the only thing using it. - add collector.py with new BaseFactCollector - add a subclass for AnsibleFactCollector - hook up dict key munging FactNamespaces - add some test cases for testing the names of facts - mv timeout stuff to facts.timeout - rm ansible_facts()/get_all_facts() etc - Instead of calling facts.ansible_facts(), fact collection api used by setup.py is now to create an AnsibleFactCollector() and call it's collect method. - replace Facts.get_user_facts with UserFactCollector - add a 'systems' facts package, mv UserFactCollector there - mv get_dns_facts to DnsFactCollector - mv get_env_facts to EnvFactCollector - include the timeout length in exception message - modules and module_utils that use AnsibleFactCollector can now theoretically set the 'valid_subsets' May be useful for network facts module that currently have to reimplement a good chunk of facts.py to get gather_subsets to work. - get_local_facts -> system/LocalFactCollector - get_date_time -> system/date_time.py - get_fips_facts -> system/fips.py - get_caps_facts() -> system/caps.py - get_apparmor_facts -> system/apparmor.py - get_selinux_facts -> system/selinux.py - get_lsb_facts -> system/lsb.py - get_service_mgr_facts -> system/service_mgr.py - Facts.is_systemd_managed -> system/service_mgr.py - get_pkg_mgr_facts -> system/pkg_mgr.py - Facts()._get_mount_size_facts() -> facts.utils.get_mount_size() - add unit test for EnvFactCollector - add a test case for minimal gather_subsets - add test case for collect_ids - Make gather_subset match existing behavior or '!all' If 'gather_subset' is provided as '!all', the existing behavior (in 2.2/2.3) is that means 'dont collect any facts except those from the Facts() class'. So 'skip everything except 'apparmor', 'caps', 'date_time', 'env', 'fips', 'local', 'lsb', 'pkg_mgr', 'python', 'selinux', 'service_mgr', 'user', 'platform', etc. The new facts setup was making '!all' mean no facts at all, since it can add/exclude at a finer granularity. Since that makes more sense for the ansible collector, and the set of minimal facts to collect is really more up to setup.py to decide we do just that. So if setup.py needs to always collect some gather_subset, even on !all, setup.py needs to have the that subset added to the list it passes as minimal_gather_subset. This should fix some intg tests that assume '!all' means that some facts are still collected (user info and env for example). If we want to make setup.py collect a more minimal set, we can do that. - force facts_dicts.keys() to a list so py3 works - split fact collector tests to test_collectors.py - convert Facter(Facts) -> other/facter.py:FacterFactCollector - add FactCollector.collect_with_namespace() regular .collect() will return a dict with the key names using the base names ('ip_address', 'service_mgr' etc) .collect_with_namespace() will return a dict where the key names have been transformed with the collectors namespace, if there is one. For most, this means a namespace that adds 'ansible_' to the start of the key name. For 'FacterFactCollector', the namespace transforms the key to 'facter_'. - add test cases for collect_with_namespace - move all the concrete 'which facts does setup.py' stuff to setup.py The caller of AnsibleFactCollector.from_gather_subset() needs to pass in the list of collector classes now. - update system/setup.py to import all of the fact classes and pass in that list. - split the Distribution fact class up a bit extracted the 'distro release' file handling (ie, linux boxes with /etc/release, /etc/os-release etc) into its own class. - extract get_cmdline_facts -> cmdline.py - extract get_public_ssh_host_keys -> system/ssh_pub_keys.py - extract get_platform_facts -> system/platform.py platform.py may be a good candidate for further splitting. - rm test for plain Facts() base class - let the base class for Collector unit tests provide collected_facts some Collectors and/or their migrated Facts() subsclasses need to look at facts collected by other modules ('ansible_architecture' the main one...). Collector.collect() has the collected_facts arg for this, so add a class variable to BaseFactsTest so we can specify it. - mv Ohai to other/ohai.py and convert to Collector - update hardware/.py to return facts (no side effects) - mv AnsibleFactCollector to setup.py - extra collector class gathering to module method in facts/__init__.py (collector_classes_from_gather_subset) - add a CollectorMetaDataCollector collector used to provide the 'gather_setup' fact - add unit test module for 'setup' module (test/units/modules/system/setup.py) - Collector init now doesnt need a module, but collect does An instance of a FactCollector() isnt tied to a AnsibleModule instance, but the collect() method can be, so optionally pass in module to FactCollector.collect() (everywhere) - add a default_collectors for list of default collectors import and use it from setup.py module eventually, would like to replace this with a plugin loader style class finder/loader - unit tests for module_utils/facts/__init__.py - add unit tests for ohai facts collector - remove self.facts side effect on populate() in hardware/sunos.py - convert OpenBSDHardware() to rm side effects on self.facts - try to rm some self.facts side effects in Network() plumb in collected_facts from populate() where it is needed. stop passing collected_facts into Network() [via cached_facts=, where it eventually becomes self.facts] - nothing provides Fact() cached_facts arg now, rm it Facts() should be internal only implementation so nothing should be using it. Of course, now someone will. - add a Collector.name attr to build a map of name->_fact_ids To properly exclude a gather_subset spec like '!hardware', we need to know that 'hardware' also means 'devices', 'dmi', etc. Before, '!hardware' would remove the 'hardware' collector name but not 'devices'. Since both would end up in id_collector_map, we would still end up with the HardwareCollector in the collector list. End result being that '!hardware' wouldn't stop hardware from being collected. So we need to be able to build that map, so add the Collector.name attribute that is the primary name (like 'hardware') and let Collector._fact_ids be the other fact ids that a collector is responsible for. Construct the aliases_map of Collector.name -> set of _fact_ids in fact/__init__.py get_collector_names, and use it when we are populating the exclude set. - refactor of distribution.py make the big OS_FAMILY literal a little easier to read Also keys can now be any string instead of python literals 99% sure the test for 'KDE Neon' was wrong I don't see how/where it should or could get 'Neon' instead of 'KDE Neon' as provided in os-release NAME= Use 'distribution' string for key to OS_MAP ie, we dont need to make it a valid python label anymore so dont. move _has_dist_file to module as _file_exists easier to mock without mucking with os.path mv platform.system() calls to within get_distribution_facts() instead of Distribution() init. - remove _json compat module The code in here was to support: -a 'json' python module that was not the standard one included with python since 2.6. - potentially fallback to simplejson if 'json' was not available. 'json' is available for all supported python versions now so no longer needed. - mv get_collector_names -> facts.collector - mv collector_classes_from_gather_subset -> facts.collector - mv collector tests from test_facts -> test_collector - Use six's reduce() in sunos/netbsd hardware facts - rm extraneous get_uname_version in utils only system/distribution.py uses it - Remove Facts() subclass metaclass usage - using fact_id and a platform id for matching collectors gut most of Facts() subclasses rm Facts() subclasses with weird metaclass only add collectors that match the fact_ids and the platform_info to the list of collectors used. atm, a collectors platform_id will default to 'Generic', and any platform matches 'Generic' goal is to select collector classes including matching the systems platform in collector.py, instead of relying on metaclasses in hardware/. To finish this, the various Facts() subclasses will need to be replaced entirely with Collector() subclasses. use collector classmethod platform_match() to match the platform This lets the particular class decide if it is compatible with a given platform_info. platform_info is a dict like obj, so it could be expanded in the future. Add a default platform_match to BaseFactCollector that matches platform_info['system'] == cls._platform They were needed previously to trigger a module load on all the collector classes when we import facts/hardare so that the Hardware() and related classes that used __new__ and find_all_subclasses() would work. Now that is done in collectors based on platform matching at runtime we dont need to do it py module import/parse time. So the non empty __init__.pys are no longer needed and their is a more flexible mechanism for selection platform specific stuff. facts/facts.py is no longer used, rm'ed - if we dont find an implement class for gather spec.. just ignore it. Would be useful to add a warn to warn about this case. - Fix SD-UX typo (should be HP-UX) - Port fix for #21893 (0 sockets) to this branch This readds the change from `8ad182059d` that got lost in merge/rebase Fixes #21893 - port sunos fact locale fix for #24542 to this branch based on `e558ec19cd` Fixes #24542 Solaris fact fix (#24793) ensure locale for solaris fact gathering fixes issue with locale interfering with proper reading of decimals - raise exceptions in the air like we just dont care. Pretty much ignore any not exit exception in facts collection. And add some test cases. - added new selinux fact to clarify python lib the selinux fact is boolean false when the library is not installed, a dictionary/hash otherwise, but this is ambigous added new fact so we can eventually remove the type dichtomy and normalize it as a dict Re-add of devel commit `85c7a7b844` to the new code layout, since it got removed in merge/rebase	9 years ago

22 Commits (dcd31da01a118774544efbb36bb6600a33f99ca4)