7 Commits (c33b02f71a2fc4aa2c19cdf3249b3fe5329cecb7)

Author	SHA1	Message	Date
Adrian Likins	a57d6a4206	Use pop in cb clean results (#33779) ... * Fix _clean_result for debug callback with 1 char var names The check in _clean_results was removing any keys that happened to be one of the chars in ('invocation') instead of the string 'invocation'. This was meant to be a tuple but there was no comma so the for iterated the string instead of the tuple. Introduced in 9dba580204 Update unit test to catch this. Fixes #33723 * Use .pop() to remove invocation from results dict In base callback _clean_results, simplify the way the 'invocation' item is removed. Add some more unit tests.	9 years ago
Brian Coca	01b6c7c9c6	better cleanup on task results display (#27175) ... * better cleanup on task results display callbacks get 'clean' copy of result objects moved cleanup into result object itself removed now redundant callback cleanup moved no_log tests * moved import as per feedback	9 years ago
Brian Coca	6ca5fb49c3	allow debug to be 'changed' (#20957) ... * allow debug to be 'changed' fixes #14430 * removed test that checked against this	10 years ago
Marius Gedminas	0a7f2c202b	Improve --diff output when files lack trailing newlines ... The behavior now matches GNU diff. Fixes #14094. Example of output before this change: TASK [healthchecks.io : hourly healthchecks.io ping] *************************** changed: [ranka] --- before: /etc/cron.hourly/mg-healthchecks-dot-io +++ after: /tmp/tmpOTvXTw @@ -1,2 +1,2 @@ #!/bin/sh -curl -sS https://hchk.io/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx > /dev/null+curl -sS https://hchk.io/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx > /dev/null after this change: TASK [healthchecks.io : hourly healthchecks.io ping] *************************** changed: [ranka] --- before: /etc/cron.hourly/mg-healthchecks-dot-io +++ after: /tmp/tmpOTvXTw @@ -1,2 +1,2 @@ #!/bin/sh -curl -sS https://hchk.io/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx > /dev/null \ No newline at end of file +curl -sS https://hchk.io/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx > /dev/null The added unit tests contain more examples. This commit also takes care to avoid "no newline at EOF" warnings when no_log is in effect, and also when modules return dicts rather than strings. (It also removes trailing whitespace from using json serialization when diffing dicts, because I hate trailing whitespace in Python source files, even if they're test files.)	10 years ago
Adrian Likins	f0c71ad68d	More test coverage for plugins/callback/__init__ (#18020)	10 years ago
Adrian Likins	c0331d50dc	Remove callback.CallbackBase._copy_result_exclude ... Nothing seems to use this now. Was added originally added in2d11cfab92f9d26448461b4bc81f466d1910a15e but the code that used it was removed in e02b98274b	10 years ago
James Cammarata	2d11cfab92	Squashed commit of the following: ... commit 24efa310b58c431b4d888a6315d1285da918f670 Author: James Cammarata <jimi@sngx.net> Date: Tue Dec 29 11:23:52 2015 -0500 Adding an additional test for copy exclusion Adds a negative test for the situation when an exclusion doesn't exist in the target to be copied. commit 643ba054877cf042177d65e6e2958178bdd2fe88 Merge: e6ee59f 66a8f7e Author: James Cammarata <jimi@sngx.net> Date: Tue Dec 29 10:59:18 2015 -0500 Merge branch 'speedup' of https://github.com/chrismeyersfsu/ansible into chrismeyersfsu-speedup commit 66a8f7e873 Author: Chris Meyers <chris.meyers.fsu@gmail.com> Date: Mon Dec 28 09:47:00 2015 -0500 better api and tests added * _copy_results = deepcopy for better performance * _copy_results_exclude to deepcopy but exclude certain fields. Pop fields that do not need to be deep copied. Re-assign popped fields after deep copy so we don't modify the original, to be copied, object. * _copy_results_exclude unit tests commit 93490960ff Author: Chris Meyers <chris.meyers.fsu@gmail.com> Date: Fri Dec 25 23:17:26 2015 -0600 remove uneeded deepcopy fields	11 years ago