ansible

Commit Graph

Author	SHA1	Message	Date
Rick Elrod	ed37efb217	"Fix" test_get_bin_path by changing mock order (#67730 ) pytest-mock 2.0.0, when run locally, gets grumpy when os.path.exists is messed with and then another method is patched afterwards. Likely something in the pytest-mock chain uses os.path.exists internally, and since pytest-mock prohibits context-specific patching, there's not a good solution. For now, just patch os.path.exists last. Signed-off-by: Rick Elrod <rick@elrod.me>	6 years ago
Sam Doran	5112feeace	Make get_bin_path() always raise an exception (#56813 ) This makes it behave in a more idiomatic way * Fix bug in Darwin facts for free memory If the vm_stat command is not found, fact gathering would fail with an unhelpful error message. Handle this gracefully and return a default value for free memory. * Add unit tests	6 years ago

Author

SHA1

Message

Date

Rick Elrod

ed37efb217

"Fix" test_get_bin_path by changing mock order (#67730 )

pytest-mock 2.0.0, when run locally, gets grumpy when os.path.exists is
messed with and then another method is patched afterwards. Likely
something in the pytest-mock chain uses os.path.exists internally, and
since pytest-mock prohibits context-specific patching, there's not a
good solution. For now, just patch os.path.exists last.

Signed-off-by: Rick Elrod <rick@elrod.me>

Sam Doran

5112feeace

Make get_bin_path() always raise an exception (#56813 )

This makes it behave in a more idiomatic way

* Fix bug in Darwin facts for free memory
    If the vm_stat command is not found, fact gathering would fail with an unhelpful 
    error message. Handle this gracefully and return a default value for free memory.

* Add unit tests

2 Commits (bae5f18f5cd8d4e896df1c321e5c0d2e81cceca6)