ansible

Commit Graph

Author	SHA1	Message	Date
Ganesh Nalawade	17fea30841	Revert "enhance recv calls in network_cli (#47345 )" (#47731 ) This reverts commit `c649d0ea32`. The change results in deadlock in network_cli while it is waiting to check the return value of recv_ready() which was added in this commit to improve performance	8 years ago
f-bor	c649d0ea32	enhance recv calls in network_cli (#47345 ) * enhance recv calls in network_cli * updated network_cli test unit * enhance recv calls in network_cli * fix mistake * better timeout management * remove exception trigger * test * test2 * restore exception and timeout * ganeshrn's way * correction * timeout and exception return	8 years ago
Ganesh Nalawade	335a979f1d	Fix prompt mismatch issue for ios (#47004 ) * Fix prompt mismatch issue for ios Fixes #40884 #44463 * If the command prompt is matched check if data is still pending to be read from buffer. * This fix adds a new timer `buffer_read_timeout` which will be trigerred after command prompt is matched and data is attempted to be read from channel. If not data is present of channel the timer will expire and response we be returned to calling function. * Fix unit test failure * Update to make buffer timeout float * Update doc and fix review comment * Fix CI issues * Update doc * Fix review comments * Fix review comments	8 years ago
Matt Clay	3033fd96b0	Move unit test compat code out of `lib/ansible/`. (#46996 ) * Move ansible.compat.tests to test/units/compat/. * Fix unit test references to ansible.compat.tests. * Move builtins compat to separate file. * Fix classification of test/units/compat/ dir.	8 years ago
Nathaniel Case	406b59aeba	Move persistent connections to only use registered variables (#45616 ) * Try to intuit proper plugins to send to ansible-connection * Move sub-plugins to init so that vars will be populated in executor * Fix connection unit tests	8 years ago
Nathaniel Case	5850591d14	Base connection class for network-style connections (#41839 ) * Create base class for network-style connections * clean up some differences * Move NetworkConnectionBase * Tweak netconf for tests * Tweak when network_os is checked to avoid failing tests * Pull back exec_command	8 years ago
Ricardo Carrillo Cruz	62e1c14edc	Pull persistent connection parameters via get_option (#39367 ) * WIP Pull persistent connection parameters via get_option * Fix pep8 * Add use_persistent_connection setting to paramiko_ssh plugin * Add vars section to persistent_command_timeout setting and prevail provider values over config manager * Use persistent_command_timeout on network_cli instead of timeout * Fix unit tests If we don't call loader to get network_cli, then _load_name is never set and we get KeyError. * Pull persistent_command_timeout via config manager for ios connection local * Pull persistent_command_timeout via config manager on connection local	8 years ago
Nathaniel Case	594840c1d6	Close & remove paramiko connection where appropriate (#37528 ) * Close & remove paramiko connection where appropriate * Update unit test	8 years ago
Nathaniel Case	a1da3dc997	Auth to become (#33319 ) * terminal.on_(de)?authorize -> terminal.on_(un)?become * Update network_cli * Readd on_(de)?authorize as wrappers * Update tests	9 years ago
Brian Coca	23b1dbacaf	Config continued (#31024 ) * included inventory and callback in new config allow inventory to be configurable updated connection options settings also updated winrm to work with new configs removed now obsolete set_host_overrides added notes for future bcoca, current one is just punting, it's future's problem updated docs per feedback added remove group/host methods to inv data moved fact cache from data to constructed cleaner/better options fix when vars are added extended ignore list to config dicts updated paramiko connection docs removed options from base that paramiko already handles left the look option as it is used by other plugin types resolve delegation updated cache doc options fixed test_script better fragment merge for options fixed proxy command restore ini for proxy normalized options moved pipelining to class updates for host_key_checking restructured mixins * fix typo	9 years ago
Nathaniel Case	9c0275a879	Connection plugins network_cli and netconf (#32521 ) * implements jsonrpc message passing for ansible-connection * implements more generic mechanism for persistent connections * starts persistent connection in task_executor if enabled and supported * supports using network_cli as top level connection plugin * enhances logging for persistent connection to stdout * Update action plugins * Fix Python3 RPC * Fix Junos bytes<-->str issues * supports using netconf as top level connection plugin * Error message when running netconf on an unsupported platform * Update tests * Fix `authorize: yes` for `connection: local` * Handle potentially JSON data in terminal * Add clarifying detail if possible on ConnectionError	9 years ago
Ganesh Nalawade	6215922889	Add support for cliconf and netconf plugin (#25093 ) * ansible-connection refactor and action plugin changes * Add cliconf plugin for eos, ios, iosxr, junos, nxos, vyos * Add netconf plugin for junos * Add jsonrpc support * Modify network_cli and netconf connection plugin * Fix py3 unit test failure * Fix review comment * Minor fixes * Fix ansible-connection review comments * Fix CI issue * platform_agnostic related changes	9 years ago
Dag Wieers	4efec414e7	test/: PEP8 compliancy (#24803 ) * test/: PEP8 compliancy - Make PEP8 compliant * Python3 chokes on casting int to bytes (#24952) But if we tell the formatter that the var is a number, it works	9 years ago
Ganesh Nalawade	825d9df5ea	Add eos changes for Python3 (#24600 ) * eos python3 changes * changes to convert response from byte to text * Add dellos6 python3 changes Make `execute_command` arguments and its return value complaint to PY3 changes made in PR #24431 * Fix py3 prompt issue for invalid show command * Fix review comments * Add generic fix for error prompt in py3 * Fix CI issue * Fix network_cli unit test failure	9 years ago
Toshio Kuratomi	d834412ead	Fix for persistent connection plugin on Python3 (#24431 ) Fix for persistent connection plugin on Python3. Note that fixes are also needed to each terminal plugin. This PR only fixes the ios terminal (as proof that this approach is workable.) Future PRs can address the other terminal types. * On Python3, pickle needs to work with byte strings, not text strings. * Set the pickle protocol version to 0 because we're using a pty to feed data to the connection plugin. A pty can't have control characters. So we have to send ascii only. That means only using protocol=0 for pickling the data. * ansible-connection isn't being used with py3 in the bug but it needs several changes to work with python3. * In python3, closing the pty too early causes no data to be sent. So leave stdin open until after we finish with the ansible-connection process. * Fix typo using traceback.format_exc() * Cleanup unnecessary StringIO, BytesIO, and to_bytes calls * Modify the network_cli and terminal plugins for py3 compat. Lots of mixing of text and byte strings that needs to be straightened out to be compatible with python3 * Documentation for the bytes<=>text strategy for terminal plugins * Update unittests for more bytes-oriented internals Fixes #24355	9 years ago
Peter Sprygada	e4a2c804be	partial revert of changes introduced in `d5f7a0181b` (#21688 )	9 years ago
Peter Sprygada	d5f7a0181b	roll up of eos fixes (#21629 ) * fixes error where eos would close the cli shell * fixes network_cli connection plugin to check before calling open_shell() * fixes json commands being sent over eapi	9 years ago
Peter Sprygada	a6cecef6bc	clean up of terminal plugins (#21549 ) * removes unneeded supports_multiplexing var * refactors terminal_prompts_re to terminal_stdout_re * refactors terminal_errors_re to terminal_stderr_re * updates network_cli unit test cases	9 years ago
Peter Sprygada	dc23667cc2	add back reverted change to network_cli (#18761 ) This adds back the change to the network_cli plugin. Ths change adds the ensure_connect decorator to the open_shell() method to make sure the connection is valid before trying to open a shell. The issue was due to the addition of the decorator that will call _connect() when there is no connection. The _connect() method should have been mocked in the test case. This commit fixes the test case as well Change was originally reverted in `c414ded69a`	10 years ago
Peter Sprygada	06f5bf980e	adds unit test for network_cli connection plugin (#18729 )	10 years ago

20 Commits (85689a3eec4e2f11c252bfbee4e3fdc9675a4c9d)