7 Commits (5cfdbd83151edd000e79edf550f0c5bc54aebd19)

Author	SHA1	Message	Date
Matt Martz	cab637a733	[stable-2.9] allow env to override unspecified unsafe_writes (#73282) (#75397) ... * [stable-2.9] allow env to override unspecified unsafe_writes (#73282) * allow env var for fallback value for unspecified unsafe_writes. (cherry picked from commit c7d4acc12f) Co-authored-by: Brian Coca <bcoca@users.noreply.github.com> * ensure unsafe writes fallback (#70722) * Ensure we actually fallback to unsafe_writes when set to true add integration test add fix for get_url not passing the parameter from args (cherry picked from commit 932ba36160) * Added clog missing for issue 70722 (#73175) (cherry picked from commit d6670da1d7) Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>	5 years ago
Sam Doran	ea8c219402	[stable-2.9] Revert "Change default file permissions so they are not world readable (#70221) (#70825)" (#71232) ... This reverts commit 0199b1cf05.	6 years ago
Sam Doran	0199b1cf05	[stable-2.9] Change default file permissions so they are not world readable (#70221) (#70825) ... * [stable-2.9] Change default file permissions so they are not world readable (#70221) * Change default file permissions so they are not world readable CVE-2020-1736 Set the default permissions for files we create with atomic_move() to 0o0660. Track which files we create that did not exist and warn if the module supports 'mode' and it was not specified and the module did not call set_mode_if_different(). This allows the user to take action and specify a mode rather than using the defaults. A code audit is needed to find all instances of modules that call atomic_move() but do not call set_mode_if_different(). The findings need to be documented in a changelog since we are not warning. Warning in those instances would be frustrating to the user since they have no way to change the module code. - use a set for storing list of created files - just check the argument spac and params rather than using another property - improve the warning message to include the default permissions. (cherry picked from commit 5260527c4a) Co-authored-by: Sam Doran <sdoran@redhat.com> * Fix jboss test * Fix lamdba_policy test * Fix aws_lamdba test * Fix warning for new default permissions when mode is not specified (#70976) Follow up to #70221 Related to #67794 CVE-2020-1736 When set_mode_if_different() is called with mode of 'None', ensure we issue a warning about the change in default permissions. Add integration tests to ensure the warning works properly. * Fix tests - actually use custom module 🤦‍♂️ - verify file permission on created files - use remote_tmp_dir so we're ready for split controller - improve test module so we can skip the call to set_fs_attributes_if_different() - fix tests for CentOS 6 (cherry-picked from commit dc79528cc6) * Use new category in changelog fragments	6 years ago
Matt Martz	697b566971	Update units to pass on macOS (#60435) ... * Update units to pass on macOS. Fixes #27810 * raising=False	7 years ago
Sam Doran	2a98faee2b	Move _handle_aliases() out of basic.py (#48578) ... Refinements: - return legal_inputs and update class properties - remove redundant arguments from method and handle in caller - add better exception types to method * Add unit tests for handle_aliases	7 years ago
Sviatoslav Sydorenko	f1e67c3328	Bugfix/ fix mocker patch in tests (#52372) ... * 🐛 Fix invalid os.stat mock in tests * 🐛 Fix leaking mock patch in tests Closes #52347	7 years ago
Toshio Kuratomi	370a7ace4b	Split basic units (#33510) ... Split the one monolithic test for basic.py into several files * Split test_basic.py along categories. This is preliminary to get a handle on things. Eventually we may want to further split it so each file is only testing a single function. * Cleanup unused imports from splitting test_basic.py * Port atomic_move test to pytest. Working on getting rid of need to maintain procenv * Split a test of symbolic_mode_to_octal to follow unittest best practices Each test should only invoke the function under test once * Port test_argument_spec to pytest. * Fix suboptions failure	9 years ago