10 Commits (stable-2.3)

Author	SHA1	Message	Date
Matt Martz	f0cae29d57	Ensure that the become password is written on py3 in the ssh connection plugin. Fixes #34727 ... (cherry picked from commit 29c1d5cb5d)	8 years ago
Toshio Kuratomi	78d153d5a0	the smart transport is broken by ssh retry code ... 1fe67f9 introduced retries to the ssh connection put file and fetch file. Unfortunately, that change broke the smart transport because it started raising exceptions instead of returning from _run(). This breakage is documented in #23711. An attempt to fix it was made at #23717 but the first attempt was objected to as needing to touch too much code. The second attmept was objected to as smart was forced to encapsulate retries (thus retrying a sftp "rety" times before trying scp "retry" times and then finally moving onto piped). This third attempt has retries encapsulate smart. So each sub-transport is tried once and if all three fail, another retry attempt is made which tries each of the three again. Fixes #23711 Fixes #23717 (cherry picked from commit 3edac559d3)	9 years ago
Strahinja Kustudić	701a47c850	Ignores ControlPersist broken pipe errors. Fixes #16731 ... Ansible will now automatically retry a connection if SSH returns an error: mux_client_hello_exchange: write packet: Broken pipe This is probably a bug in SSH, but because it's safe to retry this connection there is no need for Ansible to fail because of it. (cherry picked from commit 9f0be5a556)	9 years ago
Matt Martz	d34153a61e	Re-enable ssh retry tests with isolation fixes (#22221) ... * Re-enable ssh retry tests with isolation fixes * Don't use mock, use monkeypatch instead	9 years ago
Matt Clay	30b6ed8377	Disable failing tests until they can be fixed.	9 years ago
Matt Martz	1fe67f9f43	Extend SSH Retry to put_file and fetch_file (#20187) ... * Move retry logic into _ssh_retry decorator, and apply to exec_command, put_file and fetch_file * Update tests to reflect change * Move _ssh_retry to _run, and update tests to reflect * piped should use exec_command instead of removed _exec_command * Rework tests to support selectors instead of select.select	9 years ago
Matt Clay	a5e3d13adc	Remove shebangs from unit tests.	9 years ago
Toshio Kuratomi	d1a6b07fe1	Move ssh and local connection plugins from using raw select to selectors ... At the moment, this change will use EPoll on Linux, KQueue on *BSDs, etc, so it should alleviate problems with too many open file descriptors. * Bundle a copy of selectors2 so that we have the selectors API everywhere. * Add licensing information to selectors2 file so it's clear what the licensing terms and conditions are. * Exclude the bundled copy of selectors2 from our boilerplate code-smell test * Rewrite ssh_run tests to attempt to work around problem with mocking select on shippable Fixes #14143	9 years ago
Toshio Kuratomi	ed00741a01	Mcsalgado's change to use shlex.quote instead of pipes.quote (#18534) ... * Replace pipes.quote for shlex_quote * More migration of pipes.quote to shlex_quote Note that we cannot yet move module code over. Modules have six-1.4 bundled which does not have shlex_quote. This shouldn't be a problem as the function is still importable from pipes.quote. It's just that this has become an implementation detail that makes us want to import from shlex instead. Once we get rid of the python2.4 dependency we can update to a newer version of bundled six module-side and then we're free to use shlex_quote everywhere.	10 years ago
Matt Clay	ac8842eee8	Fix unit test dirs to match code under test.	10 years ago