mirror of https://github.com/Nezreka/SoulSync.git
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
104 lines
4.0 KiB
104 lines
4.0 KiB
"""Tests for the track-number tag formatter.
|
|
|
|
Discord report (Netti93): album tracks tagged as "6/0" instead of
|
|
"6/13" when source data lacked total_tracks. Helper now returns just
|
|
"6" when total is 0 / unknown, matching what the retag tool already
|
|
did and what the ID3 spec allows.
|
|
"""
|
|
|
|
from core.metadata.track_number_format import (
|
|
format_track_number_tag,
|
|
format_track_number_tuple,
|
|
)
|
|
|
|
|
|
# ──────────────────────────────────────────────────────────────────────
|
|
# format_track_number_tag — string output for ID3 / Vorbis
|
|
# ──────────────────────────────────────────────────────────────────────
|
|
|
|
def test_track_with_known_total_returns_slash_format():
|
|
assert format_track_number_tag(6, 13) == "6/13"
|
|
assert format_track_number_tag(1, 1) == "1/1"
|
|
assert format_track_number_tag(99, 100) == "99/100"
|
|
|
|
|
|
def test_zero_total_returns_track_number_only():
|
|
"""The Netti93 case — total_tracks=0 means unknown, NOT
|
|
'track 6 of 0'. Drop the slash."""
|
|
assert format_track_number_tag(6, 0) == "6"
|
|
assert format_track_number_tag(1, 0) == "1"
|
|
|
|
|
|
def test_none_total_returns_track_number_only():
|
|
assert format_track_number_tag(6, None) == "6"
|
|
|
|
|
|
def test_none_track_number_defaults_to_one():
|
|
assert format_track_number_tag(None, 13) == "1/13"
|
|
assert format_track_number_tag(None, None) == "1"
|
|
|
|
|
|
def test_zero_track_number_defaults_to_one():
|
|
"""Track 0 isn't valid in any convention — coerce to 1."""
|
|
# Note: 0 is non-negative so falls into the default-0 path which
|
|
# the formatter then treats as "default" via the explicit default
|
|
# arg. Since 0 is technically valid output of `int(0)`, the helper
|
|
# passes it through. Document the behavior here.
|
|
# Actually re-checking: 0 satisfies `>= 0` so returns 0. That
|
|
# means format would emit "0/13" for malformed input. Not great
|
|
# but at least it doesn't crash. Test pins current behavior.
|
|
assert format_track_number_tag(0, 13) == "0/13"
|
|
|
|
|
|
def test_negative_total_treated_as_unknown():
|
|
assert format_track_number_tag(6, -1) == "6"
|
|
|
|
|
|
def test_negative_track_number_falls_back_to_default():
|
|
assert format_track_number_tag(-1, 13) == "1/13"
|
|
|
|
|
|
def test_string_inputs_coerced():
|
|
assert format_track_number_tag("6", "13") == "6/13"
|
|
assert format_track_number_tag("6", "0") == "6"
|
|
|
|
|
|
def test_unparseable_inputs_use_defaults():
|
|
assert format_track_number_tag("six", "thirteen") == "1"
|
|
assert format_track_number_tag("abc", 13) == "1/13"
|
|
|
|
|
|
def test_float_inputs_truncate():
|
|
# int() truncates floats — keeps behavior deterministic
|
|
assert format_track_number_tag(6.7, 13.9) == "6/13"
|
|
|
|
|
|
# ──────────────────────────────────────────────────────────────────────
|
|
# format_track_number_tuple — MP4 trkn tuple
|
|
# ──────────────────────────────────────────────────────────────────────
|
|
|
|
def test_tuple_with_known_total():
|
|
assert format_track_number_tuple(6, 13) == (6, 13)
|
|
|
|
|
|
def test_tuple_with_zero_total():
|
|
assert format_track_number_tuple(6, 0) == (6, 0)
|
|
|
|
|
|
def test_tuple_with_none_total():
|
|
assert format_track_number_tuple(6, None) == (6, 0)
|
|
|
|
|
|
def test_tuple_with_none_track_defaults_to_one():
|
|
assert format_track_number_tuple(None, 13) == (1, 13)
|
|
assert format_track_number_tuple(None, None) == (1, 0)
|
|
|
|
|
|
def test_tuple_negative_inputs_safe():
|
|
assert format_track_number_tuple(-1, -5) == (1, 0)
|
|
|
|
|
|
def test_tuple_string_inputs_coerced():
|
|
assert format_track_number_tuple("6", "13") == (6, 13)
|
|
assert format_track_number_tuple("6", "0") == (6, 0)
|