You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Broque Thomas 01c528fd5f Reject AcoustID matches whose version disagrees with the expected track ... Discord report (corruption [BWC]): downloads coming through as the instrumental cut when a vocal track was requested. The verification step's `_normalize` function strips parentheticals and version-suffix tags ("(Instrumental)", "- Live", etc) so legitimate name variations don't false-fail the title-similarity check. That also means "In My Feelings" and "In My Feelings (Instrumental)" both normalize to "in my feelings", title similarity is 1.0, and the wrong cut passes verification. Detect the version label on each side BEFORE normalization runs. If the expected and matched recordings disagree on version (one is original, the other is instrumental / live / acoustic / remix / etc), return FAIL — the fingerprint identified a real song, just not the version the caller asked for. Reuses `MusicMatchingEngine.detect_version_type` so the same regex patterns the pre-download Soulseek matcher applies also drive post-download verification. No duplicated tables. Also gates the secondary fallback scan, so a wrong-version variant sitting in the same fingerprint cluster can't win the loop after the best match has already been version-rejected. 6 tests pin the behavior: - instrumental returned for vocal request → FAIL - vocal returned for instrumental request → FAIL - live vs acoustic → FAIL - matching versions on both sides → PASS - original-to-original happy path → PASS (regression guard) - secondary scan skips wrong-version recordings → not PASS 2194/2194 full suite green (was 2188 + 6 new).		3 weeks ago
..
artists	Surface silent exceptions in core/artists — 23 sites	3 weeks ago
automation	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
discovery	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
download_engine	Add module logger + surface silent exceptions in 7 logger-less files — 12 sites	3 weeks ago
download_plugins	Address Copilot doc-drift review	3 weeks ago
downloads	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
enrichment	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
imports	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
library	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
media_server	Final review-pass nits — class docstring, dead branch, dead imports, boot resilience	3 weeks ago
metadata	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
playlists	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
repair_jobs	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
search	Cin-6: Rename soulseek_client global → download_orchestrator	3 weeks ago
stats	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
streaming	Cin-6: Rename soulseek_client global → download_orchestrator	3 weeks ago
watchlist	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
wishlist	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
workers	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
acoustid_client.py	Clean up 286 ruff lint errors to unblock CI and fix 10 latent bugs	1 month ago
acoustid_verification.py	Reject AcoustID matches whose version disagrees with the expected track	3 weeks ago
album_consistency.py	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
api_call_tracker.py	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
artist_source_detail.py	Move metadata helpers into package modules	4 weeks ago
artist_source_lookup.py	Make artist_name Optional in find_library_artist_for_source	1 month ago
audiodb_client.py	…
audiodb_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
auto_import_worker.py	Surface silent exceptions in import pipeline — 11 sites	3 weeks ago
automation_engine.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
connection_detect.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
connection_test.py	Cin-6: Rename soulseek_client global → download_orchestrator	3 weeks ago
database_update_worker.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
debug_info.py	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
deezer_client.py	Surface silent exceptions in metadata clients — 37 sites	3 weeks ago
deezer_download_client.py	Surface silent exceptions in metadata clients — 37 sites	3 weeks ago
deezer_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
discogs_client.py	Surface silent exceptions in metadata clients — 37 sites	3 weeks ago
discogs_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
download_orchestrator.py	Lift shared download dataclasses + boot via singleton factory	3 weeks ago
genius_client.py	…
genius_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
genre_filter.py	Expand default genre whitelist from 223 to 272 genres	1 month ago
hifi_client.py	Surface engine-not-wired errors + exclude soulseek from monitor aggregation	3 weeks ago
hydrabase_client.py	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
hydrabase_worker.py	…
itunes_client.py	Surface silent exceptions in metadata clients — 37 sites	3 weeks ago
itunes_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
jellyfin_client.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
lastfm_client.py	Add Last.fm Track Radio to Discover page	1 month ago
lastfm_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
library_reorganize.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
lidarr_download_client.py	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
listenbrainz_client.py	…
listenbrainz_manager.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
listening_stats_worker.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
lyrics_client.py	…
matching_engine.py	Merge remote-tracking branch 'origin/dev' into refactor/media-server-engine	3 weeks ago
metadata_service.py	Move profile Spotify cache into registry	4 weeks ago
musicbrainz_client.py	MusicBrainz: Resolve release-group MBIDs to a release on album click	1 month ago
musicbrainz_search.py	MusicBrainz: Dedupe same-named homonyms in artist search results	1 month ago
musicbrainz_service.py	…
musicbrainz_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
navidrome_client.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
personalized_playlists.py	…
plex_client.py	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
qobuz_client.py	Address Copilot doc-drift review	3 weeks ago
qobuz_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
reorganize_queue.py	Reorganize queue: race + dedupe fixes from kettui review	1 month ago
reorganize_runner.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
repair_worker.py	Surface silent exceptions in repair_worker — 16 sites	3 weeks ago
replaygain.py	Add module logger + surface silent exceptions in 7 logger-less files — 12 sites	3 weeks ago
runtime_state.py	Add module logger + surface silent exceptions in 7 logger-less files — 12 sites	3 weeks ago
seasonal_discovery.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
socketio_cors.py	Socket.IO CORS: handle self-review nits	1 month ago
soulid_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
soulseek_client.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
soulsync_client.py	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
soundcloud_client.py	Surface engine-not-wired errors + exclude soulseek from monitor aggregation	3 weeks ago
spotify_client.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
spotify_public_scraper.py	…
spotify_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
tag_writer.py	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
tidal_client.py	Surface silent exceptions in metadata clients — 37 sites	3 weeks ago
tidal_download_client.py	Surface engine-not-wired errors + exclude soulseek from monitor aggregation	3 weeks ago
tidal_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
watchlist_scanner.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
web_scan_manager.py	MS Cin-5: Drop per-server globals — engine owns the clients	3 weeks ago
wishlist_service.py	Extract wishlist logic into dedicated package	4 weeks ago
worker_utils.py	Fix Album Completeness job reporting zero findings for every album	1 month ago
youtube_client.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago