You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Broque Thomas 2f284efa57 Retag now re-embeds LYRICS tag instead of leaving it empty ... Discord report (netti93). The download flow runs `enhance_file_metadata` (clears all tags) then `generate_lrc_file` (writes .lrc sidecar AND embeds USLT). The retag flow only ran the first half — `enhance_file_metadata` cleared USLT and there was no follow-up to restore it. Two coordinated fixes (no new setting per kettui scope discipline — user described it as "might even be an idea," consistency was the load-bearing ask). Fix 1 — retag calls generate_lrc_file after enhance `core/library/retag.py:execute_retag` now invokes `deps.generate_lrc_file` right after the `enhance_file_metadata` call, mirroring the download pipeline. New `generate_lrc_file` field on `RetagDeps`, defaults to None for backward compat with any test caller that builds RetagDeps without it. Web_server's `_build_retag_deps()` factory wires in the real `core.metadata.lyrics.generate_lrc_file`. Placement matters — runs BEFORE `safe_move_file` so the helper sees the audio file at its current path with its existing sidecar (which retag hasn't moved yet). After the embed, the audio file gets moved with USLT now present; the sidecar move step that follows is unaffected. Fix 2 — create_lrc_file re-embeds from existing sidecar `core/lyrics_client.py:create_lrc_file` used to early-return True when an .lrc / .txt sidecar already existed (skipping the LRClib fetch). For the retag case the sidecar is already there, so the shortcut hit and USLT was never re-written. Now the helper reads the existing sidecar and calls `_embed_lyrics` with its content before returning. Empty / unreadable sidecars short-circuit silently — defensive, no crash. Download flow unaffected because no sidecar exists at fetch time. 7 boundary tests pin: existing .lrc triggers re-embed, existing .txt triggers re-embed, empty sidecar skips embed, unreadable sidecar swallows error, no sidecar falls through to LRClib (download path regression guard), RetagDeps.generate_lrc_file field accepted, field optional for backward compat. Full suite: 3120 passed.		2 weeks ago
..
artists	Surface silent exceptions in core/artists — 23 sites	3 weeks ago
automation	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
discovery	Server playlist sync: append mode (preserve user-added tracks)	2 weeks ago
download_engine	Add module logger + surface silent exceptions in 7 logger-less files — 12 sites	3 weeks ago
download_plugins	Address Copilot doc-drift review	3 weeks ago
downloads	Fix MTV Unplugged & live-album false-quarantine pipeline	2 weeks ago
enrichment	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
imports	Quarantine management — list, approve, delete, recover	2 weeks ago
library	Retag now re-embeds LYRICS tag instead of leaving it empty	2 weeks ago
matching	AcoustID scanner: multi-candidate match + duration guard + multi-value retag	2 weeks ago
media_server	Server playlist sync: append mode (preserve user-added tracks)	2 weeks ago
metadata	Stop writing TRCK as "6/0" when album total_tracks is unknown	2 weeks ago
playlists	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
repair_jobs	AcoustID scanner: multi-candidate match + duration guard + multi-value retag	2 weeks ago
search	Cin-6: Rename soulseek_client global → download_orchestrator	3 weeks ago
stats	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
streaming	Cin-6: Rename soulseek_client global → download_orchestrator	3 weeks ago
sync	Persist Find & Add selections as permanent server-playlist match overrides	2 weeks ago
watchlist	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
webui	Extract WebUI asset helpers	2 weeks ago
wishlist	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
workers	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
acoustid_client.py	Clean up 286 ruff lint errors to unblock CI and fix 10 latent bugs	1 month ago
acoustid_verification.py	Tighten alias-lookup trust + add ambiguity gate + diagnostic log	2 weeks ago
album_consistency.py	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
api_call_tracker.py	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
artist_source_detail.py	Raise discography limit from 50 to 200	2 weeks ago
artist_source_lookup.py	Make artist_name Optional in find_library_artist_for_source	1 month ago
audiodb_client.py	…
audiodb_worker.py	AudioDB worker: stop infinite loop on direct-ID lookup failure (#553)	2 weeks ago
auto_import_worker.py	Auto-import: fall through to other metadata sources when primary returns no match	2 weeks ago
automation_engine.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
connection_detect.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
connection_test.py	Cin-6: Rename soulseek_client global → download_orchestrator	3 weeks ago
database_update_worker.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
debug_info.py	Fix Copy Debug Info music_source + surface missing services	2 weeks ago
deezer_client.py	Fix Deezer contributors tagging silently dropping for cache-polluted tracks	2 weeks ago
deezer_download_client.py	Surface silent exceptions in metadata clients — 37 sites	3 weeks ago
deezer_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
discogs_client.py	Surface silent exceptions in metadata clients — 37 sites	3 weeks ago
discogs_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
download_orchestrator.py	Lift shared download dataclasses + boot via singleton factory	3 weeks ago
genius_client.py	…
genius_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
genre_filter.py	…
hifi_client.py	Surface engine-not-wired errors + exclude soulseek from monitor aggregation	3 weeks ago
hydrabase_client.py	feat: add explicit badges to discography modal and artist-detail cards	2 weeks ago
hydrabase_worker.py	…
itunes_client.py	feat: add explicit badges to discography modal and artist-detail cards	2 weeks ago
itunes_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
jellyfin_client.py	Server playlist sync: append mode (preserve user-added tracks)	2 weeks ago
lastfm_client.py	…
lastfm_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
library_reorganize.py	Reorganize: hint at Unknown Artist Fixer for placeholder-metadata rows	2 weeks ago
lidarr_download_client.py	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
listenbrainz_client.py	…
listenbrainz_manager.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
listening_stats_worker.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
lyrics_client.py	Retag now re-embeds LYRICS tag instead of leaving it empty	2 weeks ago
matching_engine.py	Merge remote-tracking branch 'origin/dev' into refactor/media-server-engine	3 weeks ago
metadata_service.py	Move profile Spotify cache into registry	4 weeks ago
musicbrainz_client.py	MusicBrainz: Resolve release-group MBIDs to a release on album click	1 month ago
musicbrainz_search.py	MusicBrainz: Dedupe same-named homonyms in artist search results	1 month ago
musicbrainz_service.py	Cross-script artist aliases: include canonical name + non-strict fallback	2 weeks ago
musicbrainz_worker.py	Alias resolution polish: lazy-fire on direct-match failure + worker backfill	2 weeks ago
navidrome_client.py	Server playlist sync: append mode (preserve user-added tracks)	2 weeks ago
personalized_playlists.py	Discover: sharpen track selection (diversity, source-aware popularity, library dedup, SQL genre)	2 weeks ago
plex_client.py	Server playlist sync: append mode (preserve user-added tracks)	2 weeks ago
qobuz_client.py	Address Copilot doc-drift review	3 weeks ago
qobuz_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
reorganize_queue.py	Reorganize queue: race + dedupe fixes from kettui review	4 weeks ago
reorganize_runner.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
repair_worker.py	AcoustID scanner: multi-candidate match + duration guard + multi-value retag	2 weeks ago
replaygain.py	Add module logger + surface silent exceptions in 7 logger-less files — 12 sites	3 weeks ago
runtime_state.py	Add module logger + surface silent exceptions in 7 logger-less files — 12 sites	3 weeks ago
seasonal_discovery.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
socketio_cors.py	Socket.IO CORS: handle self-review nits	4 weeks ago
soulid_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
soulseek_client.py	Add min delay between slskd searches (Bell Canada anti-abuse fix)	2 weeks ago
soulsync_client.py	Surface silent exceptions across remaining modules — ~70 sites	3 weeks ago
soundcloud_client.py	Surface engine-not-wired errors + exclude soulseek from monitor aggregation	3 weeks ago
spotify_client.py	Add download buttons + bulk action to artist top-tracks sidebar	3 weeks ago
spotify_public_scraper.py	…
spotify_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
tag_writer.py	AcoustID scanner: multi-candidate match + duration guard + multi-value retag	2 weeks ago
tidal_client.py	Your Albums: selectable wishlist modal + Tidal album resolution	2 weeks ago
tidal_download_client.py	Fix MTV Unplugged & live-album false-quarantine pipeline	2 weeks ago
tidal_worker.py	Surface silent exceptions in workers + repair jobs — ~30 sites	3 weeks ago
watchlist_scanner.py	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites	3 weeks ago
web_scan_manager.py	MS Cin-5: Drop per-server globals — engine owns the clients	3 weeks ago
wishlist_service.py	Extract wishlist logic into dedicated package	4 weeks ago
worker_utils.py	Fix Album Completeness job reporting zero findings for every album	1 month ago
youtube_client.py	Drop redundant `import sys` inside _auto_download_disabled	2 weeks ago