19 Commits (d8d25a4846064bc7abbd6dff558f4c6f2a2d53e2)

Author	SHA1	Message	Date
Broque Thomas	9534843edb	Fix bulk discography losing album source context (#399) ... The bulk download_discography endpoint picked one metadata client based on the configured primary source and called .get_album() on every album with that single client. Albums whose IDs came from a fallback/provider-specific source (e.g. Deezer-formatted IDs surfaced through Hydrabase) failed with "Album not found" because the primary client couldn't resolve them. Bulk now uses the same source-aware resolver (core.metadata.album_tracks.get_artist_album_tracks) the working individual-album endpoint already uses, so the resolver's source-chain walk finds each album under whichever provider actually has it. Also adds explicit Discogs and Hydrabase support (the old if/elif chain silently 500'd for those primaries). Frontend (library.js + pages-extra.js) now sends a richer `{ albums: [{id, name, artist_name, source}] }` payload so each album can be resolved through its own source. The legacy `album_ids` payload still works as a fallback path. Closes #399.	4 weeks ago
Broque Thomas	37aefd2ff1	Reorganize queue: race + dedupe fixes from kettui review ... Five issues kettui flagged on PR #377: - Worker race (reorganize_queue.py): _next_queued() picked an item and released the lock, then re-acquired to flip status='running'. A cancel() landing in that window marked the item cancelled but the worker still ran it. Replaced with _claim_next_or_wait() that picks AND flips under one lock acquisition. - Wakeup race (reorganize_queue.py): _wakeup.clear() after the empty check could lose an enqueue's _wakeup.set(), parking a freshly-queued album for up to 60 seconds. Replaced Lock + Event with a single threading.Condition; cond.wait() releases and re-acquires atomically on notify. - Bulk dedupe (reorganize_queue.py:enqueue_many): looped single-item enqueue, so a duplicate album_id later in the same batch could slip through if the worker finished the first copy before the loop reached the second. Now holds the lock for the whole batch and tracks a per-batch seen set, so intra-batch duplicates dedupe against each other and not just pre-existing items. - Preview button stuck disabled (library.js:loadReorganizePreview): early returns and thrown errors skipped the re-enable line. Moved state into a canApply flag committed in finally, so any exit path lands the button correctly. - DB helpers swallowing failures (music_database.py): get_album_display_meta and get_artist_albums_for_reorganize used to catch every Exception and return None / [], so a real DB outage masqueraded as "album not found" / "no albums". Now lets exceptions bubble; the route layer already wraps them as 500. Tests: - test_cancel_and_run_are_mutually_exclusive — hammers enqueue+cancel pairs and asserts the invariant that no successfully-cancelled item ever ran (catches regressions to the atomic pick). - test_enqueue_many_dedupes_batch_internal_duplicates — pins the intra-batch dedupe. - test_get_album_display_meta_propagates_db_errors and test_get_artist_albums_for_reorganize_propagates_db_errors — pin the bubble-up behavior. Changelog updated in helper.js and version modal.	4 weeks ago
Broque Thomas	d6094a3587	Library reorganize: FIFO queue with live status panel ... Replaces the single-slot "one reorganize at a time, return 409 on collision" model with a per-user FIFO queue. Buttons stay clickable, "Reorganize All" is one backend call instead of an N-call JS loop, and a status panel mounted at the top of the artist actions bar shows live progress (active item, queued count, recent completions) with per-item cancel buttons. Backend - core/reorganize_queue.py: singleton queue + worker thread, dedupe-on- enqueue, cancel rules (queued cancellable, running not), enqueue_many for bulk operations, progress fan-out via update_active_progress - core/reorganize_runner.py: factory builds the worker's runner closure with injected dependencies. Reads config per-call so changing the download path in Settings takes effect on the next reorganize without a server restart - database/music_database.py: get_album_display_meta and get_artist_albums_for_reorganize — moves the SQL out of route handlers - web_server.py: thin enqueue/snapshot/cancel/clear endpoints, runner registration at module load. Old _reorganize_state globals + status endpoint deleted. Static-asset cache buster (?v=<server-start>) added so JS/CSS updates ship live without users clearing cache Frontend - webui/static/library.js: status panel mount, polling (1.5s when active, 8s when idle), expand/collapse, per-item cancel, debounced enhanced-view reload (one reload per artist batch instead of N). Per-album reorganize button paints with queued/running indicator and short-circuits to a toast when the album is already in queue - webui/static/style.css: panel + button styling matching the existing glass-UI accents - webui/static/helper.js + version modal: WHATS_NEW entry Tests (22 new) - tests/test_reorganize_queue.py (19 tests): FIFO order, dedupe, per-item source, cancel rules, continue-on-failure, snapshot shape, progress propagation, bulk enqueue - tests/test_reorganize_runner.py (4 tests): per-call config reads, setup-failure summary, dependency injection, progress fan-out - tests/test_reorganize_db_methods.py (7 tests): SQL JOIN behavior, ordering, fallback for blank strings, artist isolation Full suite 549 passed in 27s.	1 month ago
Broque Thomas	7e1c4c26ec	Reorganize: fix moved-count + status/total UX issues from PR #377 review ... Four changes addressing kettui's PR #377 review comments: 1. **`_finalize_track` no longer over-counts on DB failure (🔴 bug).** The function previously bailed on DB-update failure but `_process_one_track` still incremented `summary['moved']` unconditionally — overstating how many tracks the UI knows are at their new locations. Fixed by: - `_finalize_track` now returns ``bool`` (True only when DB row was updated AND original was dealt with) - Caller checks the return; on False, records as a failed track with a clear message ("Track landed at new location but DB update failed — file is at both old and new paths until library scan re-indexes") - Existing `test_db_update_failure_leaves_original_in_place` now also asserts `moved == 0`, `failed == 1`, and that the error message names the cause 2. **`executeReorganize` toast no longer says "undefined tracks" (🐛 bug).** `/reorganize` doesn't return `result.total` anymore (the track count is determined server-side after planning), so the "Reorganizing undefined tracks..." string was meaningless. Now uses `result.message` from the backend instead. 3. **`_pollReorganizeStatus` distinguishes completed from skipped (🟡 risk).** Backend now propagates the orchestrator's status (`completed` / `no_source_id` / `no_album` / `no_tracks` / `setup_failed` / `error`) into `_reorganize_state['result_status']` so the frontend can warn appropriately. Two new helpers: - `_classifyReorganizeOutcome(state)` — returns 'success' only when `result_status === 'completed'` AND `failed === 0`; 'warning' otherwise - `_formatReorganizeResultMessage(state)` — returns a message specific to the outcome ("Reorganize skipped — album has no metadata source ID. Run enrichment first." for `no_source_id`, etc.) Zero-failure non-completed runs now show as warnings instead of green checkmarks. 4. **Bulk mode no longer counts skipped albums as succeeded (🟡 risk).** `_executeReorganizeAll`'s loop was treating any HTTP 200 response as success, ignoring the orchestrator's actual outcome for that album. Fixed by: - `_waitForReorganizeComplete()` now resolves with the final state object (was: void) - Loop checks `finalState.result_status === 'completed'` AND `finalState.failed === 0` before counting `succeeded++`; otherwise increments `skipped` (with a per-album warning toast) or `failed` accordingly - Final summary toast now reads "Reorganized N of M albums, K skipped, J failed" and only shows green when nothing was skipped or failed All four addressed in a single commit because they form one coherent UX-correctness fix — the bug bug (#1) and the count- overstatement bug (#4) both made the user see "everything succeeded" when reality was different. Together they make the UI honestly reflect what actually happened. Files: - core/library_reorganize.py — `_finalize_track` returns bool, `_process_one_track` reads it - web_server.py — `_reorganize_state['result_status']` populated from orchestrator's summary on success and on exception - webui/static/library.js — `_classifyReorganizeOutcome` / `_formatReorganizeResultMessage` helpers, single-album + bulk-mode flows both consume them - tests/test_library_reorganize_orchestrator.py — strengthened the existing DB-failure test to assert moved/failed counts Credit: kettui — four PR #377 review comments named all of these precisely with line numbers and severity.	1 month ago
Broque Thomas	2b15260b88	Reorganize: route library files through the post-processing pipeline ... Reported on Discord by winecountrygames. The library "Reorganize" tool had several layered bugs that all traced to the same root cause: the endpoint reinvented every wheel post-processing already turns — its own template engine, its own disc-number resolution from file tags, its own sidecar sweep, its own collision detection — and each had drifted from the canonical path used by fresh downloads. Reported symptoms: - 3-disc Aerosmith deluxe collapsed to a flat single-disc layout - Half the tracks on other albums silently skipped, no error / no count - Re-runs left empty leftover album folders cluttering the artist dir Architecture: stop reinventing wheels. Route reorganize through exactly the same pipeline downloads use. Per-album: 1. Fetch the canonical tracklist from a metadata source (Spotify / iTunes / Deezer / Discogs / Hydrabase) using the album's stored source IDs. New `core/library_reorganize.py::plan_album_reorganize` does this — primary-source-first, fall through priority chain unless the user picked a specific source in the modal (strict mode). 2. For each local track, find the matching API entry via a scored candidate matcher. Score components: exact-title (100), substring-with-length-ratio (40-90), track-number agreement (20). Hard reject when the two titles have different version differentiators (Remix vs no-remix means different recordings, not annotation drift). Below threshold = unmatched, surfaced as "not in source's tracklist, left in place" rather than silently mis-routing. 3. Copy the file to a per-album staging directory, build the same context dict the import flow builds (`spotify_album` / `track_info` / etc. with `is_album_download=True` so the path builder enters ALBUM mode, not SINGLE mode), call `_post_process_matched_download(...)` — same function fresh downloads use. Post-process handles tagging, multi-disc subfolder decisions, sidecar regeneration, AcoustID verification. 4. Read `context['_final_processed_path']` to learn where it landed. Update `tracks.file_path` in the DB BEFORE removing the original (DB-update failure leaves the file at both locations, recoverable via library scan; the reverse would orphan the row). Delete per-track sidecars (post-process recreates them at the new destination). 3 concurrent workers per album via ThreadPoolExecutor, matching the download path's per-batch worker count. State mutations all guarded by a single lock; staging filenames carry a UUID prefix so concurrent copies of identically-named source files don't overwrite each other. Source picker in the modal lets the user choose which source to read the tracklist from. Two endpoints feed it: - `/api/library/album/<id>/reorganize/sources` — sources for THIS album that are both authed AND have a stored ID. For the per- album modal. - `/api/library/reorganize/sources` — all authed sources globally. For the bulk "Reorganize All" modal where per-album ID coverage varies. When the user picks a specific source, the orchestrator runs in `strict_source=True` mode (no fallback chain) — picking Spotify means "use Spotify or fail", not "use Spotify and silently fall back." Preview endpoint shares the same planning logic as apply via `preview_album_reorganize` — the destination path comes from the same `_build_final_path_for_track` post-process uses, so what you see in the preview is exactly what you get on apply. Empty destination folders (from earlier failed runs OR from the current run when post-process creates a dir then fails AcoustID) get cleaned up after each successful run: walk up to the artist folder from any successful destination, prune empty album-sibling folders one level deep. Bounded scope = won't touch unrelated user dirs. Web_server.py shrinks by ~450 net lines. The endpoint handler is now a thin wrapper that builds injected callables (path resolver, post- process function, DB updater, empty-dir cleaner), spawns a thread that calls `reorganize_album()`, and returns. All actual logic lives in `core/library_reorganize.py` where it's unit-testable without spinning up Flask. Frontend cleanup: the per-call template input in both reorganize modals (per-album and bulk) was redundant — the backend always uses the configured global download template. Removed the input and the variables-grid reference UI it was for. 39 new unit tests pin every contract: - source resolution (no_source_id when album has none, fallthrough chain when primary returns nothing, strict mode bypasses fallback) - matcher scoring (exact / substring / multi-disc disambiguation / smart-quote tolerance / dash-vs-parens / bonus-track substring / Remix-vs-original differentiator rejection / "Real" doesn't false- match "Real Real Real" / track-number-only no longer fires) - file safety (DB-update failure leaves original in place, post- process failure leaves original in place, post-process exception caught and original preserved, success removes original AND updates DB in the right order) - sidecar handling (per-track .lrc/.nfo deleted on success, kept on failure; album-level cover.jpg/folder.jpg cleaned only when directory has no remaining audio) - staging cleanup (recreated between tracks because post-process nukes it, dir cleaned up on success AND on failure) - destination-dir prune (empty siblings removed, real album with files preserved, no recursive sweep) - source picker (only authed-with-stored-ID sources for per-album, all authed sources for bulk; strict mode doesn't fall back) - concurrency (3 workers in flight, state stays consistent under races, stop_check cuts off pending tasks) - preview parity (preview produces same destination as apply for multi-disc; ALBUM mode not SINGLE mode; unmatched/no-path tracks surfaced with reasons) Limitations (deliberate punts, NOT in this PR): - Renamed local titles on multi-disc albums where track_number also disagrees: matcher returns nothing (track is "not in source"). Fixable by using duration_ms as a tertiary signal. - Per-track in-modal source switching with per-album track-count hints (would need a second API call before opening the modal). - UI status panel on the artist page during a run — currently just toasts. Documented as a follow-up PR. Files: - core/library_reorganize.py — new module: plan_album_reorganize, preview_album_reorganize, reorganize_album, available_sources_for_album, authed_sources, _score_candidate, helpers for staging/post- processing/finalizing, sidecar + dest-dir cleanup - core/metadata_service.py — no changes; reused get_album_for_source, get_album_tracks_for_source, get_source_priority, get_client_for_source - web_server.py — three endpoints (preview / apply / sources GETs) are thin wrappers; -450 net lines - tests/test_library_reorganize_orchestrator.py — 39 tests covering every contract above - webui/static/library.js — source picker UI in both modals; dead template input + variables-grid removed - webui/static/style.css — dropdown option styling fix (white-on- white was unreadable) Reported on Discord by winecountrygames — his bug report named the trigger button (Enhanced view → Reorganize All) and both symptoms (multi-disc collapse, half-album skip), which let the diagnosis go straight to the architectural problem.	1 month ago
Broque Thomas	dd20298df4	Library page empty state: offer to search metadata sources for the query ... When a user types an artist name into the library search and gets no hits, the old empty state just said "No artists found — try adjusting your search or filters." Dead end for the common case of "I searched for someone I don't own yet." The empty state now detects when libraryPageState.currentSearch is non-empty and swaps in a CTA that hands the query off to /search: "kendrick" isn't in your library They might be available on a connected metadata source. [🔍 Search online for "kendrick" →] Clicking the button navigates to /search, pre-fills the enhanced search input, and dispatches an input event so the existing debounced search fires automatically. Uses the same hand-off pattern _gsNavigateToSearchPage already uses for Soulseek, so the Search page's source-picker flow picks up naturally from there. No change to the generic empty state (no query active) or to any other library page behaviour.	1 month ago
Broque Thomas	b547909604	Address PR review feedback from JohnBaumb and Cin ... Four fixes from the review: **library.js — back button stack (JohnBaumb):** Replace the single-slot `artistDetailPageState.originPage` with an origin stack. Chained navigation like Search → Artist A → similar Artist B → similar Artist C now walks back one step at a time (C → B → A → Search) instead of jumping straight to Search and skipping A and B. `navigateToArtistDetail` takes an optional `{skipOriginPush}` flag so the back button can re-enter a prior artist without re-pushing onto the stack. Fresh entries from a non-artist page clear any stale stack from a prior chain. Duplicate-click detection avoids pushing the same target twice. Label derivation (`_updateArtistDetailBackButtonLabel`) reads the stack top so the button says "Back to <ArtistName>" mid-chain and "Back to Search" at the root. **library.js — checkArtistEnhanceEligibility after library upgrade (Cin):** The quality-analysis endpoint only works on library PKs. After the library-upgrade branch rewrites `currentArtistId` from the source ID to the library PK, the check was still using the original closure arg, so upgraded source artists never hit `/api/library/artist/<id>/quality-analysis`. Use `artistDetailPageState.currentArtistId` so the call gets the resolved id. **init.js — isPageAllowed + home page recursion (Cin):** - artist-detail is reachable from both Library and Search results now, so permission check accepts either grant (plus legacy 'downloads'/'artists' aliases). Search-only profiles can open source artists; legacy artists-only profiles no longer recurse on the home redirect. - `getProfileHomePage` rewrites 'artists' → 'search' (it already rewrote 'downloads') so legacy home_page values resolve correctly. - Legacy-compat expanded in isPageAllowed to treat 'artists' as equivalent to 'search' in both directions. **init.js — profile edit forms dropping values on save (Cin):** Both pageLabels maps (admin edit form + self-edit form) referenced the legacy 'downloads'/'artists' keys. When editing a profile saved with `home_page: 'search'` and `allowed_pages: ['search', 'library']`, the home select didn't render a 'search' option, and the allowed_pages checkboxes used 'downloads' as their value — so saving the form dropped both values. Update both maps to use 'search' as the canonical key. Add `_normalizeLegacyAllowedPages` and `_normalizeLegacyHomePage` helpers that migrate any legacy ids in allowed_pages/home_page on read, so a legacy profile's first save upgrades its stored ids to the new canonical form.	1 month ago
Broque Thomas	648e46d460	Update streaming completion handler to target the new big-photo card overlay ... The library completion stream calls updateLibraryReleaseCard once per release as ownership resolves. The handler was still updating the OLD card markup (.completion-text + .completion-fill / .completion-bar), so cards rendered with the new .completion-overlay badge stayed stuck in the pulsing 'Checking…' state forever. Now updates the new structure in place: - Toggles the .completion-overlay state class (checking → completed / nearly_complete / partial / missing) which the existing CSS uses to colour and stop the checking-pulse animation. - Rewrites the inner .completion-status text: Owned → '✓ Owned' Partial → 'X/Y' (75%+ → nearly_complete badge, else partial) Missing → 'Missing' - Sets a tooltip on the overlay with detailed track counts. Per-card .release-card.checking class also gets removed when state resolves (stops the whole-card opacity pulse).	1 month ago
Broque Thomas	59298b5b17	Restore big-photo album cards on artist-detail page ... The standalone /artist-detail page rendered releases via createReleaseCard in a stacked layout: square image on top, then title, then year, then a completion bar — all inside a 300px-tall card with internal padding. The inline Artists page (now retired) used a richer treatment: full-bleed artwork with a dark gradient overlay and the title + year pinned at the bottom. This commit brings that look to the standalone page. Card markup (still .release-card so all the existing JS filter + state hooks work, plus .album-card for the visual): <div class="release-card album-card" ...> <div class="album-card-image" data-bg-src="..."></div> <div class="completion-overlay [state]"> <span class="completion-status">...</span> </div> <div class="album-card-content"> <div class="album-card-name">title</div> <div class="album-card-year">year</div> </div> [optional .mb-card-icon] </div> Image loads lazily via the existing observeLazyBackgrounds / data-bg-src plumbing in core.js — call moved into populateRelease- Section so each batch of new cards gets observed. Completion overlay (top-right floating badge): - Library artists: 'Checking…' / '✓ Owned' / 'N/M' / 'X%' / 'Missing' based on release.owned + track_completion shape (existing logic preserved, just rendered as a badge instead of a bar). - Source artists (no library data): omitted entirely. The card just shows artwork + title + year, which is what the user asked for. CSS: scoped overrides under #artist-detail-page .release-card.album-card neutralize the old release-card background gradient, internal padding, fixed 300px height, and flex column layout. Cards become aspect-ratio:1 square with overflow:hidden so the image fills and the gradient + text sit on top. Filter state (data-is-live / data-is-compilation / data-is-featured) still tagged on each card so the Include filter group keeps working. Smoke: library Kendrick Lamar should now look like the inline Artists page used to — square cards, big artwork, name + year on the bottom. Source-clicked artist (Schoolboy Q from Deezer) shows the same visual without the completion overlay.	1 month ago
Broque Thomas	9b52c1d94f	Smart back button on artist-detail — labels and routes by origin ... The "← Back to Library" button on /artist-detail was hardcoded to navigate back to the Library page regardless of where the user came from. Now it captures the originating page and labels/routes accordingly. navigateToArtistDetail captures currentPage at call time (before the swap to artist-detail) and stashes it on artistDetailPageState.originPage. Falls back to library when the origin can't be determined or when chaining detail-to-detail (e.g. clicking a Similar Artist on the detail page). Back button label now adapts: - From Library card click → "← Back to Library" - From Search result → "← Back to Search" - From Discover hero / Your Artists → "← Back to Discover" - From Watchlist artist detail → "← Back to Watchlist" - From Wishlist / Stats / Explorer / Automations / Dashboard etc. → corresponding labels - Unknown origin → "← Back to Library" Click handler navigates to the captured origin instead of always going to library. State is cleared on click so a fresh artist-detail view starts clean next time.	1 month ago
Broque Thomas	77567a5eda	Sync currentArtistId on library upgrade + hide Similar Artists in Enhanced view ... Two bugs from the source-artist click flow: 1. After the backend's library upgrade kicks in (clicking a Deezer result for an artist you already own routes through the library path), the response's data.artist.id is the library PK while artistDetailPageState.currentArtistId still held the source id. Toggling Enhanced view then fired /api/library/artist/<source_id>/enhanced which 404'd because the source id isn't a library PK. loadArtistDetailData now updates currentArtistId from data.artist.id whenever they differ — Enhanced view, completion checks, server sync etc. all use the right id. 2. The Similar Artists section is part of the standard view and was staying visible when Enhanced view toggled on. toggleEnhancedView now hides #ad-similar-artists-section in the same flow that hides .discography-sections.	1 month ago
Broque Thomas	f936b8cb12	Enrich source-only artist-detail response and skip discography dedup for source artists ... Source artists landing on /artist-detail were rendering an almost-blank hero — image + name + a tiny Download button — because the backend response only had {id, name, image_url, server_source: null, genres: []}. The library.js renderers do their best with what they have, and that wasn't much. Backend changes (_build_source_only_artist_detail): - Set the source-specific ID field (deezer_id / spotify_artist_id / itunes_artist_id / discogs_id / soul_id / musicbrainz_id) on artist_info so the corresponding service badge renders on the hero. - Try the source's own get_artist_info / get_artist for genres + followers (Spotify always; Deezer/iTunes/Discogs when available). Spotify also fills image_url if metadata_service.get_artist_image_url came up empty. - Last.fm enrichment by artist name — bio + listeners + playcount + lastfm_url. Mirrors what library artists get from the cached enrichment workers but on demand for source artists. - All enrichment lookups are wrapped in try/except so a 500 from any one source doesn't break the whole response. Frontend (library.js populateArtistDetailPage): - Watchlist button now initialises for source artists too. Falls back to artist.id + artist.name when there's no canonical Spotify identity (which is the common case for non-library artists). Discography dedup opt-out: - Added dedup_variants flag to MetadataLookupOptions (default True so library artists are unchanged). Source-only path now passes dedup_variants=False so every "Deluxe Edition" / "Remastered" / "Anniversary" variant the source returns is shown — matches the inline /artists page behaviour the user was comparing against. Result: source artists' hero now shows badges + bio + listeners + playcount + watchlist button + genres in addition to image and name. Discography lists every release the source returns, not the deduped canonical view.	1 month ago
Broque Thomas	93f1941829	Unify artist detail: route source artists to standalone page, retire inline Artists page ... Completes the artist-detail unification. Source artists now land on the same /artist-detail page as library artists (with the source-aware backend endpoint from earlier this session handling the data fetch). The inline Artists page is gone — artists.js deleted, #artists-page HTML block removed, /artists URL aliases to /search. Source-artist callsites re-migrated from selectArtistForDetail to navigateToArtistDetail (search results, global widget, download modal, Discover hero / Your Artists cards / artmap context / genre deep-dive, watchlist artist detail). Visual upgrade to standalone hero: added .artist-detail-hero-bg + .artist-detail-hero-overlay (blurred image bg, dark gradient — same treatment as the inline page). library.js sets the bg image when loading an artist. Library-only UI hidden via CSS for source artists (existing rules from the previous commit cover Enhanced toggle, Status filter, completion bars, enrichment coverage, Top Tracks sidebar, Radio / Enhance buttons). Final 2 helpers (lazyLoadArtistImages used by wishlist-tools, showCompletionError used by completion checker) moved from artists.js into shared-helpers.js. The inline-page candidate set was dropped from _resolveSimilarArtistsTargets. init.js: 'artists' alias added at top of navigateToPage (same pattern as the existing 'downloads' alias). 'case artists:' handler removed from loadPageData. _getPageFromPath now maps artist-detail to library as its parent (matches the existing nav highlight at init.js:2161). tests/test_script_split_integrity.py: artists.js removed from SPLIT_MODULES; KNOWN_CROSS_FILE_DUPES updated to point escapeHtml at shared-helpers.js instead of artists.js. 354/354 tests pass. Net delta: -1700 lines. Stays at 2.39. Once you've verified end-to-end (library artist -> hero looks like inline visual; source artist from Search -> same page, similar artists works, no 404s; /artists URL -> /search), a follow-up commit bumps to 2.40 with the full WHATS_NEW entry that's already prepped.	1 month ago
Broque Thomas	6a76405444	Add Similar Artists to standalone /artist-detail page, hide library-only UI for source artists ... First increment of the artist-detail unification redesign. Delivers the two most-visible missing pieces for source artists without touching the hero layout — that's a later commit. Changes: - HTML: new #ad-similar-artists-section inside #artist-detail-main (scoped IDs with 'ad-' prefix so they don't collide with the inline Artists page, which has the same section using base IDs). - shared-helpers.js: similar-artists helpers (loadSimilarArtists + display/progressive/createBubble + lazy image loader) moved out of artists.js. New _resolveSimilarArtistsTargets() resolver picks whichever candidate set has a `.page.active` ancestor, so the same function works on both the inline Artists page and the standalone artist-detail page without caller changes. - library.js populateArtistDetailPage: sets document.body.dataset.artistSource = 'library' | 'source' before rendering, and fires loadSimilarArtists(artist.name) after populating the rest of the page. - style.css: body[data-artist-source='source'] rules hide library-only UI on the artist-detail page — Enhanced view toggle, Status (owned/missing) filter, completion bars, enrichment coverage, Top Tracks sidebar, Radio / Enhance Quality buttons, "X owned / Y missing" section-stats counts. CSS-only, additive, library artists completely unaffected. Impact today: - Library artists: Similar Artists section now appears at the bottom of their detail page (previously only the inline Artists page had it). All other UI unchanged. - Source artists: still route to the inline Artists page (Part B reverted earlier this session). The standalone page is now source-ready infrastructure-wise, but source artists don't reach it yet. A later commit will re-migrate source callers to the standalone page once the hero rendering is also source-ready. artists.js shrinks from 1903 -> 1584 lines (similar-artists block extracted). shared-helpers.js grows correspondingly. 357/357 tests still pass. No version bump — this is still 2.39 pending.	1 month ago
Broque Thomas	89754480be	Source-aware /api/artist-detail: fall back to metadata source when not in library ... Part A of the deferred unification cleanup. The standalone artist- detail endpoint used to 404 whenever `artist_id` wasn't a local library primary key, which is exactly what source artists (Deezer/Spotify/ iTunes/etc.) have. That forced the Phase 4a revert: source artists had to use the inline Artists page because this endpoint couldn't handle them. New behaviour: - Library PK path — unchanged. Existing callers see the same response. - `/api/artist-detail/<id>?source=<src>&name=<name>` with source in (spotify, itunes, deezer, discogs, hydrabase, musicbrainz) — when the library DB lookup misses, synthesize a response by: • fetching artist image via metadata_service.get_artist_image_url with source_override (the helper already backing /api/artist/ <id>/image) • fetching discography via metadata_service.get_artist_detail_ discography with MetadataLookupOptions(source_override=source, artist_source_ids={source: artist_id}) • returning { success, artist: {id, name, image_url, server_source: null, genres: []}, discography, enrichment_coverage: {} } - Library PK missing AND no source — preserves the 404 (caller didn't give enough info to fall back). Frontend plumbing: library.js loadArtistDetailData now appends ?source=<src>&name=<name> to the fetch URL when artistDetailPageState.currentArtistSource is set. The field is already seeded by navigateToArtistDetail's third arg (added during the earlier unification work), so no new state plumbing is needed. populateArtistDetailPage gracefully handles the missing-library-data case per earlier exploration — owned_releases empty is fine, enrichment_coverage optional, spotify_artist_id optional. Part B will re-route the source-artist callsites (Search / Discover / Watchlist / etc.) back through navigateToArtistDetail so they actually exercise this new fallback path.	1 month ago
Broque Thomas	09f15ce7d2	Retire Artists sidebar entry, redirect entry points to Search, bump to 2.46 ... Phase 4b of the Search/Artists unification. Cin flagged that 'Artists' in the sidebar read like a library section but was actually a dedicated artist-search page, duplicating what unified Search already does. Removed the sidebar entry so users funnel through Search. - Sidebar Artists button gone - 'Browse Artists' on empty Watchlist now opens Search - 'View artist from Wishlist' opens Search pre-filled with the name - Profile Home Page + Page Access drop the Artists option artists.js stays on disk: it defines ~30 shared helpers used across the app (escapeHtml, openDownloadMissingModalForArtistAlbum, service status, download bubbles, image helpers) that library/discover/etc. depend on. Wholesale deletion would orphan too much. The inline Artists page and its selectArtistForDetail flow are still there — just unreachable from the sidebar — so /artists deep links keep working for bookmarks.	1 month ago
Broque Thomas	9361c29965	Route all artist-detail callers to the standalone page, bump to 2.45 ... Phase 4a of the Search/Artists unification. The app had two artist- detail implementations: the standalone page Library navigates to via navigateToArtistDetail (its own route, deep-link support, highlights Library in the sidebar), and an inline state inside the Artists page reached via selectArtistForDetail. They rendered similar content but were separate code paths and kept drifting apart (PR #356 just had to fix source propagation in both). Every external caller of selectArtistForDetail (9 sites across api-monitor.js, discover.js, downloads.js, search.js) now calls navigateToArtistDetail(id, name, source) directly. Removed ~63 lines of the navigate-then-setTimeout-then-select dance. Source context (Spotify/iTunes/Deezer/etc.) carries cleanly through via the new third argument. Artists sidebar entry, its inline search, and selectArtistForDetail all still work — they just have no external callers. Phase 4b will retire the sidebar entry and artists.js.	1 month ago
Antti Kettunen	5420c0de24	Fix album track source propagation ... - Pass source through artist, library, wishlist, and rehydration album-track fetches - Preserve the resolved metadata source on cached discography and artist detail state - Prevent 404s when opening artist-page album modals from non-Spotify sources	1 month ago
JohnBaumb	a66c4d06e1	Split monolithic script.js (78K lines) into 17 domain modules ... Extracts the single 77,957-line script.js into focused modules: core.js (874) - Global state, confirm dialog, websocket, constants init.js (2358) - Initialization, personal settings, navigation media-player.js (2398) - Media player, audio, visualizer, radio settings.js (3657) - Settings page, quality profiles, API keys, auth search.js (1542) - Search functionality, page data loading sync-spotify.js (2538) - Spotify sync, YouTube backend, hero section downloads.js (6398) - Wing It, batched polling, cancel, notifications wishlist-tools.js (7234) - Wishlist, matched downloads, tools, retag sync-services.js (9076) - Tidal, Deezer, Beatport, YouTube, ListenBrainz sync artists.js (4610) - Artists page, artist downloads api-monitor.js (3798) - API rate monitor gauges library.js (6652) - Library, artist detail, enhanced management beatport-ui.js (3902) - Beatport sliders, genre browser discover.js (8920) - Discover page and all sub-sections enrichment.js (3551) - All enrichment workers, library repair stats-automations.js (7575) - Stats, automations, issues, import pages-extra.js (2874) - Playlist explorer, server playlists, active downloads Load order: core.js first (globals), init.js last (DOMContentLoaded). All other modules define functions and load in any order. No functional changes - pure extraction along existing section boundaries.	1 month ago