SoulSync

Commit Graph

Author	SHA1	Message	Date
Broque Thomas	a65ba7e6a3	Add node:test contract for auto-sync.js helpers Cin review: no JS tests covered the autoSync* helpers, so the timezone fix shipped without a regression test in the layer where the bug actually lived. New `tests/static/test_auto_sync.mjs` runs under `node --test` (built-in runner, no extra deps) and pins: - `autoSyncTriggerForHours` / `autoSyncHoursFromTrigger` round-trip for 1h, 4h, 12h, 24h, 48h, 168h. Catches off-by-one in the day vs hour conversion that backs the schedule board's drag-drop. - `autoSyncBucketLabel` / `autoSyncIntervalLabel` formatting + pluralization. - `autoSyncSourceLabel` known + unknown + falsy. - Predicates (`autoSyncCanSchedulePlaylist`, `autoSyncIsPipelineAutomation`, `autoSyncPlaylistIdFromAutomation`, `autoSyncIsScheduleOwned`) including the `owned_by`-flag / legacy-name-prefix split from the previous commit. - `buildAutoSyncScheduleState` partitions board-owned schedules from custom pipelines correctly. - `autoSyncNextRunLabel` parses the naive UTC timestamp as UTC, not local — exactly the regression that took an hour to diagnose this session. Includes a past-time check ("due now") and a multi-day case. - `getMirroredSourceRef` source_ref/description-URL/source_playlist_id resolution order. Cross-realm note: vm-sandbox return values fail `deepStrictEqual` against host-realm objects even when shape matches, so a small `deepShapeEqual` helper round-trips through JSON for structural comparison. The `_autoParseUTC` stub mirrors the real implementation in stats-automations.js so the timezone test exercises both files end to end. `tests/test_auto_sync_js.py` is the pytest shim — shells out to `node --test` and surfaces failures inline. Skips cleanly when node isn't on PATH or is older than 22, matching the existing discover-section-controller test pattern. Also updated SPLIT_MODULES in tests/test_script_split_integrity.py to include the new auto-sync.js — the onclick-coverage check was failing because `openAutoSyncScheduleModal` (referenced from index.html via the Sync page button) now lives in a module the integrity scanner wasn't searching. 39 new JS test cases, all green via `node --test` and via the pytest wrapper.	4 weeks ago
Broque Thomas	93f1941829	Unify artist detail: route source artists to standalone page, retire inline Artists page Completes the artist-detail unification. Source artists now land on the same /artist-detail page as library artists (with the source-aware backend endpoint from earlier this session handling the data fetch). The inline Artists page is gone — artists.js deleted, #artists-page HTML block removed, /artists URL aliases to /search. Source-artist callsites re-migrated from selectArtistForDetail to navigateToArtistDetail (search results, global widget, download modal, Discover hero / Your Artists cards / artmap context / genre deep-dive, watchlist artist detail). Visual upgrade to standalone hero: added .artist-detail-hero-bg + .artist-detail-hero-overlay (blurred image bg, dark gradient — same treatment as the inline page). library.js sets the bg image when loading an artist. Library-only UI hidden via CSS for source artists (existing rules from the previous commit cover Enhanced toggle, Status filter, completion bars, enrichment coverage, Top Tracks sidebar, Radio / Enhance buttons). Final 2 helpers (lazyLoadArtistImages used by wishlist-tools, showCompletionError used by completion checker) moved from artists.js into shared-helpers.js. The inline-page candidate set was dropped from _resolveSimilarArtistsTargets. init.js: 'artists' alias added at top of navigateToPage (same pattern as the existing 'downloads' alias). 'case artists:' handler removed from loadPageData. _getPageFromPath now maps artist-detail to library as its parent (matches the existing nav highlight at init.js:2161). tests/test_script_split_integrity.py: artists.js removed from SPLIT_MODULES; KNOWN_CROSS_FILE_DUPES updated to point escapeHtml at shared-helpers.js instead of artists.js. 354/354 tests pass. Net delta: -1700 lines. Stays at 2.39. Once you've verified end-to-end (library artist -> hero looks like inline visual; source artist from Search -> same page, similar artists works, no 404s; /artists URL -> /search), a follow-up commit bumps to 2.40 with the full WHATS_NEW entry that's already prepped.	2 months ago
Broque Thomas	1a8071d6ec	Revert "Retire artists.js and inline Artists page, ship unification at 2.40" This reverts commit `71ff5cb5c3`.	2 months ago
Broque Thomas	71ff5cb5c3	Retire artists.js and inline Artists page, ship unification at 2.40 Part D + E of the deferred cleanup + the final version bump that publishes the whole Search/Artists unification project. Deletions: - webui/static/artists.js (1903 lines) — removed entirely. The 2 remaining externally-referenced helpers (lazyLoadArtistImages + showCompletionError) moved into shared-helpers.js first. - webui/index.html — 140-line #artists-page HTML block and the <script src="artists.js"> tag both removed. init.js wiring: - 'case artists:' removed from loadPageData switch (no page to init). - navigateToPage top-level alias extended: 'artists' → 'search' (same pattern as the existing 'downloads' → 'search' alias). Legacy /artists bookmarks land on the unified Search page, the natural place to find an artist now. - _getPageFromPath now maps artist-detail → library as its parent (was artists). Matches the existing library-nav-highlight at init.js:2161. Version bump: - _SOULSYNC_BASE_VERSION 2.39 → 2.40. - WHATS_NEW entries lose the 'unreleased' scaffolding and gain a new top entry summarizing the unified artist-detail page + the final artists.js retirement. - version-info modal gets a 'Search & Artists Unification' section at the top. - The _getLatestWhatsNewVersion filter added during the unreleased- tracking phase is rolled back — entries now display as soon as they land in WHATS_NEW, matching the pre-unification behaviour. Test suite: - tests/test_script_split_integrity.py SPLIT_MODULES updated: 'artists.js' dropped, 'shared-helpers.js' added. escapeHtml's cross-file dupe list entry updated to reference shared-helpers. - 354/354 tests pass. User-visible result after this commit: - Sidebar: Search, Downloads, Discover, Library, Wishlist, etc. — no more Artists entry. - Click any artist anywhere: lands on the same /artist-detail page. - Search page has a source dropdown; Soulseek is just another option. - Legacy /downloads and /artists URLs alias to /search. - Version button shows v2.3 (Docker major); "What's New" panel opens to the unification summary. Closes the project Cin requested in Discord. Future work: source-aware /api/artist-detail could be extended to fall back through the whole source priority chain when a specific source is given but returns no discography. Not needed for the current flows.	2 months ago
Broque Thomas	a5d97261e4	Extract shared helpers from artists.js to shared-helpers.js Part C of the deferred unification cleanup. The Artists page is no longer in the sidebar, but its JS file can't be deleted yet because it houses ~20 general-purpose helpers that other modules depend on (escapeHtml used in 229 places, service-status polling, image-colour extraction, download-bubble infrastructure, discography completion checking, enrichment card rendering). Moved all non-page-specific code from artists.js into the new webui/static/shared-helpers.js — pure copy/paste, zero logic change. Two contiguous blocks extracted: Block A (lines 1097..1398 of original artists.js): discography completion suite — checkDiscographyCompletion, handleStreaming- CompletionUpdate, cacheCompletionData, updateAlbumCompletion- Overlay, getCompletionStatusText, setAlbumDownloadedStatus, setAlbumDownloadingStatus. Block B (lines 2206..EOF of original artists.js): download-bubble infrastructure (artist + search + Beatport clusters with their snapshot/hydrate/modal/monitor helpers), openDownloadMissingModal- ForArtistAlbum, image-colour extractor and dynamic-glow helper, escapeHtml, service-status polling, renderEnrichmentCards. Function declarations in a plain <script> tag are auto-global, so all existing callers continue to resolve without any import/export changes. Load order in index.html: shared-helpers.js loads right after core.js (which defines the artistDownloadBubbles / search- DownloadBubbles / beatportDownloadBubbles globals these helpers use). Stats: artists.js: 4638 → 1903 lines (-2735) shared-helpers.js: new, 2762 lines No function duplicated between the two files All 357 tests pass (3 new from split-integrity parametrization) What's left in artists.js is purely the Artists page — search UI, detail view, state switching, watchlist button, discography loading. All of that is reachable only by typing /artists in the URL bar since the sidebar entry was retired in Phase 4b. Parts D + E will delete that remainder and the file itself.	2 months ago
JohnBaumb	77b069acf4	Add split integrity tests (61 tests)	2 months ago

6 Commits (2fcdfd3145d415355b9202c406d8985fda8eb003)