5 Commits (048e4e85d5ceb6bbb9f6a6d2b2efbc259cc331ff)

Author	SHA1	Message	Date
Broque Thomas	61ba3a15de	Cin-6: Rename soulseek_client global → download_orchestrator ... The global handle in web_server.py was named soulseek_client for historical reasons but the type has long been DownloadOrchestrator, not SoulseekClient. Renamed the global plus every parameter/attribute that carried the legacy name. - web_server.py: global var renamed; all 99 references updated. - api/, core/downloads/*, core/search/*, core/streaming/*, services/sync_service.py: parameter names, dataclass fields, and init() arg names renamed. - Test fixtures (CandidatesDeps, MasterDeps, SearchDeps, etc.) and the _build_deps helpers updated accordingly. The core.soulseek_client module path and SoulseekClient class name (the actual soulseek-only client) are unchanged — only the orchestrator handle renamed. Module imports of TrackResult/AlbumResult/DownloadStatus from core.soulseek_client preserved.	3 weeks ago
Broque Thomas	7519c3d50c	Cin-5: Drop per-source attrs from orchestrator ... Removed the eight backward-compat attribute aliases on the orchestrator (soulseek, youtube, tidal, qobuz, hifi, deezer_dl, lidarr, soundcloud). External callers and the orchestrator's own internals now reach clients through the generic alias-aware client(name) accessor. - core/downloads/{master,monitor,validation}.py: migrated to client(). Monitor's per-source aggregation loop replaced with a single engine.get_all_downloads() call. - core/search/{orchestrator,stream}.py: migrated; stream.py drops the hand-built mode-to-client dict. - web_server.py: migrated /api/deezer/arl-* + tidal client lookup. - core/download_orchestrator.py: internal self.soulseek / self.deezer_dl reaches now route through self.client(); attr assignments dropped from __init__; module docstring updated. - Test fakes (_FakeSoulseek, _FakeSoulseekWithYT) expose client(name) instead of stuffing per-source attributes. - Conformance test re-pinned to the client() accessor contract.	3 weeks ago
Broque Thomas	b94cbd7dd7	Search lift: pre-merge parity polish for cin's review ... Three drifts caught in line-by-line review against the pre-lift web_server.py. All addressed for strict 1:1 behavior parity. 1. /api/enhanced-search/source/<src> now returns plain JSON `{"artists":[],"albums":[],"tracks":[],"available":false}` (or `{"videos":[],"available":false}` for youtube_videos) when the source's client isn't available, matching the original endpoint contract. Previously streamed an NDJSON `{"type":"done"}` line instead. Restructured by splitting the orchestrator into resolve+stream helpers: - `resolve_client(source_name, deps)` — already existed, used for /api/enhanced-search single-source mode - `resolve_youtube_videos_client(deps)` — new, returns the soulseek_client.youtube subclient or None - `stream_metadata_source(source_name, query, client)` — pure NDJSON generator, caller resolves client first - `stream_youtube_videos(query, youtube_client, run_async)` — same shape for the yt-dlp path The route now decides plain-JSON-vs-stream based on resolution result, mirroring the original control flow exactly. 2. core/search/library_check.py — reverted the defensive `(x or '')` and `getattr(plex_client, 'server', None) is not None` patterns to original byte-for-byte (`x.get('name', '')`, `plex_client.server`, no try/except around `get_plex_config`). Lift PR shouldn't change crash semantics; if the original raises on malformed input, mine should too. Pre-existing edge cases get their own follow-up PR. 3. core/search/stream.py — same revert: `soulseek_client.youtube` instead of `getattr(..., 'youtube', None)` etc. Also removed the module-level `EMPTY_SOURCE` from sources.py and moved its (per-call) duplicate into _fan_out_response as a local — the original used a per-request local dict and the identity-check behavior depends on that. Module-level was a footgun for future mutations. 789 tests still pass (95 search), ruff clean.	1 month ago
Broque Thomas	47b4663091	Search cache: preserve falsy provider returns to match original behavior ... Line-by-line review of the search lift caught one drift: cache.get_cache_key was coercing falsy provider returns ('', None, 0) to 'unknown' / False. Original web_server.py only fell back to those sentinels on exception, not on falsy success values. Real-world impact: low — get_active_media_server() and get_primary_source() return non-empty strings in practice. But cache keys are tuples with no schema enforcement, so any drift here can silently fragment the cache. Restored 1:1 parity with original semantics. Added test covering the falsy-success path so this can't drift again. 789 tests pass, ruff clean.	1 month ago
Broque Thomas	fd7b56e58c	Lift /api/search and /api/enhanced-search/* into core/search/ ... Routes moved to thin parse-args/jsonify handlers; logic now lives in six focused modules under core/search/. 720 lines deleted from web_server.py; 109 added back as wrappers; ~700 lines of new core code plus ~700 lines of tests. Module split: - core/search/cache.py — TTL+LRU cache for enhanced-search responses, keyed by (query, active_server, fallback_source, hydrabase_active, source_tag) so config changes don't poison stale entries. - core/search/sources.py — per-kind metadata search (artists/albums/ tracks) and the multi-kind ThreadPoolExecutor that fans them out. - core/search/library_check.py — library + wishlist presence check with Plex thumb URL resolution; profile-aware wishlist with legacy fallback for older DBs missing the profile_id column. - core/search/stream.py — single-track preview search; effective stream mode resolution, query-variant generation, retry walk, matching engine integration. - core/search/basic.py — flat Soulseek file search, quality-sorted. - core/search/orchestrator.py — main enhanced-search dispatch (short-query fast path, single-source bypass, hydrabase-primary fan out, alternate source list builder), NDJSON streaming generator for /source/<src>, and the SearchDeps dataclass that bundles the cross-cutting deps. Routes pass clients (spotify, hydrabase, hydrabase_worker, soulseek) and helpers (config_manager, fix_artist_image_url, _is_hydrabase_active, _get_metadata_fallback_*, _run_background_ comparison, run_async, dev_mode_enabled_provider) into core/search via a SearchDeps bundle built per-request. fix_artist_image_url stays in web_server.py because it touches 31 other call sites. Behavior preserved 1:1: - Same response shapes (db_artists, spotify_artists, spotify_albums, spotify_tracks, primary_source, metadata_source, alternate_sources, source_available) - Same NDJSON line ordering (artists/albums/tracks as they finish, plus done marker) - Same per-kind exception swallowing - Same hydrabase-worker mirror on dev mode - Same cache key shape (5-tuple) and TTL/LRU semantics - Same stream-track effective-mode resolution including the Soulseek-coerce-to-YouTube edge case - Same library-check Plex thumb URL rewriting and wishlist fallback for older DBs Tests: 94 new (cache TTL/LRU/key, sources happy/partial/all-fail, library presence with library + wishlist + thumbs, stream effective mode + query gen + retry, orchestrator client resolution + short query + single source + fan-out alternates + hydrabase primary + NDJSON drain). Full suite: 788 passing (was 694). Ruff clean.	1 month ago