7 Commits (main)

Author	SHA1	Message	Date
Broque Thomas	de8e079a6d	feat(media-player): playable tracks across modals + lyrics + cleanups ... Three related improvements to the now-playing media player and the "add to wishlist" / "download missing" modals. 1. Play buttons across track-list modals Every track row in the download-missing modals (Spotify, Tidal, YouTube, services, artist album, wishlist download-missing) and the add-to-wishlist modal now carries a play button. Click runs playTrackFromLibraryOrStream: - If the track has a local file_path → playLibraryTrack - Else POST /api/stats/resolve-track to find it in the library by title + artist → playLibraryTrack - Else fall back to _gsPlayTrack streaming Backend ownership response gains track_id / title / file_path so the wishlist modal's owned tracks can hand the right metadata to the player without an extra round trip. The add-to-wishlist modal previously showed the play button only on owned tracks; now the button is unconditional so the streaming fallback can take over for unowned ones (matches the standard pattern from the rest of the app). 2. Clean media-player display titles YouTube / Tidal / Qobuz / torrent / usenet plugins encode their source-side identifier into the filename field as <source_id>||<display> so download() can recover it later. The media player's track-title renderer never knew about this convention and showed strings like "wvgFsXoGFnQ||Sometimes I Cry When I'm Alone" verbatim in the now-playing UI. extractTrackTitle and setTrackInfo now strip the <id>|| prefix defensively so any path into the player gets a clean display. Local library playback also fetches canonical metadata from /api/stats/resolve-track when track.id is present so title / artist / album / album art come straight from the SoulSync DB instead of whatever the caller passed in. Falls back silently to caller values on any error so playback never blocks on the metadata fetch. 3. Lyrics panel + View Artist close New collapsed lyrics panel between the playback controls and queue panel. POST /api/lyrics/fetch (new backend endpoint) prefers the local .lrc / .txt sidecar files SoulSync writes during post-processing so downloaded tracks resolve lyrics with zero network hits; falls back to LRClib exact-match (when album + duration are available) then to LRClib search. Synced LRC results are parsed (handles multi-stamp lines for repeated choruses), and the active line highlights + smooth- scrolls into the middle of the viewport on every audio timeupdate. Plain-text results render without highlighting. Per-track cache prevents re-fetching when the user revisits the same track. Lyrics fetch is fire-and-forget — failure shows "No lyrics found" without ever blocking playback. View Artist on the expanded player now calls closeNowPlayingModal before navigating; the modal was previously sitting open over the artist page, hiding it. Handler is bound once and is a no-op when no artist_id is attached. CSS additions are additive (new .modal-track-play-btn and .np-lyrics-* rules); no existing styles touched. Backend endpoint returns 200-with-success-false on any miss so callers can render "no lyrics" without treating it as an error. WHATS_NEW updated under 2.5.9 with two entries (lyrics + View Artist close).	3 days ago
Antti Kettunen	0d683d87c0	refactor(webui): link artist detail navigation ... - replace click-driven artist-detail hops with semantic links - keep SPA transitions via shell bridge interception for /artist-detail/:source/:id - drop legacy page helper wrappers and dead bridge plumbing	7 days ago
Broque Thomas	cd715f8697	Preserve source when opening artist detail	1 week ago
Broque Thomas	6fe85f2f37	Server playlist sync: append mode (preserve user-added tracks) ... Discord report (CJFC, 2026-04-26): syncing a Spotify playlist to the server overwrote anything manually added to the server-side playlist. The fix adds a per-sync mode picker next to the Sync button on the playlist details modal — Replace (default, current delete-recreate behavior) or Append only (preserves existing tracks, only adds new ones). Useful when the source platform caps playlist size and the user is manually building beyond it on the server. Implementation: * New `append_to_playlist(name, tracks)` method on Plex / Jellyfin / Navidrome clients. Each uses the server's NATIVE append API: - Plex: `existing_playlist.addItems(new_tracks)` - Jellyfin: `POST /Playlists/<id>/Items?Ids=...&UserId=...` - Navidrome: Subsonic `updatePlaylist?songIdToAdd=...` Falls back to `create_playlist` when the playlist doesn't exist yet (first sync). No delete-recreate, no backup playlist created (preserves playlist creation date + metadata + non-soulsync-managed tracks). * Dedup-by-server-native-id (ratingKey for Plex, GUID for Jellyfin, song-id for Navidrome) — never re-adds a track already on the playlist. Server-native identity, not fuzzy title+artist match, so it can't false-collide. * `sync_service.sync_playlist` accepts `sync_mode='replace'|'append'` kwarg. Single if/else branch dispatches to `append_to_playlist` or `update_playlist`. Threaded through `core/discovery/sync.run_sync_task` and the `/api/sync/start` HTTP handler. Validation on the API rejects unknown mode strings (defaults to 'replace'). * Frontend: per-playlist `<select id="sync-mode-${id}">` rendered next to the Sync button in both modal renderers (sync-spotify.js for Spotify playlists, sync-services.js for Deezer ARL playlists). `startPlaylistSync` reads the select at click time; missing select (other callers like discover.js) defaults to 'replace' so backward compat preserved without per-call-site updates. * SoulSync standalone has no playlist methods at all and the modal hides the Sync button entirely on it via `_isSoulsyncStandalone` — dispatch never reaches that path, no defensive fallback needed. 15 new tests pin per-server append behavior: - missing playlist → create_playlist delegation - dedup filtering (existing IDs skipped, only new tracks added) - empty new-track set short-circuits without API call - failure paths return False without raising - contract listing (KNOWN_PER_SERVER_METHODS includes 'append_to_playlist'; Plex / Jellyfin / Navidrome all implement) Plus tests/discovery/test_discovery_sync.py fake `sync_playlist` fixture got `sync_mode='replace'` default to match the new signature (was breaking after the kwarg add; now passing). WHATS_NEW entry under new '2.6.0' block (hidden by `_getLatestWhatsNewVersion` until next release bump). Closes CJFC discord request.	2 weeks ago
Broque Thomas	959562f6b0	Delete Recently Added / Top Tracks / Forgotten Favorites / Familiar Favorites ... Owner decision: not worth shipping. The four library-driven personalized sections were stubbed returning [] for ages because their schema prereqs didn't exist; the prior commit re-enabled them by routing through a new `_select_library_tracks` helper. Owner reviewed and chose to delete the sections entirely instead. Removed everywhere: - `core/personalized_playlists.py` — `get_recently_added`, `get_top_tracks`, `get_forgotten_favorites`, `get_familiar_favorites` + the `_select_library_tracks` helper (no other callers; verified via grep). - `web_server.py` — 4 route handlers (`/api/discover/personalized/recently-added`, `top-tracks`, `forgotten-favorites`, `familiar-favorites`). - `webui/index.html` — 4 `<div class="discover-section">` blocks (`#personalized-recently-added`, `#personalized-top-tracks`, `#personalized-forgotten-favorites`, `#personalized-familiar-favorites`). - `webui/static/discover.js` — 4 load functions (`loadPersonalizedRecentlyAdded`, `loadPersonalizedTopTracks`, `loadPersonalizedForgottenFavorites`, `loadFamiliarFavorites`), plus their entries in `loadDiscoverPage`'s Promise.all, plus 4 module-level state vars + 6 dead branches across `openDownloadModalForDiscoverPlaylist` / `startDiscoverPlaylistSync` and the sync-progress / rehydrate dispatchers. - `webui/static/helper.js` — 4 tooltip / docs entries. - `webui/static/sync-spotify.js` — 1 stale rehydrate dispatcher branch (`discover_familiar_favorites`) caught during the global grep pass. - `tests/test_personalized_playlists_id_gate.py` — 3 library-method tests + the test infrastructure that supported them (`tracks` schema, `insert_library_track` helper). Documentation header updated to reflect the deletion. Net: -527 / +2 lines across 7 files. What stays: - Daily Mixes (also in personalized package, intentionally paused — separate decision). - Popular Picks + Hidden Gems + Discovery Shuffle (alive, not affected by this deletion). - All 14 tests in the personalized-playlists test file still pass. - The PersonalizedPlaylistsService lift from the prior commit (`_select_discovery_tracks` etc) — those are still in active use by the surviving discovery_pool methods. DISCOVER_TRACK_SELECTION_REVIEW.md at repo root contains historical references to the four deleted endpoints. Treated as historical context (same policy as WHATS_NEW), left alone. 2219/2219 full suite green (was 2222 - 3 deleted tests = 2219). JS parses clean, ruff clean.	3 weeks ago
Antti Kettunen	5420c0de24	Fix album track source propagation ... - Pass source through artist, library, wishlist, and rehydration album-track fetches - Preserve the resolved metadata source on cached discography and artist detail state - Prevent 404s when opening artist-page album modals from non-Spotify sources	1 month ago
JohnBaumb	a66c4d06e1	Split monolithic script.js (78K lines) into 17 domain modules ... Extracts the single 77,957-line script.js into focused modules: core.js (874) - Global state, confirm dialog, websocket, constants init.js (2358) - Initialization, personal settings, navigation media-player.js (2398) - Media player, audio, visualizer, radio settings.js (3657) - Settings page, quality profiles, API keys, auth search.js (1542) - Search functionality, page data loading sync-spotify.js (2538) - Spotify sync, YouTube backend, hero section downloads.js (6398) - Wing It, batched polling, cancel, notifications wishlist-tools.js (7234) - Wishlist, matched downloads, tools, retag sync-services.js (9076) - Tidal, Deezer, Beatport, YouTube, ListenBrainz sync artists.js (4610) - Artists page, artist downloads api-monitor.js (3798) - API rate monitor gauges library.js (6652) - Library, artist detail, enhanced management beatport-ui.js (3902) - Beatport sliders, genre browser discover.js (8920) - Discover page and all sub-sections enrichment.js (3551) - All enrichment workers, library repair stats-automations.js (7575) - Stats, automations, issues, import pages-extra.js (2874) - Playlist explorer, server playlists, active downloads Load order: core.js first (globals), init.js last (DOMContentLoaded). All other modules define functions and load in any order. No functional changes - pure extraction along existing section boundaries.	1 month ago