2 Commits (dev)

Author	SHA1	Message	Date
Broque Thomas	b9c8245c49	Stop config retry tests from writing to the real DB ... The fixture used the wrong env var name (SOULSYNC_DB_PATH) when trying to redirect ConfigManager at a tmp directory. ConfigManager actually reads DATABASE_PATH (config/settings.py:49), so the test ConfigManager loaded — and then saved — at the user's real database/music_library.db. The retry stub in test_lock_errors_during_retries_log_at_debug_not_error calls the real _save_to_database after its mocked failures, which then clobbered the encrypted app_config row with the test fixture's stub payload {"plex": {"base_url": "http://example.test"}}. Three layers of fix so this can't happen again: - Use the correct env var (DATABASE_PATH). - Pin mgr.database_path / mgr.config_path on the instance after construction, so the test fixture's tmp paths win even if ConfigManager's resolution logic changes. - Assert the resolved database_path is rooted under tmp_path before returning the fixture, so the test refuses to run if it would touch a non-tmp DB.	1 month ago
Broque Thomas	4238aeb4d9	Add regression tests for config DB retry behaviour (#434) ... Pin the new save-retry contract so future changes can't silently re-introduce the spam reported in #434: - Happy-path saves emit zero ERROR logs. - Transient locks during retries log at DEBUG, not ERROR. - Six attempts run before giving up, with the documented backoff schedule (0.2 + 0.5 + 1.0 + 2.0 + 4.0s). - Genuine exhaustion logs a single ERROR and writes config.json. - sqlite3.OperationalError("database is locked") routes to DEBUG; any other OperationalError still logs ERROR. - _connect_db() actually applies WAL + busy_timeout + synchronous=NORMAL. Also moves `import time` from inside _save_config to the module top so the tests can monkeypatch sleep cleanly.	1 month ago