3 Commits (dev)

Author	SHA1	Message	Date
Broque Thomas	2c0a0da9ea	Address Copilot doc-drift review ... Four stale doc/comment references caught by Copilot's pass: - core/download_plugins/base.py: TYPE_CHECKING comment said the shared dataclasses lived in core.soulseek_client. They were moved to core.download_plugins.types in this PR. Comment updated. - core/qobuz_client.py: reload_credentials docstring still referenced soulseek_client.client('qobuz') after the global rename to download_orchestrator. Updated to download_orchestrator.client(...). - webui/static/helper.js: the older WHATS_NEW entries for the plugin contract + engine refactor still claimed backward-compat self.<source> attributes were preserved. Followup commits in the same PR removed them. Each entry now flags the followup explicitly and points at the "Drop Backward-Compat Per-Source Attrs" entry above it so the changelog is internally consistent. - docs/download-engine-refactor-plan.md: Compatibility commitments section listed orchestrator.<source> attribute preservation as a guarantee. Cin's review pass removed those attrs (and renamed the global handle from soulseek_client to download_orchestrator) — both are breaking changes for in-tree callers (which were migrated) and in-flight branches (which will need to update). Section rewritten to document the actual outcome.	3 weeks ago
Broque Thomas	a3929b457b	E1: Add RateLimitPolicy declaration mechanism ... `core/download_engine/rate_limit.py` introduces a per-source policy declaration: download_concurrency + download_delay_seconds. Plugins declare via `RATE_LIMIT_POLICY` class attribute or a `rate_limit_policy()` method. Engine applies the declared policy to engine.worker at register_plugin time — set_concurrency + set_delay get pushed in automatically. Plugins without a declaration get the conservative default (1 / 0). The set_engine callback fires AFTER policy registration so config-driven sources (YouTube reads user-tunable youtube.download_delay) can override. Plan doc updated to reflect Phase D skip (search code is 90% source-specific, not 60% — lifting it would be lossy or bloated). Pure additive — no plugin migrated yet. 8 tests pin the resolution priority + engine wire-up + override semantics. Suite still green (327 download tests).	3 weeks ago
Broque Thomas	52ab9aeb5b	A1: Pin SoulseekClient download lifecycle behavior ... 13 tests pin slskd HTTP API contract: endpoint format (`transfers/downloads/<username>` POST), payload shape (slskd web-interface array format), id extraction from dict / list / fallback responses, and the username-lookup fallback in cancel_download when no username hint is provided. Phase A of the download engine refactor — pinning current behavior of every source BEFORE moving any code so the engine extraction can't drift the per-source contract. Includes the plan doc at docs/download-engine-refactor-plan.md. Pure additive — no client code changes.	3 weeks ago