3 Commits (dev)

Author	SHA1	Message	Date
Broque Thomas	9602d1827c	Final silent-exception sweep + ruff S110 lint guardrail — ~45 sites ... Catches the silent excepts the awk-based earlier sweeps missed: - Bare `except:` followed by `pass` (also swallows KeyboardInterrupt and SystemExit — actively wrong). Upgraded to `except Exception as e: logger.debug("...: %s", e)`. ~14 sites across connection_detect, soulseek_client, listenbrainz_manager, watchlist_scanner, youtube_client, navidrome_client, jellyfin_client, web_server. - `except Exception:` + pass that the awk pattern missed (e.g. multi-line or unusual whitespace). ~31 sites across automation_engine, database_update_worker, music_database, spotify_client, web_server, others. - 14 legitimate cleanup sites left silent with explicit `# noqa: S110` + comment explaining why (atexit handlers, finally-block conn.close calls). Logging during shutdown can itself crash because file handles get torn down before the handler fires. Also enables `S110` rule in pyproject.toml so this pattern fails CI going forward — drift fails at PR review instead of at runtime against a wedged worker thread. Tests path keeps S110 ignored (test fixtures legitimately use try-except-pass for cleanup). Adds a WHATS_NEW entry to helper.js summarizing the full #369 sweep. Verified: `python -m ruff check .` → All checks passed. Verified: `python -m pytest tests/` → 2188 passed. Closes #369	3 weeks ago
Broque Thomas	8dc9f79f97	Surface silent exceptions in watchlist + discovery + reorganize — 18 sites ... - watchlist_scanner.py: 6 sites - discovery/playlist.py: 5 sites - discovery/sync.py: 4 sites - watchlist/auto_scan.py: 1 site (1 left silent — finally-block scanner cleanup) - library_reorganize.py: 2 sites (4 left silent — all in finally blocks: conn.close, staging rmtree, sidecar delete, cleanup_empty_dir) All non-finally sites converted to `logger.debug("...: %s", e)`. Finally-block sites kept silent because logger calls during cleanup (after exception was already raised) can themselves raise. Refs #369	3 weeks ago
Broque Thomas	2b2003ba4c	Lift _process_watchlist_scan_automatically to core/watchlist/auto_scan.py ... Pulls the 390-line watchlist auto-scan orchestrator out of `web_server.py` into a new `core/watchlist/` package. Watchlist (followed-artists scanner that finds new releases) is a separate domain from kettui's wishlist (failed-download retry queue), so this lift does not overlap with the ongoing PR400-style extractions. What `process_watchlist_scan_automatically` does: 1. Smart stuck-detection guard before acquiring the timer lock — prevents deadlock when a previous scan flag is dangling past the 2-hour timeout. 2. Inside the timer lock: re-check + set the active scan flag with the current timestamp. 3. Per-profile expansion (or single-profile when manually triggered): - Watchlist count check + Spotify auth gate. - Backfill missing artist images. 4. Initialize a fresh `watchlist_scan_state` dict (the deps property setter rebinds the web_server.py module-level name so external sentinel checks via id() comparison still detect the swap). 5. Pause enrichment workers, then call `WatchlistScanner.scan_watchlist_artists` with a per-event progress callback that translates scanner events into automation log lines. 6. Post-scan steps (skipped if the scan was cancelled mid-flight): - Populate discovery pool from similar artists (per-profile). - Refresh ListenBrainz playlists. - Update current seasonal playlist (weekly cadence). - Generate Last.fm radio playlists. - Sync Spotify library cache. - Activity feed entry + automation_engine.emit('watchlist_scan_completed'). 7. On exception: mark state['status']='error', re-raise so the automation wrapper records the failure. 8. Finally: resume enrichment workers, clear the scanner's rescan cutoff, reset the auto-scanning flag. Strict 1:1 byte parity: The original mutated `watchlist_auto_scanning`, `watchlist_auto_scanning_timestamp`, and `watchlist_scan_state` as module globals (with a leading `global` decl). Here those names are exposed through the `WatchlistAutoScanDeps` proxy as Python properties so the lifted body keeps the same `name = value` / `name[key] = value` shape. Property setters fan writes back to web_server.py via callback pairs. Diff vs original after `deps.X` → global X normalization is **zero differences** apart from the dropped `global` declaration line — Python doesn't need it once the names are property accesses on the deps object. 390 lines orig = 390 lines lifted, byte-identical body otherwise. Dependencies injected via `WatchlistAutoScanDeps` (15 fields total) — Flask app, spotify_client, automation_engine, watchlist_timer_lock, plus 5 callable helpers and 6 property delegate callbacks (paired get/set for each of the three globals). Tests: 11 new under tests/watchlist/test_auto_scan.py covering stuck-detection guard, race-check inside lock, zero-watchlist short- circuit, unauthenticated Spotify gate, successful scan with all post- scan steps, automation event emission, activity feed logging, cancellation mid-scan skipping post-steps, profile-scoped trigger, flag reset in finally, rescan cutoff clear in finally. Full suite: 1319 passing (was 1308). Ruff clean.	4 weeks ago