4 Commits (dev)

Author	SHA1	Message	Date
BoulderBadgeDad	e32e2e5e14	Sync: append mode actually dedupes — stop re-adding the whole playlist (#823) ... carlosjfcasero round 2: after 6fa956d6 append stopped recreating the playlist, but every sync re-appended ALL matched tracks — every track N times. His log shows it plainly: "added 22 new tracks to 'Disney' (skipped 0 already present)" on a playlist that already had those 22. Root cause: the dedupe read `{t.id for t in get_playlist_tracks(...)}` — but JellyfinTrack only defines `ratingKey`, never `id`, so the existing-ids set was ALWAYS empty and everything looked new. NavidromeTrack is also ratingKey-only, so the Navidrome append had the identical bug. Plex (plexapi ratingKey) was fine. The existing tests were green because they mocked existing tracks as SimpleNamespace(id=...) — encoding the same wrong assumption as the code. Fix: - New pure planner plan_playlist_append(current, desired) in core/sync/playlist_edit.py (next to the reconcile planner): order-preserving, drops already-present ids, dedupes within desired, stringifies (Emby numeric vs string safe). - Jellyfin/Emby: existing ids fetched from the canonical /Playlists/{id}/Items endpoint (same as reconcile — works for Jellyfin GUIDs and Emby numeric ids), ratingKey fallback if that request fails. - Navidrome: dedupe on ratingKey (the attribute that actually exists). Tests: planner (skip-present incl. the reporter's unchanged-playlist case, desired-order, dupes-within-desired, int/str ids, empties) + the append-mode suite rewritten to pin the REAL shapes (raw Items dicts for Jellyfin, ratingKey objects for Navidrome) + a new fallback-path test. 524 playlist/sync/jellyfin/navidrome tests pass.	5 days ago
BoulderBadgeDad	65c9948c78	Fix #792: reconcile sync mode was clamped back to 'replace' in the backend ... start_playlist_sync validated the resolved mode with 'if sync_mode not in (replace, append): sync_mode = replace' — a pre-existing clamp two lines below the config read I added, which silently downgraded a configured 'reconcile' to 'replace'. So config=reconcile resolved correctly then got clobbered, and every sync ran replace regardless of the setting (and incognito didn't help — it's backend, not cache). Replace the hand-rolled clamp with a pure normalize_sync_mode(requested, configured) helper (VALID_SYNC_MODES includes reconcile) so the resolution is testable and can't silently drop a mode again. Regression tests cover reconcile-from-config, request-overrides-config, and unknown->replace.	1 week ago
BoulderBadgeDad	939c660498	Fix #792: 'reconcile' playlist sync mode (edit in place, keep image/description) ... Replace mode (default) deletes + recreates the server playlist every sync, which wipes its custom image, description, and identity. Add an opt-in 'reconcile' sync mode that edits the existing playlist in place — adds the tracks now in the source, removes the ones gone — without destroying the object, so the user's custom art/description survive. - Pure planner plan_playlist_reconcile(current, desired) -> {add, remove}. - Per-client reconcile_playlist: Plex addItems/removeItems on the same object; Navidrome Subsonic updatePlaylist delta (songIdToAdd / descending songIndexToRemove); Jellyfin add + remove-by-PlaylistItemId on /Playlists/{id}/Items. - sync_service: reconcile branch with a replace FALLBACK (if a server's in-place edit is unavailable/fails, sync still succeeds destructively — logged loudly). - Default stays 'replace' (no behavior change). New Settings > Playlist sync mode picker (replace/reconcile/append) backed by playlist_sync.mode; per-request sync_mode still overrides. - Reconcile skips the post-sync source-image push so a custom poster isn't re-clobbered (the bug). Tests: planner (add/remove/dedupe/order/empty) + reconcile-or-replace dispatch (success / false-fallback / exception-fallback / no-method). Per-server in-place API calls need dev validation against real Plex/Jellyfin/Navidrome. NOTE: opt-in only; default behavior unchanged.	1 week ago
BoulderBadgeDad	bba0836324	Fix #768: playlist sync editor refusing to match certain tracks ... Three compounding bugs hit tracks whose source metadata is YouTube/streaming- shaped — title "Artist - Song", artist "Official Artist"/"Artist - Topic"/ "ArtistVEVO" (reported: "Arctic Monkeys - Do I Wanna Know?" by "Official Arctic Monkeys"). Server-agnostic — affects Plex/Jellyfin/Navidrome, not just the reporter's Navidrome. Bug A — the match fails. The confidence scorer and the editor's reconcile both compared the raw "Artist - Song" title against the library's clean "Song"; the length-ratio penalty + floor drove it to ~0.18 (NO-MATCH), so the track showed unmatched while its server copy showed as an orphan "extra". New pure core/text/source_title.py (clean_source_artist / strip_artist_prefix / canonical_source_track) strips the channel/video decoration, applied at BOTH matching seams: services/sync_service._find_track_in_media_server (tries raw then canonical, keeps the best) and the editor reconcile. Conservative: a title prefix is stripped only when it equals the artist, so "Self-Titled", "Jay-Z", and "Marvin Gaye" (by another artist) are untouched, and the canonical form is an additional best-of candidate so it can only help. Bug B — manual matches never persisted. get_server_playlist_tracks built the per-source entry WITHOUT source_track_id, so "Find & add" posted an empty id and _persist_find_and_add_match returned early. The match reverted to "extra" on reload and re-adding looped. The editor's 3-pass matcher is now lifted to a pure, tested core.sync.playlist_reconcile.reconcile_playlist that includes source_track_id (the frontend at pages-extra.js:1836 already reads + sends it). Bug C — manual match duplicated + delete wiped all copies. "Find & add" always inserted, so linking a source to an already-present server track appended a duplicate (pos 72, 73...); remove filtered out EVERY entry with the target id. New pure core.sync.playlist_edit (plan_playlist_add: link-don't-duplicate when the target is already present; remove_one_occurrence: drop a single copy) wired into the Plex/Jellyfin/Navidrome add + remove branches. Tests (extreme): tests/test_source_title.py (35), tests/test_playlist_reconcile.py (11 — incl. the reported case, parity for override/exact/fuzzy/extra, and duplicate-server handling), tests/test_playlist_edit.py (12). 286 matching/sync tests still pass. Caveats: the sync_service change and the add/remove/editor endpoints are read-verified, not executed against a live media server (none in CI). The pure cores they call are exhaustively unit-tested; output-shape parity of the reconcile lift is covered. Delete removes the first matching copy (duplicates are identical, so harmless).	2 weeks ago