From ff12d8bbf207e6d78d7ff94264dc049909f5ec22 Mon Sep 17 00:00:00 2001
From: dev <dev@localhost>
Date: Wed, 24 Jun 2026 15:59:25 +0200
Subject: [PATCH] fix(repair-jobs): boolean settings saved as string
 'true'/'false' by UI dropdown

HTML <select> options can only store string values, so setting_options booleans
([True, False]) were serialised as 'true'/'false' strings and sent to the API.
Python's `x is True` check returned False for the string, making require_top_target
and deep_audio_verify permanently read as False regardless of what the user saved.

Fix JS: convert 'true'/'false' strings to real booleans before POSTing.
Fix Python: _to_bool() in quality_upgrade + inline coercion in scanner to handle
both existing string values in config and correct future booleans.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 core/repair_jobs/quality_upgrade.py         | 13 +++++++++++--
 core/repair_jobs/quality_upgrade_scanner.py |  4 ++++
 webui/static/enrichment.js                  |  5 ++++-
 3 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/core/repair_jobs/quality_upgrade.py b/core/repair_jobs/quality_upgrade.py
index 7d6a9b44..a6e70588 100644
--- a/core/repair_jobs/quality_upgrade.py
+++ b/core/repair_jobs/quality_upgrade.py
@@ -50,6 +50,15 @@ from utils.logging_config import get_logger
 logger = get_logger("repair_jobs.quality_upgrade")
 
 
+def _to_bool(val) -> bool:
+    """Coerce a setting value to bool. Handles Python bool, string 'true'/'false', and int."""
+    if isinstance(val, bool):
+        return val
+    if isinstance(val, str):
+        return val.lower() == 'true'
+    return bool(val) if val is not None else False
+
+
 # Quality ranks — higher is better. Lossless tops everything; lossy tiers fall out
 # of bitrate. 0 means "below the lowest tracked tier / unknown".
 RANK_LOSSLESS = 4
@@ -494,8 +503,8 @@ class QualityUpgradeJob(RepairJob):
             merged['min_confidence'] = float(merged.get('min_confidence', 0.7))
         except (TypeError, ValueError):
             merged['min_confidence'] = 0.7
-        merged['deep_audio_verify'] = merged.get('deep_audio_verify') is True
-        merged['require_top_target'] = merged.get('require_top_target') is True
+        merged['deep_audio_verify'] = _to_bool(merged.get('deep_audio_verify'))
+        merged['require_top_target'] = _to_bool(merged.get('require_top_target'))
         return merged
 
     def _load_tracks(self, db: Any, scope: str) -> List[dict]:
diff --git a/core/repair_jobs/quality_upgrade_scanner.py b/core/repair_jobs/quality_upgrade_scanner.py
index 060f3375..25b36e56 100644
--- a/core/repair_jobs/quality_upgrade_scanner.py
+++ b/core/repair_jobs/quality_upgrade_scanner.py
@@ -297,6 +297,10 @@ class QualityUpgradeScannerJob(RepairJob):
                     merged.update(cfg)
             except Exception as e:
                 logger.debug("settings read failed: %s", e)
+        for key in ('library_tracks_only', 'deep_audio_verify', 'require_top_target'):
+            val = merged.get(key)
+            if not isinstance(val, bool):
+                merged[key] = str(val).lower() == 'true' if val is not None else False
         return merged
 
     def _collect_music_dirs(self, context: JobContext) -> list:
diff --git a/webui/static/enrichment.js b/webui/static/enrichment.js
index e43cfe17..7ef07010 100644
--- a/webui/static/enrichment.js
+++ b/webui/static/enrichment.js
@@ -1988,7 +1988,10 @@ async function saveRepairJobSettings(jobId) {
             } else {
                 if (input.type === 'checkbox') settings[key] = input.checked;
                 else if (input.type === 'number') settings[key] = parseFloat(input.value);
-                else settings[key] = input.value;
+                else {
+                    const v = input.value;
+                    settings[key] = v === 'true' ? true : v === 'false' ? false : v;
+                }
             }
         });