From fa0ac4ced33e2e4cb1025196366ab598597cffb3 Mon Sep 17 00:00:00 2001 From: Antti Kettunen Date: Tue, 19 May 2026 10:27:21 +0300 Subject: [PATCH] refactor(webui): simplify similar artists cleanup - no need for a separate effect since we can use the existing one - no need to cancel the similar artists query upon entering, since the unregister callback already does it --- webui/src/routes/artist-detail/$source/$id.tsx | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/webui/src/routes/artist-detail/$source/$id.tsx b/webui/src/routes/artist-detail/$source/$id.tsx index 5430d2c3..6987c00e 100644 --- a/webui/src/routes/artist-detail/$source/$id.tsx +++ b/webui/src/routes/artist-detail/$source/$id.tsx @@ -1,5 +1,5 @@ import { createFileRoute } from '@tanstack/react-router'; -import { useEffect, useLayoutEffect } from 'react'; +import { useLayoutEffect } from 'react'; import { useShellBridge } from '@/platform/shell/route-controllers'; @@ -17,15 +17,10 @@ function ArtistDetailPage() { useLayoutEffect(() => { if (!bridge) return; - bridge.cancelSimilarArtistsLoad(); const normalizedSource = source.toLowerCase() === 'library' ? null : source.toLowerCase(); bridge.navigateToArtistDetail(id, '', normalizedSource, { skipRouteChange: true, }); - }, [bridge, id, source]); - - useEffect(() => { - if (!bridge) return; return () => { bridge.cancelSimilarArtistsLoad();