From c940363ec2af65cf89a67c6340b9daba1447c384 Mon Sep 17 00:00:00 2001
From: Broque Thomas <26755000+Nezreka@users.noreply.github.com>
Date: Sun, 19 Apr 2026 13:04:55 -0700
Subject: [PATCH] Fix CI test failures from incomplete dummy config and
 encoding

8 test files had _DummyConfigManager missing get_active_media_server(),
causing failures when pytest ran them before the test file that had it.
Whichever file set sys.modules first won, and the incomplete dummy broke
later tests. Also fix script.js read_text() missing encoding='utf-8'
which failed on non-UTF-8 default locales.
---
 tests/test_album_completeness_job.py     | 3 +++
 tests/test_library_reorganize.py         | 3 +++
 tests/test_metadata_gap_filler.py        | 3 +++
 tests/test_metadata_service_cache.py     | 3 +++
 tests/test_missing_cover_art.py          | 3 +++
 tests/test_repair_worker_album_fill.py   | 3 +++
 tests/test_track_number_repair.py        | 3 +++
 tests/test_unknown_artist_fixer.py       | 3 +++
 tests/test_websocket_client_transport.py | 2 +-
 9 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/tests/test_album_completeness_job.py b/tests/test_album_completeness_job.py
index b15d4fd9..f3f8145c 100644
--- a/tests/test_album_completeness_job.py
+++ b/tests/test_album_completeness_job.py
@@ -30,6 +30,9 @@ if "config.settings" not in sys.modules:
         def get(self, key, default=None):
             return default
 
+        def get_active_media_server(self):
+            return "plex"
+
     settings_mod.config_manager = _DummyConfigManager()
     config_pkg.settings = settings_mod
     sys.modules["config"] = config_pkg
diff --git a/tests/test_library_reorganize.py b/tests/test_library_reorganize.py
index d0fd6afb..50f97fa9 100644
--- a/tests/test_library_reorganize.py
+++ b/tests/test_library_reorganize.py
@@ -28,6 +28,9 @@ if 'config.settings' not in sys.modules:
         def get(self, key, default=None):
             return default
 
+        def get_active_media_server(self):
+            return "plex"
+
     settings_mod.config_manager = _DummyConfigManager()
     config_mod.settings = settings_mod
     sys.modules['config'] = config_mod
diff --git a/tests/test_metadata_gap_filler.py b/tests/test_metadata_gap_filler.py
index ba2ab44f..5747eeed 100644
--- a/tests/test_metadata_gap_filler.py
+++ b/tests/test_metadata_gap_filler.py
@@ -29,6 +29,9 @@ if 'config.settings' not in sys.modules:
         def get(self, key, default=None):
             return default
 
+        def get_active_media_server(self):
+            return "plex"
+
     settings_mod.config_manager = _DummyConfigManager()
     config_mod.settings = settings_mod
     sys.modules['config'] = config_mod
diff --git a/tests/test_metadata_service_cache.py b/tests/test_metadata_service_cache.py
index fa7b0400..a0c68d1d 100644
--- a/tests/test_metadata_service_cache.py
+++ b/tests/test_metadata_service_cache.py
@@ -32,6 +32,9 @@ if "config.settings" not in sys.modules:
         def get(self, key, default=None):
             return default
 
+        def get_active_media_server(self):
+            return "plex"
+
     settings_mod.config_manager = _DummyConfigManager()
     config_pkg.settings = settings_mod
     sys.modules["config"] = config_pkg
diff --git a/tests/test_missing_cover_art.py b/tests/test_missing_cover_art.py
index da6f5463..cb89896c 100644
--- a/tests/test_missing_cover_art.py
+++ b/tests/test_missing_cover_art.py
@@ -29,6 +29,9 @@ if 'config.settings' not in sys.modules:
         def get(self, key, default=None):
             return default
 
+        def get_active_media_server(self):
+            return "plex"
+
     settings_mod.config_manager = _DummyConfigManager()
     config_mod.settings = settings_mod
     sys.modules['config'] = config_mod
diff --git a/tests/test_repair_worker_album_fill.py b/tests/test_repair_worker_album_fill.py
index c3d40e2b..e8ebc23c 100644
--- a/tests/test_repair_worker_album_fill.py
+++ b/tests/test_repair_worker_album_fill.py
@@ -33,6 +33,9 @@ if "config.settings" not in sys.modules:
         def get(self, key, default=None):
             return default
 
+        def get_active_media_server(self):
+            return "plex"
+
     settings_mod.config_manager = _DummyConfigManager()
     config_pkg.settings = settings_mod
     sys.modules["config"] = config_pkg
diff --git a/tests/test_track_number_repair.py b/tests/test_track_number_repair.py
index 7b5cfb77..546afff5 100644
--- a/tests/test_track_number_repair.py
+++ b/tests/test_track_number_repair.py
@@ -28,6 +28,9 @@ if 'config.settings' not in sys.modules:
         def get(self, key, default=None):
             return default
 
+        def get_active_media_server(self):
+            return "plex"
+
     settings_mod.config_manager = _DummyConfigManager()
     config_mod.settings = settings_mod
     sys.modules['config'] = config_mod
diff --git a/tests/test_unknown_artist_fixer.py b/tests/test_unknown_artist_fixer.py
index 2c6d7c90..1ee99bc0 100644
--- a/tests/test_unknown_artist_fixer.py
+++ b/tests/test_unknown_artist_fixer.py
@@ -30,6 +30,9 @@ if "config.settings" not in sys.modules:
         def get(self, key, default=None):
             return default
 
+        def get_active_media_server(self):
+            return "plex"
+
     settings_mod.config_manager = _DummyConfigManager()
     config_pkg.settings = settings_mod
     sys.modules["config"] = config_pkg
diff --git a/tests/test_websocket_client_transport.py b/tests/test_websocket_client_transport.py
index d7f9e1d2..3ba371cc 100644
--- a/tests/test_websocket_client_transport.py
+++ b/tests/test_websocket_client_transport.py
@@ -3,6 +3,6 @@ from pathlib import Path
 
 def test_websocket_client_prefers_polling_before_websocket():
     script_path = Path(__file__).resolve().parents[1] / "webui" / "static" / "script.js"
-    script = script_path.read_text()
+    script = script_path.read_text(encoding="utf-8")
 
     assert "transports: ['polling', 'websocket']" in script