From a81031d63f40099f92defae39f82d81cdbfa2652 Mon Sep 17 00:00:00 2001
From: Broque Thomas <26755000+Nezreka@users.noreply.github.com>
Date: Thu, 2 Apr 2026 12:50:20 -0700
Subject: [PATCH] =?UTF-8?q?Fix=20GitHub=20Actions=20workflow=20=E2=80=94?=
 =?UTF-8?q?=20secrets=20not=20allowed=20in=20if=20expressions?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Move secret to env var, check emptiness in shell instead
- Gracefully skips if DISCORD_ANNOUNCEMENTS_WEBHOOK not configured
---
 .github/workflows/docker-publish.yml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/docker-publish.yml b/.github/workflows/docker-publish.yml
index 9469b052..0ebaae8d 100644
--- a/.github/workflows/docker-publish.yml
+++ b/.github/workflows/docker-publish.yml
@@ -43,8 +43,11 @@ jobs:
             boulderbadgedad/soulsync:${{ inputs.version_tag }}
 
       - name: Announce release to Discord
-        if: success() && secrets.DISCORD_ANNOUNCEMENTS_WEBHOOK
+        if: success()
+        env:
+          DISCORD_WEBHOOK: ${{ secrets.DISCORD_ANNOUNCEMENTS_WEBHOOK }}
         run: |
+          if [ -z "$DISCORD_WEBHOOK" ]; then echo "No webhook configured, skipping"; exit 0; fi
           curl -s -H "Content-Type: application/json" \
             -d "{\"embeds\": [{\"title\": \"SoulSync v${{ inputs.version_tag }} Released\", \"description\": \"A new version of SoulSync is available! Pull the latest Docker image to update.\n\n\`\`\`\ndocker pull boulderbadgedad/soulsync:${{ inputs.version_tag }}\n\`\`\`\", \"color\": 5025616, \"footer\": {\"text\": \"SoulSync Auto-Release\"}, \"timestamp\": \"$(date -u +%Y-%m-%dT%H:%M:%SZ)\"}]}" \
-            "${{ secrets.DISCORD_ANNOUNCEMENTS_WEBHOOK }}"
+            "$DISCORD_WEBHOOK"