From 97f35de44e3067541a6c1564ee5aaa1214fbd2a6 Mon Sep 17 00:00:00 2001
From: Broque Thomas <26755000+Nezreka@users.noreply.github.com>
Date: Tue, 19 May 2026 18:22:56 -0700
Subject: [PATCH] test(amazon): update search_albums test for
 derived-from-tracks behavior
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Commit 478bcc5d (`fix(amazon): search albums/artists and track numbers
for t2tunes`) switched `search_albums` to query `types=track` and derive
Album objects from the album metadata on each track hit — Amazon's
album-type query is broken upstream. The matching test was left asserting
the old "filter out track hits → return []" behavior and has been failing
in CI ever since.

Rewritten to assert the current intended behavior: track hits yield
distinct albums by album ASIN, with the artist credit + name preserved.
No code change.
---
 tests/tools/test_amazon_client.py | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/tests/tools/test_amazon_client.py b/tests/tools/test_amazon_client.py
index a2e21938..33fbac08 100644
--- a/tests/tools/test_amazon_client.py
+++ b/tests/tools/test_amazon_client.py
@@ -624,11 +624,20 @@ class TestSearchAlbums:
             albums = client.search_albums("GNX")
         assert len(albums) == 1
 
-    def test_ignores_track_hits(self):
+    def test_derives_albums_from_track_hits(self):
+        """search_albums now intentionally queries `types=track` and derives
+        Album objects from the album metadata carried on each track hit —
+        Amazon's album-type query is broken upstream, so the t2tunes fix
+        switched everything to track-type and reconstructs albums from the
+        results. Distinct album ASINs across the track hits yield distinct
+        albums; duplicates collapse via the explicit/clean dedup key."""
         client = _make_client({"amazon-music/search": SEARCH_RESPONSE_TRACKS})
         with patch("core.amazon_client._rate_limit"):
             albums = client.search_albums("Kendrick")
-        assert albums == []
+        # Two track hits → two distinct album ASINs → two derived albums.
+        assert {a.id for a in albums} == {"B0ABCDE123", "B0ABCDE456"}
+        assert {a.name for a in albums} == {"GNX", "euphoria"}
+        assert all(a.artists == ["Kendrick Lamar"] for a in albums)
 
     def test_strips_explicit_from_album_name(self):
         resp = {