From 8ffdca363642be5f40bbefad8a2b9dbb41786c8c Mon Sep 17 00:00:00 2001
From: BoulderBadgeDad <batmanesignal@gmail.com>
Date: Thu, 4 Jun 2026 12:53:05 -0700
Subject: [PATCH] Fix CI: drop dead RetagDeps tests + pointless f-string

Follow-on to 07801aeb (the orphaned-file delete committed alone because the
git add aborted on the already-removed pathspec). Removes the two RetagDeps
tests in test_lyrics_reembed_from_sidecar (the dataclass was deleted with the
old Retag Tool) and a no-placeholder f-string in test_library_retag_job.
---
 tests/test_library_retag_job.py           |  2 +-
 tests/test_lyrics_reembed_from_sidecar.py | 50 -----------------------
 2 files changed, 1 insertion(+), 51 deletions(-)

diff --git a/tests/test_library_retag_job.py b/tests/test_library_retag_job.py
index 46f8456e..e843ec98 100644
--- a/tests/test_library_retag_job.py
+++ b/tests/test_library_retag_job.py
@@ -47,7 +47,7 @@ def _context(conn, settings):
     findings = []
     return SimpleNamespace(
         db=SimpleNamespace(_get_connection=lambda: conn),
-        config_manager=SimpleNamespace(get=lambda k, d=None: {f'repair.jobs.library_retag.settings': settings}.get(k, d)),
+        config_manager=SimpleNamespace(get=lambda k, d=None: {'repair.jobs.library_retag.settings': settings}.get(k, d)),
         check_stop=lambda: False, wait_if_paused=lambda: False,
         update_progress=lambda *a, **k: None, report_progress=lambda *a, **k: None,
         create_finding=lambda **kw: (findings.append(kw) or True),
diff --git a/tests/test_lyrics_reembed_from_sidecar.py b/tests/test_lyrics_reembed_from_sidecar.py
index 498dda54..64577b1d 100644
--- a/tests/test_lyrics_reembed_from_sidecar.py
+++ b/tests/test_lyrics_reembed_from_sidecar.py
@@ -168,53 +168,3 @@ def test_no_sidecar_falls_through_to_lrclib(fake_audio_file):
     assert os.path.exists(lrc)
     # And USLT was embedded
     client._embed_lyrics.assert_called_once()
-
-
-# ──────────────────────────────────────────────────────────────────────
-# RetagDeps integration — generate_lrc_file is now wired
-# ──────────────────────────────────────────────────────────────────────
-
-def test_retagdeps_accepts_generate_lrc_file_field():
-    from core.library.retag import RetagDeps
-
-    # Mock the required + optional deps with do-nothing callables
-    deps = RetagDeps(
-        config_manager=MagicMock(),
-        retag_lock=MagicMock(),
-        spotify_client=MagicMock(),
-        get_audio_quality_string=lambda *a: '',
-        enhance_file_metadata=lambda *a: True,
-        build_final_path_for_track=lambda *a: ('', ''),
-        safe_move_file=lambda *a: None,
-        cleanup_empty_directories=lambda *a: None,
-        download_cover_art=lambda *a: None,
-        docker_resolve_path=lambda x: x,
-        _get_retag_state=lambda: {},
-        _set_retag_state=lambda v: None,
-        get_database=lambda: MagicMock(),
-        generate_lrc_file=lambda *a: True,
-    )
-    assert callable(deps.generate_lrc_file)
-
-
-def test_retagdeps_generate_lrc_file_optional_for_backward_compat():
-    """Tests that built RetagDeps without the new field don't break."""
-    from core.library.retag import RetagDeps
-
-    deps = RetagDeps(
-        config_manager=MagicMock(),
-        retag_lock=MagicMock(),
-        spotify_client=MagicMock(),
-        get_audio_quality_string=lambda *a: '',
-        enhance_file_metadata=lambda *a: True,
-        build_final_path_for_track=lambda *a: ('', ''),
-        safe_move_file=lambda *a: None,
-        cleanup_empty_directories=lambda *a: None,
-        download_cover_art=lambda *a: None,
-        docker_resolve_path=lambda x: x,
-        _get_retag_state=lambda: {},
-        _set_retag_state=lambda v: None,
-        get_database=lambda: MagicMock(),
-    )
-    # Field defaults to None — no crash on construction.
-    assert deps.generate_lrc_file is None